netsuite 0.0.16 → 0.0.17

data/lib/netsuite/actions/update.rb

@@ -3,8 +3,9 @@ module NetSuite
     class Update
       include Support::Requests
 
-      def initialize(obj = nil)
-        @obj = obj
+      def initialize(klass, attributes)
+        @klass      = klass
+        @attributes = attributes
       end
 
       def request
@@ -27,22 +28,26 @@ module NetSuite
       # </platformMsgs:update>
       def request_body
         hash = {
-          'platformMsgs:record' => @obj.to_record,
+          'platformMsgs:record' => updated_record.to_record,
           :attributes! => {
             'platformMsgs:record' => {
-              'xsi:type' => @obj.record_type
+              'xsi:type' => updated_record.record_type
             }
           }
         }
-        if @obj.respond_to?(:internal_id) && @obj.internal_id
-          hash[:attributes!]['platformMsgs:record']['platformMsgs:internalId'] = @obj.internal_id
+        if updated_record.respond_to?(:internal_id) && updated_record.internal_id
+          hash[:attributes!]['platformMsgs:record']['platformMsgs:internalId'] = updated_record.internal_id
         end
-        if @obj.respond_to?(:external_id) && @obj.external_id
-          hash[:attributes!]['platformMsgs:record']['platformMsgs:externalId'] = @obj.external_id
+        if updated_record.respond_to?(:external_id) && updated_record.external_id
+          hash[:attributes!]['platformMsgs:record']['platformMsgs:externalId'] = updated_record.external_id
         end
         hash
       end
 
+      def updated_record
+        @updated_record ||= @klass.new(@attributes)
+      end
+
       def success?
         @success ||= response_hash[:status][:@is_success] == 'true'
       end

data/lib/netsuite/errors.rb

@@ -1,4 +1,5 @@
 module NetSuite
   class RecordNotFound < StandardError; end
+  class InitializationError < StandardError; end
   class ConfigurationError < StandardError; end
 end

data/lib/netsuite/records/custom_field.rb

@@ -9,7 +9,6 @@ module NetSuite
       def initialize(attributes = {})
         @internal_id = attributes.delete(:internal_id) || attributes.delete(:@internal_id)
         @type        = attributes.delete(:type) || attributes.delete(:"@xsi:type")
-        @type        = @type.split(':').last if @type
         self.attributes = attributes
       end
 
@@ -20,11 +19,16 @@ module NetSuite
           hash[kname] = v
           hash
         end
-        hash_rec["#{record_namespace}:internalId"] = internal_id if internal_id
-        hash_rec["#{record_namespace}:type"]       = type if type
         hash_rec
       end
 
+      def attributes!
+        attr_hash = {}
+        attr_hash['internalId'] = internal_id if internal_id
+        attr_hash['xsi:type']       = type        if type
+        attr_hash
+      end
+
     end
   end
 end

data/lib/netsuite/records/custom_field_list.rb

@@ -17,7 +17,14 @@ module NetSuite
       end
 
       def to_record
-        { "#{record_namespace}:customField" => custom_fields.map(&:to_record) }
+        custom_fields.map do |custom_field|
+          {
+            "#{record_namespace}:customField" => custom_field.to_record,
+            :attributes! => {
+              "#{record_namespace}:customField" => custom_field.attributes!
+            }
+          }
+        end
       end
 
     end

data/lib/netsuite/records/invoice.rb

@@ -41,11 +41,19 @@ module NetSuite
       end
 
       def transaction_bill_address=(attrs)
-        attributes[:transaction_bill_address] = BillAddress.new(attrs)
+        attributes[:transaction_bill_address] = attrs.kind_of?(BillAddress) ? attrs : BillAddress.new(attrs)
+      end
+
+      def transaction_bill_address
+        attributes[:transaction_bill_address] ||= BillAddress.new
       end
 
       def transaction_ship_address=(attrs)
-        attributes[:transaction_ship_address] = ShipAddress.new(attrs)
+        attributes[:transaction_ship_address] = attrs.kind_of?(ShipAddress) ? attrs : ShipAddress.new(attrs)
+      end
+
+      def transaction_ship_address
+        attributes[:transaction_ship_address] ||= ShipAddress.new
       end
 
       def item_list
@@ -57,7 +65,7 @@ module NetSuite
       end
 
       def custom_field_list=(attrs)
-        attributes[:custom_field_list] = CustomFieldList.new(attrs)
+        attributes[:custom_field_list] = attrs.kind_of?(CustomFieldList) ? attrs : CustomFieldList.new(attrs)
       end
 
       def self.get(options = {})
@@ -74,7 +82,7 @@ module NetSuite
         if response.success?
           new(response.body)
         else
-          raise RecordNotFound, "#{self} with ID=#{id} could not be found"
+          raise InitializationError, "#{self}.initialize with #{customer} failed."
         end
       end
 

data/lib/netsuite/version.rb

@@ -1,3 +1,3 @@
 module Netsuite
-  VERSION = '0.0.16'
+  VERSION = '0.0.17'
 end

data/spec/netsuite/actions/update_spec.rb

@@ -3,9 +3,8 @@ require 'spec_helper'
 describe NetSuite::Actions::Update do
 
   context 'Customer' do
-    let(:customer) do
-      NetSuite::Records::Customer.new(:entity_id => 'Shutter Fly', :company_name => 'Shutter Fly, Inc.')
-    end
+    let(:customer) { NetSuite::Records::Customer.new }
+    let(:attributes) { { :entity_id => 'Shutter Fly', :company_name => 'Shutter Fly, Inc.' } }
 
     before do
       savon.expects(:update).with({
@@ -22,23 +21,21 @@ describe NetSuite::Actions::Update do
     end
 
     it 'makes a valid request to the NetSuite API' do
-      NetSuite::Actions::Update.call(customer)
+      NetSuite::Actions::Update.call(NetSuite::Records::Customer, attributes)
     end
 
     it 'returns a valid Response object' do
-      response = NetSuite::Actions::Update.call(customer)
+      response = NetSuite::Actions::Update.call(NetSuite::Records::Customer, attributes)
       response.should be_kind_of(NetSuite::Response)
       response.should be_success
     end
   end
 
   context 'Invoice' do
-    let(:invoice) do
-      NetSuite::Records::Invoice.new(:source => 'Google', :total => 100.0)
-    end
+    let(:invoice) { NetSuite::Records::Invoice.new }
+    let(:attributes) { { :source => 'Google', :total => 100.0 } }
 
     before do
-      pending
       savon.expects(:update).with({
         'platformMsgs:record' => {
           'listRel:source' => 'Google',
@@ -53,11 +50,11 @@ describe NetSuite::Actions::Update do
     end
 
     it 'makes a valid request to the NetSuite API' do
-      NetSuite::Actions::Update.call(invoice)
+      NetSuite::Actions::Update.call(NetSuite::Records::Invoice, attributes)
     end
 
     it 'returns a valid Response object' do
-      response = NetSuite::Actions::Update.call(invoice)
+      response = NetSuite::Actions::Update.call(NetSuite::Records::Invoice, attributes)
       response.should be_kind_of(NetSuite::Response)
       response.should be_success
     end

data/spec/netsuite/records/custom_record_spec.rb

@@ -44,7 +44,7 @@ describe NetSuite::Records::CustomRecord do
         lambda {
           NetSuite::Records::CustomRecord.get(:external_id => 1)
         }.should raise_error(NetSuite::RecordNotFound,
-          /NetSuite::Records::CustomRecord with OPTIONS={(.*)} could not be found/)
+          /NetSuite::Records::CustomRecord with OPTIONS=(.*) could not be found/)
       end
     end
   end

data/spec/support/fixtures/update/update_invoice.xml

@@ -0,0 +1,16 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<soapenv:Envelope xmlns:soapenv="http://schemas.xmlsoap.org/soap/envelope/" xmlns:xsd="http://www.w3.org/2001/XMLSchema" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance">
+  <soapenv:Header>
+    <platformMsgs:documentInfo xmlns:platformMsgs="urn:messages_2011_2.platform.webservices.netsuite.com">
+      <platformMsgs:nsId>WEBSERVICES_3392464_011320126577605972140734119_7ceea51ae8ee</platformMsgs:nsId>
+    </platformMsgs:documentInfo>
+  </soapenv:Header>
+  <soapenv:Body>
+    <updateResponse xmlns="urn:messages_2011_2.platform.webservices.netsuite.com">
+      <writeResponse>
+        <platformCore:status isSuccess="true" xmlns:platformCore="urn:core_2011_2.platform.webservices.netsuite.com"/>
+        <baseRef internalId="439" externalId="2187" type="invoice" xsi:type="platformCore:RecordRef" xmlns:platformCore="urn:core_2011_2.platform.webservices.netsuite.com"/>
+      </writeResponse>
+    </updateResponse>
+  </soapenv:Body>
+</soapenv:Envelope>

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification 
 name: netsuite
 version: !ruby/object:Gem::Version 
-  hash: 63
+  hash: 61
   prerelease: 
   segments: 
   - 0
   - 0
-  - 16
-  version: 0.0.16
+  - 17
+  version: 0.0.17
 platform: ruby
 authors: 
 - Ryan Moran
@@ -15,7 +15,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2012-01-13 00:00:00 Z
+date: 2012-01-14 00:00:00 Z
 dependencies: 
 - !ruby/object:Gem::Dependency 
   name: savon