netsoft-rubocop 1.1.9 → 1.1.11

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 6a0d1ee92ce41dac210aff7575ff6c36ce179b24d27c186797918b70402a7a26
-  data.tar.gz: 85727b896a601190f4a636b19e208618c851533850face137b7dc71354088351
+  metadata.gz: 631992cbc07c88809b99369140912e2f60489828ababe6478ccc60c466b4282d
+  data.tar.gz: 9479dbc7283e801e21c2bfe0847dc935c5ef1381a0dfddf1f7fb13d189b73f90
 SHA512:
-  metadata.gz: 21521b53f90fb9ee1982b5a82b12256189d86a53afdcb4a2ed95438faa6ae9704c874105934815ec205f5eca6e0c6b54d03571ab7f8f0d1e904a9f89de486c1d
-  data.tar.gz: ce205d3d13f12131fc597ac9265ef3d8d0d63898c7b1d15581cfdd193ea834d67d5d4e016b1f0517e7556aa19d74bfba8f4c4cab29a097eb889e06c81fe0879d
+  metadata.gz: 891a5e57b12bcd22cdbe72a7eb6e341823a7b9ae33c59b94d70f30ea33174d124c52fa697148fbe21b4193a386df91af5524b61e1b00e21d7f72e3fbf9daeea2
+  data.tar.gz: 160ae680afe2edf716d386b8e354cfb92499f082c36c2445a9d321c6a7ac83a33da2eef7a514ec6d3d6e6aba365031a7a37fcbc3442bd0e8a11883386c7a317c

data/CHANGELOG.md

@@ -10,6 +10,16 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 ### Changed
 ### Fixed
 
+## [1.1.11] - 2026-04-21
+### Changed
+- update rubocop, and rubocop-[everything] to latest possible versions as of April 2026
+- add new rules according to new cops emerged
+
+## [1.1.10] - 2025-08-11
+### Changed
+- update rubocop, and rubocop-[everything] to latest possible versions as of end of July 2025
+- add new rules according to new cops emerged
+
 ## [1.1.9] - 2024-06-17
 ### Changed
 - update rubocop, and rubocop-[everything] to latest possible versions that support Ruby 2

data/config/default.yml

@@ -1,5 +1,8 @@
 require:
   - ../lib/netsoft/rubocop/cops/netsoft/auth_http_positional_arguments
+  - rubocop-graphql
+
+plugins:
   - rubocop-rails
   - rubocop-performance
   - rubocop-rspec
@@ -7,7 +10,6 @@ require:
   - rubocop-capybara
   - rubocop-rspec_rails
   - rubocop-factory_bot
-  - rubocop-graphql
 
 AllCops:
   TargetRubyVersion: 2.5
@@ -86,6 +88,21 @@ Lint/NonDeterministicRequireOrder:
 
 Lint/StructNewOverride:
   Enabled: false
+
+# Is unhappy when a constant declared in `private` section of the module, because it doesn't make
+# the constant really private. But we don't really care if the constant is inaccessible to class'
+# clients, and use this layout to have constants closer to where they are used for algorithms.
+Lint/UselessConstantScoping:
+  Enabled: false
+
+# Is offended by
+#   some_obj&.predicate? && some_obj&.other_predicate?
+# ...and suggests to change it to:
+#   some_obj&.predicate? && some_obj.other_predicate?
+# (because in second case, if the expression is evaluated, we know some_obj is definitely present).
+# But it looks confusing, and might introduce sudden bugs if conditions are removed or switched.
+Lint/SafeNavigationConsistency:
+  Enabled: false
 #endregion
 
 # region Naming
@@ -116,12 +133,23 @@ Naming/MethodParameterName:
     - uo
     - up
 
-Naming/PredicateName:
+Naming/PredicatePrefix:
   # By default, it also forbids has_, but that's rarely a good suggestion:
   # is #has_screenshots? => #screenshots? better?..
   ForbiddenPrefixes:
     - is_
 
+# Checks if every return value of the method is boolean, and if so, requires method name to
+# end with "?"
+Naming/PredicateMethod:
+  # We exclude methods that have typical usage pattern "do work and return true if all valid"
+  AllowedMethods:
+    - call
+    - perform
+    - perform_work
+    - save
+    - save!
+
 Naming/VariableNumber:
   Enabled: false
 # endregion
@@ -271,6 +299,19 @@ RSpec/UndescriptiveLiteralsDescription:
 Capybara/NegationMatcher:
   Enabled: false
 
+# Prohibits all and every case like
+#   foo = some.calculated.values
+#
+#   it_should_behave_like 'some context', foo
+#
+#   # or
+#   foo.each do
+#     context "when #{_1}"
+#
+# Those are useful cases with no drawbacks, but rspec-rubocop still considers them "leaky"
+RSpec/LeakyLocalVariable:
+  Enabled: false
+
 # endregion
 
 # region Style
@@ -328,8 +369,17 @@ Style/FormatString:
 Style/FormatStringToken:
   Enabled: false
 
+# Enforces, when there is a hash in the end of the array, to either always use
+#   [foo, bar, {baz: blah}]
+# or always
+#   [foo, bar, baz: blah]
+#
+# Both are OK, and might be cleaner/better visible depending on the context.
 Style/HashAsLastArrayItem:
-  EnforcedStyle: no_braces
+  Enabled: false
+
+Style/HashSyntax:
+  EnforcedShorthandSyntax: always
 
 Style/Lambda:
   EnforcedStyle: literal
@@ -359,6 +409,11 @@ Style/NumberedParameters:
 Style/NumberedParametersLimit:
   Max: 2
 
+# That's a "reasonable default", which there is no need to enforce. Sometimes small utility files or
+# core_ext.rb might want to digress, and nobody will die.
+Style/OneClassPerFile:
+  Enabled: false
+
 # Just prohibits OpenStruct forever. Technically reasonable, but when we use it, we know what we do
 Style/OpenStructUse:
   Enabled: false
@@ -383,6 +438,14 @@ Style/RescueModifier:
 Style/RescueStandardError:
   Enabled: false
 
+# Limits number of calls in chaing with safe navigation, e.g. `foo&.bar&.baz` is OK,
+# but `foo&.bar&.baz&.blah&.fetch('foo')&.length` is not.
+# Might be a reasonable idea _sometimes_, but long chains are frequently the clearest way to
+# invoke something that can be absent at several points. The constant limit of chain length
+# doesn't bring much value.
+Style/SafeNavigationChainLength:
+  Enabled: false
+
 Style/SingleArgumentDig:
   Enabled: false
 

data/lib/netsoft/rubocop/cops/netsoft/auth_http_positional_arguments.rb

@@ -18,7 +18,7 @@ module RuboCop
       #
       #   # good
       #   get :new, params: { user_id: 1 }
-      class AuthHttpPositionalArguments < Cop
+      class AuthHttpPositionalArguments < Base
         extend RuboCop::Cop::TargetRailsVersion
 
         MSG = 'Use keyword arguments instead of positional arguments for http call: `%<verb>s`.'

data/lib/netsoft/rubocop/version.rb

@@ -2,6 +2,6 @@
 
 module Netsoft
   module Rubocop
-    VERSION = '1.1.9'
+    VERSION = '1.1.11'
   end
 end

metadata

@@ -1,15 +1,15 @@
 --- !ruby/object:Gem::Specification
 name: netsoft-rubocop
 version: !ruby/object:Gem::Version
-  version: 1.1.9
+  version: 1.1.11
 platform: ruby
 authors:
 - Alex Yarotsky
 - Edward Rudd
-autorequire: 
+autorequire:
 bindir: bin
 cert_chain: []
-date: 2024-06-17 00:00:00.000000000 Z
+date: 2026-04-23 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop
@@ -17,14 +17,14 @@ dependencies:
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 1.64.1
+        version: 1.86.1
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 1.64.1
+        version: 1.86.1
 - !ruby/object:Gem::Dependency
   name: rubocop-graphql
   requirement: !ruby/object:Gem::Requirement
@@ -45,99 +45,99 @@ dependencies:
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 1.21.0
+        version: 1.26.1
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 1.21.0
+        version: 1.26.1
 - !ruby/object:Gem::Dependency
   name: rubocop-rails
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 2.25.0
+        version: 2.34.3
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 2.25.0
+        version: 2.34.3
 - !ruby/object:Gem::Dependency
   name: rubocop-rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 0.6.0
+        version: 0.7.1
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 0.6.0
+        version: 0.7.1
 - !ruby/object:Gem::Dependency
   name: rubocop-rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 3.0.1
+        version: 3.9.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 3.0.1
+        version: 3.9.0
 - !ruby/object:Gem::Dependency
   name: rubocop-capybara
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 2.21.0
+        version: 2.22.1
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 2.21.0
+        version: 2.22.1
 - !ruby/object:Gem::Dependency
   name: rubocop-factory_bot
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 2.26.1
+        version: 2.28.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 2.26.1
+        version: 2.28.0
 - !ruby/object:Gem::Dependency
   name: rubocop-rspec_rails
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 2.30.0
+        version: 2.32.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 2.30.0
-description: 
+        version: 2.32.0
+description:
 email:
 - alex.yarotsky@hubstaff.com
 - edward@hubstaff.com
@@ -159,7 +159,7 @@ files:
 homepage: https://github.com/netsoftHoldings/netsoft-rubocop
 licenses: []
 metadata: {}
-post_install_message: 
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -175,7 +175,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubygems_version: 3.4.19
-signing_key: 
+signing_key:
 specification_version: 4
 summary: Hubstaff style guides and shared style configs.
 test_files: []