netsoft-rubocop 1.1.9 → 1.1.10

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 6a0d1ee92ce41dac210aff7575ff6c36ce179b24d27c186797918b70402a7a26
-  data.tar.gz: 85727b896a601190f4a636b19e208618c851533850face137b7dc71354088351
+  metadata.gz: 7949f296d24db9ce23537b92dcdd5b88e517f60719f44ace6f5f32cbde3d80a1
+  data.tar.gz: a873c697e55edbfd93e1286bb48ab48438a1a1c62d424aa35bbc05f422e0223f
 SHA512:
-  metadata.gz: 21521b53f90fb9ee1982b5a82b12256189d86a53afdcb4a2ed95438faa6ae9704c874105934815ec205f5eca6e0c6b54d03571ab7f8f0d1e904a9f89de486c1d
-  data.tar.gz: ce205d3d13f12131fc597ac9265ef3d8d0d63898c7b1d15581cfdd193ea834d67d5d4e016b1f0517e7556aa19d74bfba8f4c4cab29a097eb889e06c81fe0879d
+  metadata.gz: 623f5223d4586481783eefbc009687a8415441f29922a129e643391cf1f8c745a84b80da4cdd50b78a2fb9eff9b49621fe9f6ddce4abe94cb599a123da4c1b52
+  data.tar.gz: 6e62923f845960b3faf13da5be63e378bf5bb62c836732356aace8ecf2ac9b082e07ca19eb3cf1f3a9839c99a858e2bdf76f5f4c5f1ddc7c48214451f143f14a

data/CHANGELOG.md

@@ -10,6 +10,11 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 ### Changed
 ### Fixed
 
+## [1.1.10] - 2025-08-11
+### Changed
+- update rubocop, and rubocop-[everything] to latest possible versions as of end of July 2025
+- add new rules according to new cops emerged
+
 ## [1.1.9] - 2024-06-17
 ### Changed
 - update rubocop, and rubocop-[everything] to latest possible versions that support Ruby 2

data/config/default.yml

@@ -1,5 +1,8 @@
 require:
   - ../lib/netsoft/rubocop/cops/netsoft/auth_http_positional_arguments
+  - rubocop-graphql
+
+plugins:
   - rubocop-rails
   - rubocop-performance
   - rubocop-rspec
@@ -7,7 +10,6 @@ require:
   - rubocop-capybara
   - rubocop-rspec_rails
   - rubocop-factory_bot
-  - rubocop-graphql
 
 AllCops:
   TargetRubyVersion: 2.5
@@ -86,6 +88,21 @@ Lint/NonDeterministicRequireOrder:
 
 Lint/StructNewOverride:
   Enabled: false
+
+# Is unhappy when a constant declared in `private` section of the module, because it doesn't make
+# the constant really private. But we don't really care if the constant is inaccessible to class'
+# clients, and use this layout to have constants closer to where they are used for algorithms.
+Lint/UselessConstantScoping:
+  Enabled: false
+
+# Is offended by
+#   some_obj&.predicate? && some_obj&.other_predicate?
+# ...and suggests to change it to:
+#   some_obj&.predicate? && some_obj.other_predicate?
+# (because in second case, if the expression is evaluated, we know some_obj is definitely present).
+# But it looks confusing, and might introduce sudden bugs if conditions are removed or switched.
+Lint/SafeNavigationConsistency:
+  Enabled: false
 #endregion
 
 # region Naming
@@ -116,12 +133,23 @@ Naming/MethodParameterName:
     - uo
     - up
 
-Naming/PredicateName:
+Naming/PredicatePrefix:
   # By default, it also forbids has_, but that's rarely a good suggestion:
   # is #has_screenshots? => #screenshots? better?..
   ForbiddenPrefixes:
     - is_
 
+# Checks if every return value of the method is boolean, and if so, requires method name to
+# end with "?"
+Naming/PredicateMethod:
+  # We exclude methods that have typical usage pattern "do work and return true if all valid"
+  AllowedMethods:
+    - call
+    - perform
+    - perform_work
+    - save
+    - save!
+
 Naming/VariableNumber:
   Enabled: false
 # endregion
@@ -331,6 +359,9 @@ Style/FormatStringToken:
 Style/HashAsLastArrayItem:
   EnforcedStyle: no_braces
 
+Style/HashSyntax:
+  EnforcedShorthandSyntax: always
+
 Style/Lambda:
   EnforcedStyle: literal
 
@@ -383,6 +414,14 @@ Style/RescueModifier:
 Style/RescueStandardError:
   Enabled: false
 
+# Limits number of calls in chaing with safe navigation, e.g. `foo&.bar&.baz` is OK,
+# but `foo&.bar&.baz&.blah&.fetch('foo')&.length` is not.
+# Might be a reasonable idea _sometimes_, but long chains are frequently the clearest way to
+# invoke something that can be absent at several points. The constant limit of chain length
+# doesn't bring much value.
+Style/SafeNavigationChainLength:
+  Enabled: false
+
 Style/SingleArgumentDig:
   Enabled: false
 

data/lib/netsoft/rubocop/cops/netsoft/auth_http_positional_arguments.rb

@@ -18,7 +18,7 @@ module RuboCop
       #
       #   # good
       #   get :new, params: { user_id: 1 }
-      class AuthHttpPositionalArguments < Cop
+      class AuthHttpPositionalArguments < Base
         extend RuboCop::Cop::TargetRailsVersion
 
         MSG = 'Use keyword arguments instead of positional arguments for http call: `%<verb>s`.'

data/lib/netsoft/rubocop/version.rb

@@ -2,6 +2,6 @@
 
 module Netsoft
   module Rubocop
-    VERSION = '1.1.9'
+    VERSION = '1.1.10'
   end
 end

metadata

@@ -1,15 +1,15 @@
 --- !ruby/object:Gem::Specification
 name: netsoft-rubocop
 version: !ruby/object:Gem::Version
-  version: 1.1.9
+  version: 1.1.10
 platform: ruby
 authors:
 - Alex Yarotsky
 - Edward Rudd
-autorequire: 
+autorequire:
 bindir: bin
 cert_chain: []
-date: 2024-06-17 00:00:00.000000000 Z
+date: 2025-08-11 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop
@@ -17,14 +17,14 @@ dependencies:
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 1.64.1
+        version: 1.79.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 1.64.1
+        version: 1.79.0
 - !ruby/object:Gem::Dependency
   name: rubocop-graphql
   requirement: !ruby/object:Gem::Requirement
@@ -45,99 +45,99 @@ dependencies:
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 1.21.0
+        version: 1.25.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 1.21.0
+        version: 1.25.0
 - !ruby/object:Gem::Dependency
   name: rubocop-rails
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 2.25.0
+        version: 2.32.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 2.25.0
+        version: 2.32.0
 - !ruby/object:Gem::Dependency
   name: rubocop-rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 0.6.0
+        version: 0.7.1
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 0.6.0
+        version: 0.7.1
 - !ruby/object:Gem::Dependency
   name: rubocop-rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 3.0.1
+        version: 3.6.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 3.0.1
+        version: 3.6.0
 - !ruby/object:Gem::Dependency
   name: rubocop-capybara
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 2.21.0
+        version: 2.22.1
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 2.21.0
+        version: 2.22.1
 - !ruby/object:Gem::Dependency
   name: rubocop-factory_bot
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 2.26.1
+        version: 2.27.1
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 2.26.1
+        version: 2.27.1
 - !ruby/object:Gem::Dependency
   name: rubocop-rspec_rails
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 2.30.0
+        version: 2.31.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 2.30.0
-description: 
+        version: 2.31.0
+description:
 email:
 - alex.yarotsky@hubstaff.com
 - edward@hubstaff.com
@@ -159,7 +159,7 @@ files:
 homepage: https://github.com/netsoftHoldings/netsoft-rubocop
 licenses: []
 metadata: {}
-post_install_message: 
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -175,7 +175,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubygems_version: 3.4.19
-signing_key: 
+signing_key:
 specification_version: 4
 summary: Hubstaff style guides and shared style configs.
 test_files: []