netsoft-rubocop 1.1.8 → 1.1.10

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 6c7abd8532a60251c8b7e284add09679ca54b6c6e1005b57d6ca6fd1844388bb
-  data.tar.gz: 7c51054e4c9c09f76ca819c406520ca0154487f3ad3fef9da17fb122aabff945
+  metadata.gz: 7949f296d24db9ce23537b92dcdd5b88e517f60719f44ace6f5f32cbde3d80a1
+  data.tar.gz: a873c697e55edbfd93e1286bb48ab48438a1a1c62d424aa35bbc05f422e0223f
 SHA512:
-  metadata.gz: 75a84526711ff8368a1507b438bb1b8bc14aab96e6eae5c5538e3c47ee73da65c1ffaacebd49ad3982a93fa167921e4a0673bd3ebdc3a4e7d2962c1bec247b7d
-  data.tar.gz: 4b8b15ab4b57bd4851ae03f866be09047089bc24770837b4b5022ff18e5f51101cc16b9b0079653b6011aec2c9c964fd2d684e53701f832b8f89bd3a0297d798
+  metadata.gz: 623f5223d4586481783eefbc009687a8415441f29922a129e643391cf1f8c745a84b80da4cdd50b78a2fb9eff9b49621fe9f6ddce4abe94cb599a123da4c1b52
+  data.tar.gz: 6e62923f845960b3faf13da5be63e378bf5bb62c836732356aace8ecf2ac9b082e07ca19eb3cf1f3a9839c99a858e2bdf76f5f4c5f1ddc7c48214451f143f14a

data/CHANGELOG.md

@@ -10,6 +10,16 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 ### Changed
 ### Fixed
 
+## [1.1.10] - 2025-08-11
+### Changed
+- update rubocop, and rubocop-[everything] to latest possible versions as of end of July 2025
+- add new rules according to new cops emerged
+
+## [1.1.9] - 2024-06-17
+### Changed
+- update rubocop, and rubocop-[everything] to latest possible versions that support Ruby 2
+- add new rules according to new cops emerged
+
 ## [1.1.8] - 2023-12-12
 ### Fixed
 - fix dependency on gems that are only necessary for CI

data/config/default.yml

@@ -1,12 +1,15 @@
 require:
   - ../lib/netsoft/rubocop/cops/netsoft/auth_http_positional_arguments
+  - rubocop-graphql
+
+plugins:
   - rubocop-rails
   - rubocop-performance
   - rubocop-rspec
   - rubocop-rake
   - rubocop-capybara
+  - rubocop-rspec_rails
   - rubocop-factory_bot
-  - rubocop-graphql
 
 AllCops:
   TargetRubyVersion: 2.5
@@ -85,6 +88,21 @@ Lint/NonDeterministicRequireOrder:
 
 Lint/StructNewOverride:
   Enabled: false
+
+# Is unhappy when a constant declared in `private` section of the module, because it doesn't make
+# the constant really private. But we don't really care if the constant is inaccessible to class'
+# clients, and use this layout to have constants closer to where they are used for algorithms.
+Lint/UselessConstantScoping:
+  Enabled: false
+
+# Is offended by
+#   some_obj&.predicate? && some_obj&.other_predicate?
+# ...and suggests to change it to:
+#   some_obj&.predicate? && some_obj.other_predicate?
+# (because in second case, if the expression is evaluated, we know some_obj is definitely present).
+# But it looks confusing, and might introduce sudden bugs if conditions are removed or switched.
+Lint/SafeNavigationConsistency:
+  Enabled: false
 #endregion
 
 # region Naming
@@ -115,12 +133,23 @@ Naming/MethodParameterName:
     - uo
     - up
 
-Naming/PredicateName:
+Naming/PredicatePrefix:
   # By default, it also forbids has_, but that's rarely a good suggestion:
   # is #has_screenshots? => #screenshots? better?..
   ForbiddenPrefixes:
     - is_
 
+# Checks if every return value of the method is boolean, and if so, requires method name to
+# end with "?"
+Naming/PredicateMethod:
+  # We exclude methods that have typical usage pattern "do work and return true if all valid"
+  AllowedMethods:
+    - call
+    - perform
+    - perform_work
+    - save
+    - save!
+
 Naming/VariableNumber:
   Enabled: false
 # endregion
@@ -251,9 +280,25 @@ RSpec/SortMetadata:
   Enabled: false
 
 # Same as for Rails/HttpStatus
-RSpec/Rails/HttpStatus:
+RSpecRails/HttpStatus:
   EnforcedStyle: numeric
 
+# Limits an amount of items created by `create_list`. This should be a human decision on review, not
+# mechanical limitation.
+FactoryBot/ExcessiveCreateList:
+  Enabled: false
+
+# Prohibits literals like numbers in the descriptions; which might sometimes be useful, and also conflicts
+# with `its_call(number)` (which it understands like a description).
+RSpec/UndescriptiveLiteralsDescription:
+  Enabled: false
+
+# Enforces either `to have_no_selector` (the default) or `to_not have_selector` (a setting).
+# We use the latter in our codebase, but there is no reason to strictly prohibit the former (it
+# might be used in chains), so no biggie.
+Capybara/NegationMatcher:
+  Enabled: false
+
 # endregion
 
 # region Style
@@ -314,6 +359,9 @@ Style/FormatStringToken:
 Style/HashAsLastArrayItem:
   EnforcedStyle: no_braces
 
+Style/HashSyntax:
+  EnforcedShorthandSyntax: always
+
 Style/Lambda:
   EnforcedStyle: literal
 
@@ -366,6 +414,14 @@ Style/RescueModifier:
 Style/RescueStandardError:
   Enabled: false
 
+# Limits number of calls in chaing with safe navigation, e.g. `foo&.bar&.baz` is OK,
+# but `foo&.bar&.baz&.blah&.fetch('foo')&.length` is not.
+# Might be a reasonable idea _sometimes_, but long chains are frequently the clearest way to
+# invoke something that can be absent at several points. The constant limit of chain length
+# doesn't bring much value.
+Style/SafeNavigationChainLength:
+  Enabled: false
+
 Style/SingleArgumentDig:
   Enabled: false
 

data/lib/netsoft/rubocop/cops/netsoft/auth_http_positional_arguments.rb

@@ -18,7 +18,7 @@ module RuboCop
       #
       #   # good
       #   get :new, params: { user_id: 1 }
-      class AuthHttpPositionalArguments < Cop
+      class AuthHttpPositionalArguments < Base
         extend RuboCop::Cop::TargetRailsVersion
 
         MSG = 'Use keyword arguments instead of positional arguments for http call: `%<verb>s`.'

data/lib/netsoft/rubocop/version.rb

@@ -2,6 +2,6 @@
 
 module Netsoft
   module Rubocop
-    VERSION = '1.1.8'
+    VERSION = '1.1.10'
   end
 end

metadata

@@ -1,15 +1,15 @@
 --- !ruby/object:Gem::Specification
 name: netsoft-rubocop
 version: !ruby/object:Gem::Version
-  version: 1.1.8
+  version: 1.1.10
 platform: ruby
 authors:
 - Alex Yarotsky
 - Edward Rudd
-autorequire: 
+autorequire:
 bindir: bin
 cert_chain: []
-date: 2023-12-19 00:00:00.000000000 Z
+date: 2025-08-11 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rubocop
@@ -17,14 +17,14 @@ dependencies:
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 1.57.0
+        version: 1.79.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 1.57.0
+        version: 1.79.0
 - !ruby/object:Gem::Dependency
   name: rubocop-graphql
   requirement: !ruby/object:Gem::Requirement
@@ -45,57 +45,99 @@ dependencies:
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 1.19.1
+        version: 1.25.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 1.19.1
+        version: 1.25.0
 - !ruby/object:Gem::Dependency
   name: rubocop-rails
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 2.21.2
+        version: 2.32.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 2.21.2
+        version: 2.32.0
 - !ruby/object:Gem::Dependency
   name: rubocop-rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 0.6.0
+        version: 0.7.1
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 0.6.0
+        version: 0.7.1
 - !ruby/object:Gem::Dependency
   name: rubocop-rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 2.24.1
+        version: 3.6.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 2.24.1
-description: 
+        version: 3.6.0
+- !ruby/object:Gem::Dependency
+  name: rubocop-capybara
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - '='
+      - !ruby/object:Gem::Version
+        version: 2.22.1
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - '='
+      - !ruby/object:Gem::Version
+        version: 2.22.1
+- !ruby/object:Gem::Dependency
+  name: rubocop-factory_bot
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - '='
+      - !ruby/object:Gem::Version
+        version: 2.27.1
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - '='
+      - !ruby/object:Gem::Version
+        version: 2.27.1
+- !ruby/object:Gem::Dependency
+  name: rubocop-rspec_rails
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - '='
+      - !ruby/object:Gem::Version
+        version: 2.31.0
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - '='
+      - !ruby/object:Gem::Version
+        version: 2.31.0
+description:
 email:
 - alex.yarotsky@hubstaff.com
 - edward@hubstaff.com
@@ -117,7 +159,7 @@ files:
 homepage: https://github.com/netsoftHoldings/netsoft-rubocop
 licenses: []
 metadata: {}
-post_install_message: 
+post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -132,8 +174,8 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.4.10
-signing_key: 
+rubygems_version: 3.4.19
+signing_key:
 specification_version: 4
 summary: Hubstaff style guides and shared style configs.
 test_files: []