netsoft-rubocop 1.1.5 → 1.1.7

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 137bac43dbc24c4c97d694b86c893d4d8ea0d1257484502e6f4b5b3bd2397f81
-  data.tar.gz: d5572d8300095922e67612bb861a717b325f9dcc1c970b48b2063ac9d0156366
+  metadata.gz: 61d6a9eefb4b10ca7c1c7688b1307eb6f8fa66642e9629c16e9b5e70e9be48b1
+  data.tar.gz: 23afa0de0b2926dd3f8e1a2c0039d5d92323a2160cba8072dfce3809350bf03e
 SHA512:
-  metadata.gz: d0363016db98c292c39722f2002ebeb1e3bb328830ec67f509e91521da6faa51cd5d63ba24bfffdea7f4d10cd9e38926938b60c4311778a45fdee04cc4bb098d
-  data.tar.gz: 21b11561021e15205431a124d6aca6e28f7f1c3a614c45ac218c0c336c82101cbeeedd534ff0b65a9c2812275c46565a22b96432e2942236e81629a163265ac5
+  metadata.gz: 8f4a57da2cd304d4ddc6fc729b3097baaea0f79f41eb2d17420307a385cd622f12e6a393215c674c8ae080f92765c78932953dd0a1ce0c18b2f94e02d4a26a79
+  data.tar.gz: 543f87a74d13cd5af7555791463d2dbeb95769f0314b2d29d8b42300884fb4e49110aea9cd063816888c9eccaae831ddb3762c1280fcaa58bb998611180a90ce

data/CHANGELOG.md

@@ -10,6 +10,17 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 ### Changed
 ### Fixed
 
+## [1.1.7] - 2023-10-18
+### Changed
+- update rubocop, and rubocop-[everything] to latest versions
+- add new rules according to new cops emerged
+
+
+## [1.1.6] - 2023-05-31
+### Changed
+- update rubocop, and rubocop-[everything] to latest versions
+- add new rules according to new cops emerged
+
 ## [1.1.5] - 2022-03-18
 ### Changed
 - adjust assignment indent rule to be default 2 space indent

data/config/default.yml

@@ -4,6 +4,9 @@ require:
   - rubocop-performance
   - rubocop-rspec
   - rubocop-rake
+  - rubocop-capybara
+  - rubocop-factory_bot
+  - rubocop-graphql
 
 AllCops:
   TargetRubyVersion: 2.5
@@ -12,6 +15,7 @@ AllCops:
   StyleGuideBaseURL: https://rubystyle.guide
   NewCops: enable
   Exclude:
+    - 'bin/**/*'
     - 'db/**/*'
     - 'coverage/**/*'
     - 'log/**/*'
@@ -21,6 +25,7 @@ AllCops:
     - 'vendor/**/*'
     - 'gemfiles/**/*'
     - 'node_modules/**/*'
+    - '.pryrc'
 
 # Checks that the gemspec has metadata to require MFA from RubyGems
 # Irrelevant for internal gems
@@ -31,6 +36,12 @@ Gemspec/RequireMFA:
 Layout/AssignmentIndentation:
   IndentationWidth: 2
 
+# prohibits empty line before `rescue`. But `rescue` frequently a complicated statement, and
+# last body's statement before it might be complicated too, so there is no reason to not put
+# an extra line there if the writer wants.
+Layout/EmptyLinesAroundExceptionHandlingKeywords:
+  Enabled: false
+
 Layout/ExtraSpacing:
   AllowForAlignment: true
 
@@ -44,6 +55,9 @@ Layout/FirstArrayElementIndentation:
 Layout/FirstHashElementIndentation:
   EnforcedStyle: consistent
 
+Layout/LineContinuationSpacing:
+  EnforcedStyle: no_space
+
 Layout/SpaceInsideBlockBraces:
   EnforcedStyle: space
   SpaceBeforeBlockParameters: true
@@ -139,6 +153,13 @@ Performance/TimesMap:
 Rails:
   Enabled: true
 
+# Requires to always use `I18n.t('foo.bar.baz')` instead of I18n.t(:baz, scope: [:foo, :bar])`
+# because it is "easier to read".
+# The latter is superior when scopes are dynamic, or just very long. Cop doesn't have a setting
+# for one style or another, just always forces dots.
+Rails/DotSeparatedKeys:
+  Enabled: false
+
 Rails/FilePath:
   EnforcedStyle: arguments
 
@@ -152,6 +173,11 @@ Rails/HttpPositionalArguments:
 Rails/HttpStatus:
   EnforcedStyle: numeric
 
+# Forces _all_ strings to be in locales. Not gonna happen in any foreseeable future.
+Rails/I18nLocaleTexts:
+  Enabled: false
+
+
 # The cop states that if you have `belongs_to :organization`, the validator is added automatically,
 # so you don't need `validates :organization, presence: true` (or `validates :organization_id`).
 #
@@ -177,10 +203,16 @@ Netsoft/AuthHttpPositionalArguments:
 # endregion
 
 # region RSpec
+
 # Prohibits before/after(:all) for ever uses. But when we use it, we know what we do
 RSpec/BeforeAfterAll:
   Enabled: false
 
+# Unnecessary formality to require replacing `eq true` with `be true`
+# (for true, false and nil) because it is "stricter".
+RSpec/BeEq:
+  Enabled: false
+
 RSpec/ExpectChange:
   EnforcedStyle: block
 
@@ -214,6 +246,14 @@ RSpec/NestedGroups:
 RSpec/NotToNot:
   EnforcedStyle: to_not
 
+# Wants metadata keys to be alphabetically sorted. Like, really?..
+RSpec/SortMetadata:
+  Enabled: false
+
+# Same as for Rails/HttpStatus
+RSpec/Rails/HttpStatus:
+  EnforcedStyle: numeric
+
 # endregion
 
 # region Style
@@ -253,6 +293,11 @@ Style/DocumentDynamicEvalDefinition:
 Style/DoubleNegation:
   Enabled: false
 
+# Requires to replace all (0..10).each { ... } with 10.times { ... }
+# Not always the most expressive option.
+Style/EachForSimpleLoop:
+  Enabled: false
+
 # Asks to write empty methods this way:
 #
 #    def foo; end
@@ -272,6 +317,13 @@ Style/HashAsLastArrayItem:
 Style/Lambda:
   EnforcedStyle: literal
 
+# Forces to change `foo = val < 0 ? 0 : val` to `foo = [0, val].max`
+# Proper readable change is actually `foo = val.clamp(0..)`, but there is no such option.
+# The one with max/min produces weird-ish statements frequently, so it is better to wait for
+# a clamp-ing cop or create it ourselves.
+Style/MinMaxComparison:
+  Enabled: false
+
 Style/MultilineBlockChain:
   Enabled: false
 
@@ -301,6 +353,11 @@ Style/QuotedSymbols:
 Style/ParallelAssignment:
   Enabled: false
 
+# Prohibits `::Foo` style constants unless strictly necessary. Reasonable, but glitches with
+# autoloading/guessing from where to autoload.
+Style/RedundantConstantBase:
+  Enabled: false
+
 Style/RescueModifier:
   Enabled: false
 

data/lib/netsoft/rubocop/version.rb

@@ -2,6 +2,6 @@
 
 module Netsoft
   module Rubocop
-    VERSION = '1.1.5'
+    VERSION = '1.1.7'
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: netsoft-rubocop
 version: !ruby/object:Gem::Version
-  version: 1.1.5
+  version: 1.1.7
 platform: ruby
 authors:
 - Alex Yarotsky
@@ -9,78 +9,92 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2022-03-18 00:00:00.000000000 Z
+date: 2023-10-18 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
-  name: bundler
+  name: bigdecimal
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - "<="
       - !ruby/object:Gem::Version
-        version: '1.15'
-  type: :development
+        version: 3.1.3
+  type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - "<="
       - !ruby/object:Gem::Version
-        version: '1.15'
+        version: 3.1.3
 - !ruby/object:Gem::Dependency
-  name: rake
+  name: racc
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "<="
       - !ruby/object:Gem::Version
-        version: '12.0'
-  type: :development
+        version: 1.6.2
+  type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "<="
       - !ruby/object:Gem::Version
-        version: '12.0'
+        version: 1.6.2
 - !ruby/object:Gem::Dependency
   name: rubocop
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 1.25.0
+        version: 1.57.0
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - '='
+      - !ruby/object:Gem::Version
+        version: 1.57.0
+- !ruby/object:Gem::Dependency
+  name: rubocop-graphql
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - '='
+      - !ruby/object:Gem::Version
+        version: 1.1.1
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 1.25.0
+        version: 1.1.1
 - !ruby/object:Gem::Dependency
   name: rubocop-performance
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 1.13.2
+        version: 1.19.1
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 1.13.2
+        version: 1.19.1
 - !ruby/object:Gem::Dependency
   name: rubocop-rails
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 2.13.2
+        version: 2.21.2
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 2.13.2
+        version: 2.21.2
 - !ruby/object:Gem::Dependency
   name: rubocop-rake
   requirement: !ruby/object:Gem::Requirement
@@ -101,14 +115,14 @@ dependencies:
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 2.7.0
+        version: 2.24.1
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 2.7.0
+        version: 2.24.1
 description: 
 email:
 - alex.yarotsky@hubstaff.com
@@ -139,14 +153,14 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: '2.4'
+      version: '2.7'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.0.3
+rubygems_version: 3.4.10
 signing_key: 
 specification_version: 4
 summary: Hubstaff style guides and shared style configs.