netsoft-rubocop 1.1.3.beta1 → 1.1.5

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
checksums.yaml CHANGED
@@ -1,7 +1,7 @@
1
1
  ---
2
2
  SHA256:
3
- metadata.gz: 43c5f6140cb57936431a1eb6d8736dffeaff0d581098906dd830c755ba9d7ef4
4
- data.tar.gz: d6583255ec92163e3799ac9d5dc2fc52763843cb3eba53f2295d64d9305c0cc6
3
+ metadata.gz: 137bac43dbc24c4c97d694b86c893d4d8ea0d1257484502e6f4b5b3bd2397f81
4
+ data.tar.gz: d5572d8300095922e67612bb861a717b325f9dcc1c970b48b2063ac9d0156366
5
5
  SHA512:
6
- metadata.gz: 3564de283848dc3880fa55f64904a281aed3a86a7e1d70bfb65edbce2ca637a78ca9238653e010ab297d9d3eaf43331b42083584a95503b8024f1daa9ddfee2b
7
- data.tar.gz: fe4f50ea5f47770ed185639f080099d8573938c67fee39e382c4390ea762741022a809a3c1bbc1a15c738befd6d6c3856019af2d26315e868184776a31e934e3
6
+ metadata.gz: d0363016db98c292c39722f2002ebeb1e3bb328830ec67f509e91521da6faa51cd5d63ba24bfffdea7f4d10cd9e38926938b60c4311778a45fdee04cc4bb098d
7
+ data.tar.gz: 21b11561021e15205431a124d6aca6e28f7f1c3a614c45ac218c0c336c82101cbeeedd534ff0b65a9c2812275c46565a22b96432e2942236e81629a163265ac5
data/CHANGELOG.md CHANGED
@@ -10,6 +10,14 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
10
10
  ### Changed
11
11
  ### Fixed
12
12
 
13
+ ## [1.1.5] - 2022-03-18
14
+ ### Changed
15
+ - adjust assignment indent rule to be default 2 space indent
16
+
17
+ ## [1.1.4] - 2022-01-26
18
+ ### Changed
19
+ - update rubocop, and rubocop-[everything] to latest versions
20
+
13
21
  ## [1.1.3] - 2021-05-10
14
22
  ### Changed
15
23
  - update rubocop, and rubocop-[everything] to latest versions
data/config/default.yml CHANGED
@@ -22,9 +22,14 @@ AllCops:
22
22
  - 'gemfiles/**/*'
23
23
  - 'node_modules/**/*'
24
24
 
25
+ # Checks that the gemspec has metadata to require MFA from RubyGems
26
+ # Irrelevant for internal gems
27
+ Gemspec/RequireMFA:
28
+ Enabled: false
29
+
25
30
  # region Layout
26
31
  Layout/AssignmentIndentation:
27
- IndentationWidth: 4
32
+ IndentationWidth: 2
28
33
 
29
34
  Layout/ExtraSpacing:
30
35
  AllowForAlignment: true
@@ -52,6 +57,15 @@ Lint/AmbiguousBlockAssociation:
52
57
  Exclude:
53
58
  - spec/**/*
54
59
 
60
+ # Requires to change `foo + bar * baz` into `foo + (bar * baz)` for clarity. WHAT.
61
+ Lint/AmbiguousOperatorPrecedence:
62
+ Enabled: false
63
+
64
+ # Prohibits ranges like 1.minute..5.minutes, and wants them to look like (1.minute)..(5.minutes)
65
+ # Please no.
66
+ Lint/AmbiguousRange:
67
+ Enabled: false
68
+
55
69
  Lint/NonDeterministicRequireOrder:
56
70
  Enabled: false
57
71
 
@@ -98,6 +112,11 @@ Naming/VariableNumber:
98
112
  # endregion
99
113
 
100
114
  # region Performance
115
+ # Wants to convert 0.to_d into BigDecimal.new('0'), which is ugly and doesn't actually do anything
116
+ # to "improve performance"
117
+ Performance/BigDecimalWithNumericArgument:
118
+ Enabled: false
119
+
101
120
  Performance/CollectionLiteralInLoop:
102
121
  Enabled: false
103
122
 
@@ -133,6 +152,15 @@ Rails/HttpPositionalArguments:
133
152
  Rails/HttpStatus:
134
153
  EnforcedStyle: numeric
135
154
 
155
+ # The cop states that if you have `belongs_to :organization`, the validator is added automatically,
156
+ # so you don't need `validates :organization, presence: true` (or `validates :organization_id`).
157
+ #
158
+ # I (zverok) checked it on our codebase and it is not true. Should be clarified later, maybe our
159
+ # Rails version is too old?..
160
+ #
161
+ Rails/RedundantPresenceValidationOnBelongsTo:
162
+ Enabled: false
163
+
136
164
  Rails/SkipsModelValidations:
137
165
  AllowedMethods:
138
166
  - touch
@@ -255,6 +283,21 @@ Style/MultilineBlockChain:
255
283
  Style/MutableConstant:
256
284
  Enabled: false
257
285
 
286
+ # Allows them only in single-line blocks. Doesn't really help!
287
+ Style/NumberedParameters:
288
+ Enabled: false
289
+
290
+ Style/NumberedParametersLimit:
291
+ Max: 2
292
+
293
+ # Just prohibits OpenStruct forever. Technically reasonable, but when we use it, we know what we do
294
+ Style/OpenStructUse:
295
+ Enabled: false
296
+
297
+ # Asks to change `"foo-bar": baz` to `'foo-bar': baz`. Lots of changes, little value
298
+ Style/QuotedSymbols:
299
+ Enabled: false
300
+
258
301
  Style/ParallelAssignment:
259
302
  Enabled: false
260
303
 
@@ -2,6 +2,6 @@
2
2
 
3
3
  module Netsoft
4
4
  module Rubocop
5
- VERSION = '1.1.3.beta1'
5
+ VERSION = '1.1.5'
6
6
  end
7
7
  end
metadata CHANGED
@@ -1,7 +1,7 @@
1
1
  --- !ruby/object:Gem::Specification
2
2
  name: netsoft-rubocop
3
3
  version: !ruby/object:Gem::Version
4
- version: 1.1.3.beta1
4
+ version: 1.1.5
5
5
  platform: ruby
6
6
  authors:
7
7
  - Alex Yarotsky
@@ -9,7 +9,7 @@ authors:
9
9
  autorequire:
10
10
  bindir: bin
11
11
  cert_chain: []
12
- date: 2021-11-10 00:00:00.000000000 Z
12
+ date: 2022-03-18 00:00:00.000000000 Z
13
13
  dependencies:
14
14
  - !ruby/object:Gem::Dependency
15
15
  name: bundler
@@ -45,70 +45,70 @@ dependencies:
45
45
  requirements:
46
46
  - - '='
47
47
  - !ruby/object:Gem::Version
48
- version: 1.14.0
48
+ version: 1.25.0
49
49
  type: :runtime
50
50
  prerelease: false
51
51
  version_requirements: !ruby/object:Gem::Requirement
52
52
  requirements:
53
53
  - - '='
54
54
  - !ruby/object:Gem::Version
55
- version: 1.14.0
55
+ version: 1.25.0
56
56
  - !ruby/object:Gem::Dependency
57
57
  name: rubocop-performance
58
58
  requirement: !ruby/object:Gem::Requirement
59
59
  requirements:
60
60
  - - '='
61
61
  - !ruby/object:Gem::Version
62
- version: 1.11.3
62
+ version: 1.13.2
63
63
  type: :runtime
64
64
  prerelease: false
65
65
  version_requirements: !ruby/object:Gem::Requirement
66
66
  requirements:
67
67
  - - '='
68
68
  - !ruby/object:Gem::Version
69
- version: 1.11.3
69
+ version: 1.13.2
70
70
  - !ruby/object:Gem::Dependency
71
71
  name: rubocop-rails
72
72
  requirement: !ruby/object:Gem::Requirement
73
73
  requirements:
74
74
  - - '='
75
75
  - !ruby/object:Gem::Version
76
- version: 2.10.1
76
+ version: 2.13.2
77
77
  type: :runtime
78
78
  prerelease: false
79
79
  version_requirements: !ruby/object:Gem::Requirement
80
80
  requirements:
81
81
  - - '='
82
82
  - !ruby/object:Gem::Version
83
- version: 2.10.1
83
+ version: 2.13.2
84
84
  - !ruby/object:Gem::Dependency
85
85
  name: rubocop-rake
86
86
  requirement: !ruby/object:Gem::Requirement
87
87
  requirements:
88
88
  - - '='
89
89
  - !ruby/object:Gem::Version
90
- version: 0.5.1
90
+ version: 0.6.0
91
91
  type: :runtime
92
92
  prerelease: false
93
93
  version_requirements: !ruby/object:Gem::Requirement
94
94
  requirements:
95
95
  - - '='
96
96
  - !ruby/object:Gem::Version
97
- version: 0.5.1
97
+ version: 0.6.0
98
98
  - !ruby/object:Gem::Dependency
99
99
  name: rubocop-rspec
100
100
  requirement: !ruby/object:Gem::Requirement
101
101
  requirements:
102
102
  - - '='
103
103
  - !ruby/object:Gem::Version
104
- version: 2.3.0
104
+ version: 2.7.0
105
105
  type: :runtime
106
106
  prerelease: false
107
107
  version_requirements: !ruby/object:Gem::Requirement
108
108
  requirements:
109
109
  - - '='
110
110
  - !ruby/object:Gem::Version
111
- version: 2.3.0
111
+ version: 2.7.0
112
112
  description:
113
113
  email:
114
114
  - alex.yarotsky@hubstaff.com
@@ -142,9 +142,9 @@ required_ruby_version: !ruby/object:Gem::Requirement
142
142
  version: '2.4'
143
143
  required_rubygems_version: !ruby/object:Gem::Requirement
144
144
  requirements:
145
- - - ">"
145
+ - - ">="
146
146
  - !ruby/object:Gem::Version
147
- version: 1.3.1
147
+ version: '0'
148
148
  requirements: []
149
149
  rubygems_version: 3.0.3
150
150
  signing_key: