netsoft-rubocop 1.0.2 → 1.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 42f5eb03efee42ae00c20783523ffc3bacceea1b70e6fa4ebb242cf2a104e5e8
-  data.tar.gz: a20b0c422a7d58e54a0bbbb60152904a1b69d2fe271565e6a146629bf7cee5b7
+  metadata.gz: a27d4fbbc329f03b7ba1545338a36e2bed33af93c22a17a3be81e634c817f1a5
+  data.tar.gz: 1bea462450d76226ca69170644648dcd4f336ba3dc0b33933a3b5df9d8a9a12b
 SHA512:
-  metadata.gz: 590e1f8a6b8b1e46ac1f155a74c5b7f155a28f9cbdb66c62381bb69722e2982f347dbadf49508ac1361fbf87b03136b34c7afaa75e744a98300b7ab279f2d81c
-  data.tar.gz: 1e1cff02bbe014b3884dd0c60a70a1a4601d901c3ddade0836dcceb7c8c83c18cc4b493a8434708a5c61bec72649a3dbbb7e9c72cad2faf56dec5bd6eb4a498a
+  metadata.gz: e640a48f004db898ad5a520361bb24ed5750f2af791e070bb1eb420e01eb001e28a289638ce46269ca73d4f26bdbeef3d99f6caac17f5c9c078ac93774025f73
+  data.tar.gz: f5e54bb635b7c4d71b1b5c53fcaa60e6316a1c2ff8be91c7a379af7478a6630a9f8addbe44c109694947fcbe24fe87e9b92a6711ffcf9e97e8815a94bdc2f69f

data/CHANGELOG.md

@@ -6,7 +6,15 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
 ## [Unreleased]
+### Added
+### Changed
+### Fixed
 
+## [1.1.0] - 2021-01-20
+### Changed
+- Switch to newest versions of rubocop, and rubocop-[everything]
+- Update the default config with the recent set of rules corresponding to the new version
+- reworked gem so that it can simply be required like other rubocop gems
 
 ## [1.0.2] - 2020-09-09
 ### Changed

data/TODO.md

@@ -0,0 +1,4 @@
+## Custom cops to develop:
+
+* `DeepFreeze`: Instead of `Style/MutableConstant`, we need our custom `.deep_freeze` method and cop checking it is
+  attached to arrays, hashes, and values from configs.

data/config/default.yml

@@ -0,0 +1,297 @@
+require:
+  - ./lib/netsoft/rubocop/cops/auth_http_positional_arguments
+  - rubocop-rails
+  - rubocop-performance
+  - rubocop-rspec
+  - rubocop-rake
+
+AllCops:
+  TargetRubyVersion: 2.5
+  TargetRailsVersion: 5.2
+  DisplayStyleGuide: true
+  StyleGuideBaseURL: https://rubystyle.guide
+  NewCops: enable
+  Exclude:
+    - 'db/**/*'
+    - 'coverage/**/*'
+    - 'log/**/*'
+    - 'public/**/*'
+    - 'tmp/**/*'
+    - 'spec/dummy/**/*'
+    - 'vendor/**/*'
+    - 'gemfiles/**/*'
+    - 'node_modules/**/*'
+
+# region Layout
+Layout/AssignmentIndentation:
+  IndentationWidth: 4
+
+Layout/ExtraSpacing:
+  AllowForAlignment: true
+
+Layout/HashAlignment:
+  EnforcedHashRocketStyle: table
+  EnforcedColonStyle: table
+
+Layout/FirstArrayElementIndentation:
+  EnforcedStyle: consistent
+  IndentationWidth: 4
+
+Layout/FirstHashElementIndentation:
+  EnforcedStyle: consistent
+  IndentationWidth: 4
+
+Layout/MultilineMethodCallIndentation:
+  EnforcedStyle: indented_relative_to_receiver
+  IndentationWidth: 4
+
+Layout/SpaceInsideBlockBraces:
+  EnforcedStyle: space
+  SpaceBeforeBlockParameters: true
+
+Layout/SpaceInsideHashLiteralBraces:
+  EnforcedStyle: no_space
+# endregion
+
+# region Lint
+Lint/AmbiguousBlockAssociation:
+  Exclude:
+    - spec/**/*
+
+Lint/NonDeterministicRequireOrder:
+  Enabled: false
+
+Lint/StructNewOverride:
+  Enabled: false
+#endregion
+
+# region Naming
+Naming/RescuedExceptionsVariableName:
+  PreferredName: ex
+
+Naming/MemoizedInstanceVariableName:
+  EnforcedStyleForLeadingUnderscores: optional
+
+Naming/MethodParameterName:
+  AllowedNames:
+    - at
+    - by
+    - db
+    - id
+    - in
+    - io
+    - ip
+    - of
+    - 'on'
+    - os
+    - pp
+    - to
+    - tz
+    - my
+    - me
+    - ex
+    - uo
+    - up
+
+Naming/PredicateName:
+  # By default, it also forbids has_, but that's rarely a good suggestion:
+  # is #has_screenshots? => #screenshots? better?..
+  ForbiddenPrefixes:
+    - is_
+
+Naming/VariableNumber:
+  Enabled: false
+# endregion
+
+# region Performance
+Performance/CollectionLiteralInLoop:
+  Enabled: false
+
+Performance/MethodObjectAsBlock:
+  Enabled: false
+
+# superseded by Performance/RgexpMatch
+Performance/RedundantMatch:
+  Enabled: false
+
+Performance/BlockGivenWithExplicitBlock:
+  Enabled: false
+
+Performance/TimesMap:
+  Enabled: false
+
+# endregion
+
+# region Rails
+Rails:
+  Enabled: true
+
+Rails/FilePath:
+  EnforcedStyle: arguments
+
+# We do it on a DB level
+Rails/HasManyOrHasOneDependent:
+  Enabled: false
+
+Rails/HttpPositionalArguments:
+  Enabled: false
+
+Rails/HttpStatus:
+  EnforcedStyle: numeric
+
+Rails/SkipsModelValidations:
+  AllowedMethods:
+    - touch
+    - update_attribute
+    - update_counters
+    - increment_counter
+    - decrement_counter
+
+Netsoft/AuthHttpPositionalArguments:
+  Enabled: true
+  Include:
+    - 'spec/controllers/**/*'
+
+# endregion
+
+# region RSpec
+# Prohibits before/after(:all) for ever uses. But when we use it, we know what we do
+RSpec/BeforeAfterAll:
+  Enabled: false
+
+RSpec/ExpectChange:
+  EnforcedStyle: block
+
+RSpec/ImplicitSubject:
+  Enabled: false
+
+# Just prohibits `let!` for any usages
+# Nice try, Rubocop.
+RSpec/LetSetup:
+  Enabled: false
+
+RSpec/MessageSpies:
+  Enabled: false
+
+# TODO: It would be good to set a realistic Max: once, but we have all kind of specs with multiple
+# expectations now.
+RSpec/MultipleExpectations:
+  Enabled: false
+
+# Allows to limit number of `let`s. What for?..
+# NB: With current setting (5 max) we have... "Offense count: 22706"
+RSpec/MultipleMemoizedHelpers:
+  Enabled: false
+
+RSpec/NamedSubject:
+  Enabled: false
+
+RSpec/NestedGroups:
+  Enabled: false
+
+RSpec/NotToNot:
+  EnforcedStyle: to_not
+
+# endregion
+
+# region Style
+
+# Allows to enforce either this:
+#
+#   attr_reader :a
+#   attr_reader :b
+#
+# (all accessors separate), or this:
+#
+#   attr_reader :a, :b
+#
+# (all accessors in one statement).
+#
+# We use both, and it is hard to tell why it should be limited...
+Style/AccessorGrouping:
+  Enabled: false
+
+Style/AndOr:
+  EnforcedStyle: conditionals
+
+Style/BlockDelimiters:
+  EnforcedStyle: semantic
+  AllowBracesOnProceduralOneLiners: true
+
+Style/CommentAnnotation:
+  Enabled: false
+
+# Asks to write comment besides dynamically evaluated method, showing how the code would look,
+# see cop docs: https://docs.rubocop.org/rubocop/cops_style.html#styledocumentdynamicevaldefinition
+#
+# Ideally, would be cool, but lot of work.
+Style/DocumentDynamicEvalDefinition:
+  Enabled: false
+
+Style/DoubleNegation:
+  Enabled: false
+
+# Asks to write empty methods this way:
+#
+#    def foo; end
+#
+Style/EmptyMethod:
+  Enabled: false
+
+Style/FormatString:
+  EnforcedStyle: percent
+
+Style/FormatStringToken:
+  Enabled: false
+
+Style/HashAsLastArrayItem:
+  EnforcedStyle: no_braces
+
+Style/Lambda:
+  EnforcedStyle: literal
+
+Style/MultilineBlockChain:
+  Enabled: false
+
+# FIXME: This cop requires to attach .freeze to each and every constant.
+# It is both ugly AND doesn't protect from bugs (the freeze is shallow, so some frozen CONFIG hash
+# can still be changed).
+# We need to develop our own .deep_freeze for configs, and cops to check that it is attached to
+# hashes, arrays and values fetched from ENV/configs.
+Style/MutableConstant:
+  Enabled: false
+
+Style/ParallelAssignment:
+  Enabled: false
+
+Style/RescueModifier:
+  Enabled: false
+
+# Asks to avoid `rescue => exception` without particular class.
+# Why?..
+Style/RescueStandardError:
+  Enabled: false
+
+Style/SingleArgumentDig:
+  Enabled: false
+
+Style/StringConcatenation:
+  Enabled: false
+
+Style/StringLiterals:
+  # up for debate
+  Enabled: false
+
+Style/StructInheritance:
+  Enabled: false
+
+Style/TrailingCommaInArrayLiteral:
+  EnforcedStyleForMultiline: comma
+
+Style/TrailingCommaInHashLiteral:
+  EnforcedStyleForMultiline: comma
+
+#endregion
+
+Metrics:
+  Enabled: false

data/lib/netsoft-rubocop.rb

@@ -0,0 +1,11 @@
+# frozen_string_literal: true
+
+require 'rubocop'
+
+require_relative 'netsoft/rubocop'
+require_relative 'netsoft/rubocop/version'
+require_relative 'netsoft/rubocop/inject'
+
+Netsoft::Rubocop::Inject.defaults!
+
+require_relative 'netsoft/rubocop/cops/netsoft_cops'

data/lib/netsoft/rubocop.rb

@@ -1,9 +1,14 @@
 # frozen_string_literal: true
 
-require 'netsoft/rubocop/version'
+require 'yaml'
 
 module Netsoft
   # Hubstaff shared rubocop style configs
   module Rubocop
+    PROJECT_ROOT   = Pathname.new(__dir__).parent.parent.expand_path.freeze
+    CONFIG_DEFAULT = PROJECT_ROOT.join('config', 'default.yml').freeze
+    CONFIG         = YAML.safe_load(CONFIG_DEFAULT.read).freeze
+
+    private_constant(:CONFIG_DEFAULT, :PROJECT_ROOT)
   end
 end

data/lib/netsoft/rubocop/cops/{auth_http_positional_arguments.rb → netsoft/auth_http_positional_arguments.rb}

@@ -37,7 +37,7 @@ module RuboCop
         PATTERN
 
         def on_send(node)
-          message = format(MSG, verb: node.method_name)
+          message = MSG % {verb: node.method_name}
 
           http_request?(node) do |data|
             return unless needs_conversion?(data)
@@ -77,9 +77,9 @@ module RuboCop
           code_to_replace = node.loc.expression
           # what to replace with
           format = parentheses_format(node)
-          new_code = format(format, name: node.method_name,
+          new_code = format % {name: node.method_name,
                             action: has_auth ? [user.source, controller_action].join(',') : controller_action,
-                            params: params, session: session)
+                            params: params, session: session}
           ->(corrector) { corrector.replace(code_to_replace, new_code) }
         end
 
@@ -115,15 +115,14 @@ module RuboCop
           return '' if data.hash_type? && data.empty?
 
           hash_data = if data.hash_type?
-                        format('{ %<data>s }',
-                               data: data.pairs.map(&:source).join(', '))
+                        '{ %<data>s }' % {data: data.pairs.map(&:source).join(', ')}
                       else
                         # user supplies an object,
                         # no need to surround with braces
                         data.source
                       end
 
-          format(', %<type>s: %<hash_data>s', type: type, hash_data: hash_data)
+          ', %<type>s: %<hash_data>s' % {type: type, hash_data: hash_data}
         end
 
         def parentheses_format(node)

data/lib/netsoft/rubocop/cops/netsoft_cops.rb

@@ -0,0 +1,3 @@
+# frozen_string_literal: true
+
+require_relative 'netsoft/auth_http_positional_arguments'

data/lib/netsoft/rubocop/inject.rb

@@ -0,0 +1,18 @@
+# frozen_string_literal: true
+
+module Netsoft
+  module Rubocop
+    # Because RuboCop doesn't yet support plugins, we have to monkey patch in a
+    # bit of our configuration.
+    module Inject
+      def self.defaults!
+        path = CONFIG_DEFAULT.to_s
+        hash = ::RuboCop::ConfigLoader.send(:load_yaml_configuration, path)
+        config = ::RuboCop::Config.new(hash, path)
+        puts "configuration from #{path}" if ::RuboCop::ConfigLoader.debug?
+        config = ::RuboCop::ConfigLoader.merge_with_default(config, path)
+        ::RuboCop::ConfigLoader.instance_variable_set(:@default_configuration, config)
+      end
+    end
+  end
+end

data/lib/netsoft/rubocop/version.rb

@@ -2,6 +2,6 @@
 
 module Netsoft
   module Rubocop
-    VERSION = '1.0.2'
+    VERSION = '1.1.0'
   end
 end

metadata

@@ -1,14 +1,15 @@
 --- !ruby/object:Gem::Specification
 name: netsoft-rubocop
 version: !ruby/object:Gem::Version
-  version: 1.0.2
+  version: 1.1.0
 platform: ruby
 authors:
 - Alex Yarotsky
+- Edward Rudd
 autorequire: 
-bindir: exe
+bindir: bin
 cert_chain: []
-date: 2020-09-09 00:00:00.000000000 Z
+date: 2021-01-20 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -28,94 +29,105 @@ dependencies:
   name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
         version: '12.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
         version: '12.0'
 - !ruby/object:Gem::Dependency
   name: rubocop
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - '='
       - !ruby/object:Gem::Version
-        version: 0.74.0
+        version: 1.8.1
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - '='
       - !ruby/object:Gem::Version
-        version: 0.74.0
+        version: 1.8.1
 - !ruby/object:Gem::Dependency
   name: rubocop-performance
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - '='
       - !ruby/object:Gem::Version
-        version: '1.4'
+        version: 1.9.2
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - '='
       - !ruby/object:Gem::Version
-        version: '1.4'
+        version: 1.9.2
 - !ruby/object:Gem::Dependency
   name: rubocop-rails
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - '='
       - !ruby/object:Gem::Version
-        version: '2.2'
+        version: 2.9.1
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - '='
       - !ruby/object:Gem::Version
-        version: '2.2'
+        version: 2.9.1
+- !ruby/object:Gem::Dependency
+  name: rubocop-rake
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - '='
+      - !ruby/object:Gem::Version
+        version: 0.5.1
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - '='
+      - !ruby/object:Gem::Version
+        version: 0.5.1
 - !ruby/object:Gem::Dependency
   name: rubocop-rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - '='
       - !ruby/object:Gem::Version
-        version: '1.35'
+        version: 2.1.0
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - '='
       - !ruby/object:Gem::Version
-        version: '1.35'
+        version: 2.1.0
 description: 
 email:
 - alex.yarotsky@hubstaff.com
+- edward@hubstaff.com
 executables: []
 extensions: []
-extra_rdoc_files: []
+extra_rdoc_files:
+- README.md
 files:
-- ".circleci/config.yml"
-- ".gitignore"
-- ".rubocop.yml"
 - CHANGELOG.md
-- Dangerfile
-- Gemfile
 - README.md
-- Rakefile
-- bin/setup-rubygems.sh
-- bin/tag_check.sh
-- default.yml
+- TODO.md
+- config/default.yml
+- lib/netsoft-rubocop.rb
 - lib/netsoft/rubocop.rb
-- lib/netsoft/rubocop/cops/auth_http_positional_arguments.rb
+- lib/netsoft/rubocop/cops/netsoft/auth_http_positional_arguments.rb
+- lib/netsoft/rubocop/cops/netsoft_cops.rb
+- lib/netsoft/rubocop/inject.rb
 - lib/netsoft/rubocop/version.rb
-- netsoft-rubocop.gemspec
 homepage: https://github.com/netsoftHoldings/netsoft-rubocop
 licenses: []
 metadata: {}
@@ -127,15 +139,14 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: '0'
+      version: '2.4'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.7.7
+rubygems_version: 3.0.3
 signing_key: 
 specification_version: 4
 summary: Hubstaff style guides and shared style configs.

data/.circleci/config.yml

@@ -1,141 +0,0 @@
-version: 2
-
-defaults: &defaults
-  docker: &ruby_image
-    - &ruby_image
-      image: circleci/ruby:2.4.4-stretch
-      environment:
-        CIRCLE_ARTIFACTS: /tmp/circelci-artifacts
-        RUBYOPT: '-KU -E utf-8:utf-8'
-        BUNDLE_PATH: vendor/bundle
-        BUNDLE_VERSION: 1.15.2
-        BUNDLE_JOBS: 4
-        BUNDLE_RETRY: 3
-
-filters:
-  test: &filter_test
-    filters:
-      tags:
-        ignore: /^v.*/
-  beta: &filter_beta
-    filters:
-      branches:
-        ignore: /.*/
-      tags:
-        only: /^v[0-9]+(\.[0-9]+)+(\.[a-z].+).*/
-  release: &filter_release
-    filters:
-      branches:
-        ignore: /.*/
-      tags:
-        only: /^v[0-9]+(\.[0-9]+)+/
-
-workflows:
-  version: 2
-  build_test:
-    jobs:
-      - "Checkout":
-          <<: *filter_test
-          context: org-global
-      - "Build":
-          <<: *filter_test
-          context: org-global
-          requires:
-            - "Checkout"
-  build_test_beta:
-    jobs:
-      - "Checkout":
-          <<: *filter_beta
-          context: org-global
-      - "Build":
-          <<: *filter_beta
-          context: org-global
-          requires:
-            - "Checkout"
-      - "Publish":
-          <<: *filter_beta
-          context: org-global
-          requires:
-            - "Build"
-  build_test_release:
-    jobs:
-      - "Checkout":
-          <<: *filter_release
-          context: org-global
-      - "Build":
-          <<: *filter_release
-          context: org-global
-          requires:
-            - "Checkout"
-      - "Publish":
-          <<: *filter_release
-          context: org-global
-          requires:
-            - "Build"
-
-jobs:
-  "Checkout":
-    <<: *defaults
-    steps:
-      - attach_workspace:
-          at: .
-      - checkout
-
-      - restore_cache:
-          keys:
-            - netsoft-rubocop-bundle-v2-{{ checksum "Gemfile" }}-{{ checksum "netsoft-rubocop.gemspec" }}
-      - run:
-          name: Install bundler
-          command: gem install bundler --version=$BUNDLE_VERSION
-      - run:
-          name: Bundle Install
-          command: |-
-            bundle _${BUNDLE_VERSION}_ check || bundle _${BUNDLE_VERSION}_ install --retry=$BUNDLE_RETRY
-      - save_cache:
-          key: netsoft-rubocop--bundle-v2-{{ checksum "Gemfile" }}-{{ checksum "netsoft-rubocop.gemspec" }}
-          paths:
-            - vendor/bundle
-            - Gemfile.lock
-
-      - persist_to_workspace:
-          root: .
-          paths: .
-  "Build":
-    <<: *defaults
-    steps:
-      - attach_workspace:
-          at: .
-      - run:
-          name: Install bundler
-          command: gem install bundler --version=$BUNDLE_VERSION
-      - run:
-          name: Build gem
-          command: |-
-            gem build *.gemspec
-      - run:
-          name: "Install netsoft-danger"
-          command: |-
-            gem install netsoft-danger
-      - run:
-          name: Run rubocop
-          command: |-
-            netsoft-circle rubocop
-      - run:
-          name: Run Danger
-          command: |-
-            danger
-      - store_artifacts:
-          path: /tmp/circelci-artifacts
-  "Publish":
-    <<: *defaults
-    steps:
-      - attach_workspace:
-          at: .
-      - run:
-          name: Deploy to gem server
-          command: |-
-            ./bin/tag_check.sh
-            ./bin/setup-rubygems.sh
-            rm -rf pkg
-            rake build
-            gem push pkg/*.gem

data/.gitignore

@@ -1,56 +0,0 @@
-*.gem
-*.rbc
-/.config
-/coverage/
-/InstalledFiles
-/pkg/
-/spec/reports/
-/spec/examples.txt
-/test/tmp/
-/test/version_tmp/
-/tmp/
-
-# Used by dotenv library to load environment variables.
-# .env
-
-# Ignore Byebug command history file.
-.byebug_history
-
-## Specific to RubyMotion:
-.dat*
-.repl_history
-build/
-*.bridgesupport
-build-iPhoneOS/
-build-iPhoneSimulator/
-
-## Specific to RubyMotion (use of CocoaPods):
-#
-# We recommend against adding the Pods directory to your .gitignore. However
-# you should judge for yourself, the pros and cons are mentioned at:
-# https://guides.cocoapods.org/using/using-cocoapods.html#should-i-check-the-pods-directory-into-source-control
-#
-# vendor/Pods/
-
-## Documentation cache and generated files:
-/.yardoc/
-/_yardoc/
-/doc/
-/rdoc/
-
-## Environment normalization:
-/.bundle/
-/vendor/bundle
-/lib/bundler/man/
-
-# for a library or gem, you might want to ignore these files since the code is
-# intended to run in multiple environments; otherwise, check them in:
-# Gemfile.lock
-# .ruby-version
-# .ruby-gemset
-
-# unless supporting rvm < 1.11.0 or doing something fancy, ignore this:
-.rvmrc
-
-Gemfile.lock
-.ruby-*

data/.rubocop.yml

@@ -1 +0,0 @@
-inherit_from: default.yml

data/Dangerfile

@@ -1,3 +0,0 @@
-# frozen_string_literal: true
-
-danger.import_dangerfile(gem: 'netsoft-danger')

data/Gemfile

@@ -1,8 +0,0 @@
-# frozen_string_literal: true
-
-source 'https://rubygems.org'
-
-git_source(:github) { |repo_name| "https://github.com/#{repo_name}" }
-
-# Specify your gem's dependencies in netsoft-rubocop.gemspec
-gemspec

data/Rakefile

@@ -1,4 +0,0 @@
-# frozen_string_literal: true
-
-require 'bundler/gem_tasks'
-task default: :spec

data/bin/setup-rubygems.sh

@@ -1,3 +0,0 @@
-mkdir ~/.gem
-echo -e "---\n:rubygems_api_key: $RUBYGEMS_API_KEY" > ~/.gem/credentials
-chmod 0600 ~/.gem/credentials

data/bin/tag_check.sh

@@ -1,17 +0,0 @@
-#!/bin/sh
-
-tag=`git describe --tags --exact-match  HEAD 2> /dev/null`
-
-if [ $? -eq 0 ]; then
-  version=`grep VERSION lib/netsoft/rubocop/version.rb | sed -e "s/.*'\([^']*\)'.*/\1/"`
-  
-  if [ "v$version" = "$tag" ]; then
-    echo "Revision $tag Matches $version"
-  else
-    echo "Revision $tag does not match $version"
-    exit 2
-  fi
-else
-  echo "No tag found"
-  exit 1
-fi

data/default.yml

@@ -1,124 +0,0 @@
-require:
-  - ./lib/netsoft/rubocop/cops/auth_http_positional_arguments
-  - rubocop-rails
-  - rubocop-performance
-  - rubocop-rspec
-
-AllCops:
-  TargetRubyVersion: 2.5
-  TargetRailsVersion: 5.2
-  DisplayStyleGuide: true
-  StyleGuideBaseURL: https://rubystyle.guide
-  Exclude:
-    - 'db/**/*'
-    - 'coverage/**/*'
-    - 'log/**/*'
-    - 'public/**/*'
-    - 'tmp/**/*'
-    - 'spec/dummy/**/*'
-    - 'vendor/**/*'
-    - 'gemfiles/**/*'
-    - 'node_modules/**/*'
-
-Naming/RescuedExceptionsVariableName:
-  PreferredName: ex
-
-Naming/UncommunicativeMethodParamName:
-  AllowedNames:
-    - me
-    - ex
-
-Layout/AlignHash:
-  EnforcedHashRocketStyle: table
-  EnforcedColonStyle: table
-
-Layout/ExtraSpacing:
-  AllowForAlignment: true
-
-Layout/IndentAssignment:
-  IndentationWidth: 4
-
-Layout/IndentFirstArrayElement:
-  EnforcedStyle: consistent
-  IndentationWidth: 4
-
-Layout/IndentFirstHashElement:
-  EnforcedStyle: consistent
-  IndentationWidth: 4
-
-Layout/MultilineMethodCallIndentation:
-  EnforcedStyle: indented_relative_to_receiver
-  IndentationWidth: 4
-
-Layout/SpaceInsideBlockBraces:
-  EnforcedStyle: space
-  SpaceBeforeBlockParameters: true
-
-Layout/SpaceInsideHashLiteralBraces:
-  EnforcedStyle: no_space
-
-Lint/AmbiguousBlockAssociation:
-  Exclude:
-    - spec/**/*
-
-Rails:
-  Enabled: true
-
-Rails/HttpPositionalArguments:
-  Enabled: false
-
-Rails/SkipsModelValidations:
-  Whitelist:
-    - touch
-    - update_attribute
-    - update_counters
-    - increment_counter
-    - decrement_counter
-
-Netsoft/AuthHttpPositionalArguments:
-  Enabled: true
-  Include:
-    - 'spec/controllers/**/*'
-
-RSpec/ExpectChange:
-  EnforcedStyle: block
-
-RSpec/ImplicitSubject:
-  Enabled: false
-
-RSpec/MessageSpies:
-  Enabled: false
-
-RSpec/NamedSubject:
-  Enabled: false
-
-RSpec/NestedGroups:
-  Enabled: false
-
-RSpec/NotToNot:
-  EnforcedStyle: to_not
-
-Style/AndOr:
-  EnforcedStyle: conditionals
-
-Style/BlockDelimiters:
-  EnforcedStyle: semantic
-  AllowBracesOnProceduralOneLiners: true
-
-Style/MultilineBlockChain:
-  Enabled: false
-
-Style/RescueModifier:
-  Enabled: false
-
-Style/TrailingCommaInArrayLiteral:
-  EnforcedStyleForMultiline: comma
-
-Style/TrailingCommaInHashLiteral:
-  EnforcedStyleForMultiline: comma
-
-Metrics:
-  Enabled: false
-
-Style/DoubleNegation:
-  Enabled: false

data/netsoft-rubocop.gemspec

@@ -1,32 +0,0 @@
-# frozen_string_literal: true
-
-lib = File.expand_path('lib', __dir__)
-$LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
-require 'netsoft/rubocop/version'
-
-Gem::Specification.new do |spec|
-  spec.name          = 'netsoft-rubocop'
-  spec.version       = Netsoft::Rubocop::VERSION
-  spec.authors       = ['Alex Yarotsky']
-  spec.email         = ['alex.yarotsky@hubstaff.com']
-
-  spec.summary       = 'Hubstaff style guides and shared style configs.'
-  spec.homepage      = 'https://github.com/netsoftHoldings/netsoft-rubocop'
-
-  # Specify which files should be added to the gem when it is released.
-  # The `git ls-files -z` loads the files in the RubyGem that have been added into git.
-  spec.files         = Dir.chdir(File.expand_path(__dir__)) do
-    `git ls-files -z`.split("\x0").reject { |f| f.match(%r{^(test|spec|features)/}) }
-  end
-  spec.bindir        = 'exe'
-  spec.executables   = spec.files.grep(%r{^exe/}) { |f| File.basename(f) }
-  spec.require_paths = %w[lib]
-
-  spec.add_development_dependency 'bundler', '~> 1.15'
-  spec.add_development_dependency 'rake', '~> 12.0'
-
-  spec.add_runtime_dependency 'rubocop', '~> 0.74.0'
-  spec.add_runtime_dependency 'rubocop-performance', '~> 1.4'
-  spec.add_runtime_dependency 'rubocop-rails', '~> 2.2'
-  spec.add_runtime_dependency 'rubocop-rspec', '~> 1.35'
-end