netsoft-danger 0.5.0 → 0.7.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 9e08eb241362988d887b622fb6a446e8e76fd5dd93384ef105ea91e073d86737
-  data.tar.gz: 3e5c368c2e1b2048abd67b3d781f112ef117b3e1bde28ce58a8dc29a9e8f0f54
+  metadata.gz: '0981c81d0ae817b555ad494429d321ca25193ae0084b61fa1205a934ff3f6372'
+  data.tar.gz: '0991c0da27a9809734a3c5d6366d726bba8308fb33165f767645174676d60d4a'
 SHA512:
-  metadata.gz: ce2b4c4f42b58878171a7a990d00155881af9a62d641c992c9edf376df41f6e68a0d95755f6e477ca73ce97d5c2707218697ea46fdd96f5f97cc3d2529ede9fe
-  data.tar.gz: b5591601776b74461a67cd573b4ac08ec7e9eb66082e22ee0805195b3a9037ce1a56612da6b5f435686f2ef2a7cc32bda7edc299e6d42380c2bfee0a66f9349b
+  metadata.gz: 8537ad5a81b1cd8e028a5af2ae90fe1309d0794254a94b32b38b5560e842290940c77655e653774d718dcb6ff0802b332b0c47ed43d23c2f112886b29fe18fdd
+  data.tar.gz: c5c57afe569726883d54732717357415c76e9334f8f1c2e13cab3fdf6f7d8593353986da1510a9c685138ea754f6da1f20aeeadfade307d6ba84758b67ecf84d

data/CHANGELOG.md

@@ -9,6 +9,13 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
 ### Changed
 ### Fixed
 
+## [0.7.0]
+### Changed
+- remove checks for migration and gemfile prefixes in commit messages
+
+## [0.6.0]
+- remove the focus and print checks from the ruby danger (now handled by rubocop)
+
 ## [0.5.0]
 ### Changed
 - updated danger to 8.x

data/Dangerfile

@@ -12,14 +12,6 @@ def toggle_label(github, label, should_set)
   end
 end
 
-# Don't let testing shortcuts get into master by accident
-if Dir.exist?('spec')
-  fail('fdescribe left in tests') if `grep -r -I -e '\\bfdescribe\\b' spec/ |grep -v 'danger ok' `.length > 1
-  fail('fcontext left in tests') if `grep -r -I -e '\\bfcontext\\b' spec/ |grep -v 'danger ok' `.length > 1
-  fail('ap left in tests') if `grep -r -I -e '\\bap\\b' spec/ | grep -v 'danger ok' `.length > 1
-  fail('puts left in tests') if `grep -r -I -e '\\bputs\\b' spec/ | grep -v 'danger ok' `.length > 1
-end
-
 if File.exist?('Gemfile')
   if `grep -r -e "^ *gem 'hubstaff_[a-z]\\+" Gemfile | grep -e ",.\\+[a-zA-Z]" `.length > 1
     fail('gemfile: Beta hubstaff_* gems are not allowed in master/production')
@@ -36,110 +28,10 @@ if github.branch_for_head.start_with?('security')
   toggle_label(github, 'security', true)
 end
 
-should_have_migration_label = false
-
 git.commits.each do |c|
-  short              = " ( #{c.sha[0..7]} )"
-  has_migrations     = c.diff_parent.any? { |f| f.path =~ %r{db/migrate/} }
+  has_migrations = c.diff_parent.any? { |f| f.path =~ %r{db/migrate/} }
   has_schema_changes = c.diff_parent.any? { |f| f.path =~ %r{db/schema\.rb} }
-  has_migration_msg  = c.message.match?(/\Amigration(\([A-Za-z]+\))?:/)
-  no_schema_ok       = ENV['DANGER_NO_SCHEMA_OK'] || false
-  if has_migrations || has_schema_changes
-    unless has_migration_msg
-      fail 'migration: Schema migration commits needs to be tagged with (migration). e.g. migration(Module): ' + short
-    end
-    if has_migrations && !has_schema_changes && !no_schema_ok
-      fail 'migration: Please checkin your schema.rb changes with your migration' + short
-    end
-    if !has_migrations && has_schema_changes
-      warn 'migration: Please checkin your migrations with your schema.rb changes' + short
-    end
-    if c.diff_parent.any? { |f| f.path !~ %r{db/migrate/|db/schema\.rb} }
-      fail 'migration: Migration commit contains non-migration changes' + short
-    end
-
-    should_have_migration_label = true
-  elsif has_migration_msg
-    fail '[migration] Migration commit with no migrations!' + short
-  end
-
-  has_hubstaff_icon_changes = c.diff_parent.any? { |f| f.path =~ /hubstaff(icons|font)|fontcustom-manifest/ }
-  if has_hubstaff_icon_changes
-    if c.diff_parent.any? { |f| !(f.path =~ /hubstaff-(icons|font)/ || f.path =~ /fontcustom-manifest/) }
-      fail 'hubstaff-icons: Put hubstaff-icon changes into their own commit' + short
-    end
-  end
-
-  has_gemfile_changes = c.diff_parent.any? { |f| f.path =~ /Gemfile|gemspec/ }
-  has_gemfile_msg     = c.message.match?(/\Agemfile(\([A-Za-z]+\))?:/)
-  if has_gemfile_changes
-    unless has_gemfile_msg
-      fail 'gemfile: Gemfile commits needs to be tagged with (gemfile). e.g. gemfile(Module): ' + short
-    end
-    if c.diff_parent.any? { |f| f.path !~ /Gemfile|gemspec/ }
-      fail 'gemfile: Gemfile commit contains non-gemfile changes' + short
-    end
-    if c.diff_parent.any? { |f| f.path == 'Gemfile.lock' }
-      unless `grep -E -- '^BUNDLED WITH\s*\n\s+(1\\.15\\.2|1\\.17\\.3)$' Gemfile.lock`.length > 1
-        fail('gemfile: Gemfile not bundled with bundler 1.15.2 or 1.17.3')
-      end
-    end
-  elsif has_gemfile_msg
-    fail 'gemfile: Gemfile commit has no gemfile changes!' + short
-  end
 
-  has_package_changes = c.diff_parent.any? { |f| f.path =~ /package\.json|yarn\.lock/ }
-  has_package_msg     = c.message.match?(/\Apackage(\([A-Za-z]+\))?:/)
-  if has_package_changes
-    unless has_package_msg
-      fail 'package: Package.json commits needs to be tagged with package. e.g package(Module): ' + short
-    end
-    if c.diff_parent.any? { |f| f.path !~ /package\.json|yarn\.lock/ }
-      fail 'package: Package.json commit contains non-package changes' + short
-    end
-  elsif has_package_msg
-    fail 'package: Pacakge.json commit has no package changes!' + short
-  end
-end
-
-toggle_label(github, 'run migration', should_have_migration_label)
-
-if ENV['CIRCLE_TOKEN']
-  require 'open-uri'
-
-  artifact_url = "https://circleci.com/api/v1.1/project/github/#{ENV['CIRCLE_PROJECT_USERNAME']}/#{ENV['CIRCLE_PROJECT_REPONAME']}/#{ENV['CIRCLE_BUILD_NUM']}/artifacts?circle-token=#{ENV['CIRCLE_TOKEN']}"
-  artifacts    = JSON.parse(URI.parse(artifact_url).read).map { |a| a['url'] }
-
-  jest        = artifacts.find { |artifact| artifact.end_with?('jest/index.html') }
-  coverage    = artifacts.find { |artifact| artifact.end_with?('coverage/index.html') }
-  rubocop     = artifacts.find { |artifact| artifact.end_with?('rubocop/report.html') }
-  eslint      = artifacts.find { |artifact| artifact.end_with?('eslint/report.html') }
-  brakeman    = artifacts.find { |artifact| artifact.end_with?('brakeman/report.html') }
-  rspec_files = artifacts.select { |artifact| artifact =~ /rspec-(.+)\.html$/ }
-
-  {}.tap do |hash|
-    hash['Ruby coverage report']      = coverage if coverage
-    hash['RSpec test report']         = rspec_files unless rspec_files.empty?
-    hash['RuboCop inspection report'] = rubocop if rubocop
-    hash['ESLint inspection report']  = eslint if eslint
-    hash['Jest coverage report']      = jest if jest
-    hash['Brakeman issues report']    = brakeman if brakeman
-  end.each do |msg, links|
-    links = [*links]
-    if links.size == 1
-      message("[#{msg}](#{links[0]})")
-    else
-      r         = /rspec-(.+)\.html$/
-      the_links = links.map { |l|
-        m = r.match(l)
-        if m
-          "[#{m[1]}](#{l})"
-        else
-          "[link](#{l})"
-        end
-      }.join(', ')
-
-      message("#{msg} - #{the_links}")
-    end
-  end
+  should_have_migration_label = true if has_migrations || has_schema_changes
+  toggle_label(github, 'run migration', should_have_migration_label)
 end

data/lib/netsoft-danger/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module NetsoftDanger
-  VERSION = '0.5.0'
+  VERSION = '0.7.0'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: netsoft-danger
 version: !ruby/object:Gem::Version
-  version: 0.5.0
+  version: 0.7.0
 platform: ruby
 authors:
 - urkle
-autorequire:
+autorequire: 
 bindir: bin
 cert_chain: []
-date: 2022-01-13 00:00:00.000000000 Z
+date: 2023-02-24 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: danger
@@ -121,7 +121,7 @@ files:
 homepage: https://github.com/NetsoftHoldings/danger
 licenses: []
 metadata: {}
-post_install_message:
+post_install_message: 
 rdoc_options: []
 require_paths:
 - lib
@@ -136,8 +136,8 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.0.8
-signing_key:
+rubygems_version: 3.0.3
+signing_key: 
 specification_version: 4
 summary: Danger.systems conventions for Netsoft projects.
 test_files: []