netsoft-danger 0.3.4 → 0.3.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 896e582de631d926bd01d4f5d98d0bde7f20f9a0ec129600bcea3eff09ffbb53
-  data.tar.gz: 9613d84bcd13e28594d387b66c1d1cc379d2f6ee62857e4ddcf2bce30761466a
+  metadata.gz: 2b7b3e2a4fbfa992da4950813e78d8276a5f8055b4b09987d36b62b761134f8a
+  data.tar.gz: e7f4046f836e76a11c5fcb5e37b31acdf664e921f506f8f7312a489852418168
 SHA512:
-  metadata.gz: 9600eeb6dc24d45393f88ce2f4e956885209974d0910bec466354fca4950de21a78fad98986f2c1593074a44c72f95d8d0760254e6b08a5b3bd6b1a6daef5d39
-  data.tar.gz: 244fa8e69810e66bd44b37d6b156dc58229bc6ff6fe39f736928332f1209d200fc003651dc7c8f1863cc90d57dbb24f874e4075492239d33e3506829ecd752ec
+  metadata.gz: 2cde3fa84fa78f571710f9d52d4508410550f0e30d7795e5f925aca31902453e328ccb332db3fb003bcfd692a22a55a470eff5ed0859a87492131b5c3636aa76
+  data.tar.gz: 38b61ca91282d42ba78b2bd7752f0be930fc1790f751bfb7c1e53e4772d66ca74dcf3d5e756aeb8011c6da009340bbacd436c7969f1030cce123ea406aefe8d1

data/.circleci/config.yml

@@ -124,7 +124,9 @@ jobs:
           name: Deploy to gem server
           command: |-
             ./bin/tag_check.sh
+            ./bin/setup-rubygems.sh
             rm -rf pkg
             gem install geminabox
             rake build
             gem inabox -g ${HUBSTAFF_GEM_SERVER} pkg/*
+            gem push pkg/*.gem

data/CHANGELOG.md

@@ -0,0 +1,17 @@
+# Changelog
+All notable changes to this project will be documented in this file.
+
+The format is based on [Keep a Changelog](http://keepachangelog.com/en/1.0.0/)
+and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.html).
+
+## [Next]
+### Added
+### Changed
+### Fixed
+
+## [0.3.5]
+### Added
+- package.json checks
+### Fixed
+- requie older version of faraday until octokit is fixed (https://github.com/octokit/octokit.rb/pull/1154)
+

data/Dangerfile

@@ -23,7 +23,7 @@ git.commits.each do |c|
   short = " ( #{c.sha[0..7]} )"
   has_migrations = c.diff_parent.any? {|f| f.path =~ /db\/migrate\// }
   has_schema_changes = c.diff_parent.any? {|f| f.path =~ /db\/schema\.rb/ }
-  has_migration_msg = c.message =~ /^\[migration\]/
+  has_migration_msg = c.message =~ /\A\[migration\]/
   no_schema_ok = ENV['DANGER_NO_SCHEMA_OK'] || false
   if has_migrations || has_schema_changes
     unless has_migration_msg
@@ -35,27 +35,27 @@ git.commits.each do |c|
     if !has_migrations && has_schema_changes
       warn '[migration] Please checkin your migrations with your schema.rb changes' + short
     end
-    if c.diff_parent.any? {|f| !( f.path =~ /db\/migrate\// or f.path =~ /db\/schema.rb/ ) }
+    if c.diff_parent.any? {|f| !( f.path =~ /db\/migrate\/|db\/schema\.rb/ ) }
       fail '[migration] Migration commit contains non-migration changes' + short
     end
   elsif has_migration_msg
     fail '[migration] Migration commit with no migrations!' + short
   end
 
-  has_hubstaff_icon_changes = c.diff_parent.any? {|f| f.path =~ /hubstaff(icons|font)/ || f.path =~ /fontcustom-manifest/ }
+  has_hubstaff_icon_changes = c.diff_parent.any? {|f| f.path =~ /hubstaff(icons|font)|fontcustom-manifest/ }
   if has_hubstaff_icon_changes
     if c.diff_parent.any? {|f| !( f.path =~ /hubstaff-(icons|font)/ || f.path =~ /fontcustom-manifest/ ) }
       fail '[hubstaff-icons] Put hubstaff-icon changes into their own commit' + short
     end
   end
 
-  has_gemfile_changes = c.diff_parent.any? {|f| f.path =~ /Gemfile/ || f.path =~ /gemspec/ }
-  has_gemfile_msg = c.message =~ /^\[gemfile\]/
+  has_gemfile_changes = c.diff_parent.any? {|f| f.path =~ /Gemfile|gemspec/ }
+  has_gemfile_msg = c.message =~ /\A\[gemfile\]/
   if has_gemfile_changes
     unless has_gemfile_msg
       fail '[gemfile] Gemfile commits need to be prefixed with [gemfile] ' + short
     end
-    if c.diff_parent.any? {|f| !( f.path =~ /Gemfile/ || f.path =~ /gemspec/ ) }
+    if c.diff_parent.any? {|f| !( f.path =~ /Gemfile|gemspec/ ) }
       fail '[gemfile] Gemfile commit contains non-gemfile changes' + short
     end
     if c.diff_parent.any? {|f| f.path == 'Gemfile.lock' }
@@ -66,6 +66,19 @@ git.commits.each do |c|
   elsif has_gemfile_msg
     fail '[gemfile] Gemfile commit has no gemfile changes!' + short
   end
+
+  has_package_changes = c.diff_parent.any? {|f| f.path =~ /package\.json|yarn\.lock/ }
+  has_package_msg = c.message =~ /\A\[package\.json\]/
+  if has_package_changes
+    unless has_package_msg
+      fail '[package.json] Package.json commits need to be prefixed with [package.json] ' + short
+    end
+    if c.diff_parent.any? {|f| !( f.path =~ /package\.json|yarn\.lock/ ) }
+      fail '[package.json] Package.json commit contains non-package changes' + short
+    end
+  elsif has_package_msg
+    fail '[package.json] Pacakge.json commit has no package changes!' + short
+  end
 end
 
 require 'open-uri'

data/bin/setup-rubygems.sh

@@ -0,0 +1,3 @@
+mkdir ~/.gem
+echo -e "---\n:rubygems_api_key: $RUBYGEMS_API_KEY" > ~/.gem/credentials
+chmod 0600 ~/.gem/credentials

data/lib/netsoft-danger/version.rb

@@ -1,3 +1,3 @@
 module NetsoftDanger
-  VERSION = '0.3.4'.freeze
+  VERSION = '0.3.5'.freeze
 end

data/netsoft-danger.gemspec

@@ -18,4 +18,5 @@ Gem::Specification.new do |s|
   s.add_development_dependency 'rake'
   s.add_runtime_dependency 'danger', '~> 5.0'
   s.add_runtime_dependency 'thor'
+  s.add_runtime_dependency 'faraday', '~> 0.15.0'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: netsoft-danger
 version: !ruby/object:Gem::Version
-  version: 0.3.4
+  version: 0.3.5
 platform: ruby
 authors:
 - urkle
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-09-03 00:00:00.000000000 Z
+date: 2019-09-29 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rake
@@ -52,6 +52,20 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: faraday
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 0.15.0
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 0.15.0
 description: Packages a Dangerfile to be used with Danger.
 email: []
 executables:
@@ -61,11 +75,13 @@ extra_rdoc_files: []
 files:
 - ".circleci/config.yml"
 - ".gitignore"
+- CHANGELOG.md
 - Dangerfile
 - Gemfile
 - README.md
 - Rakefile
 - bin/netsoft-circle
+- bin/setup-rubygems.sh
 - bin/tag_check.sh
 - dangerfiles/issue.js
 - dangerfiles/pr.js