RubyGems - netsoft-danger - Versions diffs - 0.3.3 → 0.3.8 - Mend

netsoft-danger 0.3.3 → 0.3.8

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.

Files changed (18) hide show

checksums.yaml +4 -4
data/.circleci/config.yml +6 -0
data/.rubocop.yml +15 -0
data/CHANGELOG.md +34 -0
data/Dangerfile +109 -61
data/Gemfile +2 -0
data/Rakefile +3 -1
data/bin/netsoft-circle +25 -23
data/bin/setup-rubygems.sh +3 -0
data/dangerfiles/pr.js +6 -2
data/lib/netsoft-danger/version.rb +3 -1
data/netsoft-danger.gemspec +12 -7
data/yarn.lock +317 -117
metadata +69 -42
data/lib/netsoft-danger.rb +0 -3
data/lib/netsoft-danger/cops.rb +0 -1
data/lib/netsoft-danger/cops/netsoft/auth_http_positional_arguments.rb +0 -142
data/rubocop/config-2019-08-12.yml +0 -95

metadata CHANGED

@@ -1,23 +1,37 @@
 --- !ruby/object:Gem::Specification
 name: netsoft-danger
 version: !ruby/object:Gem::Version
-  version: 0.3.3
+  version: 0.3.8
 platform: ruby
 authors:
 - urkle
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2019-08-13 00:00:00.000000000 Z
+date: 2020-07-02 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
-  name: rake
+  name: danger
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '5.0'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '5.0'
+- !ruby/object:Gem::Dependency
+  name: faraday
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
-  type: :development
+  type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
@@ -25,89 +39,103 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: danger
+  name: thor
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '5.0'
+        version: '0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '5.0'
+        version: '0'
 - !ruby/object:Gem::Dependency
-  name: rubocop
+  name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: 0.74.0
-  type: :runtime
+        version: '0'
+  type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: 0.74.0
+        version: '0'
 - !ruby/object:Gem::Dependency
-  name: rubocop-rails
+  name: netsoft-rubocop
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - '='
       - !ruby/object:Gem::Version
-        version: 2.2.1
-  type: :runtime
+        version: 1.0.1
+  type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - '='
       - !ruby/object:Gem::Version
-        version: 2.2.1
+        version: 1.0.1
+- !ruby/object:Gem::Dependency
+  name: rubocop
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - '='
+      - !ruby/object:Gem::Version
+        version: 0.74.0
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - '='
+      - !ruby/object:Gem::Version
+        version: 0.74.0
 - !ruby/object:Gem::Dependency
   name: rubocop-performance
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - '='
       - !ruby/object:Gem::Version
-        version: 1.4.1
-  type: :runtime
+        version: 1.5.2
+  type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - '='
       - !ruby/object:Gem::Version
-        version: 1.4.1
+        version: 1.5.2
 - !ruby/object:Gem::Dependency
-  name: rubocop-rspec
+  name: rubocop-rails
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - '='
       - !ruby/object:Gem::Version
-        version: 1.35.0
-  type: :runtime
+        version: 2.4.2
+  type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - '='
       - !ruby/object:Gem::Version
-        version: 1.35.0
+        version: 2.4.2
 - !ruby/object:Gem::Dependency
-  name: thor
+  name: rubocop-rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - '='
       - !ruby/object:Gem::Version
-        version: '0'
-  type: :runtime
+        version: 1.38.1
+  type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - '='
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 1.38.1
 description: Packages a Dangerfile to be used with Danger.
 email: []
 executables:
@@ -117,21 +145,20 @@ extra_rdoc_files: []
 files:
 - ".circleci/config.yml"
 - ".gitignore"
+- ".rubocop.yml"
+- CHANGELOG.md
 - Dangerfile
 - Gemfile
 - README.md
 - Rakefile
 - bin/netsoft-circle
+- bin/setup-rubygems.sh
 - bin/tag_check.sh
 - dangerfiles/issue.js
 - dangerfiles/pr.js
-- lib/netsoft-danger.rb
-- lib/netsoft-danger/cops.rb
-- lib/netsoft-danger/cops/netsoft/auth_http_positional_arguments.rb
 - lib/netsoft-danger/version.rb
 - netsoft-danger.gemspec
 - package.json
-- rubocop/config-2019-08-12.yml
 - settings-peril.json
 - yarn.lock
 homepage: https://github.com/NetsoftHoldings/danger

data/lib/netsoft-danger.rb DELETED

@@ -1,3 +0,0 @@
-require 'rubocop'
-require_relative 'netsoft-danger/cops'

data/lib/netsoft-danger/cops.rb DELETED

	@@ -1 +0,0 @@
1	- require_relative 'cops/netsoft/auth_http_positional_arguments'

data/lib/netsoft-danger/cops/netsoft/auth_http_positional_arguments.rb DELETED

@@ -1,142 +0,0 @@
-# frozen_string_literal: true
-require 'rubocop/cop/mixin/target_rails_version'
-module RuboCop
-  module Cop
-    module Netsoft
-      # This cop is used to identify usages of http methods like `get`, `post`,
-      # `put`, `patch` without the usage of keyword arguments in your tests and
-      # change them to use keyword args. This cop only applies to Rails >= 5.
-      # If you are running Rails < 5 you should disable the
-      # Netsoft/HttpPositionalArguments cop or set your TargetRailsVersion in your
-      # .rubocop.yml file to 4.0, etc.
-      #
-      # @example
-      #   # bad
-      #   get :new, { user_id: 1}
-      #
-      #   # good
-      #   get :new, params: { user_id: 1 }
-      class AuthHttpPositionalArguments < Cop
-        extend RuboCop::Cop::TargetRailsVersion
-        MSG = 'Use keyword arguments instead of ' \
-              'positional arguments for http call: `%<verb>s`.'.freeze
-        KEYWORD_ARGS = %i[
-          method params session body flash xhr as headers env
-        ].freeze
-        HTTP_METHODS = %i[get post put patch delete head].freeze
-        HTTP_AUTH_METHODS = %i[get_with post_with put_with patch_with delete_with].freeze
-        minimum_target_rails_version 5.0
-        def_node_matcher :http_request?, <<-PATTERN
-          (send nil? {#{HTTP_METHODS.map(&:inspect).join(' ')}} !nil? $_ ...)
-        PATTERN
-        def_node_matcher :http_auth_request?, <<-PATTERN
-          (send nil? {#{HTTP_AUTH_METHODS.map(&:inspect).join(' ')}} !nil? !nil? $_ ...)
-        PATTERN
-        def on_send(node)
-          http_request?(node) do |data|
-            return unless needs_conversion?(data)
-            add_offense(node, location: :selector,
-                        message: format(MSG, verb: node.method_name))
-          end
-          http_auth_request?(node) do |data|
-            return unless auth_needs_conversion?(data)
-            add_offense(node, location: :selector,
-                        message: format(MSG, verb: node.method_name))
-          end
-        end
-        # given a pre Rails 5 method: get :new, {user_id: @user.id}, {}
-        #
-        # @return lambda of auto correct procedure
-        # the result should look like:
-        #     get :new, params: { user_id: @user.id }, session: {}
-        # the http_method is the method used to call the controller
-        # the controller node can be a symbol, method, object or string
-        # that represents the path/action on the Rails controller
-        # the data is the http parameters and environment sent in
-        # the Rails 5 http call
-        def autocorrect(node)
-          has_auth = HTTP_AUTH_METHODS.include?(node.method_name.to_sym)
-          if has_auth
-            user, http_path, *data = *node.arguments
-          else
-            http_path, *data = *node.arguments
-          end
-          controller_action = http_path.source
-          params = convert_hash_data(data.first, 'params')
-          session = convert_hash_data(data.last, 'session') if data.size > 1
-          # the range of the text to replace, which is the whole line
-          code_to_replace = node.loc.expression
-          # what to replace with
-          format = parentheses_format(node)
-          new_code = format(format, name: node.method_name,
-                            action: has_auth ? [user.source, controller_action].join(',') : controller_action,
-                            params: params, session: session)
-          ->(corrector) { corrector.replace(code_to_replace, new_code) }
-        end
-        private
-        def needs_conversion?(data)
-          return true unless data.hash_type?
-          data.each_pair.none? do |pair|
-            special_keyword_arg?(pair.key) ||
-                format_arg?(pair.key) && data.pairs.one?
-          end
-        end
-        def auth_needs_conversion?(data)
-          return true unless data.hash_type?
-          data.each_pair.none? do |pair|
-            special_keyword_arg?(pair.key) ||
-                format_arg?(pair.key) && data.pairs.one?
-          end
-        end
-        def special_keyword_arg?(node)
-          node.sym_type? && KEYWORD_ARGS.include?(node.value)
-        end
-        def format_arg?(node)
-          node.sym_type? && node.value == :format
-        end
-        def convert_hash_data(data, type)
-          return '' if data.hash_type? && data.empty?
-          hash_data = if data.hash_type?
-                        format('{ %<data>s }',
-                               data: data.pairs.map(&:source).join(', '))
-                      else
-                        # user supplies an object,
-                        # no need to surround with braces
-                        data.source
-                      end
-          format(', %<type>s: %<hash_data>s', type: type, hash_data: hash_data)
-        end
-        def parentheses_format(node)
-          if parentheses?(node)
-            '%<name>s(%<action>s%<params>s%<session>s)'
-          else
-            '%<name>s %<action>s%<params>s%<session>s'
-          end
-        end
-      end
-    end
-  end
-end

data/rubocop/config-2019-08-12.yml DELETED

@@ -1,95 +0,0 @@
-require:
-  - netsoft-danger
-  - rubocop-rails
-  - rubocop-performance
-  - rubocop-rspec
-AllCops:
-  TargetRubyVersion: 2.4
-  TargetRailsVersion: 5.2
-  DisplayStyleGuide: true
-  StyleGuideBaseURL: https://rubystyle.guide
-  Exclude:
-    - 'db/**/*'
-    - 'coverage/**/*'
-    - 'log/**/*'
-    - 'public/**/*'
-    - 'tmp/**/*'
-    - 'spec/dummy/**/*'
-    - 'vendor/**/*'
-Naming/RescuedExceptionsVariableName:
-  PreferredName: ex
-Naming/UncommunicativeMethodParamName:
-  AllowedNames:
-    - me
-    - ex
-Layout/AlignHash:
-  EnforcedHashRocketStyle: table
-  EnforcedColonStyle: table
-Layout/ExtraSpacing:
-  AllowForAlignment: true
-Layout/IndentAssignment:
-  IndentationWidth: 4
-Layout/IndentFirstArrayElement:
-  EnforcedStyle: consistent
-  IndentationWidth: 4
-Layout/IndentFirstHashElement:
-  EnforcedStyle: consistent
-  IndentationWidth: 4
-Layout/SpaceInsideBlockBraces:
-  EnforcedStyle: no_space
-  SpaceBeforeBlockParameters: false
-Layout/SpaceInsideHashLiteralBraces:
-  EnforcedStyle: no_space
-Lint/AmbiguousBlockAssociation:
-  Exclude:
-    - spec/**/*
-Rails:
-  Enabled: true
-Rails/HttpPositionalArguments:
-  Enabled: false
-Rails/SkipsModelValidations:
-  Whitelist:
-    - touch
-    - update_attribute
-    - update_counters
-    - increment_counter
-    - decrement_counter
-Netsoft/AuthHttpPositionalArguments:
-  Enabled: true
-  Include:
-    - 'spec/controllers/**/*'
-RSpec/ExpectChange:
-  EnforcedStyle: block
-RSpec/ImplicitSubject:
-  Enabled: false
-RSpec/MessageSpies:
-  Enabled: false
-RSpec/NamedSubject:
-  Enabled: false
-RSpec/NestedGroups:
-  Enabled: false
-RSpec/NotToNot:
-  EnforcedStyle: to_not
-Style/AndOr:
-  EnforcedStyle: conditionals
-Style/BlockDelimiters:
-  EnforcedStyle: semantic
-  AllowBracesOnProceduralOneLiners: true
-Style/MultilineBlockChain:
-  Enabled: false
-Style/RescueModifier:
-  Enabled: false
-Style/TrailingCommaInArrayLiteral:
-  EnforcedStyleForMultiline: comma
-Style/TrailingCommaInHashLiteral:
-  EnforcedStyleForMultiline: comma
-Metrics:
-  Enabled: false