netsoft-danger 0.3.3 → 0.3.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 834689b35350c36d2d44ddf42e4f4063d6a64669eae0b81622bd75a4a84ad521
-  data.tar.gz: 60f0dce22bea4f15e6c41dca65b68015117580cf2f6b887b96ea7c5e5cf08e52
+  metadata.gz: 896e582de631d926bd01d4f5d98d0bde7f20f9a0ec129600bcea3eff09ffbb53
+  data.tar.gz: 9613d84bcd13e28594d387b66c1d1cc379d2f6ee62857e4ddcf2bce30761466a
 SHA512:
-  metadata.gz: ba7dd552680963b240de97848204a8da274fcd62826284bad93a906f0d629de0e41f0fc2a72da71590005392e0415a84d5fd27a4d9b726a997d80da9db4242f3
-  data.tar.gz: fb9da655dc4673612375ae7b0307fd6add7a01922152f08d1f8728550723df6b725150add8f480b7726756c0f986f797e73ac569e67d1c98673b8f72e67afd9c
+  metadata.gz: 9600eeb6dc24d45393f88ce2f4e956885209974d0910bec466354fca4950de21a78fad98986f2c1593074a44c72f95d8d0760254e6b08a5b3bd6b1a6daef5d39
+  data.tar.gz: 244fa8e69810e66bd44b37d6b156dc58229bc6ff6fe39f736928332f1209d200fc003651dc7c8f1863cc90d57dbb24f874e4075492239d33e3506829ecd752ec

data/bin/netsoft-circle

@@ -70,7 +70,7 @@ EOF
   desc 'rubocop', 'Run rubocop'
   def rubocop
     system <<-EOF
-      rubocop \
+      bundle _${BUNDLE_VERSION}_ exec rubocop \
         --parallel \
         --format progress \
         --format html \

data/lib/netsoft-danger/version.rb

@@ -1,3 +1,3 @@
 module NetsoftDanger
-  VERSION = '0.3.3'.freeze
+  VERSION = '0.3.4'.freeze
 end

data/netsoft-danger.gemspec

@@ -17,9 +17,5 @@ Gem::Specification.new do |s|
 
   s.add_development_dependency 'rake'
   s.add_runtime_dependency 'danger', '~> 5.0'
-  s.add_runtime_dependency 'rubocop', '~> 0.74.0'
-  s.add_runtime_dependency 'rubocop-rails', '~> 2.2.1'
-  s.add_runtime_dependency 'rubocop-performance', '~> 1.4.1'
-  s.add_runtime_dependency 'rubocop-rspec', '~> 1.35.0'
   s.add_runtime_dependency 'thor'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: netsoft-danger
 version: !ruby/object:Gem::Version
-  version: 0.3.3
+  version: 0.3.4
 platform: ruby
 authors:
 - urkle
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-08-13 00:00:00.000000000 Z
+date: 2019-09-03 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rake
@@ -38,62 +38,6 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '5.0'
-- !ruby/object:Gem::Dependency
-  name: rubocop
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: 0.74.0
-  type: :runtime
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: 0.74.0
-- !ruby/object:Gem::Dependency
-  name: rubocop-rails
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: 2.2.1
-  type: :runtime
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: 2.2.1
-- !ruby/object:Gem::Dependency
-  name: rubocop-performance
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: 1.4.1
-  type: :runtime
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: 1.4.1
-- !ruby/object:Gem::Dependency
-  name: rubocop-rspec
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: 1.35.0
-  type: :runtime
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: 1.35.0
 - !ruby/object:Gem::Dependency
   name: thor
   requirement: !ruby/object:Gem::Requirement
@@ -125,13 +69,9 @@ files:
 - bin/tag_check.sh
 - dangerfiles/issue.js
 - dangerfiles/pr.js
-- lib/netsoft-danger.rb
-- lib/netsoft-danger/cops.rb
-- lib/netsoft-danger/cops/netsoft/auth_http_positional_arguments.rb
 - lib/netsoft-danger/version.rb
 - netsoft-danger.gemspec
 - package.json
-- rubocop/config-2019-08-12.yml
 - settings-peril.json
 - yarn.lock
 homepage: https://github.com/NetsoftHoldings/danger

data/lib/netsoft-danger.rb

@@ -1,3 +0,0 @@
-require 'rubocop'
-
-require_relative 'netsoft-danger/cops'

data/lib/netsoft-danger/cops.rb

@@ -1 +0,0 @@
-require_relative 'cops/netsoft/auth_http_positional_arguments'

data/lib/netsoft-danger/cops/netsoft/auth_http_positional_arguments.rb

@@ -1,142 +0,0 @@
-# frozen_string_literal: true
-
-require 'rubocop/cop/mixin/target_rails_version'
-
-module RuboCop
-  module Cop
-    module Netsoft
-      # This cop is used to identify usages of http methods like `get`, `post`,
-      # `put`, `patch` without the usage of keyword arguments in your tests and
-      # change them to use keyword args. This cop only applies to Rails >= 5.
-      # If you are running Rails < 5 you should disable the
-      # Netsoft/HttpPositionalArguments cop or set your TargetRailsVersion in your
-      # .rubocop.yml file to 4.0, etc.
-      #
-      # @example
-      #   # bad
-      #   get :new, { user_id: 1}
-      #
-      #   # good
-      #   get :new, params: { user_id: 1 }
-      class AuthHttpPositionalArguments < Cop
-        extend RuboCop::Cop::TargetRailsVersion
-
-        MSG = 'Use keyword arguments instead of ' \
-              'positional arguments for http call: `%<verb>s`.'.freeze
-        KEYWORD_ARGS = %i[
-          method params session body flash xhr as headers env
-        ].freeze
-        HTTP_METHODS = %i[get post put patch delete head].freeze
-        HTTP_AUTH_METHODS = %i[get_with post_with put_with patch_with delete_with].freeze
-
-        minimum_target_rails_version 5.0
-
-        def_node_matcher :http_request?, <<-PATTERN
-          (send nil? {#{HTTP_METHODS.map(&:inspect).join(' ')}} !nil? $_ ...)
-        PATTERN
-
-        def_node_matcher :http_auth_request?, <<-PATTERN
-          (send nil? {#{HTTP_AUTH_METHODS.map(&:inspect).join(' ')}} !nil? !nil? $_ ...)
-        PATTERN
-
-        def on_send(node)
-          http_request?(node) do |data|
-            return unless needs_conversion?(data)
-
-            add_offense(node, location: :selector,
-                        message: format(MSG, verb: node.method_name))
-          end
-
-          http_auth_request?(node) do |data|
-            return unless auth_needs_conversion?(data)
-
-            add_offense(node, location: :selector,
-                        message: format(MSG, verb: node.method_name))
-          end
-        end
-
-        # given a pre Rails 5 method: get :new, {user_id: @user.id}, {}
-        #
-        # @return lambda of auto correct procedure
-        # the result should look like:
-        #     get :new, params: { user_id: @user.id }, session: {}
-        # the http_method is the method used to call the controller
-        # the controller node can be a symbol, method, object or string
-        # that represents the path/action on the Rails controller
-        # the data is the http parameters and environment sent in
-        # the Rails 5 http call
-        def autocorrect(node)
-          has_auth = HTTP_AUTH_METHODS.include?(node.method_name.to_sym)
-          if has_auth
-            user, http_path, *data = *node.arguments
-          else
-            http_path, *data = *node.arguments
-          end
-
-          controller_action = http_path.source
-          params = convert_hash_data(data.first, 'params')
-          session = convert_hash_data(data.last, 'session') if data.size > 1
-          # the range of the text to replace, which is the whole line
-          code_to_replace = node.loc.expression
-          # what to replace with
-          format = parentheses_format(node)
-          new_code = format(format, name: node.method_name,
-                            action: has_auth ? [user.source, controller_action].join(',') : controller_action,
-                            params: params, session: session)
-          ->(corrector) { corrector.replace(code_to_replace, new_code) }
-        end
-
-        private
-
-        def needs_conversion?(data)
-          return true unless data.hash_type?
-
-          data.each_pair.none? do |pair|
-            special_keyword_arg?(pair.key) ||
-                format_arg?(pair.key) && data.pairs.one?
-          end
-        end
-
-        def auth_needs_conversion?(data)
-          return true unless data.hash_type?
-
-          data.each_pair.none? do |pair|
-            special_keyword_arg?(pair.key) ||
-                format_arg?(pair.key) && data.pairs.one?
-          end
-        end
-
-        def special_keyword_arg?(node)
-          node.sym_type? && KEYWORD_ARGS.include?(node.value)
-        end
-
-        def format_arg?(node)
-          node.sym_type? && node.value == :format
-        end
-
-        def convert_hash_data(data, type)
-          return '' if data.hash_type? && data.empty?
-
-          hash_data = if data.hash_type?
-                        format('{ %<data>s }',
-                               data: data.pairs.map(&:source).join(', '))
-                      else
-                        # user supplies an object,
-                        # no need to surround with braces
-                        data.source
-                      end
-
-          format(', %<type>s: %<hash_data>s', type: type, hash_data: hash_data)
-        end
-
-        def parentheses_format(node)
-          if parentheses?(node)
-            '%<name>s(%<action>s%<params>s%<session>s)'
-          else
-            '%<name>s %<action>s%<params>s%<session>s'
-          end
-        end
-      end
-    end
-  end
-end

data/rubocop/config-2019-08-12.yml

@@ -1,95 +0,0 @@
-require:
-  - netsoft-danger
-  - rubocop-rails
-  - rubocop-performance
-  - rubocop-rspec
-
-AllCops:
-  TargetRubyVersion: 2.4
-  TargetRailsVersion: 5.2
-  DisplayStyleGuide: true
-  StyleGuideBaseURL: https://rubystyle.guide
-  Exclude:
-    - 'db/**/*'
-    - 'coverage/**/*'
-    - 'log/**/*'
-    - 'public/**/*'
-    - 'tmp/**/*'
-    - 'spec/dummy/**/*'
-    - 'vendor/**/*'
-
-Naming/RescuedExceptionsVariableName:
-  PreferredName: ex
-Naming/UncommunicativeMethodParamName:
-  AllowedNames:
-    - me
-    - ex
-
-Layout/AlignHash:
-  EnforcedHashRocketStyle: table
-  EnforcedColonStyle: table
-Layout/ExtraSpacing:
-  AllowForAlignment: true
-Layout/IndentAssignment:
-  IndentationWidth: 4
-Layout/IndentFirstArrayElement:
-  EnforcedStyle: consistent
-  IndentationWidth: 4
-Layout/IndentFirstHashElement:
-  EnforcedStyle: consistent
-  IndentationWidth: 4
-Layout/SpaceInsideBlockBraces:
-  EnforcedStyle: no_space
-  SpaceBeforeBlockParameters: false
-Layout/SpaceInsideHashLiteralBraces:
-  EnforcedStyle: no_space
-
-Lint/AmbiguousBlockAssociation:
-  Exclude:
-    - spec/**/*
-
-Rails:
-  Enabled: true
-Rails/HttpPositionalArguments:
-  Enabled: false
-Rails/SkipsModelValidations:
-  Whitelist:
-    - touch
-    - update_attribute
-    - update_counters
-    - increment_counter
-    - decrement_counter
-Netsoft/AuthHttpPositionalArguments:
-  Enabled: true
-  Include:
-    - 'spec/controllers/**/*'
-
-RSpec/ExpectChange:
-  EnforcedStyle: block
-RSpec/ImplicitSubject:
-  Enabled: false
-RSpec/MessageSpies:
-  Enabled: false
-RSpec/NamedSubject:
-  Enabled: false
-RSpec/NestedGroups:
-  Enabled: false
-RSpec/NotToNot:
-  EnforcedStyle: to_not
-
-Style/AndOr:
-  EnforcedStyle: conditionals
-Style/BlockDelimiters:
-  EnforcedStyle: semantic
-  AllowBracesOnProceduralOneLiners: true
-Style/MultilineBlockChain:
-  Enabled: false
-Style/RescueModifier:
-  Enabled: false
-Style/TrailingCommaInArrayLiteral:
-  EnforcedStyleForMultiline: comma
-Style/TrailingCommaInHashLiteral:
-  EnforcedStyleForMultiline: comma
-
-Metrics:
-  Enabled: false