netsnmp 0.1.3 → 0.1.4

data/spec/support/Dockerfile

@@ -1,8 +1,8 @@
-FROM python:2
-Maintainer Tiago Cardoso <tiago.cardoso@swisscom.com>
+FROM python:2.7-alpine
+Maintainer Tiago Cardoso <cardoso_tiago@hotmail.com>
 
 RUN easy_install snmpsim==0.3.0
-RUN easy_install pycrypto 
+RUN easy_install pycrypto==2.6.1
 EXPOSE 1161
 # Create non-privileged user
 RUN useradd -m snmp_server

data/spec/support/celluloid.rb

@@ -1,31 +1,37 @@
+# frozen_string_literal: true
+
 # Copied from celluloid-io spec helpers
 module CelluloidHelpers
   class WrapperActor
     include ::Celluloid::IO
     execute_block_on_receiver :wrap
-  
+
     def wrap
       yield
     end
   end
-  
+
   def with_wrapper_actor
     WrapperActor.new
   end
+
   def within_io_actor(&block)
     actor = WrapperActor.new
     actor.wrap(&block)
   ensure
-    actor.terminate if actor.alive? rescue nil
+    begin
+      actor.terminate if actor.alive?
+    rescue StandardError
+      nil
+    end
   end
 
-
   class Proxy < NETSNMP::Session::Transport
     MAXPDUSIZE = 0xffff + 1
 
     def initialize(host, port)
       @socket = Celluloid::IO::UDPSocket.new
-      @socket.connect( host, port )
+      @socket.connect(host, port)
       @timeout = 2
     end
 
@@ -34,6 +40,7 @@ module CelluloidHelpers
     end
 
     private
+
     def wait(mode)
       Celluloid.timeout(@timeout) do
         @socket.__send__(mode)
@@ -41,6 +48,5 @@ module CelluloidHelpers
     rescue Celluloid::TaskTimeout
       raise Timeout::Error, "Timeout after #{@timeout} seconds"
     end
-
   end
 end

data/spec/support/request_examples.rb

@@ -1,10 +1,14 @@
+# frozen_string_literal: true
+
 RSpec.shared_examples "an snmp client" do
-  let(:device_options) { {
-    host: "localhost",
-    port: SNMPPORT
-  } }
-  let(:protocol_options) { { } } 
-  let(:extra_options) { { } }
+  let(:device_options) do
+    {
+      host: "localhost",
+      port: SNMPPORT
+    }
+  end
+  let(:protocol_options) { {} }
+  let(:extra_options) { {} }
   let(:options) { protocol_options.merge(device_options).merge(extra_options) }
 
   subject { described_class.new(options) }
@@ -14,6 +18,14 @@ RSpec.shared_examples "an snmp client" do
     it "fetches the varbinds for a given oid" do
       expect(value).to eq(get_result)
     end
+    context "with multiple oids" do
+      let(:value) { subject.get({ oid: get_oid }, oid: next_oid) }
+      it "returns the values for both" do
+        expect(value).to be_a(Array)
+        expect(value).to include(/#{get_result}/)
+        expect(value).to include(/#{next_result}/)
+      end
+    end
   end
 
   describe "#get_next" do
@@ -28,9 +40,8 @@ RSpec.shared_examples "an snmp client" do
   describe "#walk" do
     let(:value) { subject.walk(oid: walk_oid) }
     it "fetches the varbinds for the next oid" do
-      values = value.map {|oid, val| "#{oid}: #{val}" }.join("\n") << "\n" 
+      values = value.map { |oid, val| "#{oid}: #{val}" }.join("\n") << "\n"
       expect(values).to eq(walk_result)
     end
   end
-
 end

data/spec/support/specs.sh

@@ -0,0 +1,39 @@
+#!/usr/bin/env bash
+function start {
+  docker pull honeyryderchuck/snmp-server-emulator:latest
+  docker run -d -p :1161/udp --name test-snmp -v $(pwd)/spec/support/snmpsim:/home/snmp_server/.snmpsim honeyryderchuck/snmp-server-emulator \
+  --v3-engine-id=000000000000000000000002 \
+  --agent-udpv4-endpoint=0.0.0.0:1161 --agent-udpv6-endpoint='[::0]:1161' \
+  --v3-user=simulator --v3-auth-key=auctoritas --v3-priv-key=privatus \
+  --v3-user=authmd5 --v3-auth-key=maplesyrup --v3-auth-proto=MD5 --v3-priv-proto=NONE \
+  --v3-user=authsha --v3-auth-key=maplesyrup --v3-auth-proto=SHA --v3-priv-proto=NONE \
+  --v3-user=authprivshaaes --v3-auth-key=maplesyrup --v3-auth-proto=SHA \
+                           --v3-priv-key=maplesyrup --v3-priv-proto=AES \
+  --v3-user=authprivmd5aes --v3-auth-key=maplesyrup --v3-auth-proto=MD5 \
+                           --v3-priv-key=maplesyrup --v3-priv-proto=AES \
+  --v3-user=authprivshades --v3-auth-key=maplesyrup --v3-auth-proto=SHA \
+                           --v3-priv-key=maplesyrup --v3-priv-proto=DES \
+  --v3-user=authprivmd5des --v3-auth-key=maplesyrup --v3-auth-proto=MD5 \
+                           --v3-priv-key=maplesyrup --v3-priv-proto=DES \
+  --v3-user=unsafe --v3-auth-proto=NONE --v3-priv-proto=NONE
+
+}
+
+
+function finish {
+  docker stop test-snmp
+  docker rm test-snmp
+}
+
+trap finish EXIT
+
+start
+sleep 20 # give some time for the simulator to boot
+
+port="$(docker port test-snmp 1161/udp)"
+export SNMP_PORT=$(echo $port | cut -d':' -f2)
+
+bundle exec rake spec:ci
+bundle exec rubocop
+
+

data/spec/support/{start_docker.sh → start-docker.sh}

@@ -1,5 +1,5 @@
-sudo docker build --build-arg http_proxy=$http_proxy --build-arg https_proxy=$https_proxy -t snmp-server-emulator -f spec/support/Dockerfile .
-sudo docker run -d -p :1161/udp --name test-snmp-emulator snmp-server-emulator \
+docker build -t snmp-server -f spec/support/Dockerfile .
+docker run -p :1161/udp --name test-snmp-emulator -v $(pwd)/spec/support/snmpsim:/home/snmp_server/.snmpsim snmp-server \
   --v3-engine-id=000000000000000000000002 \
   --agent-udpv4-endpoint=0.0.0.0:1161 --agent-udpv6-endpoint='[::0]:1161' \
   --v3-user=simulator --v3-auth-key=auctoritas --v3-priv-key=privatus \
@@ -14,6 +14,6 @@ sudo docker run -d -p :1161/udp --name test-snmp-emulator snmp-server-emulator \
   --v3-user=authprivmd5des --v3-auth-key=maplesyrup --v3-auth-proto=MD5 \
                            --v3-priv-key=maplesyrup --v3-priv-proto=DES \
   --v3-user=unsafe --v3-auth-proto=NONE --v3-priv-proto=NONE
-sleep 20 # give some time for the simulator to boot
-
+#sleep 20 # give some time for the simulator to boot
+export SNMP_PORT=`echo $(docker port test-snmp-emulator 1161/udp) | cut -d':' -f2`
 

data/spec/timeticks_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 # from https://ask.wireshark.org/questions/14002/how-to-decode-timeticks-hundreds-seconds-to-readable-date-time
 RSpec.describe NETSNMP::Timetick do
   subject { described_class.new(1525917187) }

data/spec/v3_session_spec.rb

@@ -1,7 +1,11 @@
+# frozen_string_literal: true
+
 RSpec.describe NETSNMP::V3Session do
-  let(:security_options) { { username: "authprivmd5des", auth_password: "maplesyrup",
-                             auth_protocol: :md5, priv_password: "maplesyrup",
-                             priv_protocol: :des, security_level: :auth_priv } }
+  let(:security_options) do
+    { username: "authprivmd5des", auth_password: "maplesyrup",
+      auth_protocol: :md5, priv_password: "maplesyrup",
+      priv_protocol: :des, security_level: :auth_priv }
+  end
   it "generates the security parameters handler" do
     sess = described_class.new(security_options.merge(host: "localhost", port: SNMPPORT))
     # not generated yet
@@ -16,6 +20,6 @@ RSpec.describe NETSNMP::V3Session do
   end
 
   it "fails if the pass object doesn't follow the expected api" do
-    expect { described_class.new(host: "localhost", port: SNMPPORT, security_parameters: double) }.to raise_error(NETSNMP::Error) 
+    expect { described_class.new(host: "localhost", port: SNMPPORT, security_parameters: double) }.to raise_error(NETSNMP::Error)
   end
 end

data/spec/varbind_spec.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 RSpec.describe NETSNMP::Varbind do
   describe "#to_der" do
     it { expect(described_class.new(".1.3.6.1.2.1.1.1.0").to_der).to eq("0\f\006\b+\006\001\002\001\001\001\000\005\000".b) }
@@ -15,6 +17,16 @@ RSpec.describe NETSNMP::Varbind do
       end
       context "when passed a type" do
         # TODO: tidy this for IP Addresses
+        it "converts gauge32" do
+          gauge = 805
+          varbind = described_class.new(".1.3.6.1.2.1.1.3.0", type: :gauge, value: gauge)
+          expect(varbind.to_der).to end_with("B\x02\x03%".b)
+        end
+        it "converts counter32" do
+          gauge = 998932
+          varbind = described_class.new(".1.3.6.1.2.1.1.3.0", type: :counter32, value: gauge)
+          expect(varbind.to_der).to end_with("A\x02>\x14".b)
+        end
         it "converts integer ticks" do
           timetick = 1
           varbind = described_class.new(".1.3.6.1.2.1.1.3.0", type: :timetick, value: timetick)

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: netsnmp
 version: !ruby/object:Gem::Version
-  version: 0.1.3
+  version: 0.1.4
 platform: ruby
 authors:
 - Tiago Cardoso
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-02-21 00:00:00.000000000 Z
+date: 2018-02-16 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rake
@@ -70,9 +70,9 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: 0.17.2
-description: |
-  Wraps the net-snmp core usage into idiomatic ruby.
-  It is designed to support as many environments and concurrency frameworks as possible.
+description: |2
+      Wraps the net-snmp core usage into idiomatic ruby.
+      It is designed to support as many environments and concurrency frameworks as possible.
 email: cardoso_tiago@hotmail.com
 executables: []
 extensions: []
@@ -81,6 +81,8 @@ files:
 - ".coveralls.yml"
 - ".gitignore"
 - ".rspec"
+- ".rubocop.yml"
+- ".rubocop_todo.yml"
 - ".travis.yml"
 - AUTHORS
 - Gemfile
@@ -114,7 +116,8 @@ files:
 - spec/support/Dockerfile
 - spec/support/celluloid.rb
 - spec/support/request_examples.rb
-- spec/support/start_docker.sh
+- spec/support/specs.sh
+- spec/support/start-docker.sh
 - spec/support/stop_docker.sh
 - spec/timeticks_spec.rb
 - spec/v3_session_spec.rb
@@ -132,7 +135,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: 2.1.0
+      version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
@@ -141,7 +144,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
 requirements:
 - net-snmp
 rubyforge_project: 
-rubygems_version: 2.2.5
+rubygems_version: 2.7.4
 signing_key: 
 specification_version: 4
 summary: SNMP Client library
@@ -156,7 +159,8 @@ test_files:
 - spec/support/Dockerfile
 - spec/support/celluloid.rb
 - spec/support/request_examples.rb
-- spec/support/start_docker.sh
+- spec/support/specs.sh
+- spec/support/start-docker.sh
 - spec/support/stop_docker.sh
 - spec/timeticks_spec.rb
 - spec/v3_session_spec.rb