net-ssh 6.2.0.rc2 → 7.0.1

data/.rubocop_todo.yml

@@ -1,46 +1,29 @@
 # This configuration was generated by
 # `rubocop --auto-gen-config`
-# on 2020-05-29 10:37:36 +0200 using RuboCop version 0.74.0.
+# on 2022-04-29 12:31:14 UTC using RuboCop version 1.28.2.
 # The point is for the user to remove these configuration records
 # one by one as the offenses are removed from the code base.
 # Note that changes in the inspected code, or installation of new
 # versions of RuboCop, may require this file to be generated again.
 
-# Offense count: 75
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle, IndentationWidth.
-# SupportedStyles: with_first_argument, with_fixed_indentation
-Layout/AlignArguments:
-  Enabled: false
-
-# Offense count: 63
-# Cop supports --auto-correct.
-# Configuration parameters: AllowMultipleStyles, EnforcedHashRocketStyle, EnforcedColonStyle, EnforcedLastArgumentHashStyle.
-# SupportedHashRocketStyles: key, separator, table
-# SupportedColonStyles: key, separator, table
-# SupportedLastArgumentHashStyles: always_inspect, always_ignore, ignore_implicit, ignore_explicit
-Layout/AlignHash:
+# Offense count: 1
+# This cop supports safe auto-correction (--auto-correct).
+# Configuration parameters: Include.
+# Include: **/*.gemspec
+Gemspec/RequireMFA:
   Exclude:
-    - 'lib/net/ssh/key_factory.rb'
-    - 'lib/net/ssh/transport/cipher_factory.rb'
-    - 'lib/net/ssh/transport/hmac.rb'
-    - 'lib/net/ssh/transport/kex.rb'
-    - 'test/test_config.rb'
-
-# Offense count: 70
-# Cop supports --auto-correct.
-Layout/EmptyLineAfterGuardClause:
-  Enabled: false
+    - 'net-ssh.gemspec'
 
-# Offense count: 172
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle.
-# SupportedStyles: empty_lines, empty_lines_except_namespace, empty_lines_special, no_empty_lines
-Layout/EmptyLinesAroundModuleBody:
-  Enabled: false
+# Offense count: 1
+# This cop supports safe auto-correction (--auto-correct).
+# Configuration parameters: EnforcedStyle, IndentationWidth.
+# SupportedStyles: aligned, indented
+Layout/LineEndStringConcatenationIndentation:
+  Exclude:
+    - 'lib/net/ssh/transport/algorithms.rb'
 
-# Offense count: 23
-# Cop supports --auto-correct.
+# Offense count: 7
+# This cop supports safe auto-correction (--auto-correct).
 # Configuration parameters: EnforcedStyle, IndentationWidth.
 # SupportedStyles: aligned, indented
 Layout/MultilineOperationIndentation:
@@ -49,32 +32,9 @@ Layout/MultilineOperationIndentation:
     - 'lib/net/ssh/proxy/https.rb'
     - 'lib/net/ssh/transport/algorithms.rb'
     - 'lib/net/ssh/transport/state.rb'
-    - 'lib/net/ssh/verifiers/always.rb'
-    - 'test/authentication/methods/test_hostbased.rb'
-    - 'test/authentication/methods/test_publickey.rb'
 
-# Offense count: 16
-# Cop supports --auto-correct.
-Layout/SpaceAfterColon:
-  Exclude:
-    - 'lib/net/ssh/authentication/ed25519.rb'
-    - 'test/integration/test_ed25519_pkeys.rb'
-    - 'test/verifiers/test_always.rb'
-
-# Offense count: 291
-# Cop supports --auto-correct.
-Layout/SpaceAfterComma:
-  Enabled: false
-
-# Offense count: 136
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle.
-# SupportedStyles: space, no_space
-Layout/SpaceAroundEqualsInParameterDefault:
-  Enabled: false
-
-# Offense count: 12
-# Cop supports --auto-correct.
+# Offense count: 5
+# This cop supports safe auto-correction (--auto-correct).
 # Configuration parameters: EnforcedStyle, EnforcedStyleForEmptyBraces, SpaceBeforeBlockParameters.
 # SupportedStyles: space, no_space
 # SupportedStylesForEmptyBraces: space, no_space
@@ -83,12 +43,9 @@ Layout/SpaceInsideBlockBraces:
     - 'lib/net/ssh/authentication/session.rb'
     - 'lib/net/ssh/transport/ctr.rb'
     - 'support/ssh_tunnel_bug.rb'
-    - 'test/authentication/test_agent.rb'
-    - 'test/authentication/test_key_manager.rb'
-    - 'test/start/test_user_nil.rb'
 
 # Offense count: 6
-# Cop supports --auto-correct.
+# This cop supports safe auto-correction (--auto-correct).
 # Configuration parameters: EnforcedStyle, EnforcedStyleForEmptyBrackets.
 # SupportedStyles: space, no_space
 # SupportedStylesForEmptyBrackets: space, no_space
@@ -96,11 +53,18 @@ Layout/SpaceInsideReferenceBrackets:
   Exclude:
     - 'lib/net/ssh/transport/algorithms.rb'
 
-# Offense count: 730
-# Cop supports --auto-correct.
-# Configuration parameters: AllowInHeredoc.
-Layout/TrailingWhitespace:
-  Enabled: false
+# Offense count: 11
+# This cop supports safe auto-correction (--auto-correct).
+Lint/AmbiguousOperatorPrecedence:
+  Exclude:
+    - 'lib/net/ssh/authentication/certificate.rb'
+    - 'lib/net/ssh/config.rb'
+    - 'lib/net/ssh/loggable.rb'
+    - 'lib/net/ssh/transport/kex/diffie_hellman_group_exchange_sha1.rb'
+    - 'lib/net/ssh/transport/openssl.rb'
+    - 'lib/net/ssh/transport/state.rb'
+    - 'lib/net/ssh/version.rb'
+    - 'test/integration/test_proxy.rb'
 
 # Offense count: 4
 # Configuration parameters: AllowSafeAssignment.
@@ -111,84 +75,142 @@ Lint/AssignmentInCondition:
     - 'lib/net/ssh/proxy/command.rb'
 
 # Offense count: 1
-Lint/EmptyWhen:
+# Configuration parameters: AllowedMethods.
+# AllowedMethods: enums
+Lint/ConstantDefinitionInBlock:
   Exclude:
-    - 'lib/net/ssh/config.rb'
+    - 'test/transport/test_cipher_factory.rb'
 
-# Offense count: 9
-# Configuration parameters: AllowComments.
-Lint/HandleExceptions:
+# Offense count: 1
+# This cop supports safe auto-correction (--auto-correct).
+Lint/DeprecatedClassMethods:
+  Exclude:
+    - 'lib/net/ssh/transport/packet_stream.rb'
+
+# Offense count: 12
+# This cop supports safe auto-correction (--auto-correct).
+Lint/DeprecatedOpenSSLConstant:
   Exclude:
-    - 'lib/net/ssh/authentication/session.rb'
-    - 'lib/net/ssh/known_hosts.rb'
     - 'lib/net/ssh/transport/openssl.rb'
-    - 'test/integration/common.rb'
-    - 'test/integration/test_forward.rb'
-    - 'test/start/test_connection.rb'
+
+# Offense count: 2
+# Configuration parameters: AllowComments, AllowEmptyLambdas.
+Lint/EmptyBlock:
+  Exclude:
+    - 'test/common.rb'
     - 'test/start/test_transport.rb'
 
+# Offense count: 1
+# Configuration parameters: AllowComments.
+Lint/EmptyWhen:
+  Exclude:
+    - 'lib/net/ssh/config.rb'
+
 # Offense count: 72
 Lint/ImplicitStringConcatenation:
   Exclude:
     - 'lib/net/ssh/transport/kex/diffie_hellman_group14_sha1.rb'
     - 'lib/net/ssh/transport/kex/diffie_hellman_group1_sha1.rb'
 
-# Offense count: 1
-Lint/LiteralAsCondition:
+# Offense count: 8
+# This cop supports safe auto-correction (--auto-correct).
+Lint/IncompatibleIoSelectWithFiberScheduler:
   Exclude:
-    - 'lib/net/ssh/authentication/pageant.rb'
+    - 'lib/net/ssh/buffered_io.rb'
+    - 'lib/net/ssh/proxy/command.rb'
+    - 'lib/net/ssh/transport/packet_stream.rb'
+    - 'lib/net/ssh/transport/server_version.rb'
 
 # Offense count: 2
+# This cop supports unsafe auto-correction (--auto-correct-all).
 Lint/Loop:
   Exclude:
     - 'lib/net/ssh/authentication/methods/password.rb'
     - 'lib/net/ssh/key_factory.rb'
 
+# Offense count: 3
+Lint/MissingSuper:
+  Exclude:
+    - 'lib/net/ssh/proxy/jump.rb'
+    - 'test/common.rb'
+    - 'test/integration/mitm_server.rb'
+
 # Offense count: 1
 Lint/NonLocalExitFromIterator:
   Exclude:
     - 'lib/net/ssh/known_hosts.rb'
 
+# Offense count: 2
+# This cop supports unsafe auto-correction (--auto-correct-all).
+Lint/OrAssignmentToConstant:
+  Exclude:
+    - 'lib/net/ssh/authentication/pageant.rb'
+
+# Offense count: 6
+# This cop supports unsafe auto-correction (--auto-correct-all).
+# Configuration parameters: AllowedImplicitNamespaces.
+# AllowedImplicitNamespaces: Gem
+Lint/RaiseException:
+  Exclude:
+    - 'Rakefile'
+    - 'lib/net/ssh/buffer.rb'
+    - 'lib/net/ssh/key_factory.rb'
+
+# Offense count: 1
+# This cop supports safe auto-correction (--auto-correct).
+Lint/RedundantCopDisableDirective:
+  Exclude:
+    - 'lib/net/ssh/key_factory.rb'
+
 # Offense count: 3
 Lint/RescueException:
   Exclude:
     - 'lib/net/ssh/authentication/key_manager.rb'
     - 'lib/net/ssh/service/forward.rb'
 
+# Offense count: 4
+# This cop supports safe auto-correction (--auto-correct).
+Lint/SendWithMixinArgument:
+  Exclude:
+    - 'lib/net/ssh/test/extensions.rb'
+
 # Offense count: 2
 Lint/ShadowedException:
   Exclude:
     - 'lib/net/ssh/authentication/key_manager.rb'
 
+# Offense count: 5
+# Configuration parameters: AllowComments, AllowNil.
+Lint/SuppressedException:
+  Exclude:
+    - 'lib/net/ssh/authentication/session.rb'
+    - 'lib/net/ssh/transport/openssl.rb'
+    - 'test/integration/common.rb'
+    - 'test/integration/test_forward.rb'
+
 # Offense count: 1
 # Configuration parameters: AllowKeywordBlockArguments.
 Lint/UnderscorePrefixedVariableName:
   Exclude:
     - 'lib/net/ssh/test/local_packet.rb'
 
-# Offense count: 60
-# Cop supports --auto-correct.
+# Offense count: 15
+# This cop supports safe auto-correction (--auto-correct).
 # Configuration parameters: IgnoreEmptyBlocks, AllowUnusedKeywordArguments.
 Lint/UnusedBlockArgument:
   Exclude:
     - 'lib/net/ssh/connection/keepalive.rb'
     - 'lib/net/ssh/connection/session.rb'
     - 'lib/net/ssh/service/forward.rb'
-    - 'test/authentication/methods/test_password.rb'
-    - 'test/authentication/test_agent.rb'
-    - 'test/common.rb'
-    - 'test/connection/test_channel.rb'
-    - 'test/connection/test_session.rb'
-    - 'test/transport/test_algorithms.rb'
-    - 'test/transport/test_hmac.rb'
 
-# Offense count: 65
-# Cop supports --auto-correct.
-# Configuration parameters: AllowUnusedKeywordArguments, IgnoreEmptyMethods.
+# Offense count: 74
+# This cop supports safe auto-correction (--auto-correct).
+# Configuration parameters: AllowUnusedKeywordArguments, IgnoreEmptyMethods, IgnoreNotImplementedMethods.
 Lint/UnusedMethodArgument:
   Enabled: false
 
 # Offense count: 3
+# This cop supports safe auto-correction (--auto-correct).
 # Configuration parameters: ContextCreatingMethods, MethodCreatingMethods.
 Lint/UselessAccessModifier:
   Exclude:
@@ -204,13 +226,20 @@ Lint/UselessAssignment:
     - 'test/integration/common.rb'
     - 'test/integration/test_forward.rb'
 
-# Offense count: 239
+# Offense count: 1
+# This cop supports unsafe auto-correction (--auto-correct-all).
+Lint/UselessTimes:
+  Exclude:
+    - 'test/integration/test_forward.rb'
+
+# Offense count: 205
+# Configuration parameters: IgnoredMethods, CountRepeatedAttributes.
 Metrics/AbcSize:
-  Max: 71
+  Max: 74
 
-# Offense count: 17
-# Configuration parameters: CountComments, ExcludedMethods.
-# ExcludedMethods: refine
+# Offense count: 16
+# Configuration parameters: CountComments, CountAsOne, ExcludedMethods, IgnoredMethods.
+# IgnoredMethods: refine
 Metrics/BlockLength:
   Max: 59
 
@@ -220,32 +249,34 @@ Metrics/BlockNesting:
   Max: 4
 
 # Offense count: 33
-# Configuration parameters: CountComments.
+# Configuration parameters: CountComments, CountAsOne.
 Metrics/ClassLength:
   Max: 488
 
-# Offense count: 40
+# Offense count: 38
+# Configuration parameters: IgnoredMethods.
 Metrics/CyclomaticComplexity:
-  Max: 28
+  Max: 32
 
-# Offense count: 224
-# Configuration parameters: CountComments, ExcludedMethods.
+# Offense count: 232
+# Configuration parameters: CountComments, CountAsOne, ExcludedMethods, IgnoredMethods.
 Metrics/MethodLength:
   Max: 72
 
 # Offense count: 3
-# Configuration parameters: CountComments.
+# Configuration parameters: CountComments, CountAsOne.
 Metrics/ModuleLength:
   Max: 160
 
-# Offense count: 1
-# Configuration parameters: CountKeywordArgs.
+# Offense count: 2
+# Configuration parameters: Max, CountKeywordArgs.
 Metrics/ParameterLists:
-  Max: 6
+  MaxOptionalParameters: 4
 
-# Offense count: 32
+# Offense count: 34
+# Configuration parameters: IgnoredMethods.
 Metrics/PerceivedComplexity:
-  Max: 20
+  Max: 32
 
 # Offense count: 10
 Naming/AccessorMethodName:
@@ -259,12 +290,15 @@ Naming/AccessorMethodName:
     - 'lib/net/ssh/transport/kex/diffie_hellman_group_exchange_sha1.rb'
 
 # Offense count: 2
+# This cop supports safe auto-correction (--auto-correct).
 Naming/BinaryOperatorParameterName:
   Exclude:
     - 'lib/net/ssh/buffer.rb'
     - 'lib/net/ssh/version.rb'
 
 # Offense count: 16
+# Configuration parameters: AllowedNames.
+# AllowedNames: module_parent
 Naming/ClassAndModuleCamelCase:
   Enabled: false
 
@@ -275,9 +309,9 @@ Naming/ConstantName:
     - 'lib/net/ssh/transport/kex/diffie_hellman_group1_sha1.rb'
     - 'lib/net/ssh/transport/openssl.rb'
 
-# Offense count: 12
-# Configuration parameters: Blacklist.
-# Blacklist: (?-mix:(^|\s)(EO[A-Z]{1}|END)(\s|$))
+# Offense count: 15
+# Configuration parameters: ForbiddenDelimiters.
+# ForbiddenDelimiters: (?-mix:(^|\s)(EO[A-Z]{1}|END)(\s|$))
 Naming/HeredocDelimiterNaming:
   Exclude:
     - 'test/authentication/test_agent.rb'
@@ -296,7 +330,7 @@ Naming/MemoizedInstanceVariableName:
     - 'test/authentication/test_key_manager.rb'
 
 # Offense count: 32
-# Configuration parameters: EnforcedStyle.
+# Configuration parameters: EnforcedStyle, AllowedPatterns, IgnoredPatterns.
 # SupportedStyles: snake_case, camelCase
 Naming/MethodName:
   Exclude:
@@ -309,19 +343,10 @@ Naming/MethodName:
     - 'test/test_config.rb'
     - 'test/test_key_factory.rb'
 
-# Offense count: 4
-# Cop supports --auto-correct.
-# Configuration parameters: PreferredName.
-Naming/RescuedExceptionsVariableName:
-  Exclude:
-    - 'lib/net/ssh/connection/session.rb'
-    - 'lib/net/ssh/service/forward.rb'
-    - 'lib/net/ssh/verifiers/accept_new.rb'
-
 # Offense count: 23
 # Configuration parameters: MinNameLength, AllowNamesEndingInNumbers, AllowedNames, ForbiddenNames.
-# AllowedNames: io, id, to, by, on, in, at, ip, db
-Naming/UncommunicativeMethodParamName:
+# AllowedNames: at, by, db, id, in, io, ip, of, on, os, pp, to
+Naming/MethodParameterName:
   Exclude:
     - 'lib/net/ssh/authentication/certificate.rb'
     - 'lib/net/ssh/authentication/ed25519.rb'
@@ -335,17 +360,53 @@ Naming/UncommunicativeMethodParamName:
     - 'lib/net/ssh/transport/identity_cipher.rb'
     - 'test/connection/test_session.rb'
 
-# Offense count: 8
-# Configuration parameters: EnforcedStyle.
+# Offense count: 4
+# This cop supports safe auto-correction (--auto-correct).
+# Configuration parameters: PreferredName.
+Naming/RescuedExceptionsVariableName:
+  Exclude:
+    - 'lib/net/ssh/connection/session.rb'
+    - 'lib/net/ssh/service/forward.rb'
+    - 'lib/net/ssh/verifiers/accept_new.rb'
+
+# Offense count: 5
+# Configuration parameters: EnforcedStyle, CheckMethodNames, CheckSymbols, AllowedIdentifiers.
+# SupportedStyles: snake_case, normalcase, non_integer
+# AllowedIdentifiers: capture3, iso8601, rfc1123_date, rfc822, rfc2822, rfc3339
+Naming/VariableNumber:
+  Exclude:
+    - 'test/test_buffer.rb'
+    - 'test/test_known_hosts.rb'
+    - 'test/transport/test_identity_cipher.rb'
+
+# Offense count: 1
+# This cop supports unsafe auto-correction (--auto-correct-all).
+Security/IoMethods:
+  Exclude:
+    - 'lib/net/ssh/config.rb'
+
+# Offense count: 2
+# Configuration parameters: EnforcedStyle, AllowModifiersOnSymbols.
 # SupportedStyles: inline, group
 Style/AccessModifierDeclarations:
   Exclude:
     - 'lib/net/ssh/authentication/pageant.rb'
-    - 'lib/net/ssh/transport/openssl.rb'
-    - 'test/test_key_factory.rb'
+
+# Offense count: 31
+# This cop supports safe auto-correction (--auto-correct).
+# Configuration parameters: EnforcedStyle.
+# SupportedStyles: separated, grouped
+Style/AccessorGrouping:
+  Exclude:
+    - 'lib/net/ssh/authentication/certificate.rb'
+    - 'lib/net/ssh/transport/kex/abstract.rb'
+    - 'test/common.rb'
+    - 'test/connection/test_channel.rb'
+    - 'test/integration/mitm_server.rb'
+    - 'test/start/test_transport.rb'
 
 # Offense count: 2
-# Cop supports --auto-correct.
+# This cop supports safe auto-correction (--auto-correct).
 # Configuration parameters: EnforcedStyle.
 # SupportedStyles: prefer_alias, prefer_alias_method
 Style/Alias:
@@ -353,36 +414,19 @@ Style/Alias:
     - 'lib/net/ssh/connection/session.rb'
     - 'lib/net/ssh/service/forward.rb'
 
-# Offense count: 31
-# Cop supports --auto-correct.
+# Offense count: 9
+# This cop supports safe auto-correction (--auto-correct).
 # Configuration parameters: EnforcedStyle.
 # SupportedStyles: always, conditionals
 Style/AndOr:
   Exclude:
-    - 'lib/net/ssh/authentication/key_manager.rb'
-    - 'lib/net/ssh/buffer.rb'
-    - 'lib/net/ssh/buffered_io.rb'
     - 'lib/net/ssh/connection/channel.rb'
     - 'lib/net/ssh/connection/session.rb'
-    - 'lib/net/ssh/key_factory.rb'
     - 'lib/net/ssh/service/forward.rb'
-    - 'lib/net/ssh/test/channel.rb'
-    - 'lib/net/ssh/test/script.rb'
-    - 'lib/net/ssh/transport/cipher_factory.rb'
-    - 'lib/net/ssh/transport/hmac.rb'
-    - 'lib/net/ssh/transport/key_expander.rb'
-    - 'test/common.rb'
-
-# Offense count: 2
-# Configuration parameters: AllowedChars.
-Style/AsciiComments:
-  Exclude:
-    - 'lib/net/ssh/authentication/pageant.rb'
-    - 'lib/net/ssh/buffered_io.rb'
 
 # Offense count: 9
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle, ProceduralMethods, FunctionalMethods, IgnoredMethods, AllowBracesOnProceduralOneLiners.
+# This cop supports safe auto-correction (--auto-correct).
+# Configuration parameters: EnforcedStyle, ProceduralMethods, FunctionalMethods, IgnoredMethods, AllowBracesOnProceduralOneLiners, BracesRequiredMethods.
 # SupportedStyles: line_count_based, semantic, braces_for_chaining, always_braces
 # ProceduralMethods: benchmark, bm, bmbm, create, each_with_object, measure, new, realtime, tap, with_object
 # FunctionalMethods: let, let!, subject, watch
@@ -397,37 +441,42 @@ Style/BlockDelimiters:
     - 'lib/net/ssh/transport/ctr.rb'
     - 'test/verifiers/test_always.rb'
 
-# Offense count: 7
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle.
-# SupportedStyles: braces, no_braces, context_dependent
-Style/BracesAroundHashParameters:
-  Exclude:
-    - 'lib/net/ssh/config.rb'
-    - 'test/integration/test_ed25519_pkeys.rb'
-    - 'test/integration/test_id_rsa_keys.rb'
-    - 'test/transport/test_hmac.rb'
-    - 'test/transport/test_session.rb'
-
 # Offense count: 2
+# This cop supports safe auto-correction (--auto-correct).
+# Configuration parameters: AllowOnConstant.
 Style/CaseEquality:
   Exclude:
     - 'lib/net/ssh/buffer.rb'
     - 'lib/net/ssh/connection/session.rb'
 
+# Offense count: 3
+# This cop supports unsafe auto-correction (--auto-correct-all).
+Style/CaseLikeIf:
+  Exclude:
+    - 'lib/net/ssh/transport/openssl.rb'
+    - 'test/connection/test_session.rb'
+
 # Offense count: 1
-# Cop supports --auto-correct.
+# This cop supports safe auto-correction (--auto-correct).
 Style/CharacterLiteral:
   Exclude:
     - 'test/test_buffer.rb'
 
-# Offense count: 17
-# Cop supports --auto-correct.
-# Configuration parameters: AutoCorrect, EnforcedStyle.
+# Offense count: 18
+# This cop supports safe auto-correction (--auto-correct).
+# Configuration parameters: EnforcedStyle.
 # SupportedStyles: nested, compact
 Style/ClassAndModuleChildren:
   Enabled: false
 
+# Offense count: 1
+# This cop supports safe auto-correction (--auto-correct).
+# Configuration parameters: IgnoredMethods.
+# IgnoredMethods: ==, equal?, eql?
+Style/ClassEqualityComparison:
+  Exclude:
+    - 'lib/net/ssh/service/forward.rb'
+
 # Offense count: 7
 Style/ClassVars:
   Exclude:
@@ -437,15 +486,21 @@ Style/ClassVars:
     - 'test/authentication/methods/test_publickey.rb'
 
 # Offense count: 1
-# Cop supports --auto-correct.
+# This cop supports safe auto-correction (--auto-correct).
 Style/ColonMethodCall:
   Exclude:
     - 'lib/net/ssh/authentication/ed25519.rb'
 
+# Offense count: 2
+Style/CombinableLoops:
+  Exclude:
+    - 'lib/net/ssh/connection/channel.rb'
+    - 'test/integration/test_hmac_etm.rb'
+
 # Offense count: 4
-# Cop supports --auto-correct.
-# Configuration parameters: Keywords.
-# Keywords: TODO, FIXME, OPTIMIZE, HACK, REVIEW
+# This cop supports safe auto-correction (--auto-correct).
+# Configuration parameters: Keywords, RequireColon.
+# Keywords: TODO, FIXME, OPTIMIZE, HACK, REVIEW, NOTE
 Style/CommentAnnotation:
   Exclude:
     - 'lib/net/ssh/authentication/ed25519.rb'
@@ -454,13 +509,14 @@ Style/CommentAnnotation:
     - 'lib/net/ssh/config.rb'
 
 # Offense count: 3
+# This cop supports safe auto-correction (--auto-correct).
 Style/CommentedKeyword:
   Exclude:
     - 'test/connection/test_session.rb'
     - 'test/integration/test_forward.rb'
 
 # Offense count: 7
-# Cop supports --auto-correct.
+# This cop supports safe auto-correction (--auto-correct).
 # Configuration parameters: EnforcedStyle, SingleLineConditionsOnly, IncludeTernaryExpressions.
 # SupportedStyles: assign_to_condition, assign_inside_condition
 Style/ConditionalAssignment:
@@ -471,7 +527,8 @@ Style/ConditionalAssignment:
     - 'lib/net/ssh/transport/state.rb'
     - 'test/test_key_factory.rb'
 
-# Offense count: 13
+# Offense count: 12
+# Configuration parameters: AllowedConstants.
 Style/Documentation:
   Exclude:
     - 'spec/**/*'
@@ -485,19 +542,43 @@ Style/Documentation:
     - 'lib/net/ssh/transport/openssl.rb'
 
 # Offense count: 1
-# Cop supports --auto-correct.
-Style/EmptyLiteral:
+# This cop supports safe auto-correction (--auto-correct).
+Style/EvenOdd:
   Exclude:
-    - 'lib/net/ssh/transport/kex/diffie_hellman_group1_sha1.rb'
+    - 'lib/net/ssh/buffer.rb'
+
+# Offense count: 9
+# This cop supports safe auto-correction (--auto-correct).
+Style/ExplicitBlockArgument:
+  Exclude:
+    - 'lib/net/ssh/loggable.rb'
+    - 'lib/net/ssh/test.rb'
+    - 'test/integration/common.rb'
+    - 'test/integration/mitm_server.rb'
+    - 'test/integration/test_forward.rb'
+
+# Offense count: 12
+# This cop supports safe auto-correction (--auto-correct).
+# Configuration parameters: AllowedVars.
+Style/FetchEnvVar:
+  Exclude:
+    - 'lib/net/ssh.rb'
+    - 'lib/net/ssh/authentication/agent.rb'
+    - 'lib/net/ssh/authentication/methods/hostbased.rb'
+    - 'test/authentication/test_agent.rb'
+    - 'test/common.rb'
+    - 'test/start/test_options.rb'
+    - 'test/test_all.rb'
+    - 'test/test_config.rb'
 
 # Offense count: 1
-# Cop supports --auto-correct.
-Style/EvenOdd:
+# This cop supports safe auto-correction (--auto-correct).
+Style/FileWrite:
   Exclude:
-    - 'lib/net/ssh/buffer.rb'
+    - 'test/integration/test_proxy.rb'
 
 # Offense count: 2
-# Cop supports --auto-correct.
+# This cop supports safe auto-correction (--auto-correct).
 # Configuration parameters: EnforcedStyle.
 # SupportedStyles: format, sprintf, percent
 Style/FormatString:
@@ -505,33 +586,41 @@ Style/FormatString:
     - 'lib/net/ssh/authentication/pageant.rb'
     - 'lib/net/ssh/loggable.rb'
 
-# Offense count: 1
-# Configuration parameters: EnforcedStyle.
-# SupportedStyles: annotated, template, unannotated
-Style/FormatStringToken:
-  Exclude:
-    - 'lib/net/ssh/loggable.rb'
-
-# Offense count: 171
-# Cop supports --auto-correct.
+# Offense count: 174
+# This cop supports safe auto-correction (--auto-correct).
 # Configuration parameters: EnforcedStyle.
-# SupportedStyles: always, never
+# SupportedStyles: always, always_true, never
 Style/FrozenStringLiteralComment:
   Enabled: false
 
+# Offense count: 1
+# This cop supports safe auto-correction (--auto-correct).
+Style/GlobalStdStream:
+  Exclude:
+    - 'lib/net/ssh.rb'
+
 # Offense count: 35
-# Configuration parameters: MinBodyLength.
+# Configuration parameters: MinBodyLength, AllowConsecutiveConditionals.
 Style/GuardClause:
   Enabled: false
 
+# Offense count: 3
+# This cop supports safe auto-correction (--auto-correct).
+# Configuration parameters: AllowSplatArgument.
+Style/HashConversion:
+  Exclude:
+    - 'lib/net/ssh/authentication/certificate.rb'
+    - 'test/test_config.rb'
+
 # Offense count: 1
+# This cop supports safe auto-correction (--auto-correct).
 # Configuration parameters: AllowIfModifier.
 Style/IfInsideElse:
   Exclude:
     - 'lib/net/ssh/connection/session.rb'
 
 # Offense count: 13
-# Cop supports --auto-correct.
+# This cop supports safe auto-correction (--auto-correct).
 Style/IfUnlessModifier:
   Exclude:
     - 'lib/net/ssh.rb'
@@ -544,13 +633,13 @@ Style/IfUnlessModifier:
     - 'test/test_key_factory.rb'
 
 # Offense count: 1
-# Cop supports --auto-correct.
+# This cop supports unsafe auto-correction (--auto-correct-all).
 Style/InfiniteLoop:
   Exclude:
     - 'lib/net/ssh/authentication/pageant.rb'
 
 # Offense count: 27
-# Cop supports --auto-correct.
+# This cop supports safe auto-correction (--auto-correct).
 Style/LineEndConcatenation:
   Exclude:
     - 'lib/net/ssh/authentication/pageant.rb'
@@ -559,9 +648,10 @@ Style/LineEndConcatenation:
     - 'lib/net/ssh/verifiers/always.rb'
 
 # Offense count: 1
-Style/MethodMissingSuper:
+# This cop supports unsafe auto-correction (--auto-correct-all).
+Style/MapToHash:
   Exclude:
-    - 'lib/net/ssh/connection/session.rb'
+    - 'lib/net/ssh/config.rb'
 
 # Offense count: 1
 Style/MissingRespondToMissing:
@@ -569,21 +659,22 @@ Style/MissingRespondToMissing:
     - 'lib/net/ssh/connection/session.rb'
 
 # Offense count: 3
-# Cop supports --auto-correct.
+# This cop supports safe auto-correction (--auto-correct).
 Style/MultilineIfThen:
   Exclude:
     - 'lib/net/ssh/buffered_io.rb'
     - 'lib/net/ssh/service/forward.rb'
 
-# Offense count: 6
-# Cop supports --auto-correct.
+# Offense count: 7
+# This cop supports safe auto-correction (--auto-correct).
 Style/MultilineWhenThen:
   Exclude:
-    - 'lib/net/ssh/test/packet.rb'
     - 'lib/net/ssh/transport/packet_stream.rb'
     - 'lib/net/ssh/transport/session.rb'
 
 # Offense count: 5
+# This cop supports safe auto-correction (--auto-correct).
+# Configuration parameters: AllowMethodComparison.
 Style/MultipleComparison:
   Exclude:
     - 'lib/net/ssh/authentication/agent.rb'
@@ -591,15 +682,15 @@ Style/MultipleComparison:
     - 'lib/net/ssh/known_hosts.rb'
     - 'lib/net/ssh/verifiers/accept_new_or_local_tunnel.rb'
 
-# Offense count: 41
-# Cop supports --auto-correct.
+# Offense count: 42
+# This cop supports safe auto-correction (--auto-correct).
 # Configuration parameters: EnforcedStyle.
 # SupportedStyles: literals, strict
 Style/MutableConstant:
   Enabled: false
 
 # Offense count: 14
-# Cop supports --auto-correct.
+# This cop supports safe auto-correction (--auto-correct).
 # Configuration parameters: EnforcedStyle.
 # SupportedStyles: both, prefix, postfix
 Style/NegatedIf:
@@ -614,14 +705,21 @@ Style/NegatedIf:
     - 'test/test_key_factory.rb'
     - 'test/transport/test_state.rb'
 
+# Offense count: 2
+# This cop supports safe auto-correction (--auto-correct).
+Style/NegatedIfElseCondition:
+  Exclude:
+    - 'lib/net/ssh/transport/algorithms.rb'
+    - 'lib/net/ssh/transport/cipher_factory.rb'
+
 # Offense count: 1
-# Cop supports --auto-correct.
+# This cop supports safe auto-correction (--auto-correct).
 Style/NegatedWhile:
   Exclude:
     - 'lib/net/ssh/config.rb'
 
 # Offense count: 1
-# Cop supports --auto-correct.
+# This cop supports safe auto-correction (--auto-correct).
 # Configuration parameters: EnforcedStyle, MinBodyLength.
 # SupportedStyles: skip_modifier_ifs, always
 Style/Next:
@@ -629,7 +727,7 @@ Style/Next:
     - 'lib/net/ssh/authentication/key_manager.rb'
 
 # Offense count: 1
-# Cop supports --auto-correct.
+# This cop supports safe auto-correction (--auto-correct).
 # Configuration parameters: EnforcedStyle.
 # SupportedStyles: predicate, comparison
 Style/NilComparison:
@@ -637,26 +735,52 @@ Style/NilComparison:
     - 'lib/net/ssh/proxy/command.rb'
 
 # Offense count: 3
-# Cop supports --auto-correct.
+# This cop supports safe auto-correction (--auto-correct).
 Style/Not:
   Exclude:
     - 'lib/net/ssh/connection/channel.rb'
 
-# Offense count: 10
-# Cop supports --auto-correct.
-# Configuration parameters: Strict.
+# Offense count: 11
+# This cop supports safe auto-correction (--auto-correct).
+# Configuration parameters: Strict, AllowedNumbers.
 Style/NumericLiterals:
   MinDigits: 310
 
 # Offense count: 29
-# Cop supports --auto-correct.
-# Configuration parameters: AutoCorrect, EnforcedStyle, IgnoredMethods.
+# This cop supports unsafe auto-correction (--auto-correct-all).
+# Configuration parameters: EnforcedStyle, IgnoredMethods.
 # SupportedStyles: predicate, comparison
 Style/NumericPredicate:
   Enabled: false
 
+# Offense count: 13
+Style/OpenStructUse:
+  Exclude:
+    - 'test/authentication/test_ed25519.rb'
+    - 'test/common.rb'
+    - 'test/transport/kex/test_curve25519_sha256.rb'
+    - 'test/transport/kex/test_diffie_hellman_group1_sha1.rb'
+    - 'test/transport/kex/test_ecdh_sha2_nistp256.rb'
+    - 'test/verifiers/test_always.rb'
+
+# Offense count: 16
+# Configuration parameters: AllowedMethods.
+# AllowedMethods: respond_to_missing?
+Style/OptionalBooleanParameter:
+  Exclude:
+    - 'lib/net/ssh/connection/session.rb'
+    - 'lib/net/ssh/key_factory.rb'
+    - 'lib/net/ssh/prompt.rb'
+    - 'lib/net/ssh/test/channel.rb'
+    - 'lib/net/ssh/test/script.rb'
+    - 'lib/net/ssh/transport/algorithms.rb'
+    - 'lib/net/ssh/transport/session.rb'
+    - 'lib/net/ssh/transport/state.rb'
+    - 'test/common.rb'
+    - 'test/transport/test_server_version.rb'
+
 # Offense count: 15
-# Cop supports --auto-correct.
+# This cop supports safe auto-correction (--auto-correct).
 Style/ParallelAssignment:
   Exclude:
     - 'lib/net/ssh/config.rb'
@@ -670,7 +794,7 @@ Style/ParallelAssignment:
     - 'test/connection/test_channel.rb'
 
 # Offense count: 5
-# Cop supports --auto-correct.
+# This cop supports safe auto-correction (--auto-correct).
 # Configuration parameters: AllowSafeAssignment, AllowInMultilineConditions.
 Style/ParenthesesAroundCondition:
   Exclude:
@@ -680,15 +804,15 @@ Style/ParenthesesAroundCondition:
     - 'test/integration/test_proxy.rb'
 
 # Offense count: 23
-# Cop supports --auto-correct.
+# This cop supports safe auto-correction (--auto-correct).
 # Configuration parameters: PreferredDelimiters.
 Style/PercentLiteralDelimiters:
   Exclude:
     - 'net-ssh.gemspec'
     - 'test/test_config.rb'
 
-# Offense count: 15
-# Cop supports --auto-correct.
+# Offense count: 17
+# This cop supports safe auto-correction (--auto-correct).
 Style/PerlBackrefs:
   Exclude:
     - 'lib/net/ssh/buffer.rb'
@@ -698,8 +822,8 @@ Style/PerlBackrefs:
     - 'lib/net/ssh/proxy/socks5.rb'
     - 'test/integration/common.rb'
 
-# Offense count: 14
-# Cop supports --auto-correct.
+# Offense count: 15
+# This cop supports safe auto-correction (--auto-correct).
 Style/Proc:
   Exclude:
     - 'lib/net/ssh/connection/session.rb'
@@ -712,29 +836,72 @@ Style/Proc:
     - 'test/connection/test_session.rb'
 
 # Offense count: 7
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle.
+# This cop supports safe auto-correction (--auto-correct).
+# Configuration parameters: EnforcedStyle, AllowedCompactTypes.
 # SupportedStyles: compact, exploded
 Style/RaiseArgs:
   Exclude:
     - 'lib/net/ssh/authentication/ed25519.rb'
 
-# Offense count: 4
-# Cop supports --auto-correct.
+# Offense count: 6
+# This cop supports unsafe auto-correction (--auto-correct-all).
+# Configuration parameters: Methods.
+Style/RedundantArgument:
+  Exclude:
+    - 'lib/net/ssh/known_hosts.rb'
+    - 'test/authentication/test_ed25519.rb'
+
+# Offense count: 5
+# This cop supports safe auto-correction (--auto-correct).
 Style/RedundantBegin:
   Exclude:
     - 'lib/net/ssh/buffered_io.rb'
+    - 'lib/net/ssh/service/forward.rb'
     - 'lib/net/ssh/verifiers/accept_new.rb'
     - 'test/manual/test_pageant.rb'
 
-# Offense count: 61
-# Cop supports --auto-correct.
+# Offense count: 1
+# This cop supports safe auto-correction (--auto-correct).
+Style/RedundantCondition:
+  Exclude:
+    - 'lib/net/ssh/proxy/command.rb'
+
+# Offense count: 1
+# This cop supports safe auto-correction (--auto-correct).
+Style/RedundantFileExtensionInRequire:
+  Exclude:
+    - 'lib/net/ssh/transport/cipher_factory.rb'
+
+# Offense count: 2
+# This cop supports safe auto-correction (--auto-correct).
+Style/RedundantInterpolation:
+  Exclude:
+    - 'lib/net/ssh/proxy/socks5.rb'
+    - 'lib/net/ssh/transport/session.rb'
+
+# Offense count: 2
+# This cop supports safe auto-correction (--auto-correct).
+Style/RedundantPercentQ:
+  Exclude:
+    - 'net-ssh.gemspec'
+
+# Offense count: 11
+# This cop supports safe auto-correction (--auto-correct).
+Style/RedundantRegexpEscape:
+  Exclude:
+    - 'lib/net/ssh/authentication/agent.rb'
+    - 'lib/net/ssh/buffer.rb'
+    - 'lib/net/ssh/config.rb'
+    - 'lib/net/ssh/transport/cipher_factory.rb'
+
+# Offense count: 87
+# This cop supports safe auto-correction (--auto-correct).
 # Configuration parameters: AllowMultipleReturnValues.
 Style/RedundantReturn:
   Enabled: false
 
 # Offense count: 18
-# Cop supports --auto-correct.
+# This cop supports safe auto-correction (--auto-correct).
 Style/RedundantSelf:
   Exclude:
     - 'lib/net/ssh/connection/channel.rb'
@@ -742,16 +909,16 @@ Style/RedundantSelf:
     - 'test/authentication/test_ed25519.rb'
 
 # Offense count: 6
-# Cop supports --auto-correct.
+# This cop supports safe auto-correction (--auto-correct).
 Style/RescueModifier:
   Exclude:
     - 'lib/net/ssh/service/forward.rb'
     - 'lib/net/ssh/transport/algorithms.rb'
 
 # Offense count: 25
-# Cop supports --auto-correct.
-# Configuration parameters: ConvertCodeThatCanStartToReturnNil, Whitelist.
-# Whitelist: present?, blank?, presence, try, try!
+# This cop supports safe auto-correction (--auto-correct).
+# Configuration parameters: ConvertCodeThatCanStartToReturnNil, AllowedMethods, MaxChainLength.
+# AllowedMethods: present?, blank?, presence, try, try!
 Style/SafeNavigation:
   Exclude:
     - 'lib/net/ssh/authentication/key_manager.rb'
@@ -767,14 +934,20 @@ Style/SafeNavigation:
     - 'lib/net/ssh/transport/algorithms.rb'
     - 'lib/net/ssh/transport/packet_stream.rb'
 
+# Offense count: 3
+# This cop supports safe auto-correction (--auto-correct).
+Style/SelectByRegexp:
+  Exclude:
+    - 'test/test_all.rb'
+
 # Offense count: 2
-# Cop supports --auto-correct.
+# This cop supports safe auto-correction (--auto-correct).
 Style/SelfAssignment:
   Exclude:
     - 'lib/net/ssh/config.rb'
 
 # Offense count: 7
-# Cop supports --auto-correct.
+# This cop supports safe auto-correction (--auto-correct).
 # Configuration parameters: AllowAsExpressionSeparator.
 Style/Semicolon:
   Exclude:
@@ -783,7 +956,7 @@ Style/Semicolon:
     - 'test/connection/test_session.rb'
 
 # Offense count: 2
-# Cop supports --auto-correct.
+# This cop supports safe auto-correction (--auto-correct).
 # Configuration parameters: EnforcedStyle.
 # SupportedStyles: only_raise, only_fail, semantic
 Style/SignalException:
@@ -792,16 +965,37 @@ Style/SignalException:
     - 'lib/net/ssh/connection/channel.rb'
 
 # Offense count: 2
-# Cop supports --auto-correct.
+# This cop supports safe auto-correction (--auto-correct).
 # Configuration parameters: AllowIfMethodIsEmpty.
 Style/SingleLineMethods:
   Exclude:
     - 'lib/net/ssh/buffered_io.rb'
 
+# Offense count: 11
+# This cop supports unsafe auto-correction (--auto-correct-all).
+Style/SlicingWithRange:
+  Exclude:
+    - 'lib/net/ssh/authentication/ed25519.rb'
+    - 'lib/net/ssh/buffer.rb'
+    - 'lib/net/ssh/config.rb'
+    - 'lib/net/ssh/transport/algorithms.rb'
+    - 'lib/net/ssh/transport/packet_stream.rb'
+    - 'lib/net/ssh/transport/state.rb'
+    - 'test/transport/test_packet_stream.rb'
+
+# Offense count: 3
+# This cop supports safe auto-correction (--auto-correct).
+# Configuration parameters: AllowModifier.
+Style/SoleNestedConditional:
+  Exclude:
+    - 'lib/net/ssh/transport/packet_stream.rb'
+    - 'test/common.rb'
+    - 'test/integration/test_proxy.rb'
+
 # Offense count: 18
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle.
-# SupportedStyles: use_perl_names, use_english_names
+# This cop supports safe auto-correction (--auto-correct).
+# Configuration parameters: RequireEnglish, EnforcedStyle.
+# SupportedStyles: use_perl_names, use_english_names, use_builtin_english_names
 Style/SpecialGlobalVars:
   Exclude:
     - 'lib/net/ssh/authentication/agent.rb'
@@ -812,16 +1006,39 @@ Style/SpecialGlobalVars:
     - 'test/manual/test_pageant.rb'
     - 'test/test_all.rb'
 
-# Offense count: 1801
-# Cop supports --auto-correct.
+# Offense count: 1
+# This cop supports unsafe auto-correction (--auto-correct-all).
+Style/StringChars:
+  Exclude:
+    - 'test/transport/test_server_version.rb'
+
+# Offense count: 27
+# This cop supports unsafe auto-correction (--auto-correct-all).
+# Configuration parameters: Mode.
+Style/StringConcatenation:
+  Exclude:
+    - 'lib/net/ssh/authentication/certificate.rb'
+    - 'lib/net/ssh/authentication/key_manager.rb'
+    - 'lib/net/ssh/authentication/pageant.rb'
+    - 'lib/net/ssh/config.rb'
+    - 'lib/net/ssh/transport/algorithms.rb'
+    - 'lib/net/ssh/transport/kex/diffie_hellman_group1_sha1.rb'
+    - 'test/authentication/test_key_manager.rb'
+    - 'test/integration/common.rb'
+    - 'test/integration/test_proxy.rb'
+    - 'test/test_buffer.rb'
+    - 'test/test_key_factory.rb'
+
+# Offense count: 1849
+# This cop supports safe auto-correction (--auto-correct).
 # Configuration parameters: EnforcedStyle, ConsistentQuotesInMultiline.
 # SupportedStyles: single_quotes, double_quotes
 Style/StringLiterals:
   Enabled: false
 
-# Offense count: 7
-# Cop supports --auto-correct.
-# Configuration parameters: IgnoredMethods.
+# Offense count: 6
+# This cop supports unsafe auto-correction (--auto-correct-all).
+# Configuration parameters: AllowMethodsWithArguments, IgnoredMethods, AllowComments.
 # IgnoredMethods: respond_to, define_method
 Style/SymbolProc:
   Exclude:
@@ -829,36 +1046,27 @@ Style/SymbolProc:
     - 'lib/net/ssh/buffer.rb'
     - 'lib/net/ssh/connection/session.rb'
     - 'lib/net/ssh/test/extensions.rb'
-    - 'lib/net/ssh/transport/algorithms.rb'
-
-# Offense count: 1
-# Cop supports --auto-correct.
-Style/UnneededCondition:
-  Exclude:
-    - 'lib/net/ssh/proxy/command.rb'
-
-# Offense count: 2
-# Cop supports --auto-correct.
-Style/UnneededInterpolation:
-  Exclude:
-    - 'lib/net/ssh/proxy/socks5.rb'
-    - 'lib/net/ssh/transport/session.rb'
 
-# Offense count: 2
-# Cop supports --auto-correct.
-Style/UnneededPercentQ:
+# Offense count: 14
+# This cop supports safe auto-correction (--auto-correct).
+Style/UnpackFirst:
   Exclude:
-    - 'net-ssh.gemspec'
+    - 'lib/net/ssh/authentication/pageant.rb'
+    - 'lib/net/ssh/buffer.rb'
+    - 'lib/net/ssh/key_factory.rb'
+    - 'lib/net/ssh/known_hosts.rb'
+    - 'lib/net/ssh/transport/openssl.rb'
+    - 'lib/net/ssh/transport/packet_stream.rb'
 
 # Offense count: 2
-# Cop supports --auto-correct.
+# This cop supports safe auto-correction (--auto-correct).
 Style/WhileUntilDo:
   Exclude:
     - 'lib/net/ssh/config.rb'
     - 'test/integration/common.rb'
 
-# Offense count: 3
-# Cop supports --auto-correct.
+# Offense count: 4
+# This cop supports safe auto-correction (--auto-correct).
 # Configuration parameters: WordRegex.
 # SupportedStyles: percent, brackets
 Style/WordArray:
@@ -866,7 +1074,7 @@ Style/WordArray:
   MinSize: 3
 
 # Offense count: 4
-# Cop supports --auto-correct.
+# This cop supports unsafe auto-correction (--auto-correct-all).
 Style/ZeroLengthPredicate:
   Exclude:
     - 'lib/net/ssh/buffered_io.rb'