net-ssh 4.0.0.rc1 → 4.0.0.rc2

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
checksums.yaml CHANGED
@@ -1,7 +1,7 @@
1
1
  ---
2
2
  SHA1:
3
- metadata.gz: 6b4a7aacc4f382c72615319abb6514a3440a8294
4
- data.tar.gz: 2be9a22f174b022b0361dbe559e24ed77645b2ab
3
+ metadata.gz: f1956d73c8269053e9a74ba3a9f35fbf3b74b30b
4
+ data.tar.gz: 787bec5bdcd306b76fb46df94f58117409302355
5
5
  SHA512:
6
- metadata.gz: 03c4e8fbedf00e24c79ab2adc62f1783e84b83f3b645224d883af15d09c9538eb7c5d20b296a5a216800bd92a40a0fcde55b3e4dd20cbe6b13c8e6b626ce166d
7
- data.tar.gz: 546ecc7fe50cc365dda91c76136e6c1ed5d5f9e3d8a8cc8b97346e0e6a261d7fa5c04da01832e5de8694a24c9a6bb87282ebd140feb63357bb0973c9e5d39919
6
+ metadata.gz: a0061edadf67e981245ecc5ba288edc601b93a581429920532329a41e866df8ce5f497dee81bdc90581997f25ee2763e11547dab8ae11e437ef33badc913639d
7
+ data.tar.gz: ac13a2b972abc5295374cde51df3413d38534b08cbd5acb636d7b16974c24db277c409ab5e8c38512b58fb630c92d0911f0f7d6fe9e82424113ac4c2cf624c1a
Binary file
data.tar.gz.sig CHANGED
Binary file
@@ -1,12 +1,12 @@
1
1
  # This configuration was generated by
2
2
  # `rubocop --auto-gen-config`
3
- # on 2016-03-30 13:23:48 +0200 using RuboCop version 0.39.0.
3
+ # on 2016-12-11 13:27:14 +0100 using RuboCop version 0.46.0.
4
4
  # The point is for the user to remove these configuration records
5
5
  # one by one as the offenses are removed from the code base.
6
6
  # Note that changes in the inspected code, or installation of new
7
7
  # versions of RuboCop, may require this file to be generated again.
8
8
 
9
- # Offense count: 9
9
+ # Offense count: 4
10
10
  # Configuration parameters: AllowSafeAssignment.
11
11
  Lint/AssignmentInCondition:
12
12
  Exclude:
@@ -14,7 +14,7 @@ Lint/AssignmentInCondition:
14
14
  - 'lib/net/ssh/connection/session.rb'
15
15
  - 'lib/net/ssh/proxy/command.rb'
16
16
 
17
- # Offense count: 2
17
+ # Offense count: 1
18
18
  # Cop supports --auto-correct.
19
19
  # Configuration parameters: AlignWith, SupportedStyles.
20
20
  # SupportedStyles: either, start_of_block, start_of_line
@@ -22,28 +22,25 @@ Lint/BlockAlignment:
22
22
  Exclude:
23
23
  - 'test/integration/test_proxy.rb'
24
24
 
25
- # Offense count: 3
26
- # Cop supports --auto-correct.
27
- Lint/Debugger:
28
- Exclude:
29
- - 'quicktest.rb'
30
- - 'test.rb'
31
- - 'test_connection_close_shall_close_cannels.rb'
32
-
33
25
  # Offense count: 1
34
26
  # Cop supports --auto-correct.
35
27
  Lint/DeprecatedClassMethods:
36
28
  Exclude:
37
29
  - 'Rakefile'
38
30
 
39
- # Offense count: 217
31
+ # Offense count: 1
32
+ Lint/EmptyWhen:
33
+ Exclude:
34
+ - 'lib/net/ssh/config.rb'
35
+
36
+ # Offense count: 223
40
37
  # Cop supports --auto-correct.
41
38
  # Configuration parameters: AlignWith, SupportedStyles, AutoCorrect.
42
39
  # SupportedStyles: keyword, variable, start_of_line
43
40
  Lint/EndAlignment:
44
41
  Enabled: false
45
42
 
46
- # Offense count: 12
43
+ # Offense count: 8
47
44
  Lint/HandleExceptions:
48
45
  Exclude:
49
46
  - 'lib/net/ssh/authentication/session.rb'
@@ -51,7 +48,6 @@ Lint/HandleExceptions:
51
48
  - 'lib/net/ssh/transport/openssl.rb'
52
49
  - 'test/integration/common.rb'
53
50
  - 'test/integration/test_forward.rb'
54
- - 'test/manual/test_pageant.rb'
55
51
  - 'test/start/test_connection.rb'
56
52
  - 'test/start/test_transport.rb'
57
53
 
@@ -61,11 +57,10 @@ Lint/ImplicitStringConcatenation:
61
57
  - 'lib/net/ssh/transport/kex/diffie_hellman_group14_sha1.rb'
62
58
  - 'lib/net/ssh/transport/kex/diffie_hellman_group1_sha1.rb'
63
59
 
64
- # Offense count: 3
60
+ # Offense count: 1
65
61
  Lint/LiteralInCondition:
66
62
  Exclude:
67
63
  - 'lib/net/ssh/authentication/pageant.rb'
68
- - 'quicktest.rb'
69
64
 
70
65
  # Offense count: 2
71
66
  Lint/Loop:
@@ -73,12 +68,6 @@ Lint/Loop:
73
68
  - 'lib/net/ssh/authentication/methods/password.rb'
74
69
  - 'lib/net/ssh/key_factory.rb'
75
70
 
76
- # Offense count: 12
77
- Lint/NestedMethodDefinition:
78
- Exclude:
79
- - 'lib/net/ssh/transport/ctr.rb'
80
- - 'test/authentication/methods/test_keyboard_interactive.rb'
81
-
82
71
  # Offense count: 1
83
72
  Lint/NextWithoutAccumulator:
84
73
  Exclude:
@@ -96,28 +85,24 @@ Lint/RescueException:
96
85
  - 'lib/net/ssh/service/forward.rb'
97
86
  - 'lib/net/ssh/transport/kex/diffie_hellman_group1_sha1.rb'
98
87
 
99
- # Offense count: 9
100
- Lint/ShadowingOuterLocalVariable:
88
+ # Offense count: 2
89
+ Lint/ShadowedException:
101
90
  Exclude:
102
- - 'quicktest_1_open_channel_nb.rb'
103
- - 'quicktest_337.rb'
104
- - 'quicktest_4gb.rb'
91
+ - 'lib/net/ssh/authentication/key_manager.rb'
105
92
 
106
93
  # Offense count: 1
107
94
  Lint/UnderscorePrefixedVariableName:
108
95
  Exclude:
109
96
  - 'lib/net/ssh/test/local_packet.rb'
110
97
 
111
- # Offense count: 53
98
+ # Offense count: 52
112
99
  # Cop supports --auto-correct.
113
- # Configuration parameters: IgnoreEmptyBlocks.
100
+ # Configuration parameters: IgnoreEmptyBlocks, AllowUnusedKeywordArguments.
114
101
  Lint/UnusedBlockArgument:
115
102
  Exclude:
116
103
  - 'lib/net/ssh/connection/keepalive.rb'
117
104
  - 'lib/net/ssh/connection/session.rb'
118
105
  - 'lib/net/ssh/service/forward.rb'
119
- - 'quicktest_337.rb'
120
- - 'quicktest_4gb.rb'
121
106
  - 'test/authentication/methods/test_password.rb'
122
107
  - 'test/authentication/test_agent.rb'
123
108
  - 'test/common.rb'
@@ -126,68 +111,72 @@ Lint/UnusedBlockArgument:
126
111
  - 'test/transport/test_algorithms.rb'
127
112
  - 'test/transport/test_hmac.rb'
128
113
 
129
- # Offense count: 44
114
+ # Offense count: 50
130
115
  # Cop supports --auto-correct.
131
116
  # Configuration parameters: AllowUnusedKeywordArguments, IgnoreEmptyMethods.
132
117
  Lint/UnusedMethodArgument:
133
118
  Enabled: false
134
119
 
135
120
  # Offense count: 3
121
+ # Configuration parameters: ContextCreatingMethods.
136
122
  Lint/UselessAccessModifier:
137
123
  Exclude:
138
124
  - 'lib/net/ssh/buffered_io.rb'
139
125
  - 'lib/net/ssh/connection/channel.rb'
140
126
  - 'lib/net/ssh/transport/session.rb'
141
127
 
142
- # Offense count: 12
128
+ # Offense count: 10
143
129
  Lint/UselessAssignment:
144
130
  Exclude:
145
- - 'lib/net/ssh/key_factory.rb'
146
131
  - 'lib/net/ssh/proxy/socks4.rb'
147
132
  - 'lib/net/ssh/proxy/socks5.rb'
148
- - 'quicktest_337.rb'
149
133
  - 'test/integration/common.rb'
150
134
  - 'test/integration/test_forward.rb'
151
135
 
152
- # Offense count: 185
136
+ # Offense count: 196
153
137
  Metrics/AbcSize:
154
- Max: 91
138
+ Max: 76
155
139
 
156
- # Offense count: 2
140
+ # Offense count: 14
141
+ # Configuration parameters: CountComments.
142
+ Metrics/BlockLength:
143
+ Max: 88
144
+
145
+ # Offense count: 1
157
146
  Metrics/BlockNesting:
158
147
  Max: 4
159
148
 
160
- # Offense count: 31
149
+ # Offense count: 27
161
150
  # Configuration parameters: CountComments.
162
151
  Metrics/ClassLength:
163
- Max: 1130
152
+ Max: 548
164
153
 
165
154
  # Offense count: 34
166
155
  Metrics/CyclomaticComplexity:
167
156
  Max: 39
168
157
 
169
- # Offense count: 1275
170
- # Configuration parameters: AllowHeredoc, AllowURI, URISchemes.
158
+ # Offense count: 1341
159
+ # Configuration parameters: AllowHeredoc, AllowURI, URISchemes, IgnoreCopDirectives, IgnoredPatterns.
171
160
  # URISchemes: http, https
172
161
  Metrics/LineLength:
173
162
  Max: 934
174
163
 
175
- # Offense count: 166
164
+ # Offense count: 164
176
165
  # Configuration parameters: CountComments.
177
166
  Metrics/MethodLength:
178
- Max: 99
167
+ Max: 93
179
168
 
180
- # Offense count: 3
169
+ # Offense count: 1
181
170
  # Configuration parameters: CountComments.
182
171
  Metrics/ModuleLength:
183
- Max: 155
172
+ Max: 142
184
173
 
185
174
  # Offense count: 1
186
175
  # Configuration parameters: CountKeywordArgs.
187
176
  Metrics/ParameterLists:
188
177
  Max: 6
189
178
 
190
- # Offense count: 28
179
+ # Offense count: 27
191
180
  Metrics/PerceivedComplexity:
192
181
  Max: 23
193
182
 
@@ -211,19 +200,18 @@ Performance/RedundantMatch:
211
200
  - 'lib/net/ssh/key_factory.rb'
212
201
  - 'lib/net/ssh/transport/server_version.rb'
213
202
 
214
- # Offense count: 14
203
+ # Offense count: 13
215
204
  Style/AccessorMethodName:
216
205
  Exclude:
217
206
  - 'lib/net/ssh/authentication/methods/password.rb'
218
207
  - 'lib/net/ssh/authentication/pageant.rb'
219
208
  - 'lib/net/ssh/connection/session.rb'
220
- - 'lib/net/ssh/prompt.rb'
221
209
  - 'lib/net/ssh/transport/kex/diffie_hellman_group14_sha1.rb'
222
210
  - 'lib/net/ssh/transport/kex/diffie_hellman_group1_sha1.rb'
223
211
  - 'lib/net/ssh/transport/kex/diffie_hellman_group_exchange_sha1.rb'
224
212
  - 'lib/net/ssh/transport/kex/ecdh_sha2_nistp256.rb'
225
213
 
226
- # Offense count: 3
214
+ # Offense count: 2
227
215
  # Cop supports --auto-correct.
228
216
  # Configuration parameters: EnforcedStyle, SupportedStyles.
229
217
  # SupportedStyles: prefer_alias, prefer_alias_method
@@ -231,7 +219,6 @@ Style/Alias:
231
219
  Exclude:
232
220
  - 'lib/net/ssh/connection/session.rb'
233
221
  - 'lib/net/ssh/service/forward.rb'
234
- - 'lib/net/ssh/transport/ctr.rb'
235
222
 
236
223
  # Offense count: 1
237
224
  # Cop supports --auto-correct.
@@ -254,28 +241,42 @@ Style/AlignHash:
254
241
  - 'test/transport/test_cipher_factory.rb'
255
242
  - 'test/transport/test_state.rb'
256
243
 
257
- # Offense count: 76
244
+ # Offense count: 72
258
245
  # Cop supports --auto-correct.
259
- # Configuration parameters: EnforcedStyle, SupportedStyles.
246
+ # Configuration parameters: EnforcedStyle, SupportedStyles, IndentationWidth.
260
247
  # SupportedStyles: with_first_parameter, with_fixed_indentation
261
248
  Style/AlignParameters:
262
249
  Enabled: false
263
250
 
264
- # Offense count: 46
251
+ # Offense count: 33
265
252
  # Cop supports --auto-correct.
266
253
  # Configuration parameters: EnforcedStyle, SupportedStyles.
267
254
  # SupportedStyles: always, conditionals
268
255
  Style/AndOr:
269
- Enabled: false
256
+ Exclude:
257
+ - 'lib/net/ssh/authentication/key_manager.rb'
258
+ - 'lib/net/ssh/buffer.rb'
259
+ - 'lib/net/ssh/buffered_io.rb'
260
+ - 'lib/net/ssh/config.rb'
261
+ - 'lib/net/ssh/connection/channel.rb'
262
+ - 'lib/net/ssh/connection/session.rb'
263
+ - 'lib/net/ssh/key_factory.rb'
264
+ - 'lib/net/ssh/service/forward.rb'
265
+ - 'lib/net/ssh/test/channel.rb'
266
+ - 'lib/net/ssh/test/script.rb'
267
+ - 'lib/net/ssh/transport/cipher_factory.rb'
268
+ - 'lib/net/ssh/transport/hmac.rb'
269
+ - 'lib/net/ssh/transport/key_expander.rb'
270
+ - 'lib/net/ssh/transport/packet_stream.rb'
271
+ - 'test/common.rb'
270
272
 
271
- # Offense count: 3
273
+ # Offense count: 2
272
274
  Style/AsciiComments:
273
275
  Exclude:
274
- - 'lib/net/ssh/authentication/agent/java_pageant.rb'
275
276
  - 'lib/net/ssh/authentication/pageant.rb'
276
277
  - 'lib/net/ssh/buffered_io.rb'
277
278
 
278
- # Offense count: 32
279
+ # Offense count: 11
279
280
  # Cop supports --auto-correct.
280
281
  # Configuration parameters: EnforcedStyle, SupportedStyles, ProceduralMethods, FunctionalMethods, IgnoredMethods.
281
282
  # SupportedStyles: line_count_based, semantic, braces_for_chaining
@@ -317,7 +318,16 @@ Style/CaseEquality:
317
318
  # Configuration parameters: IndentWhenRelativeTo, SupportedStyles, IndentOneStep, IndentationWidth.
318
319
  # SupportedStyles: case, end
319
320
  Style/CaseIndentation:
320
- Enabled: false
321
+ Exclude:
322
+ - 'lib/net/ssh.rb'
323
+ - 'lib/net/ssh/authentication/methods/hostbased.rb'
324
+ - 'lib/net/ssh/authentication/methods/none.rb'
325
+ - 'lib/net/ssh/authentication/methods/password.rb'
326
+ - 'lib/net/ssh/authentication/methods/publickey.rb'
327
+ - 'lib/net/ssh/buffer.rb'
328
+ - 'lib/net/ssh/config.rb'
329
+ - 'lib/net/ssh/test/local_packet.rb'
330
+ - 'lib/net/ssh/test/packet.rb'
321
331
 
322
332
  # Offense count: 1
323
333
  # Cop supports --auto-correct.
@@ -341,26 +351,11 @@ Style/ClassAndModuleCamelCase:
341
351
  - 'test/transport/hmac/test_sha2_512.rb'
342
352
  - 'test/transport/hmac/test_sha2_512_96.rb'
343
353
 
344
- # Offense count: 15
354
+ # Offense count: 16
345
355
  # Configuration parameters: EnforcedStyle, SupportedStyles.
346
356
  # SupportedStyles: nested, compact
347
357
  Style/ClassAndModuleChildren:
348
- Exclude:
349
- - 'lib/net/ssh/transport/ctr.rb'
350
- - 'lib/net/ssh/transport/hmac.rb'
351
- - 'lib/net/ssh/transport/hmac/md5.rb'
352
- - 'lib/net/ssh/transport/hmac/md5_96.rb'
353
- - 'lib/net/ssh/transport/hmac/none.rb'
354
- - 'lib/net/ssh/transport/hmac/ripemd160.rb'
355
- - 'lib/net/ssh/transport/hmac/sha1.rb'
356
- - 'lib/net/ssh/transport/hmac/sha1_96.rb'
357
- - 'lib/net/ssh/transport/hmac/sha2_256.rb'
358
- - 'lib/net/ssh/transport/hmac/sha2_256_96.rb'
359
- - 'lib/net/ssh/transport/hmac/sha2_512.rb'
360
- - 'lib/net/ssh/transport/hmac/sha2_512_96.rb'
361
- - 'lib/net/ssh/transport/kex.rb'
362
- - 'lib/net/ssh/transport/kex/diffie_hellman_group_exchange_sha1.rb'
363
- - 'lib/net/ssh/transport/kex/diffie_hellman_group_exchange_sha256.rb'
358
+ Enabled: false
364
359
 
365
360
  # Offense count: 1
366
361
  # Cop supports --auto-correct.
@@ -416,11 +411,10 @@ Style/ConditionalAssignment:
416
411
  - 'lib/net/ssh/proxy/socks5.rb'
417
412
  - 'lib/net/ssh/test/script.rb'
418
413
 
419
- # Offense count: 8
414
+ # Offense count: 5
420
415
  Style/ConstantName:
421
416
  Exclude:
422
417
  - 'lib/net/ssh/authentication/pageant.rb'
423
- - 'lib/net/ssh/prompt.rb'
424
418
  - 'lib/net/ssh/transport/kex/diffie_hellman_group14_sha1.rb'
425
419
  - 'lib/net/ssh/transport/kex/diffie_hellman_group1_sha1.rb'
426
420
  - 'lib/net/ssh/transport/openssl.rb'
@@ -431,14 +425,7 @@ Style/DefWithParentheses:
431
425
  Exclude:
432
426
  - 'test/integration/test_forward.rb'
433
427
 
434
- # Offense count: 3
435
- # Cop supports --auto-correct.
436
- Style/DeprecatedHashMethods:
437
- Exclude:
438
- - 'lib/net/ssh/connection/session.rb'
439
- - 'test/transport/test_packet_stream.rb'
440
-
441
- # Offense count: 29
428
+ # Offense count: 16
442
429
  Style/Documentation:
443
430
  Exclude:
444
431
  - 'spec/**/*'
@@ -461,9 +448,11 @@ Style/Documentation:
461
448
  # Configuration parameters: EnforcedStyle, SupportedStyles.
462
449
  # SupportedStyles: leading, trailing
463
450
  Style/DotPosition:
464
- Enabled: false
451
+ Exclude:
452
+ - 'test/transport/test_algorithms.rb'
465
453
 
466
454
  # Offense count: 3
455
+ # Cop supports --auto-correct.
467
456
  Style/EachWithObject:
468
457
  Exclude:
469
458
  - 'lib/net/ssh/config.rb'
@@ -488,7 +477,7 @@ Style/EmptyLineBetweenDefs:
488
477
  - 'test/test_buffer.rb'
489
478
  - 'test/test_key_factory.rb'
490
479
 
491
- # Offense count: 22
480
+ # Offense count: 16
492
481
  # Cop supports --auto-correct.
493
482
  Style/EmptyLines:
494
483
  Exclude:
@@ -507,27 +496,26 @@ Style/EmptyLines:
507
496
  - 'test/test_known_hosts.rb'
508
497
  - 'test/transport/test_cipher_factory.rb'
509
498
 
510
- # Offense count: 48
499
+ # Offense count: 39
511
500
  # Cop supports --auto-correct.
512
501
  # Configuration parameters: EnforcedStyle, SupportedStyles.
513
- # SupportedStyles: empty_lines, no_empty_lines
502
+ # SupportedStyles: empty_lines, empty_lines_except_namespace, empty_lines_special, no_empty_lines
514
503
  Style/EmptyLinesAroundClassBody:
515
504
  Enabled: false
516
505
 
517
- # Offense count: 5
506
+ # Offense count: 4
518
507
  # Cop supports --auto-correct.
519
508
  Style/EmptyLinesAroundMethodBody:
520
509
  Exclude:
521
510
  - 'lib/net/ssh/transport/kex/diffie_hellman_group_exchange_sha1.rb'
522
511
  - 'lib/net/ssh/transport/openssl.rb'
523
- - 'test/authentication/methods/test_keyboard_interactive.rb'
524
512
  - 'test/transport/hmac/test_sha2_256.rb'
525
513
  - 'test/transport/hmac/test_sha2_512.rb'
526
514
 
527
515
  # Offense count: 209
528
516
  # Cop supports --auto-correct.
529
517
  # Configuration parameters: EnforcedStyle, SupportedStyles.
530
- # SupportedStyles: empty_lines, no_empty_lines
518
+ # SupportedStyles: empty_lines, empty_lines_except_namespace, empty_lines_special, no_empty_lines
531
519
  Style/EmptyLinesAroundModuleBody:
532
520
  Enabled: false
533
521
 
@@ -544,7 +532,7 @@ Style/EvenOdd:
544
532
  Exclude:
545
533
  - 'lib/net/ssh/buffer.rb'
546
534
 
547
- # Offense count: 28
535
+ # Offense count: 17
548
536
  # Cop supports --auto-correct.
549
537
  # Configuration parameters: AllowForAlignment, ForceEqualSignAlignment.
550
538
  Style/ExtraSpacing:
@@ -555,14 +543,13 @@ Style/ExtraSpacing:
555
543
  - 'lib/net/ssh/proxy/socks5.rb'
556
544
  - 'lib/net/ssh/transport/hmac/sha2_256_96.rb'
557
545
  - 'lib/net/ssh/transport/hmac/sha2_512_96.rb'
558
- - 'quicktest_337.rb'
559
546
  - 'test/authentication/test_key_manager.rb'
560
547
  - 'test/integration/test_forward.rb'
561
548
  - 'test/test_config.rb'
562
549
  - 'test/test_key_factory.rb'
563
550
  - 'test/transport/test_packet_stream.rb'
564
551
 
565
- # Offense count: 3
552
+ # Offense count: 2
566
553
  # Configuration parameters: EnforcedStyle, SupportedStyles.
567
554
  # SupportedStyles: format, sprintf, percent
568
555
  Style/FormatString:
@@ -570,49 +557,17 @@ Style/FormatString:
570
557
  - 'lib/net/ssh/authentication/pageant.rb'
571
558
  - 'lib/net/ssh/loggable.rb'
572
559
 
573
-
574
- # Offense count: 11
560
+ # Offense count: 35
575
561
  # Configuration parameters: MinBodyLength.
576
562
  Style/GuardClause:
577
- Exclude:
578
- - 'lib/net/ssh.rb'
579
- - 'lib/net/ssh/buffered_io.rb'
580
- - 'lib/net/ssh/connection/channel.rb'
581
- - 'lib/net/ssh/key_factory.rb'
582
- - 'lib/net/ssh/service/forward.rb'
583
- - 'lib/net/ssh/transport/openssl.rb'
584
- - 'lib/net/ssh/transport/algorithms.rb'
585
- - 'lib/net/ssh/test/script.rb'
586
- - 'lib/net/ssh/authentication/agent/socket.rb'
587
- - 'lib/net/ssh/authentication/pageant.rb'
588
- - 'lib/net/ssh/authentication/buffer.rb'
589
- - 'lib/net/ssh/authentication/config.rb'
590
- - 'lib/net/ssh/connection/keepalive.rb'
591
- - 'lib/net/ssh/connection/session.rb'
592
- - 'lib/net/ssh/buffer.rb'
593
- - 'lib/net/ssh/proxy/command.rb'
594
- - 'lib/net/ssh/proxy/socks5.rb'
595
- - 'lib/net/ssh/transport/packet_stream.rb'
596
- - 'lib/net/ssh/transport/server_version.rb'
597
- - 'lib/net/ssh/transport/session.rb'
598
- - 'test/authentication/test_key_manager.rb'
599
- - 'test/common.rb'
600
- - 'lib/net/ssh/transport/kex/diffie_hellman_group1_sha1.rb'
601
-
602
- # Offense count: 338
603
- # Cop supports --auto-correct.
604
- # Configuration parameters: EnforcedStyle, SupportedStyles, UseHashRocketsWithSymbolValues.
605
- # SupportedStyles: ruby19, ruby19_no_mixed_keys, hash_rockets
606
- Style/HashSyntax:
607
563
  Enabled: false
608
564
 
609
- # Offense count: 2
565
+ # Offense count: 1
610
566
  Style/IfInsideElse:
611
567
  Exclude:
612
568
  - 'lib/net/ssh/connection/session.rb'
613
- - 'lib/net/ssh/key_factory.rb'
614
569
 
615
- # Offense count: 8
570
+ # Offense count: 9
616
571
  # Cop supports --auto-correct.
617
572
  # Configuration parameters: MaxLineLength.
618
573
  Style/IfUnlessModifier:
@@ -631,7 +586,8 @@ Style/IfUnlessModifier:
631
586
  # Configuration parameters: EnforcedStyle, SupportedStyles, IndentationWidth.
632
587
  # SupportedStyles: special_inside_parentheses, consistent, align_brackets
633
588
  Style/IndentArray:
634
- Enabled: false
589
+ Exclude:
590
+ - 'lib/net/ssh/transport/openssl.rb'
635
591
 
636
592
  # Offense count: 4
637
593
  # Cop supports --auto-correct.
@@ -643,14 +599,14 @@ Style/IndentAssignment:
643
599
  - 'test/transport/kex/test_ecdh_sha2_nistp384.rb'
644
600
  - 'test/transport/kex/test_ecdh_sha2_nistp521.rb'
645
601
 
646
- # Offense count: 216
602
+ # Offense count: 227
647
603
  # Cop supports --auto-correct.
648
604
  # Configuration parameters: EnforcedStyle, SupportedStyles.
649
605
  # SupportedStyles: normal, rails
650
606
  Style/IndentationConsistency:
651
607
  Enabled: false
652
608
 
653
- # Offense count: 93
609
+ # Offense count: 96
654
610
  # Cop supports --auto-correct.
655
611
  # Configuration parameters: Width.
656
612
  Style/IndentationWidth:
@@ -662,20 +618,16 @@ Style/InfiniteLoop:
662
618
  Exclude:
663
619
  - 'lib/net/ssh/authentication/pageant.rb'
664
620
 
665
- # Offense count: 33
621
+ # Offense count: 17
666
622
  # Cop supports --auto-correct.
667
623
  Style/LeadingCommentSpace:
668
624
  Exclude:
669
- - 'quicktest.rb'
670
- - 'quicktest_1_open_channel_nb.rb'
671
- - 'quicktest_337.rb'
672
- - 'quicktest_keepalive.rb'
673
625
  - 'test/integration/test_ed25519_pkeys.rb'
674
626
  - 'test/integration/test_forward.rb'
675
627
  - 'test/integration/test_id_rsa_keys.rb'
676
628
  - 'test/integration/test_proxy.rb'
677
629
 
678
- # Offense count: 29
630
+ # Offense count: 27
679
631
  # Cop supports --auto-correct.
680
632
  Style/LineEndConcatenation:
681
633
  Exclude:
@@ -685,11 +637,10 @@ Style/LineEndConcatenation:
685
637
  - 'lib/net/ssh/transport/kex/ecdh_sha2_nistp256.rb'
686
638
  - 'lib/net/ssh/verifiers/secure.rb'
687
639
 
688
- # Offense count: 52
640
+ # Offense count: 12
689
641
  # Cop supports --auto-correct.
690
642
  Style/MethodCallParentheses:
691
643
  Exclude:
692
- - 'quicktest_337.rb'
693
644
  - 'test/authentication/test_key_manager.rb'
694
645
  - 'test/connection/test_session.rb'
695
646
  - 'test/integration/test_forward.rb'
@@ -700,13 +651,27 @@ Style/MethodCallParentheses:
700
651
  # Configuration parameters: EnforcedStyle, SupportedStyles.
701
652
  # SupportedStyles: require_parentheses, require_no_parentheses, require_no_parentheses_except_multiline
702
653
  Style/MethodDefParentheses:
703
- Enabled: false
654
+ Exclude:
655
+ - 'test/common.rb'
656
+ - 'test/integration/common.rb'
704
657
 
705
- # Offense count: 22
658
+ # Offense count: 1
659
+ Style/MethodMissing:
660
+ Exclude:
661
+ - 'lib/net/ssh/connection/session.rb'
662
+
663
+ # Offense count: 24
706
664
  # Configuration parameters: EnforcedStyle, SupportedStyles.
707
665
  # SupportedStyles: snake_case, camelCase
708
666
  Style/MethodName:
709
- Enabled: false
667
+ Exclude:
668
+ - 'lib/net/ssh/authentication/ed25519_loader.rb'
669
+ - 'test/authentication/test_agent.rb'
670
+ - 'test/authentication/test_session.rb'
671
+ - 'test/common.rb'
672
+ - 'test/connection/test_channel.rb'
673
+ - 'test/test_config.rb'
674
+ - 'test/test_key_factory.rb'
710
675
 
711
676
  # Offense count: 3
712
677
  # Cop supports --auto-correct.
@@ -715,30 +680,33 @@ Style/MultilineIfThen:
715
680
  - 'lib/net/ssh/buffered_io.rb'
716
681
  - 'lib/net/ssh/service/forward.rb'
717
682
 
718
- # Offense count: 24
683
+ # Offense count: 23
719
684
  # Cop supports --auto-correct.
720
685
  # Configuration parameters: EnforcedStyle, SupportedStyles, IndentationWidth.
721
686
  # SupportedStyles: aligned, indented
722
687
  Style/MultilineOperationIndentation:
723
- Enabled: false
724
-
725
- # Offense count: 1
726
- Style/MultilineTernaryOperator:
727
688
  Exclude:
728
- - 'lib/net/ssh/authentication/agent.rb'
689
+ - 'lib/net/ssh/authentication/pageant.rb'
690
+ - 'lib/net/ssh/known_hosts.rb'
691
+ - 'lib/net/ssh/proxy/https.rb'
692
+ - 'lib/net/ssh/transport/algorithms.rb'
693
+ - 'lib/net/ssh/transport/kex/ecdh_sha2_nistp256.rb'
694
+ - 'lib/net/ssh/transport/state.rb'
695
+ - 'lib/net/ssh/verifiers/secure.rb'
696
+ - 'test/authentication/methods/test_hostbased.rb'
697
+ - 'test/authentication/methods/test_publickey.rb'
729
698
 
730
- # Offense count: 49
699
+ # Offense count: 40
731
700
  # Cop supports --auto-correct.
732
701
  Style/MutableConstant:
733
702
  Enabled: false
734
703
 
735
- # Offense count: 14
704
+ # Offense count: 13
736
705
  # Cop supports --auto-correct.
737
706
  Style/NegatedIf:
738
707
  Exclude:
739
708
  - 'lib/net/ssh.rb'
740
709
  - 'lib/net/ssh/authentication/key_manager.rb'
741
- - 'lib/net/ssh/prompt.rb'
742
710
  - 'lib/net/ssh/service/forward.rb'
743
711
  - 'lib/net/ssh/transport/algorithms.rb'
744
712
  - 'lib/net/ssh/transport/hmac/abstract.rb'
@@ -753,11 +721,6 @@ Style/NegatedWhile:
753
721
  Exclude:
754
722
  - 'lib/net/ssh/config.rb'
755
723
 
756
- # Offense count: 2
757
- Style/NestedTernaryOperator:
758
- Exclude:
759
- - 'lib/net/ssh/authentication/agent.rb'
760
-
761
724
  # Offense count: 2
762
725
  # Cop supports --auto-correct.
763
726
  # Configuration parameters: EnforcedStyle, MinBodyLength, SupportedStyles.
@@ -774,24 +737,40 @@ Style/NilComparison:
774
737
  - 'lib/net/ssh/proxy/command.rb'
775
738
  - 'lib/net/ssh/transport/openssl.rb'
776
739
 
777
- # Offense count: 4
740
+ # Offense count: 3
778
741
  # Cop supports --auto-correct.
779
742
  Style/Not:
780
743
  Exclude:
781
744
  - 'lib/net/ssh/connection/channel.rb'
782
745
 
783
- # Offense count: 6
746
+ # Offense count: 7
784
747
  # Cop supports --auto-correct.
785
748
  Style/NumericLiterals:
786
749
  MinDigits: 310
787
750
 
751
+ # Offense count: 11
752
+ # Cop supports --auto-correct.
753
+ # Configuration parameters: AutoCorrect, EnforcedStyle, SupportedStyles.
754
+ # SupportedStyles: predicate, comparison
755
+ Style/NumericPredicate:
756
+ Exclude:
757
+ - 'spec/**/*'
758
+ - 'lib/net/ssh/authentication/methods/password.rb'
759
+ - 'lib/net/ssh/authentication/pageant.rb'
760
+ - 'lib/net/ssh/buffer.rb'
761
+ - 'lib/net/ssh/service/forward.rb'
762
+ - 'lib/net/ssh/test/extensions.rb'
763
+ - 'lib/net/ssh/transport/key_expander.rb'
764
+ - 'test/transport/test_packet_stream.rb'
765
+ - 'test_connection_close_shall_close_cannels.rb'
766
+
788
767
  # Offense count: 2
789
768
  Style/OpMethod:
790
769
  Exclude:
791
770
  - 'lib/net/ssh/buffer.rb'
792
771
  - 'lib/net/ssh/version.rb'
793
772
 
794
- # Offense count: 16
773
+ # Offense count: 15
795
774
  # Cop supports --auto-correct.
796
775
  Style/ParallelAssignment:
797
776
  Exclude:
@@ -816,7 +795,7 @@ Style/ParenthesesAroundCondition:
816
795
  - 'lib/net/ssh/transport/ctr.rb'
817
796
  - 'test/integration/test_proxy.rb'
818
797
 
819
- # Offense count: 9
798
+ # Offense count: 5
820
799
  # Cop supports --auto-correct.
821
800
  # Configuration parameters: PreferredDelimiters.
822
801
  Style/PercentLiteralDelimiters:
@@ -825,7 +804,7 @@ Style/PercentLiteralDelimiters:
825
804
  - 'net-ssh.gemspec'
826
805
  - 'test/test_config.rb'
827
806
 
828
- # Offense count: 17
807
+ # Offense count: 16
829
808
  # Cop supports --auto-correct.
830
809
  Style/PerlBackrefs:
831
810
  Exclude:
@@ -851,16 +830,17 @@ Style/Proc:
851
830
  - 'test/connection/test_session.rb'
852
831
 
853
832
  # Offense count: 7
833
+ # Cop supports --auto-correct.
854
834
  # Configuration parameters: EnforcedStyle, SupportedStyles.
855
835
  # SupportedStyles: compact, exploded
856
836
  Style/RaiseArgs:
857
- Enabled: false
837
+ Exclude:
838
+ - 'lib/net/ssh/authentication/ed25519.rb'
858
839
 
859
- # Offense count: 8
840
+ # Offense count: 4
860
841
  # Cop supports --auto-correct.
861
842
  Style/RedundantBegin:
862
843
  Exclude:
863
- - 'lib/net/ssh/authentication/agent/socket.rb'
864
844
  - 'lib/net/ssh/buffered_io.rb'
865
845
  - 'lib/net/ssh/verifiers/strict.rb'
866
846
  - 'test/manual/test_pageant.rb'
@@ -871,7 +851,7 @@ Style/RedundantParentheses:
871
851
  Exclude:
872
852
  - 'support/arcfour_check.rb'
873
853
 
874
- # Offense count: 49
854
+ # Offense count: 57
875
855
  # Cop supports --auto-correct.
876
856
  # Configuration parameters: AllowMultipleReturnValues.
877
857
  Style/RedundantReturn:
@@ -894,20 +874,18 @@ Style/RescueModifier:
894
874
  - 'lib/net/ssh/service/forward.rb'
895
875
  - 'lib/net/ssh/transport/algorithms.rb'
896
876
 
897
- # Offense count: 2
877
+ # Offense count: 1
898
878
  # Cop supports --auto-correct.
899
879
  Style/SelfAssignment:
900
880
  Exclude:
901
881
  - 'lib/net/ssh/config.rb'
902
- - 'quicktest_337.rb'
903
882
 
904
- # Offense count: 10
883
+ # Offense count: 8
905
884
  # Cop supports --auto-correct.
906
885
  # Configuration parameters: AllowAsExpressionSeparator.
907
886
  Style/Semicolon:
908
887
  Exclude:
909
888
  - 'lib/net/ssh/buffer.rb'
910
- - 'quicktest_337.rb'
911
889
  - 'test/connection/test_channel.rb'
912
890
  - 'test/connection/test_session.rb'
913
891
  - 'test/transport/kex/test_ecdh_sha2_nistp256.rb'
@@ -928,28 +906,27 @@ Style/SingleLineMethods:
928
906
  Exclude:
929
907
  - 'lib/net/ssh/buffered_io.rb'
930
908
 
931
- # Offense count: 17
909
+ # Offense count: 16
932
910
  # Cop supports --auto-correct.
933
911
  Style/SpaceAfterColon:
934
912
  Exclude:
935
913
  - 'lib/net/ssh/authentication/ed25519.rb'
936
- - 'quicktest_keepalive.rb'
937
914
  - 'test/integration/test_ed25519_pkeys.rb'
938
915
  - 'test/verifiers/test_secure.rb'
939
916
 
940
- # Offense count: 247
917
+ # Offense count: 254
941
918
  # Cop supports --auto-correct.
942
919
  Style/SpaceAfterComma:
943
920
  Enabled: false
944
921
 
945
- # Offense count: 131
922
+ # Offense count: 132
946
923
  # Cop supports --auto-correct.
947
924
  # Configuration parameters: EnforcedStyle, SupportedStyles.
948
925
  # SupportedStyles: space, no_space
949
926
  Style/SpaceAroundEqualsInParameterDefault:
950
927
  Enabled: false
951
928
 
952
- # Offense count: 56
929
+ # Offense count: 55
953
930
  # Cop supports --auto-correct.
954
931
  # Configuration parameters: AllowForAlignment.
955
932
  Style/SpaceAroundOperators:
@@ -960,7 +937,11 @@ Style/SpaceAroundOperators:
960
937
  # Configuration parameters: EnforcedStyle, SupportedStyles.
961
938
  # SupportedStyles: space, no_space
962
939
  Style/SpaceBeforeBlockBraces:
963
- Enabled: false
940
+ Exclude:
941
+ - 'lib/net/ssh/authentication/session.rb'
942
+ - 'support/ssh_tunnel_bug.rb'
943
+ - 'test/authentication/test_agent.rb'
944
+ - 'test/connection/test_session.rb'
964
945
 
965
946
  # Offense count: 4
966
947
  # Cop supports --auto-correct.
@@ -978,20 +959,20 @@ Style/SpaceBeforeFirstArg:
978
959
  - 'lib/net/ssh/transport/hmac/sha2_512_96.rb'
979
960
  - 'test/authentication/test_key_manager.rb'
980
961
 
981
- # Offense count: 1
982
- # Cop supports --auto-correct.
983
- Style/SpaceBeforeSemicolon:
984
- Exclude:
985
- - 'quicktest_337.rb'
986
-
987
- # Offense count: 30
962
+ # Offense count: 10
988
963
  # Cop supports --auto-correct.
989
964
  # Configuration parameters: EnforcedStyle, SupportedStyles, EnforcedStyleForEmptyBraces, SpaceBeforeBlockParameters.
990
965
  # SupportedStyles: space, no_space
991
966
  Style/SpaceInsideBlockBraces:
992
- Enabled: false
967
+ Exclude:
968
+ - 'lib/net/ssh/authentication/session.rb'
969
+ - 'lib/net/ssh/transport/ctr.rb'
970
+ - 'support/ssh_tunnel_bug.rb'
971
+ - 'test/authentication/test_agent.rb'
972
+ - 'test/authentication/test_key_manager.rb'
973
+ - 'test/start/test_user_nil.rb'
993
974
 
994
- # Offense count: 40
975
+ # Offense count: 22
995
976
  # Cop supports --auto-correct.
996
977
  Style/SpaceInsideBrackets:
997
978
  Exclude:
@@ -1001,10 +982,10 @@ Style/SpaceInsideBrackets:
1001
982
  - 'test/integration/test_forward.rb'
1002
983
  - 'test/start/test_options.rb'
1003
984
 
1004
- # Offense count: 46
985
+ # Offense count: 69
1005
986
  # Cop supports --auto-correct.
1006
987
  # Configuration parameters: EnforcedStyle, EnforcedStyleForEmptyBraces, SupportedStyles.
1007
- # SupportedStyles: space, no_space
988
+ # SupportedStyles: space, no_space, compact
1008
989
  Style/SpaceInsideHashLiteralBraces:
1009
990
  Enabled: false
1010
991
 
@@ -1022,35 +1003,34 @@ Style/SpaceInsideRangeLiteral:
1022
1003
  - 'lib/net/ssh/authentication/ed25519.rb'
1023
1004
  - 'lib/net/ssh/transport/algorithms.rb'
1024
1005
 
1025
- # Offense count: 40
1006
+ # Offense count: 22
1026
1007
  # Cop supports --auto-correct.
1027
1008
  # Configuration parameters: EnforcedStyle, SupportedStyles.
1028
1009
  # SupportedStyles: use_perl_names, use_english_names
1029
1010
  Style/SpecialGlobalVars:
1030
- Enabled: false
1011
+ Exclude:
1012
+ - 'lib/net/ssh/authentication/agent.rb'
1013
+ - 'lib/net/ssh/connection/session.rb'
1014
+ - 'support/ssh_tunnel_bug.rb'
1015
+ - 'test/integration/common.rb'
1016
+ - 'test/integration/test_forward.rb'
1017
+ - 'test/manual/test_pageant.rb'
1018
+ - 'test/test_all.rb'
1019
+ - 'test_connection_close_shall_close_cannels.rb'
1020
+ - 'test_kerberos_client2.rb'
1031
1021
 
1032
- # Offense count: 1739
1022
+ # Offense count: 1846
1033
1023
  # Cop supports --auto-correct.
1034
1024
  # Configuration parameters: EnforcedStyle, SupportedStyles, ConsistentQuotesInMultiline.
1035
1025
  # SupportedStyles: single_quotes, double_quotes
1036
1026
  Style/StringLiterals:
1037
1027
  Enabled: false
1038
1028
 
1039
- # Offense count: 1
1040
- # Cop supports --auto-correct.
1041
- # Configuration parameters: EnforcedStyle, SupportedStyles.
1042
- # SupportedStyles: single_quotes, double_quotes
1043
- Style/StringLiteralsInInterpolation:
1044
- Enabled: false
1045
-
1046
- # Offense count: 17
1029
+ # Offense count: 11
1047
1030
  # Cop supports --auto-correct.
1048
1031
  # Configuration parameters: IgnoredMethods.
1049
- # IgnoredMethods: respond_to, on_close
1032
+ # IgnoredMethods: respond_to, define_method
1050
1033
  Style/SymbolProc:
1051
- IgnoredMethods:
1052
- - respond_to
1053
- - on_close
1054
1034
  Exclude:
1055
1035
  - 'lib/net/ssh/authentication/session.rb'
1056
1036
  - 'lib/net/ssh/buffer.rb'
@@ -1058,6 +1038,7 @@ Style/SymbolProc:
1058
1038
  - 'lib/net/ssh/test/extensions.rb'
1059
1039
  - 'lib/net/ssh/transport/algorithms.rb'
1060
1040
  - 'test/integration/test_forward.rb'
1041
+ - 'test/test/test_test.rb'
1061
1042
 
1062
1043
  # Offense count: 1
1063
1044
  # Cop supports --auto-correct.
@@ -1065,7 +1046,7 @@ Style/Tab:
1065
1046
  Exclude:
1066
1047
  - 'lib/net/ssh/config.rb'
1067
1048
 
1068
- # Offense count: 41
1049
+ # Offense count: 39
1069
1050
  # Cop supports --auto-correct.
1070
1051
  # Configuration parameters: EnforcedStyle, SupportedStyles.
1071
1052
  # SupportedStyles: final_newline, final_blank_line
@@ -1084,12 +1065,12 @@ Style/TrailingCommaInLiteral:
1084
1065
  - 'lib/net/ssh/transport/openssl.rb'
1085
1066
  - 'test/transport/test_packet_stream.rb'
1086
1067
 
1087
- # Offense count: 120
1068
+ # Offense count: 66
1088
1069
  # Cop supports --auto-correct.
1089
1070
  Style/TrailingWhitespace:
1090
1071
  Enabled: false
1091
1072
 
1092
- # Offense count: 2
1073
+ # Offense count: 1
1093
1074
  # Cop supports --auto-correct.
1094
1075
  # Configuration parameters: ExactNameMatch, AllowPredicates, AllowDSLWriters, IgnoreClassMethods, Whitelist.
1095
1076
  # Whitelist: to_ary, to_a, to_c, to_enum, to_h, to_hash, to_i, to_int, to_io, to_open, to_path, to_proc, to_r, to_regexp, to_str, to_s, to_sym
@@ -1130,7 +1111,7 @@ Style/WhileUntilDo:
1130
1111
  - 'lib/net/ssh/config.rb'
1131
1112
  - 'test/integration/common.rb'
1132
1113
 
1133
- # Offense count: 2
1114
+ # Offense count: 3
1134
1115
  # Cop supports --auto-correct.
1135
1116
  # Configuration parameters: SupportedStyles, WordRegex.
1136
1117
  # SupportedStyles: percent, brackets