net-ping 1.0.1 → 1.1.0

data/CHANGES

@@ -1,3 +1,10 @@
+== 1.1.0 - 17-Jul-2005
+* Fixed a bug in the PingHTTP#ping method where I was accidentally passing
+  the timeout value instead of the port number as the third argument to
+  Net::HTTP.get_response.
+* The PingHTTP.new method now has a default port of 80.
+* Minor doc update for PingHTTP.new.
+
 == 1.0.1 - 22-Jun-2005
 * Bug fix for the install.rb file.  The gem is unaffected.
 

data/doc/ping.txt

@@ -90,7 +90,7 @@ PingExternal#ping?
 	ping was successful and true is returned.  Otherwise, false is returned.
 	
 === PingHTTP
-PingHTTP.new(uri, port=7, timeout=5)
+PingHTTP.new(uri, port=80, timeout=5)
 	Creates and returns a new PingHTTP object.
 	
 PingHTTP#ping

data/lib/net/ping.rb

@@ -4,7 +4,7 @@ require "timeout"
 module Net
    # An abstract base class.  Do not instantiate directly.
    class Ping
-      VERSION = "1.0.1"
+      VERSION = "1.1.0"
       attr_accessor :host, :port, :timeout
       attr_reader :exception, :warning
       
@@ -30,7 +30,7 @@ module Net
    class PingTCP < Ping
       @@econnrefused = false
 
-      # Returns true if the ECONNREFUSED error is to be considered a
+      # Returns whether or not ECONNREFUSED error is to be considered a
       # successful ping.  The default is false.
       def self.econnrefused
          @@econnrefused
@@ -42,7 +42,7 @@ module Net
       end
 
       # Sets whether or not an ECONNREFUSED error should be considered a
-      # successful ping or not.
+      # successful ping.
       def self.econnrefused=(bool)
          unless bool.kind_of?(TrueClass) || bool.kind_of?(FalseClass)
             raise ArgumentError, "argument must be true or false"
@@ -198,15 +198,23 @@ module Net
       require "net/http"
       require "uri"
       include Net
+      
+      # Creates and returns a new PingHTTP object.
+      #--
+      # Defined separately in order to set the default port to 80.
+      def initialize(host, port=80, timeout=5)
+         super(host, port, timeout)
+      end
 
       # Looks for an HTTP response from the URI passed to the constructor.
       # If the result is HTTPSuccess or HTTPOK, the ping was successful.
       def ping
          super
          success = false
+         uri = URI.parse(@host)
 
          begin
-            resp = HTTP.get_response(URI.parse(@host), nil, @timeout)
+            resp = HTTP.get_response(uri.host, uri.path, @port)
          rescue Exception => e
             @exception = e
          else

data/test/tc_pinghttp.rb

@@ -17,12 +17,12 @@ include Net
 class TC_PingHTTP < Test::Unit::TestCase
    def setup
       @uri  = "http://www.pragmaticprogrammer.com/index.html"
-      @http = PingHTTP.new(@uri)
+      @http = PingHTTP.new(@uri)      
       @bad  = PingHTTP.new("http://www.blabfoobarurgh.com")
    end
 
    def test_version
-      assert_equal("1.0.1", PingHTTP::VERSION, "Bad version constant")
+      assert_equal("1.1.0", PingHTTP::VERSION, "Bad version constant")
    end
    
    def test_ping

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification 
-rubygems_version: 0.8.10
+rubygems_version: 0.8.11
 specification_version: 1
 name: net-ping
 version: !ruby/object:Gem::Version 
-  version: 1.0.1
-date: 2005-06-22
+  version: 1.1.0
+date: 2005-07-18 00:00:00 -06:00
 summary: A ping interface for Ruby
 require_paths: 
-- lib
+  - lib
 email: djberg96@gmail.com
 homepage: http://www.rubyforge.org/projects/shards
 rubyforge_project: 
@@ -18,37 +18,35 @@ bindir: bin
 has_rdoc: true
 required_ruby_version: !ruby/object:Gem::Version::Requirement 
   requirements: 
-  - - ">"
-    - !ruby/object:Gem::Version 
-      version: 0.0.0
+    - 
+      - ">"
+      - !ruby/object:Gem::Version 
+        version: 0.0.0
   version: 
 platform: ruby
+signing_key: 
+cert_chain: 
 authors: 
-- Daniel J. Berger
+  - Daniel J. Berger
 files: 
-- lib/net/ping.rb
-- CHANGES
-- MANIFEST
-- README
-- test/tc_pingexternal.rb
-- test/tc_pinghttp.rb
-- test/tc_pingtcp.rb
-- test/tc_pingudp.rb
-- test/ts_ping.rb
-- doc/ping.txt
+  - lib/net/ping.rb
+  - README
+  - CHANGES
+  - MANIFEST
+  - test/tc_pingtcp.rb
+  - test/tc_pingudp.rb
+  - test/tc_pingexternal.rb
+  - test/ts_ping.rb
+  - test/tc_pinghttp.rb
+  - doc/ping.txt
 test_files: 
-- test/ts_ping.rb
+  - test/ts_ping.rb
 rdoc_options: []
-
 extra_rdoc_files: 
-- README
-- CHANGES
-- doc/ping.txt
+  - README
+  - CHANGES
+  - doc/ping.txt
 executables: []
-
 extensions: []
-
 requirements: []
-
-dependencies: []
-
+dependencies: []