net-http-pool 0.0.2 → 0.0.3

data/.travis.yml

@@ -0,0 +1,5 @@
+language: ruby
+rvm:
+  - 1.9.2
+  - 1.9.3
+  - jruby

data/README.md

@@ -1,5 +1,7 @@
 # Net::HTTP::Pool
 
+[![Build Status](https://secure.travis-ci.org/elcuervo/net-http-pool.png?branch=master)](http://travis-ci.org/elcuervo/net-http-pool)
+
 ![Pool](http://www.beijingboyce.com/wp-content/uploads/2008/03/pool-table.JPG)
 
 Act like a database pool but for HTTP.
@@ -12,13 +14,25 @@ verb block it's async.
 The target of the lib it's to provide DB-like pool to handle information
 exchange.
 
+## Motivation
+
+The main goal it's to provide a easy to use HTTP pool exploiting HTTP 1.1
+persistent connections in a non-blocking way.
+
 ## Example
 
 ```ruby
 require 'net/http/pool'
 
 pool = Net::HTTP::Pool.new("http://elcuervo.co")
-pool.get("/humans.txt") do |response|
+request = Net::HTTP::Get.new("/humans.txt")
+
+pool.request(request) do |response|
   File.open('nevermore.txt', 'w') { |f| f << response.body } if response.code == "200"
 end
 ```
+
+## Thanks to
+
+  * [@foca](http://github.com/foca) and [@dcadenas](http://github.com/dcadenas)
+    for code-review and corrections.

data/SPEC.md

@@ -1,3 +1,4 @@
 # Pool of persistent connections
 
-Pool of connections to use with Spirit... for now
+Pool of HTTP connections. Works together with Net::HTTP.
+Works with aync calls using actors

data/lib/net/http/pool.rb

@@ -7,13 +7,6 @@ require 'net/http/persistent'
 class Net::HTTP::Pool
   include Celluloid
 
-  # Private: Custom Error for a missing block in the call.
-  class MissingBlock < StandardError
-    def message
-      "You must pass a block"
-    end
-  end
-
   # Public: The Connection Pool.
   #
   # host    - The string of the host.
@@ -37,9 +30,10 @@ class Net::HTTP::Pool
     #
     # &block - The block to be called passing the current connection
     def round_robin(&block)
-      raise MissingBlock unless block
+      raise LocalJumpError unless block
+
       @current_index = @current_index > @pool.size ? 0 : @current_index + 1
-      yield @pool[@current_index] if block
+      yield @pool[@current_index]
     end
 
     # Public: Helper to access the connection asynchronous
@@ -55,30 +49,16 @@ class Net::HTTP::Pool
     @uri = URI(host)
   end
 
-  def get(path, headers = {}, &block)
-    request!(path, Net::HTTP::Get, nil, headers, &block)
-  end
-
-  def post(path, body = nil, headers = {}, &block)
-    request!(path, Net::HTTP::Post, body, headers, &block)
+  def request(request, &block)
+    async_request!(request, &block)
   end
 
-  def put(path, body = nil, headers = {}, &block)
-    request!(path, Net::HTTP::Put, body, headers, &block)
-  end
+  def async_request(request, &block)
+    raise LocalJumpError unless block
 
-  def delete(path, headers = {}, &block)
-    request!(path, Net::HTTP::Delete, headers, &block)
-  end
-
-  def request(path, type, body = nil, headers = {}, &block)
-    raise MissingBlock unless block
     @pool.with do |connection|
-      request = type.new(path)
-      request.body = body if body
-      headers.each { |key, value| request.add_field(key, value) }
-      request['Content-Length'] = body && body.length || 0
-      yield connection.request(@uri, request) if block
+      yield connection.request(@uri, request)
     end
   end
+
 end

data/net-http-pool.gemspec

@@ -1,6 +1,6 @@
 Gem::Specification.new do |s|
   s.name       = "net-http-pool"
-  s.version    = "0.0.2"
+  s.version    = "0.0.3"
   s.summary    = "Persistent pool of HTTP connections"
   s.authors    = ["elcuervo"]
   s.email      = ["yo@brunoaguirre.com"]

data/test/pool.rb

@@ -35,34 +35,47 @@ scope do
   end
 
   test "check that the HTTP verbs do work" do
-    @pool.get("/") do |res|
+    request = Net::HTTP::Get.new("/")
+
+    @pool.request(request) do |res|
       assert_equal "200", res.code
       assert_equal 'What is up dog!', res.body
     end
 
-    @pool.get("/marco") do |res|
+    request = Net::HTTP::Get.new("/marco")
+
+    @pool.request(request) do |res|
       assert_equal "200", res.code
       assert_equal 'polo', res.body
     end
 
-    @pool.post("/post", 'test=yes', {'X-Fancy-Header' => 'Sometimes'}) do |res|
+    request = Net::HTTP::Post.new("/post")
+    request.body = 'test=test'
+    request['X-Fancy-Header'] = 'Sometimes'
+
+    @pool.request(request) do |res|
       assert_equal "200", res.code
       assert_equal 'this is a test', res.body
     end
 
-    @pool.put("/put", 'run=fast') do |res|
+    request = Net::HTTP::Put.new("/put")
+    request.body = 'run=fast'
+
+    @pool.request(request) do |res|
       assert_equal "200", res.code
       assert_equal 'fast', res.body
     end
 
-    @pool.delete("/delete") do |res|
+    request = Net::HTTP::Delete.new("/delete")
+    @pool.request(request) do |res|
       assert_equal "200", res.code
     end
   end
 
   test "do not block main thread when resource is slow" do
     start = Time.now
-    5.times { @pool.get("/wait") {} }
+    request = Net::HTTP::Get.new("/wait")
+    5.times { @pool.request(request) {} }
     assert Time.now - start < 20
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: net-http-pool
 version: !ruby/object:Gem::Version
-  version: 0.0.2
+  version: 0.0.3
   prerelease: 
 platform: ruby
 authors:
@@ -13,7 +13,7 @@ date: 2012-04-12 00:00:00.000000000Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: net-http-persistent
-  requirement: &70302928111800 !ruby/object:Gem::Requirement
+  requirement: &70350927480060 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ! '>='
@@ -21,10 +21,10 @@ dependencies:
         version: '2.6'
   type: :runtime
   prerelease: false
-  version_requirements: *70302928111800
+  version_requirements: *70350927480060
 - !ruby/object:Gem::Dependency
   name: celluloid
-  requirement: &70302928111020 !ruby/object:Gem::Requirement
+  requirement: &70350927479400 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -32,10 +32,10 @@ dependencies:
         version: 0.9.0
   type: :runtime
   prerelease: false
-  version_requirements: *70302928111020
+  version_requirements: *70350927479400
 - !ruby/object:Gem::Dependency
   name: cutest
-  requirement: &70302928110440 !ruby/object:Gem::Requirement
+  requirement: &70350927478640 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -43,10 +43,10 @@ dependencies:
         version: 1.1.3
   type: :development
   prerelease: false
-  version_requirements: *70302928110440
+  version_requirements: *70350927478640
 - !ruby/object:Gem::Dependency
   name: capybara
-  requirement: &70302928109860 !ruby/object:Gem::Requirement
+  requirement: &70350927478040 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -54,10 +54,10 @@ dependencies:
         version: 1.1.2
   type: :development
   prerelease: false
-  version_requirements: *70302928109860
+  version_requirements: *70350927478040
 - !ruby/object:Gem::Dependency
   name: mock-server
-  requirement: &70302928109300 !ruby/object:Gem::Requirement
+  requirement: &70350927477380 !ruby/object:Gem::Requirement
     none: false
     requirements:
     - - ~>
@@ -65,7 +65,7 @@ dependencies:
         version: 0.1.2
   type: :development
   prerelease: false
-  version_requirements: *70302928109300
+  version_requirements: *70350927477380
 description: 
 email:
 - yo@brunoaguirre.com
@@ -73,6 +73,7 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
+- .travis.yml
 - Gemfile
 - README.md
 - Rakefile