net-http-persistent 4.0.3 → 4.0.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: dda1829232ea53f61dd44b4added8e65777661bb9c2bb8f4c49014c7dbbe3d1d
-  data.tar.gz: 9321f0aad6dbc328d2612212321e9f2daa8cad2330f677208c55089676f666e7
+  metadata.gz: d990a23527093f31794ae1e926c425666b2d680ed811282dd4b795a24862876a
+  data.tar.gz: a4faf258fd1a299cd1c86a45a68f6d7034105633313255a16485f9a1f6015507
 SHA512:
-  metadata.gz: 9ca608a9a2f899b0ac3636d848f4581085fae57eec74527ed457e21a6c1988d909123cd4d4e102ab77d53a3839e9778adc140ecdff9d57d5f1dcbcd2c2d69c5c
-  data.tar.gz: 03622a828eea0b5266511a39afc8bafdccf41d1e7e572cf04e0e23548104307d857b33bdaa387ed12ef46f8fd890762a8d39fa3ac9a4e2ca7d70026cd9bfd1b5
+  metadata.gz: bb00624ad04bf5380843d1870b3cd23b6f2a6442c2f956869dbac748dcdfe65fb6f040139c1e859d2b0df0592ef45119ad9701f2b9e8a983f741b3ecb05c6087
+  data.tar.gz: addb4fbf6cf6c051406ca5d03243d8cf5b5ba605b7cac229b0ca6df1dc61f030222d22d5e8380deaf45df6489a4ec9dd1b83309197be893df266b86fa9b0eaf8

data/History.txt

@@ -1,4 +1,10 @@
-=== 4.0.2 / 2024-09-09
+=== 4.0.4 / 2024-09-09
+
+Bug fixes:
+
+* Allow setting verify_hostname to false
+
+=== 4.0.3 / 2024-09-09
 
 Bug fixes:
 

data/lib/net/http/persistent.rb

@@ -181,7 +181,7 @@ class Net::HTTP::Persistent
   ##
   # The version of Net::HTTP::Persistent you are using
 
-  VERSION = '4.0.3'
+  VERSION = '4.0.4'
 
   ##
   # Error class for errors raised by Net::HTTP::Persistent.  Various
@@ -1001,7 +1001,7 @@ class Net::HTTP::Persistent
     connection.verify_depth    = @verify_depth
     connection.verify_mode     = @verify_mode
     connection.verify_hostname = @verify_hostname if
-      @verify_hostname && connection.respond_to?(:verify_hostname=)
+      @verify_hostname != nil && connection.respond_to?(:verify_hostname=)
 
     if OpenSSL::SSL::VERIFY_PEER == OpenSSL::SSL::VERIFY_NONE and
        not Object.const_defined?(:I_KNOW_THAT_OPENSSL_VERIFY_PEER_EQUALS_VERIFY_NONE_IS_WRONG) then
@@ -1111,7 +1111,7 @@ application:
   end
 
   ##
-  # Sets the HTTPS verify_hostname.  Defaults to false.
+  # Sets the HTTPS verify_hostname.
 
   def verify_hostname= verify_hostname
     @verify_hostname = verify_hostname
@@ -1131,4 +1131,3 @@ end
 
 require_relative 'persistent/connection'
 require_relative 'persistent/pool'
-

data/test/test_net_http_persistent.rb

@@ -1343,7 +1343,7 @@ class TestNetHttpPersistent < Minitest::Test
     assert_equal OpenSSL::SSL::VERIFY_NONE, c.verify_mode
   end
 
-  def test_ssl_verify_hostname
+  def test_ssl_enable_verify_hostname
     skip 'OpenSSL is missing' unless HAVE_OPENSSL
 
     @http.verify_hostname = true
@@ -1358,6 +1358,22 @@ class TestNetHttpPersistent < Minitest::Test
     assert c.verify_hostname
   end
 
+  def test_ssl_disable_verify_hostname
+    skip 'OpenSSL is missing' unless HAVE_OPENSSL
+
+    @http.verify_hostname = false
+    c = Net::HTTP.new 'localhost', 80
+
+    skip 'net/http doesn\'t provide verify_hostname= method' unless
+      c.respond_to?(:verify_hostname=)
+
+    @http.ssl c
+
+    assert c.use_ssl?
+    assert c.verify_hostname == false
+  end
+
+
   def test_ssl_warning
     skip 'OpenSSL is missing' unless HAVE_OPENSSL
 
@@ -1474,4 +1490,3 @@ class TestNetHttpPersistent < Minitest::Test
     end
   end
 end
-

metadata

@@ -1,10 +1,11 @@
 --- !ruby/object:Gem::Specification
 name: net-http-persistent
 version: !ruby/object:Gem::Version
-  version: 4.0.3
+  version: 4.0.4
 platform: ruby
 authors:
 - Eric Hodel
+autorequire: 
 bindir: bin
 cert_chain: []
 date: 2024-09-09 00:00:00.000000000 Z
@@ -62,6 +63,7 @@ licenses:
 - MIT
 metadata:
   homepage_uri: https://github.com/drbrain/net-http-persistent
+post_install_message: 
 rdoc_options:
 - "--main"
 - README.rdoc
@@ -78,7 +80,8 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.6.0.dev
+rubygems_version: 3.0.3.1
+signing_key: 
 specification_version: 4
 summary: Manages persistent connections using Net::HTTP including a thread pool for
   connecting to multiple hosts