net-http-persistent 3.0.1 → 4.0.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 544b6c4e52caee7104e021181a7ab8723a625e239820297b7e6d87934c7e0e0e
-  data.tar.gz: 03e9df91b7e30d25886c30a650f9e6feb8fa7d945cf5e61b19d416bfe46eff6a
+  metadata.gz: 9123e98741595dbcc1c9a9713ecdcfb517597dc52791dc546bd868c31cbe88d0
+  data.tar.gz: 462f4ae1dd63c8776ac18e3eab2b8e4c43e65d906722086a670d5ae3b764eb2b
 SHA512:
-  metadata.gz: 38b3695f98f1bae796fb0b51b12d992b621ac9d0d8b6e9f885c9327a91d994acdfa18e37018bf5a7a28bf52e11413194b027dd332d3605f913c66f847402d683
-  data.tar.gz: 32420e4a50e91fcac562ab34b1c383a7ce529d0c6646a802e4625f5f61b4c017ef6640d4e466bd803d4a5d0172d577cd05ef1979a450ef326af68a76de4f709a
+  metadata.gz: 45e3ea77d23e8c9829bba490c61546b71a221194cf8106bbb32ad746408283df04923649aef952d7317f06475a0a5466b19376c7a38e8b62490d65f24b6031cf
+  data.tar.gz: e46564075c2d655e258c5fd9ff3c45843b48c5bd6d8c5f80fe84450a36e7ac5811d0f97b5e8223277c2b607e7259df70e1e331c372e12a4bd33efec0e555e743

data/Gemfile

@@ -0,0 +1,14 @@
+# -*- ruby -*-
+
+source "https://rubygems.org/"
+
+gemspec
+
+gem "rake", "~>13.0"
+gem "minitest", "~>5.15", :group => [:development, :test]
+gem "rdoc", ">=4.0", "<7", :group => [:development, :test]
+gem "rake-manifest", "~>0.2"
+
+gem 'net-http-pipeline', '~> 1.0' if ENV['CI_MATRIX'] == 'pipeline'
+
+# vim: syntax=ruby

data/History.txt

@@ -1,4 +1,92 @@
-=== 3.0
+=== 4.0.2 / 2023-03-29
+
+Bug fixes:
+
+* Fix compatibility with `connection_pool 2.4+`
+
+=== 4.0.1 / 2021-01-12
+
+Bug fixes:
+
+* Loosen Ruby version requirement so Ruby 3.0 will work.
+
+=== 4.0.0 / 2020-04-30
+
+Breaking changes:
+
+* Removed built-in support for retrying failed requests as Net::HTTP has this
+  built-in for all supported versions.  Pull request #100 by Michael Grosser.
+* Dropped support for EoL ruby versions (< 2.4).  Future feature releases may
+  drop support for ruby versions that are at end-of-life or in security-only
+  maintenance mode with any release.  Pull request #113 by David Rodríguez
+
+New features:
+
+* Added Net::HTTP::Persistent#max_retries= to configure the number of retries
+  performed on a request for ruby versions that support it (2.5+).
+* URI-ness is determined through #respond_to? to allow compatibility with
+  Addressable::URI.  Pull request #67 by Ryan McKern.
+* Use require_relative to reduce patch burden for vendored versions.  Pull
+  Request #106 by David Rodríguez
+
+Bug fixes:
+
+* Stop wasting a connection when the keep-alive timeout is less than the idle
+  timeout.  Pull request #115 by Yap Sok Ann.
+* Improved use of URI#hostname for IPv6 connections.  Pull request #76 by
+  Tomas Koutsky.
+* Improved check for Process::RLIMIT_NOFILE support.  Pull request #109 by Vít
+  Ondruch.
+* Fix namespace in comments for escape/unescape wrappers.  Pull request #114
+  by David Rodríguez.
+* Fix History.txt timestamp for 3.0.0 release.  Pull request #107 by Joe Van
+  Dyk.
+* Fix link to PR #98 in 3.1.0 release notes.  Pull request #110 by Justin
+  Reid.
+
+Other:
+
+* Updated Net::HTTP::Persistent#reconnect documentation to indicate that all
+  connections are reset.  Issue #117 by Taisuke Miyazaki.
+
+=== 3.1.0 / 2019-07-24
+
+New features:
+* Support ruby 2.6 Net::HTTP#write_timeout=.  Pull request #99 by Víctor
+  Roldán Betancort.
+* Support setting TLS min/max version.  Pull request #94 by Bart.
+
+Bug fixes:
+* Reduce potential for memory leak through Hash default proc bindings.  Pull
+  request #64 by Dominic Metzger.
+* Test proxy auto detection from no_proxy in ENV.  Pull request #60 by
+  HINOHARA Hiroshi.
+* Add missing timestamp for 3.0 release.  Pull request #78 by Joe Van Dyk.
+* Support IPv6 URLs in proxy checks.  Pull request #82 by Nicolás Sanguinetti.
+* Use Net::HTTPGenericRequest#method to check idempotence for improved
+  compatibility.  Pull request #83 by Fotos Georgiadis.
+* Run net-http-pipeline tests in travis.  Pull request #86 by T.J. Schuck.
+* Correct +no_proxy+ support to override Net::HTTP proxy fallback.  Pull
+  request #88 by Jared Kauppila.
+* Mitigate memory leak when combined with faraday.  Pull request #105 by Yohei
+  Kitamura.
+* Set default connection pool size for Windows.  Pull request #90 by Jared
+  Kauppila.
+* Fix missing +name:+ argument in documentation.  Pull requests #85 by T.J.
+  Schuck, #84 by James White.
+* Fix memory leak from connection pooling.  Pull request #98 by Aaron
+  Patterson.
+* Update tests for minitest assert_equal deprecation.  Pull request #92 by
+  Olle Jonsson.
+* Fix typo in Net::HTTP::Persistent#pipeline.  Pull request #91 by Kazuma
+  Furuhashi.
+
+Other:
+* Added bundler hoe plugin.  Pull request #103 by Michael Grosser.
+* Updated ruby versions in Travis CI.  Pull request #93 by Olle Jonsson.  Pull
+  request #103 by Michael Grosser.
+
+=== 3.0 / 2016-10-05
 
 Breaking changes:
 

data/Manifest.txt

@@ -1,6 +1,6 @@
 .autotest
 .gemtest
-.travis.yml
+Gemfile
 History.txt
 Manifest.txt
 README.rdoc

data/README.rdoc

@@ -1,27 +1,27 @@
 = net-http-persistent
 
-* http://docs.seattlerb.org/net-http-persistent
-* https://github.com/drbrain/net-http-persistent
+home :: https://github.com/drbrain/net-http-persistent
+rdoc :: https://rdoc.info/gems/net-http-persistent
 
 == DESCRIPTION:
 
-Manages persistent connections using Net::HTTP plus a speed fix for Ruby 1.8.
-It's thread-safe too!
+Manages persistent connections using Net::HTTP including a thread pool for
+connecting to multiple hosts.
 
 Using persistent HTTP connections can dramatically increase the speed of HTTP.
 Creating a new HTTP connection for every request involves an extra TCP
 round-trip and causes TCP congestion avoidance negotiation to start over.
 
 Net::HTTP supports persistent connections with some API methods but does not
-handle reconnection gracefully.  Net::HTTP::Persistent supports reconnection
-and retry according to RFC 2616.
+make setting up a single persistent connection or managing multiple
+connections easy.  Net::HTTP::Persistent wraps Net::HTTP and allows you to
+focus on how to make HTTP requests.
 
 == FEATURES/PROBLEMS:
 
-* Supports SSL
+* Supports TLS with secure defaults
 * Thread-safe
 * Pure ruby
-* Timeout-less speed boost for Ruby 1.8 (by Aaron Patterson)
 
 == SYNOPSIS
 
@@ -60,7 +60,7 @@ including SSL connection verification, header handling and tunable options.
 
 (The MIT License)
 
-Copyright (c) 2010 Eric Hodel, Aaron Patterson
+Copyright (c) Eric Hodel, Aaron Patterson
 
 Permission is hereby granted, free of charge, to any person obtaining
 a copy of this software and associated documentation files (the

data/Rakefile

@@ -1,27 +1,25 @@
 # -*- ruby -*-
 
-require 'rubygems'
-require 'hoe'
-
-Hoe.plugin :git
-Hoe.plugin :minitest
-Hoe.plugin :travis
-
-Hoe.spec 'net-http-persistent' do
-  developer 'Eric Hodel', 'drbrain@segment7.net'
-
-  self.readme_file      = 'README.rdoc'
-  self.extra_rdoc_files += Dir['*.rdoc']
-
-  self.require_ruby_version '~> 2.1'
-
-  license 'MIT'
-
-  rdoc_locations <<
-    'docs.seattlerb.org:/data/www/docs.seattlerb.org/net-http-persistent/'
-
-  dependency 'connection_pool', '~> 2.2'
-  dependency 'minitest',        '~> 5.2', :development
+require "bundler/gem_tasks"
+
+require "rake/testtask"
+
+Rake::TestTask.new
+
+require "rake/manifest"
+
+Rake::Manifest::Task.new do |t|
+  t.patterns = [
+    ".autotest",
+    ".gemtest",
+    ".travis.yml",
+    "Gemfile",
+    "History.txt",
+    "Manifest.txt",
+    "README.rdoc",
+    "Rakefile",
+    "{test,lib}/**/*"
+  ]
 end
 
 # vim: syntax=Ruby

data/lib/net/http/persistent/connection.rb

@@ -25,6 +25,7 @@ class Net::HTTP::Persistent::Connection # :nodoc:
   ensure
     reset
   end
+  alias_method :close, :finish
 
   def reset
     @last_use = Net::HTTP::Persistent::EPOCH

data/lib/net/http/persistent/pool.rb

@@ -11,17 +11,32 @@ class Net::HTTP::Persistent::Pool < ConnectionPool # :nodoc:
   end
 
   def checkin net_http_args
-    stack = Thread.current[@key][net_http_args] ||= []
+    if net_http_args.is_a?(Hash) && net_http_args.size == 1 && net_http_args[:force]
+      # ConnectionPool 2.4+ calls `checkin(force: true)` after fork.
+      # When this happens, we should remove all connections from Thread.current
+      if stacks = Thread.current[@key]
+        stacks.each do |http_args, connections|
+          connections.each do |conn|
+            @available.push conn, connection_args: http_args
+          end
+          connections.clear
+        end
+      end
+    else
+      stack = Thread.current[@key][net_http_args] ||= []
 
-    raise ConnectionPool::Error, 'no connections are checked out' if
-      stack.empty?
+      raise ConnectionPool::Error, 'no connections are checked out' if
+        stack.empty?
 
-    conn = stack.pop
+      conn = stack.pop
 
-    if stack.empty?
-      @available.push conn, connection_args: net_http_args
-    end
+      if stack.empty?
+        @available.push conn, connection_args: net_http_args
 
+        Thread.current[@key].delete(net_http_args)
+        Thread.current[@key] = nil if Thread.current[@key].empty?
+      end
+    end
     nil
   end
 
@@ -46,5 +61,5 @@ class Net::HTTP::Persistent::Pool < ConnectionPool # :nodoc:
   end
 end
 
-require 'net/http/persistent/timed_stack_multi'
+require_relative 'timed_stack_multi'
 

data/lib/net/http/persistent/timed_stack_multi.rb

@@ -1,10 +1,20 @@
 class Net::HTTP::Persistent::TimedStackMulti < ConnectionPool::TimedStack # :nodoc:
 
+  ##
+  # Returns a new hash that has arrays for keys
+  #
+  # Using a class method to limit the bindings referenced by the hash's
+  # default_proc
+
+  def self.hash_of_arrays # :nodoc:
+    Hash.new { |h,k| h[k] = [] }
+  end
+
   def initialize(size = 0, &block)
     super
 
     @enqueued = 0
-    @ques = Hash.new { |h, k| h[k] = [] }
+    @ques = self.class.hash_of_arrays
     @lru = {}
     @key = :"connection_args-#{object_id}"
   end