net-http-persistent 2.2 → 2.3

data/History.txt

@@ -1,6 +1,12 @@
-=== 2.2 / 2011-10-24
+=== 2.3 / 2011-10-25
 
 * Minor Enhancement
+  * The time since last use for a connection is now recorded in error
+    messages for the connection.
+
+=== 2.2 / 2011-10-24
+
+* Minor Enhancements
   * Added timeouts for idle connections which are set through #idle_timeout.
     The default timeout is 5 seconds.  Reducing the idle timeout is preferred
     over setting #retry_change_requests to true if you wish to avoid the "too

data/lib/net/http/persistent.rb

@@ -149,7 +149,7 @@ class Net::HTTP::Persistent
   ##
   # The version of Net::HTTP::Persistent you are using
 
-  VERSION = '2.2'
+  VERSION = '2.3'
 
   ##
   # Error class for errors raised by Net::HTTP::Persistent.  Various
@@ -425,10 +425,13 @@ class Net::HTTP::Persistent
   # this connection
 
   def error_message connection
-    requests =
-      Thread.current[@request_key][connection.object_id]
+    requests = Thread.current[@request_key][connection.object_id] - 1 # fixup
+    last_use = Thread.current[@timeout_key][connection.object_id]
 
-    "after #{requests} requests on #{connection.object_id}"
+    age = Time.now - last_use
+
+    "after #{requests} requests on #{connection.object_id}, " \
+      "last used #{age} seconds ago"
   end
 
   ##

data/test/test_net_http_persistent.rb

@@ -348,9 +348,12 @@ class TestNetHttpPersistent < MiniTest::Unit::TestCase
 
   def test_error_message
     c = basic_connection
+    touts[c.object_id] = Time.now - 1
     reqs[c.object_id] = 5
 
-    assert_equal "after 5 requests on #{c.object_id}", @http.error_message(c)
+    message = @http.error_message(c)
+    assert_match %r%after 4 requests on #{c.object_id}%, message
+    assert_match %r%, last used [\d.]+ seconds ago%, message
   end
 
   def test_escape

metadata

@@ -1,12 +1,12 @@
 --- !ruby/object:Gem::Specification 
 name: net-http-persistent
 version: !ruby/object:Gem::Version 
-  hash: 7
+  hash: 5
   prerelease: 
   segments: 
   - 2
-  - 2
-  version: "2.2"
+  - 3
+  version: "2.3"
 platform: ruby
 authors: 
 - Eric Hodel