net-http-persistent 1.7 → 1.8

data/History.txt

@@ -1,3 +1,11 @@
+=== 1.8 / 2011-06-27
+
+* Minor Enhancement
+  * Added Net::HTTP::Persistent#retry_change_requests which allows POST and
+    other non-idempotent requests to be retried automatically.  Take care when
+    enabling this option to ensure the server will handle multiple POSTs with
+    the same data in a sane manner.
+
 === 1.7 / 2011-04-17
 
 * Minor Enhancement

data/lib/net/http/persistent.rb

@@ -42,7 +42,7 @@ class Net::HTTP::Persistent
   ##
   # The version of Net::HTTP::Persistent use are using
 
-  VERSION = '1.7'
+  VERSION = '1.8'
 
   ##
   # Error class for errors raised by Net::HTTP::Persistent.  Various
@@ -152,6 +152,17 @@ class Net::HTTP::Persistent
 
   attr_accessor :verify_mode
 
+  ##
+  # Enable retries of non-idempotent requests that change data (e.g. POST
+  # requests) when the server has disconnected.
+  #
+  # This will in the worst case lead to multiple requests with the same data,
+  # but it may be useful for some applications.  Take care when enabling
+  # this option to ensure it is safe to POST or perform other non-idempotent
+  # requests to the server.
+
+  attr_accessor :retry_change_requests
+
   ##
   # Creates a new Net::HTTP::Persistent.
   #
@@ -211,6 +222,8 @@ class Net::HTTP::Persistent
     @private_key     = nil
     @verify_callback = nil
     @verify_mode     = nil
+
+    @retry_change_requests = false
   end
 
   ##
@@ -305,6 +318,13 @@ class Net::HTTP::Persistent
     end
   end
 
+  ##
+  # Is the request idempotent or is retry_change_requests allowed
+
+  def can_retry? req
+    retry_change_requests or idempotent?(req)
+  end
+
   ##
   # Adds "http://" to the String +uri+ if it is missing.
 
@@ -409,7 +429,7 @@ class Net::HTTP::Persistent
       finish connection
 
       raise Error, "too many bad responses #{message}" if
-        bad_response or not idempotent? req
+        bad_response or not can_retry? req
 
       bad_response = true
       retry
@@ -417,7 +437,7 @@ class Net::HTTP::Persistent
            Errno::ECONNABORTED, Errno::ECONNRESET, Errno::EPIPE,
            Errno::EINVAL => e
 
-      if retried or not idempotent? req
+      if retried or not can_retry? req
         due_to = "(due to #{e.message} - #{e.class})"
         message = error_message connection
 

data/test/test_net_http_persistent.rb

@@ -783,5 +783,17 @@ class TestNetHttpPersistent < MiniTest::Unit::TestCase
     assert_equal OpenSSL::SSL::VERIFY_NONE, c.verify_mode
   end
 
+  def test_can_retry_change_requests
+    get  = Net::HTTP::Get.new('/')
+    post = Net::HTTP::Post.new('/')
+    assert @http.can_retry?(get)
+    refute @http.retry_change_requests
+    refute @http.can_retry?(post)
+    @http.retry_change_requests = true
+    assert @http.can_retry?(get)
+    assert @http.retry_change_requests
+    assert @http.can_retry?(post)
+  end
+
 end
 

metadata

@@ -1,12 +1,12 @@
 --- !ruby/object:Gem::Specification 
 name: net-http-persistent
 version: !ruby/object:Gem::Version 
-  hash: 1
+  hash: 31
   prerelease: 
   segments: 
   - 1
-  - 7
-  version: "1.7"
+  - 8
+  version: "1.8"
 platform: ruby
 authors: 
 - Eric Hodel
@@ -35,7 +35,7 @@ cert_chain:
   x52qPcexcYZR7w==
   -----END CERTIFICATE-----
 
-date: 2011-04-17 00:00:00 Z
+date: 2011-06-27 00:00:00 Z
 dependencies: 
 - !ruby/object:Gem::Dependency 
   name: minitest
@@ -45,12 +45,12 @@ dependencies:
     requirements: 
     - - ">="
       - !ruby/object:Gem::Version 
-        hash: 11
+        hash: 1
         segments: 
         - 2
-        - 0
-        - 2
-        version: 2.0.2
+        - 3
+        - 1
+        version: 2.3.1
   type: :development
   version_requirements: *id001
 - !ruby/object:Gem::Dependency 
@@ -59,14 +59,13 @@ dependencies:
   requirement: &id002 !ruby/object:Gem::Requirement 
     none: false
     requirements: 
-    - - ">="
+    - - ~>
       - !ruby/object:Gem::Version 
-        hash: 35
+        hash: 17
         segments: 
         - 2
         - 9
-        - 4
-        version: 2.9.4
+        version: "2.9"
   type: :development
   version_requirements: *id002
 description: |-
@@ -130,7 +129,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
 requirements: []
 
 rubyforge_project: net-http-persistent
-rubygems_version: 1.7.2
+rubygems_version: 1.8.5
 signing_key: 
 specification_version: 3
 summary: Manages persistent connections using Net::HTTP plus a speed fix for 1.8