net-http-persistent 1.6 → 1.6.1

data/History.txt

@@ -1,3 +1,9 @@
+=== 1.6.1 / 2011-03-08
+
+* Bug Fix
+  * Net::HTTP::Persistent#request now handles Errno::EINVAL as a connection
+    reset and will be retried for idempotent requests.
+
 === 1.6 / 2011-03-01
 
 * Minor Engancement

data/README.txt

@@ -1,12 +1,21 @@
 = net-http-persistent
 
 * http://seattlerb.rubyforge.org/net-http-persistent
+* https://github.com/drbrain/net-http-persistent
 
 == DESCRIPTION:
 
-Persistent connections using Net::HTTP plus a speed fix for 1.8.  It's
+Manages persistent connections using Net::HTTP plus a speed fix for 1.8.  It's
 thread-safe too!
 
+Using persistent HTTP connections can dramatically increase the speed of HTTP.
+Creating a new HTTP connection for every request involves an extra TCP
+round-trip and causes TCP congestion avoidance negotiation to start over.
+
+Net::HTTP supports persistent connections with some API methods but does not
+handle reconnection gracefully.  net-http-persistent supports reconnection
+according to RFC 2616.
+
 == FEATURES/PROBLEMS:
 
 * Supports SSL

data/Rakefile

@@ -5,11 +5,12 @@ require 'hoe'
 
 Hoe.plugin :git
 Hoe.plugin :minitest
-Hoe.plugin :rubyforge
 
 Hoe.spec 'net-http-persistent' do |p|
-  self.rubyforge_name = 'seattlerb'
   developer 'Eric Hodel', 'drbrain@segment7.net'
+
+  rdoc_locations <<
+    'docs.seattlerb.org:/data/www/docs.seattlerb.org/net-http-persistent/'
 end
 
 # vim: syntax=Ruby

data/lib/net/http/persistent.rb

@@ -37,7 +37,7 @@ class Net::HTTP::Persistent
   ##
   # The version of Net::HTTP::Persistent use are using
 
-  VERSION = '1.6'
+  VERSION = '1.6.1'
 
   ##
   # Error class for errors raised by Net::HTTP::Persistent.  Various
@@ -392,7 +392,8 @@ class Net::HTTP::Persistent
       bad_response = true
       retry
     rescue IOError, EOFError, Timeout::Error,
-           Errno::ECONNABORTED, Errno::ECONNRESET, Errno::EPIPE => e
+           Errno::ECONNABORTED, Errno::ECONNRESET, Errno::EPIPE,
+           Errno::EINVAL => e
 
       if retried or not idempotent? req
         due_to = "(due to #{e.message} - #{e.class})"

data/test/test_net_http_persistent.rb

@@ -522,6 +522,35 @@ class TestNetHttpPersistent < MiniTest::Unit::TestCase
     assert_equal 1, reqs[c.object_id]
   end
 
+  def test_request_invalid
+    c = basic_connection
+    def c.request(*a) raise Errno::EINVAL, "write" end
+
+    e = assert_raises Net::HTTP::Persistent::Error do
+      @http.request @uri
+    end
+
+    assert_equal 0, reqs[c.object_id]
+    assert_match %r%too many connection resets%, e.message
+  end
+
+  def test_request_invalid_retry
+    c = basic_connection
+    def c.request(*a)
+      if defined? @called then
+        Net::HTTPResponse.allocate
+      else
+        @called = true
+        raise Errno::EINVAL, "write"
+      end
+    end
+
+    @http.request @uri
+
+    assert c.reset?
+    assert c.finished?
+  end
+
   def test_request_reset
     c = basic_connection
     def c.request(*a) raise Errno::ECONNRESET end

metadata

@@ -1,12 +1,13 @@
 --- !ruby/object:Gem::Specification 
 name: net-http-persistent
 version: !ruby/object:Gem::Version 
-  hash: 3
+  hash: 13
   prerelease: 
   segments: 
   - 1
   - 6
-  version: "1.6"
+  - 1
+  version: 1.6.1
 platform: ruby
 authors: 
 - Eric Hodel
@@ -35,7 +36,7 @@ cert_chain:
   x52qPcexcYZR7w==
   -----END CERTIFICATE-----
 
-date: 2011-03-01 00:00:00 -08:00
+date: 2011-03-08 00:00:00 -08:00
 default_executable: 
 dependencies: 
 - !ruby/object:Gem::Dependency 
@@ -54,41 +55,33 @@ dependencies:
         version: 2.0.2
   type: :development
   version_requirements: *id001
-- !ruby/object:Gem::Dependency 
-  name: rubyforge
-  prerelease: false
-  requirement: &id002 !ruby/object:Gem::Requirement 
-    none: false
-    requirements: 
-    - - ">="
-      - !ruby/object:Gem::Version 
-        hash: 7
-        segments: 
-        - 2
-        - 0
-        - 4
-        version: 2.0.4
-  type: :development
-  version_requirements: *id002
 - !ruby/object:Gem::Dependency 
   name: hoe
   prerelease: false
-  requirement: &id003 !ruby/object:Gem::Requirement 
+  requirement: &id002 !ruby/object:Gem::Requirement 
     none: false
     requirements: 
     - - ">="
       - !ruby/object:Gem::Version 
-        hash: 43
+        hash: 41
         segments: 
         - 2
         - 9
-        - 0
-        version: 2.9.0
+        - 1
+        version: 2.9.1
   type: :development
-  version_requirements: *id003
+  version_requirements: *id002
 description: |-
-  Persistent connections using Net::HTTP plus a speed fix for 1.8.  It's
+  Manages persistent connections using Net::HTTP plus a speed fix for 1.8.  It's
   thread-safe too!
+  
+  Using persistent HTTP connections can dramatically increase the speed of HTTP.
+  Creating a new HTTP connection for every request involves an extra TCP
+  round-trip and causes TCP congestion avoidance negotiation to start over.
+  
+  Net::HTTP supports persistent connections with some API methods but does not
+  handle reconnection gracefully.  net-http-persistent supports reconnection
+  according to RFC 2616.
 email: 
 - drbrain@segment7.net
 executables: []
@@ -139,10 +132,10 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: "0"
 requirements: []
 
-rubyforge_project: seattlerb
-rubygems_version: 1.6.0
+rubyforge_project: net-http-persistent
+rubygems_version: 1.6.1
 signing_key: 
 specification_version: 3
-summary: Persistent connections using Net::HTTP plus a speed fix for 1.8
+summary: Manages persistent connections using Net::HTTP plus a speed fix for 1.8
 test_files: 
 - test/test_net_http_persistent.rb