net-http-persistent 1.2.4 → 1.2.5

data/History.txt

@@ -1,3 +1,9 @@
+=== 1.2.5 / 2010-07-27
+
+* Bug Fixes
+  * Fix duplicated test name.  Noted by Peter Higgins.
+  * #shutdown now works even when no connections were made.
+
 === 1.2.4 / 2010-07-26
 
 * Bug Fixes

data/lib/net/http/persistent.rb

@@ -36,7 +36,7 @@ class Net::HTTP::Persistent
   ##
   # The version of Net::HTTP::Persistent use are using
 
-  VERSION = '1.2.4'
+  VERSION = '1.2.5'
 
   ##
   # Error class for errors raised by Net::HTTP::Persistent.  Various
@@ -375,9 +375,11 @@ class Net::HTTP::Persistent
   # this in each thread.
 
   def shutdown
-    Thread.current[@connection_key].each do |_, connection|
+    connections = Thread.current[@connection_key]
+
+    connections.each do |_, connection|
       connection.finish
-    end
+    end if connections
 
     Thread.current[@connection_key] = nil
     Thread.current[@request_key]    = nil

data/test/test_net_http_persistent.rb

@@ -369,7 +369,7 @@ class TestNetHttpPersistent < MiniTest::Unit::TestCase
     assert_match %r%too many bad responses%, e.message
   end
 
-  def test_request_reset_retry
+  def test_request_bad_response_retry
     c = connection
     def c.request(*a)
       def self.request(*a)
@@ -505,6 +505,13 @@ class TestNetHttpPersistent < MiniTest::Unit::TestCase
     refute_same rs, reqs
   end
 
+  def test_shutdown_no_connections
+    @http.shutdown
+
+    assert_nil Thread.current[@http.connection_key]
+    assert_nil Thread.current[@http.request_key]
+  end
+
   def test_ssl
     @http.verify_callback = :callback
     c = Net::HTTP.new 'localhost', 80

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification 
 name: net-http-persistent
 version: !ruby/object:Gem::Version 
-  hash: 23
+  hash: 21
   prerelease: false
   segments: 
   - 1
   - 2
-  - 4
-  version: 1.2.4
+  - 5
+  version: 1.2.5
 platform: ruby
 authors: 
 - Eric Hodel
@@ -36,7 +36,7 @@ cert_chain:
   x52qPcexcYZR7w==
   -----END CERTIFICATE-----
 
-date: 2010-07-26 00:00:00 -07:00
+date: 2010-07-27 00:00:00 -07:00
 default_executable: 
 dependencies: 
 - !ruby/object:Gem::Dependency