net-hippie 0.2.6 → 1.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 5d1f9e15a11440c2c2468f74058b5149f192e4ad06ae6294611fb5338e647773
-  data.tar.gz: a4d57905ab58bff0f00749087204dfd310e68a3b5089c29a0848e496a1c21bd8
+  metadata.gz: ca969a22c79466a3c517f262f6a7c72137a62304b358b2f1caeec7849e222357
+  data.tar.gz: e9faffeec00a494e39f795d5ab3d32c7f58e9027e3ec79106256ae2b7b70d6f0
 SHA512:
-  metadata.gz: 6f097e0155295f4b1a8db79f355660a00f85567e01fea8b12b31ea054da73122428f79b1be4f43e7b112814251ffc1be897c143cc205f98c92bb5a8cec422922
-  data.tar.gz: b93b6026fc81629f532f64b52e4fbb694a553e275affb4514e336e087fee71a429325012e4bcba258a8d73f16063011a6dfcc9453b3e47dda9ab35ea96895eeb
+  metadata.gz: 035f5e34f31997473705d0556ee16e3e038c004fff44065c7ac86c1ffa2abd659cf0eb7ef1ff44baf51f31c7113e623621d627fd5fbccc478616585a10b59aa0
+  data.tar.gz: f86f16b3fa730239cf81683a1087a275633b88cee991358e7ad282db965b18f9293fc4bf8de6c991dee7ad2921de5413bcbcd6abdb178a42d2f77c2da523fcc1

data/.github/workflows/test.yml

@@ -0,0 +1,17 @@
+name: Test
+
+on: [push, pull_request]
+
+jobs:
+  test:
+    runs-on: ubuntu-latest
+    strategy:
+      matrix:
+        ruby: [ '2.5', '2.6', '2.7' ]
+    steps:
+    - uses: actions/checkout@v1
+    - uses: actions/setup-ruby@v1
+      with:
+        ruby-version: ${{ matrix.ruby }}
+    - name: cibuild
+      run: bin/cibuild

data/.rubocop.yml

@@ -5,9 +5,10 @@ AllCops:
     - 'test/**/*'
     - 'tmp/**/*'
     - 'vendor/**/*'
-  TargetRubyVersion: 2.6
+  NewCops: enable
+  TargetRubyVersion: 2.5
 
-Layout/AlignParameters:
+Layout/ParameterAlignment:
   EnforcedStyle: with_fixed_indentation
 
 Naming/RescuedExceptionsVariableName:

data/CHANGELOG.md

@@ -1,4 +1,5 @@
-Version 0.2.6
+Version 1.0.0
+
 # Changelog
 All notable changes to this project will be documented in this file.
 
@@ -7,6 +8,42 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [Unreleased]
 
+## [1.0.0] - 2020-07-31
+### Added
+- Add simpler API to remove the need to instantiate a `Client` directly.
+- Default to 3 retries using simple API.
+- Re-use client connection for connections to the same scheme, host, and port.
+
+### Removed
+- Remove support for Ruby 2.4
+- Remove legacy `Api` class.
+
+### Changed
+- Limit mutable options on Client.
+- Change default `read_timeout` to 10 seconds.
+- Change default `open_timeout` to 10 seconds.
+- Log to `STDERR` by default instead of `STDOUT`.
+
+## [0.3.2] - 2020-01-28
+### Fixed
+- Follow relative path redirects
+
+## [0.3.1] - 2020-01-14
+### Fixed
+- Parse location header in response then follow redirect.
+- Follow redirect using GET regardless of the original request method.
+
+## [0.3.0] - 2020-01-13
+### Added
+- Allow following HTTP redirects.
+
+## [0.2.7] - 2019-10-04
+### Added
+- add additional connection errors
+
+### Changed
+- specify ruby 2.4 and minimum required.
+
 ## [0.2.6] - 2019-04-30
 ### Added
 - add support for PATCH verb.
@@ -32,7 +69,12 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 - with\_retry.https://www.mokhan.ca/%F0%9F%92%8E/2018/11/10/net-hippie-0-2-0.html
 - authorization header helpers
 
-[Unreleased]: https://github.com/mokhan/net-hippie/compare/v0.2.6...HEAD
+[Unreleased]: https://github.com/mokhan/net-hippie/compare/v1.0.0...HEAD
+[1.0.0]: https://github.com/mokhan/net-hippie/compare/v0.3.2...v1.0.0
+[0.3.2]: https://github.com/mokhan/net-hippie/compare/v0.3.1...v0.3.2
+[0.3.1]: https://github.com/mokhan/net-hippie/compare/v0.3.0...v0.3.1
+[0.3.0]: https://github.com/mokhan/net-hippie/compare/v0.2.7...v0.3.0
+[0.2.7]: https://github.com/mokhan/net-hippie/compare/v0.2.6...v0.2.7
 [0.2.6]: https://github.com/mokhan/net-hippie/compare/v0.2.5...v0.2.6
 [0.2.5]: https://github.com/mokhan/net-hippie/compare/v0.2.4...v0.2.5
 [0.2.4]: https://github.com/mokhan/net-hippie/compare/v0.2.3...v0.2.4

data/Gemfile

@@ -2,7 +2,5 @@
 
 source 'https://rubygems.org'
 
-git_source(:github) { |repo_name| "https://github.com/#{repo_name}" }
-
 # Specify your gem's dependencies in net-hippie.gemspec
 gemspec

data/README.md

@@ -1,10 +1,10 @@
 # Net::Hippie
 
 [![Gem Version](https://badge.fury.io/rb/net-hippie.svg)](https://rubygems.org/gems/net-hippie)
-[![Build Status](https://travis-ci.org/mokhan/net-hippie.svg?branch=master)](https://travis-ci.org/mokhan/net-hippie)
+[![Build Status](https://github.com/mokhan/net-hippie/workflows/Test/badge.svg)](https://github.com/mokhan/net-hippie/actions)
 
-Net::Hippie is a light weight wrapper around `net/http` that defaults to
-sending JSON messages.
+`Net::Hippie` is a light weight wrapper around `net/http` that defaults to
+sending `JSON` messages.
 
 ## Installation
 
@@ -27,23 +27,22 @@ Or install it yourself as:
 ```ruby
 require 'net/hippie'
 
-Net::Hippie.logger = Rails.logger
-
-client = Net::Hippie::Client.new
+Net::Hippie.logger = Logger.new(STDERR)
 
 headers = {
   'Accept' => 'application/vnd.haveibeenpwned.v2+json'
 }
 
-uri = URI.parse('https://haveibeenpwned.com/api/breaches')
-response = client.get(uri, headers: headers)
+uri = 'https://haveibeenpwned.com/api/breaches'
+response = Net::Hippie.get(uri, headers: headers)
 puts JSON.parse(response.body)
 ```
 
 ```ruby
-client = Net::Hippie::Client.new
-body = { user: { name: 'hippie' } }
-response = client.post(URI.parse('https://example.org'), body: body)
+response = Net::Hippie.post(
+  'https://example.org',
+  body: { name: 'hippie' }
+)
 puts JSON.parse(response.body)
 ```
 
@@ -69,24 +68,30 @@ client = Net::Hippie::Client.new(
 ### Basic Auth
 
 ```ruby
-client = Net::Hippie::Client.new
-headers = { 'Authorization' => Net::Hippie.basic_auth('username', 'password') }
-client.get('https://www.example.org', headers: headers)
+Net::Hippie.get(
+  'https://www.example.org',
+  headers: {
+    'Authorization' => Net::Hippie.basic_auth('username', 'password')
+  }
+)
 ```
 
 ### Bearer Auth
 
 ```ruby
-client = Net::Hippie::Client.new
 headers = { 'Authorization' => Net::Hippie.bearer_auth('token') }
-client.get('https://www.example.org', headers: headers)
+Net::Hippie.get('https://www.example.org', headers: headers)
 ```
 
 ## Development
 
-After checking out the repo, run `bin/setup` to install dependencies. Then, run `rake test` to run the tests. You can also run `bin/console` for an interactive prompt that will allow you to experiment.
+After checking out the repo, run `bin/setup` to install dependencies. Then, run `bin/test` to run the tests.
+You can also run `bin/console` for an interactive prompt that will allow you to experiment.
 
-To install this gem onto your local machine, run `bundle exec rake install`. To release a new version, update the version number in `version.rb`, and then run `bundle exec rake release`, which will create a git tag for the version, push git commits and tags, and push the `.gem` file to [rubygems.org](https://rubygems.org).
+To install this gem onto your local machine, run `bundle exec rake install`.
+To release a new version, update the version number in `version.rb`,
+and then run `bin/shipit`, which will create a git tag for the version,
+push git commits and tags, and push the `.gem` file to [rubygems.org](https://rubygems.org).
 
 ## Contributing
 

data/Rakefile

@@ -6,7 +6,7 @@ require 'rubocop/rake_task'
 
 Rake::TestTask.new(:test) do |t|
   t.libs << 'test'
-  t.libs << 'lib'
+  t.verbose = true
   t.test_files = FileList['test/**/*_test.rb']
 end
 RuboCop::RakeTask.new(:rubocop)

data/bin/cibuild

@@ -1,15 +1,10 @@
 #!/bin/sh
 
-# script/cibuild: Setup environment for CI to run tests. This is primarily
-#                 designed to run on the continuous integration server.
-
 set -e
+[ -z "$DEBUG" ] || set -x
 
 cd "$(dirname "$0")/.."
 
-echo [$(date "+%H:%M:%S")] "==> Started at…"
-
-# GC customizations
 export RUBY_GC_MALLOC_LIMIT=79000000
 export RUBY_GC_HEAP_INIT_SLOTS=800000
 export RUBY_HEAP_FREE_MIN=100000
@@ -17,7 +12,11 @@ export RUBY_HEAP_SLOTS_INCREMENT=400000
 export RUBY_HEAP_SLOTS_GROWTH_FACTOR=1
 export CIBUILD=1
 
-ruby -v
-gem install bundler:2.0.1 --conservative
+echo "[$(date "+%H:%M:%S")] ==> Running setup…"
+bin/setup
+
+echo "[$(date "+%H:%M:%S")] ==> Running tests…"
 bin/test
+
+echo "[$(date "+%H:%M:%S")] ==> Running linters…"
 bin/lint

data/bin/lint

@@ -2,7 +2,4 @@
 
 set -e
 
-[ -z "$DEBUG" ] || set -x
-
-echo [$(date "+%H:%M:%S")] "==> Running linters…"
 bundle exec rake lint

data/bin/setup

@@ -1,8 +1,7 @@
 #!/usr/bin/env bash
 set -euo pipefail
 IFS=$'\n\t'
-set -vx
 
+ruby -v
+gem install bundler -v '~> 2.0'
 bundle install
-
-# Do any other automated setup that you need to do here

data/bin/test

@@ -1,17 +1,7 @@
 #!/bin/sh
 
-# script/test: Run test suite for application. Optionally pass in a path to an
-#              individual test file to run a single test.
-
-
 set -e
 
 cd "$(dirname "$0")/.."
 
-[ -z "$DEBUG" ] || set -x
-
-echo [$(date "+%H:%M:%S")] "==> Running setup…"
-bin/setup
-
-echo [$(date "+%H:%M:%S")] "==> Running tests…"
 bundle exec rake test

data/lib/net/hippie.rb

@@ -6,24 +6,32 @@ require 'logger'
 require 'net/http'
 require 'openssl'
 
-require 'net/hippie/version'
-require 'net/hippie/content_type_mapper'
 require 'net/hippie/client'
-require 'net/hippie/api'
+require 'net/hippie/connection'
+require 'net/hippie/content_type_mapper'
+require 'net/hippie/version'
 
 module Net
   # net/http for hippies.
   module Hippie
     CONNECTION_ERRORS = [
       EOFError,
+      Errno::ECONNREFUSED,
+      Errno::ECONNRESET,
       Errno::ECONNRESET,
+      Errno::EHOSTUNREACH,
       Errno::EINVAL,
+      Net::OpenTimeout,
       Net::ProtocolError,
+      Net::ReadTimeout,
+      OpenSSL::OpenSSLError,
+      OpenSSL::SSL::SSLError,
+      SocketError,
       Timeout::Error
     ].freeze
 
     def self.logger
-      @logger ||= Logger.new(STDOUT)
+      @logger ||= Logger.new(STDERR)
     end
 
     def self.logger=(logger)
@@ -45,5 +53,19 @@ module Net
     def self.bearer_auth(token)
       "Bearer #{token}"
     end
+
+    def self.method_missing(symbol, *args)
+      default_client.with_retry(retries: 3) do |client|
+        client.public_send(symbol, *args)
+      end || super
+    end
+
+    def self.respond_to_missing?(name, _include_private = false)
+      Client.public_instance_methods.include?(name.to_sym)
+    end
+
+    def self.default_client
+      @default_client ||= Client.new(follow_redirects: 3, logger: logger)
+    end
   end
 end

data/lib/net/hippie/client.rb

@@ -10,55 +10,50 @@ module Net
         'User-Agent' => "net/hippie #{Net::Hippie::VERSION}"
       }.freeze
 
-      attr_accessor :mapper, :read_timeout, :open_timeout, :logger
-
-      def initialize(certificate: nil, headers: DEFAULT_HEADERS,
-        key: nil, passphrase: nil, verify_mode: Net::Hippie.verify_mode)
-        @certificate = certificate
-        @default_headers = headers
-        @key = key
-        @mapper = ContentTypeMapper.new
-        @passphrase = passphrase
-        @read_timeout = 30
-        @verify_mode = verify_mode
-        @logger = Net::Hippie.logger
+      attr_reader :mapper, :logger, :follow_redirects
+
+      def initialize(options = {})
+        @options = options
+        @mapper = options.fetch(:mapper, ContentTypeMapper.new)
+        @logger = options.fetch(:logger, Net::Hippie.logger)
+        @follow_redirects = options.fetch(:follow_redirects, 0)
+        @default_headers = options.fetch(:headers, DEFAULT_HEADERS)
+        @connections = Hash.new do |hash, key|
+          scheme, host, port = key
+          hash[key] = Connection.new(scheme, host, port, options)
+        end
       end
 
-      def execute(uri, request)
-        response = http_for(normalize_uri(uri)).request(request)
-        if block_given?
-          yield request, response
+      def execute(uri, request, limit: follow_redirects, &block)
+        connection = connection_for(uri)
+        response = connection.run(request)
+        if limit.positive? && response.is_a?(Net::HTTPRedirection)
+          url = connection.build_url_for(response['location'])
+          request = request_for(Net::HTTP::Get, url)
+          execute(url, request, limit: limit - 1, &block)
         else
-          response
+          block_given? ? yield(request, response) : response
         end
       end
 
       def get(uri, headers: {}, body: {}, &block)
-        request = request_for(Net::HTTP::Get, uri, headers: headers, body: body)
-        execute(uri, request, &block)
+        run(uri, Net::HTTP::Get, headers, body, &block)
       end
 
       def patch(uri, headers: {}, body: {}, &block)
-        type = Net::HTTP::Patch
-        request = request_for(type, uri, headers: headers, body: body)
-        execute(uri, request, &block)
+        run(uri, Net::HTTP::Patch, headers, body, &block)
       end
 
       def post(uri, headers: {}, body: {}, &block)
-        type = Net::HTTP::Post
-        request = request_for(type, uri, headers: headers, body: body)
-        execute(uri, request, &block)
+        run(uri, Net::HTTP::Post, headers, body, &block)
       end
 
       def put(uri, headers: {}, body: {}, &block)
-        request = request_for(Net::HTTP::Put, uri, headers: headers, body: body)
-        execute(uri, request, &block)
+        run(uri, Net::HTTP::Put, headers, body, &block)
       end
 
       def delete(uri, headers: {}, body: {}, &block)
-        type = Net::HTTP::Delete
-        request = request_for(type, uri, headers: headers, body: body)
-        execute(uri, request, &block)
+        run(uri, Net::HTTP::Delete, headers, body, &block)
       end
 
       # attempt 1 -> delay 0.1 second
@@ -82,8 +77,6 @@ module Net
       private
 
       attr_reader :default_headers
-      attr_reader :verify_mode
-      attr_reader :certificate, :key, :passphrase
 
       def attempt(attempt, max)
         yield
@@ -91,45 +84,25 @@ module Net
         raise error if attempt == max
 
         delay = ((2**attempt) * 0.1) + Random.rand(0.05) # delay + jitter
-        warn("`#{error.message}` Retry: #{attempt + 1}/#{max} Delay: #{delay}s")
+        logger.warn("`#{error.message}` #{attempt + 1}/#{max} Delay: #{delay}s")
         sleep delay
       end
 
-      def http_for(uri)
-        http = Net::HTTP.new(uri.host, uri.port)
-        http.read_timeout = read_timeout
-        http.open_timeout = open_timeout if open_timeout
-        http.use_ssl = uri.scheme == 'https'
-        http.verify_mode = verify_mode
-        http.set_debug_output(logger)
-        apply_client_tls_to(http)
-        http
-      end
-
       def request_for(type, uri, headers: {}, body: {})
         final_headers = default_headers.merge(headers)
-        type.new(uri.to_s, final_headers).tap do |x|
+        type.new(URI.parse(uri.to_s), final_headers).tap do |x|
           x.body = mapper.map_from(final_headers, body) unless body.empty?
         end
       end
 
-      def normalize_uri(uri)
-        uri.is_a?(URI) ? uri : URI.parse(uri)
-      end
-
-      def private_key(type = OpenSSL::PKey::RSA)
-        passphrase ? type.new(key, passphrase) : type.new(key)
-      end
-
-      def apply_client_tls_to(http)
-        return if certificate.nil? || key.nil?
-
-        http.cert = OpenSSL::X509::Certificate.new(certificate)
-        http.key = private_key
+      def run(uri, http_method, headers, body, &block)
+        request = request_for(http_method, uri, headers: headers, body: body)
+        execute(uri, request, &block)
       end
 
-      def warn(message)
-        logger.warn(message)
+      def connection_for(uri)
+        uri = URI.parse(uri.to_s)
+        @connections[[uri.scheme, uri.host, uri.port]]
       end
     end
   end

data/lib/net/hippie/connection.rb

@@ -0,0 +1,42 @@
+# frozen_string_literal: true
+
+module Net
+  module Hippie
+    # A connection to a specific host
+    class Connection
+      def initialize(scheme, host, port, options = {})
+        http = Net::HTTP.new(host, port)
+        http.read_timeout = options.fetch(:read_timeout, 10)
+        http.open_timeout = options.fetch(:open_timeout, 10)
+        http.use_ssl = scheme == 'https'
+        http.verify_mode = options.fetch(:verify_mode, Net::Hippie.verify_mode)
+        http.set_debug_output(options.fetch(:logger, Net::Hippie.logger))
+        apply_client_tls_to(http, options)
+        @http = http
+      end
+
+      def run(request)
+        @http.request(request)
+      end
+
+      def build_url_for(path)
+        return path if path.start_with?('http')
+
+        "#{@http.use_ssl? ? 'https' : 'http'}://#{@http.address}#{path}"
+      end
+
+      private
+
+      def apply_client_tls_to(http, options)
+        return if options[:certificate].nil? || options[:key].nil?
+
+        http.cert = OpenSSL::X509::Certificate.new(options[:certificate])
+        http.key = private_key(options[:key], options[:passphrase])
+      end
+
+      def private_key(key, passphrase, type = OpenSSL::PKey::RSA)
+        passphrase ? type.new(key, passphrase) : type.new(key)
+      end
+    end
+  end
+end

data/lib/net/hippie/content_type_mapper.rb

@@ -5,6 +5,8 @@ module Net
     # Converts a ruby hash into a JSON string
     class ContentTypeMapper
       def map_from(headers, body)
+        return body if body.is_a?(String)
+
         content_type = headers['Content-Type'] || ''
         return JSON.generate(body) if content_type.include?('json')
 

data/lib/net/hippie/version.rb

@@ -2,6 +2,6 @@
 
 module Net
   module Hippie
-    VERSION = '0.2.6'
+    VERSION = '1.0.0'
   end
 end

data/net-hippie.gemspec

@@ -21,10 +21,11 @@ Gem::Specification.new do |spec|
   spec.bindir        = 'exe'
   spec.executables   = spec.files.grep(%r{^exe/}) { |f| File.basename(f) }
   spec.require_paths = ['lib']
+  spec.required_ruby_version = '~> 2.5'
 
   spec.add_development_dependency 'minitest', '~> 5.0'
-  spec.add_development_dependency 'rake', '~> 10.0'
+  spec.add_development_dependency 'rake', '~> 13.0'
   spec.add_development_dependency 'rubocop', '~> 0.55'
-  spec.add_development_dependency 'vcr', '~> 4.0'
+  spec.add_development_dependency 'vcr', '~> 6.0'
   spec.add_development_dependency 'webmock', '~> 3.4'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: net-hippie
 version: !ruby/object:Gem::Version
-  version: 0.2.6
+  version: 1.0.0
 platform: ruby
 authors:
 - mo
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2019-04-30 00:00:00.000000000 Z
+date: 2020-08-01 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: minitest
@@ -30,14 +30,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '10.0'
+        version: '13.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '10.0'
+        version: '13.0'
 - !ruby/object:Gem::Dependency
   name: rubocop
   requirement: !ruby/object:Gem::Requirement
@@ -58,14 +58,14 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '4.0'
+        version: '6.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '4.0'
+        version: '6.0'
 - !ruby/object:Gem::Dependency
   name: webmock
   requirement: !ruby/object:Gem::Requirement
@@ -88,10 +88,10 @@ executables:
 extensions: []
 extra_rdoc_files: []
 files:
+- ".github/workflows/test.yml"
 - ".gitignore"
 - ".gitlab-ci.yml"
 - ".rubocop.yml"
-- ".travis.yml"
 - CHANGELOG.md
 - Gemfile
 - LICENSE.txt
@@ -105,8 +105,8 @@ files:
 - bin/test
 - exe/net-hippie
 - lib/net/hippie.rb
-- lib/net/hippie/api.rb
 - lib/net/hippie/client.rb
+- lib/net/hippie/connection.rb
 - lib/net/hippie/content_type_mapper.rb
 - lib/net/hippie/version.rb
 - net-hippie.gemspec
@@ -120,16 +120,16 @@ require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
-  - - ">="
+  - - "~>"
     - !ruby/object:Gem::Version
-      version: '0'
+      version: '2.5'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.0.3
+rubygems_version: 3.1.4
 signing_key: 
 specification_version: 4
 summary: net/http for hippies. ☮️

data/.travis.yml

@@ -1,8 +0,0 @@
-sudo: false
-language: ruby
-rvm:
-  - 2.4.5
-  - 2.5.5
-  - 2.6.3
-script:
-  - bin/cibuild

data/lib/net/hippie/api.rb

@@ -1,29 +0,0 @@
-# frozen_string_literal: true
-
-module Net
-  module Hippie
-    # A no nonsense class to perform HTTP requests.
-    class Api
-      attr_reader :uri, :verify_mode
-
-      def initialize(url, verify_none: false)
-        @uri = URI.parse(url)
-        @verify_mode = OpenSSL::SSL::VERIFY_NONE if verify_none
-      end
-
-      def get
-        client.get(uri).body
-      end
-
-      def execute(request)
-        client.execute(uri, request)
-      end
-
-      private
-
-      def client
-        @client ||= Client.new(headers: {}, verify_mode: verify_mode)
-      end
-    end
-  end
-end