net-github-upload 0.0.3 → 0.0.4

data/Rakefile

@@ -75,12 +75,12 @@ end
 
 desc "gem install"
 task :install => [:package] do
-  sh "sudo gem install pkg/#{$name}-#{$version}.gem --local"
+  sh "gem install pkg/#{$name}-#{$version}.gem --local"
 end
 
 desc "gem uninstall"
 task :uninstall do
-  sh "sudo gem uninstall #{$name}"
+  sh "gem uninstall #{$name}"
 end
 
 # vim: syntax=ruby

data/lib/net/github-upload.rb

@@ -6,10 +6,14 @@ require 'faster_xml_simple'
 module Net
   module GitHub
     class Upload
-      VERSION = '0.0.3'
+      VERSION = '0.0.4'
       def initialize params=nil
         @login = params[:login]
         @token = params[:token]
+
+        if @login.empty? or @token.empty?
+          raise "login or token is empty"
+        end
       end
 
       def upload info
@@ -46,9 +50,10 @@ module Net
           raise "file '#{info[:name]}' is already uploaded. please try different name"
         end
 
+        info[:content_type] ||= 'application/octet-stream'
         stat = HTTPClient.post("http://github.com/#{info[:repos]}/downloads", {
           "file_size"    => info[:file] ? File.stat(info[:file]).size : info[:data].size,
-          "content_type" => info[:content_type] || 'application/octet-stream',
+          "content_type" => info[:content_type],
           "file_name"    => info[:name],
           "description"  => info[:description] || '',
           "login"        => @login,
@@ -68,7 +73,6 @@ module Net
             ['success_action_status', 201],
             ['key', upload_info['prefix'] + info[:name]],
             ['AWSAccessKeyId', upload_info['accesskeyid']],
-            ['Content-Type', info[:content_type] || 'application/octet-stream'],
             ['signature', upload_info['signature']],
             ['acl', upload_info['acl']],
             ['file', f]
@@ -81,7 +85,6 @@ module Net
             ['success_action_status', 201],
             ['key', upload_info['prefix'] + info[:name]],
             ['AWSAccessKeyId', upload_info['accesskeyid']],
-            ['Content-Type', info[:content_type] || 'application/octet-stream'],
             ['signature', upload_info['signature']],
             ['acl', upload_info['acl']],
             ['file', StringIO.new(info[:data])]
@@ -91,7 +94,7 @@ module Net
         if stat.code == 201
           return FasterXmlSimple.xml_in(stat.content)['PostResponse']['Location']
         else
-          raise 'Failed to upload'
+          raise 'Failed to upload' + extract_error_message(stat)
         end
       end
 
@@ -100,6 +103,17 @@ module Net
       end
 
       private
+
+
+      def extract_error_message(stat)
+        # @see http://docs.amazonwebservices.com/AmazonS3/2006-03-01/ErrorResponses.html
+        error = FasterXmlSimple.xml_in(stat.content)['Error']
+        " due to #{error['Code']} (#{error['Message']})"
+      rescue
+        ''
+      end
+
+
       def list_files repos
         raise "required repository name" unless repos
         res = HTTPClient.get_content("http://github.com/#{repos}/downloads", {

data/test/github_test.rb

@@ -9,7 +9,7 @@ class GitHubUploadTest < Test::Unit::TestCase
 			:login => login,
 			:token => token
 		)
-		@repos = 'taberareloo'
+		@repos = 'ruby-net-github-upload'
 	end
 
 	def test_file_upload

metadata

@@ -1,7 +1,13 @@
 --- !ruby/object:Gem::Specification 
 name: net-github-upload
 version: !ruby/object:Gem::Version 
-  version: 0.0.3
+  hash: 23
+  prerelease: false
+  segments: 
+  - 0
+  - 0
+  - 4
+  version: 0.0.4
 platform: ruby
 authors: 
 - Constellation
@@ -9,39 +15,53 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2010-01-17 00:00:00 +09:00
+date: 2010-08-12 00:00:00 +09:00
 default_executable: 
 dependencies: 
 - !ruby/object:Gem::Dependency 
   name: nokogiri
-  type: :runtime
-  version_requirement: 
-  version_requirements: !ruby/object:Gem::Requirement 
+  prerelease: false
+  requirement: &id001 !ruby/object:Gem::Requirement 
+    none: false
     requirements: 
     - - ">="
       - !ruby/object:Gem::Version 
+        hash: 7
+        segments: 
+        - 1
+        - 4
+        - 0
         version: 1.4.0
-    version: 
+  type: :runtime
+  version_requirements: *id001
 - !ruby/object:Gem::Dependency 
   name: faster_xml_simple
-  type: :runtime
-  version_requirement: 
-  version_requirements: !ruby/object:Gem::Requirement 
+  prerelease: false
+  requirement: &id002 !ruby/object:Gem::Requirement 
+    none: false
     requirements: 
     - - ">="
       - !ruby/object:Gem::Version 
+        hash: 3
+        segments: 
+        - 0
         version: "0"
-    version: 
+  type: :runtime
+  version_requirements: *id002
 - !ruby/object:Gem::Dependency 
   name: httpclient
-  type: :runtime
-  version_requirement: 
-  version_requirements: !ruby/object:Gem::Requirement 
+  prerelease: false
+  requirement: &id003 !ruby/object:Gem::Requirement 
+    none: false
     requirements: 
     - - ">="
       - !ruby/object:Gem::Version 
+        hash: 3
+        segments: 
+        - 0
         version: "0"
-    version: 
+  type: :runtime
+  version_requirements: *id003
 description: |
   Ruby Net::GitHub::Upload is upload user agent for GitHub Downloads
 
@@ -55,8 +75,8 @@ extra_rdoc_files:
 files: 
 - README.rdoc
 - Rakefile
-- test/github_test.rb
 - test/test
+- test/github_test.rb
 - lib/net/github-upload.rb
 has_rdoc: true
 homepage: http://github.com/Constellation/ruby-net-github-upload
@@ -73,21 +93,27 @@ rdoc_options:
 require_paths: 
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement 
+  none: false
   requirements: 
   - - ">="
     - !ruby/object:Gem::Version 
+      hash: 3
+      segments: 
+      - 0
       version: "0"
-  version: 
 required_rubygems_version: !ruby/object:Gem::Requirement 
+  none: false
   requirements: 
   - - ">="
     - !ruby/object:Gem::Version 
+      hash: 3
+      segments: 
+      - 0
       version: "0"
-  version: 
 requirements: []
 
 rubyforge_project: ruby-net-github-upload
-rubygems_version: 1.3.5
+rubygems_version: 1.3.7
 signing_key: 
 specification_version: 3
 summary: ruby porting of Net::GitHub::Upload