net-dns 0.8.0 → 0.9.0

checksums.yaml

@@ -1,15 +1,7 @@
 ---
-!binary "U0hBMQ==":
-  metadata.gz: !binary |-
-    ODAwMGQ4ODMyYTIyZmNkN2NlNjIwMDk3Y2Y0ODNmYmZkODY0NmE4NQ==
-  data.tar.gz: !binary |-
-    NTAzODI5MjhmZWNmZDZmOWEyM2UyMDBkZDRmNmQxY2E4MDE0YjYxYw==
-!binary "U0hBNTEy":
-  metadata.gz: !binary |-
-    YzMzY2RhYjJlNTcyNTllMzQ4ODdlYjkzNjViY2QyNDg4ZTQxNDJhNjA0MDM1
-    OThjMGZjY2EwMmY2ZTNjYTM0NGRmMDM2YzcwMDk0Yzg2MGVjYzNiODYzZDhj
-    M2JjNzExN2FkMTdlMzg5MGE1ZWIyMWJlOTQzMTBmMzYxOTAwYjk=
-  data.tar.gz: !binary |-
-    NDRiZjIyY2UxZTMxMjYxZDM3MjhlYjFiNDAxNDhmNWEwMDRmODNiYjg3MmY3
-    MzQxNWU4ZTlhMGE1ZDQ0MGYzNzBmMTU4YzVkYjc4ZjJlYmQ1NmY0OTE3ZDQ5
-    ZjkwYTNiZmM5ODBlMjM1MWU0Y2I5MmU4ZmI4NWJmNmEzMzRiNTQ=
+SHA256:
+  metadata.gz: 5dc42ad67563fd2c8dff75111f86d918da967e98b0beb1be2797b5a718081a65
+  data.tar.gz: 7dcdef18fe96bde06059de4953787a4f80f352dd49f4d75d1358e44c286477b5
+SHA512:
+  metadata.gz: 29ec0713726b0a5b8ff79e3bedc35dbb9ace5f6e98c4b77e5ceaaf814b1220028ef879e426468e5189364ffc028c2d938f2639420f398701656eb2a562f6cf7b
+  data.tar.gz: a515331bf54ce6c5d2d5971979d333043f02b569d4343f3883b99af92c162669eea0aa1287307573c1455a4f257d970a86bf6c0c717a068b8213879190a63460

data/.gitignore

@@ -3,6 +3,6 @@
 pkg/*
 Gemfile.lock
 
-# YARD artifacts
+# YARD
 .yardoc
 yardoc/

data/.rspec

@@ -0,0 +1 @@
+--colour

data/.rubocop.yml

@@ -0,0 +1,3 @@
+inherit_from:
+  - .rubocop_defaults.yml
+  - .rubocop_todo.yml

data/.rubocop_defaults.yml

@@ -0,0 +1,364 @@
+# This cop requires odd code indentations (as of rubocop 0.57.0)
+# https://github.com/rubocop-hq/rubocop/issues/5956
+Layout/AccessModifierIndentation:
+  Enabled: false
+
+# It causes weird aligments, especially for specs.
+Layout/BlockEndNewline:
+  Enabled: false
+
+# Generally, the keyword style uses a lot of space. This is particularly true when
+# you use case/if statements, in combination with a long-name variable.
+#
+#   invoice_error_message = case error
+#                           when 1 == 1
+#                             do_something
+#                           else
+#                             do_else
+#                           end
+#
+Layout/EndAlignment:
+  EnforcedStyleAlignWith: variable
+
+# [codesmell]
+Lint/HandleExceptions:
+  Enabled: false
+
+# [codesmell]
+Metrics/AbcSize:
+  Enabled: false
+  Exclude:
+  - 'spec/**/*_spec.rb'
+  - 'test/**/*_test.rb'
+
+# [codesmell]
+Metrics/BlockLength:
+  Enabled: false
+
+# [codesmell]
+Metrics/CyclomaticComplexity:
+  Enabled: false
+  Exclude:
+  - 'spec/**/*_spec.rb'
+  - 'test/**/*_test.rb'
+
+# [codesmell]
+Metrics/ClassLength:
+  Enabled: false
+  Exclude:
+  - 'spec/**/*_spec.rb'
+  - 'test/**/*_test.rb'
+
+# [codesmell]
+Metrics/LineLength:
+  Enabled: false
+  Exclude:
+  - 'spec/**/*_spec.rb'
+  - 'test/**/*_test.rb'
+  Max: 100
+
+# [codesmell]
+Metrics/MethodLength:
+  Enabled: false
+  Exclude:
+  - 'spec/**/*_spec.rb'
+  - 'test/**/*_test.rb'
+  Max: 10
+
+# [codesmell]
+Metrics/ModuleLength:
+  Enabled: false
+  Exclude:
+  - 'spec/**/*_spec.rb'
+  - 'test/**/*_test.rb'
+
+# [codesmell]
+Metrics/ParameterLists:
+  Enabled: false
+  Max: 5
+
+# [codesmell]
+Metrics/PerceivedComplexity:
+  Enabled: false
+
+# We tend to use @_name to represent a variable that is memoized,
+# but it should not be accessed directly and kept as private.
+Naming/MemoizedInstanceVariableName:
+  Enabled: false
+
+# We use it from time to time, as it's not always possible (or maintainable)
+# to use simple ? methods.
+# Moreover, it's actually more efficient to not-use predicates:
+# https://github.com/bbatsov/rubocop/issues/3633
+Naming/PredicateName:
+  Enabled: false
+
+# This cop triggers several false positives that make sense in our domain model.
+# For instance, ip is considered an uncommunicative parameter name:
+#
+#   ipv4_to_arpa_name(ip)
+#
+Naming/UncommunicativeMethodParamName:
+  Enabled: false
+
+# [codesmell]
+# I don't really get the point of this cop.
+Performance/RedundantMerge:
+  Enabled: false
+
+# This cop returns false positive violations (as of rubocop 0.57.0)
+# https://github.com/rubocop-hq/rubocop/issues/5953
+Style/AccessModifierDeclarations:
+  Enabled: false
+
+# Do not use "and" or "or" in conditionals, but for readability we can use it
+# to chain executions. Just beware of operator order.
+Style/AndOr:
+  EnforcedStyle: conditionals
+
+# No specific reason, except that %q() is easier to grep than %()
+Style/BarePercentLiterals:
+  EnforcedStyle: percent_q
+
+# braces_for_chaining seems a good fit of what we've been doing so far.
+Style/BlockDelimiters:
+  EnforcedStyle: braces_for_chaining
+  IgnoredMethods:
+  - expect
+
+# I'm not sure we should enforce a style,
+# but if we do, context_dependent offers a good compromise on readability.
+Style/BracesAroundHashParameters:
+  Enabled: false
+  EnforcedStyle: context_dependent
+
+# Warn on empty else.
+Style/EmptyElse:
+  EnforcedStyle: empty
+
+# There is no specific preference for empty methods.
+# One-line methods are not exceptionally nice in Ruby. Just ignore this cop for now.
+Style/EmptyMethod:
+  Enabled: false
+
+# We don't care about the format style.
+# In most cases we use %, but not at the point we want to enforce it
+# as a convention in the entire code.
+Style/FormatString:
+  Enabled: false
+
+# Annotated tokens (like %<foo>s) are a good thing, but in most cases we don't need them.
+# %s is a simpler and straightforward version that works in almost all cases. So don't complain.
+Style/FormatStringToken:
+  Enabled: false
+
+# We don't support frozen strings.
+# This is an experimental feature and we don't know if it will be shipped with
+# Ruby 3.0 or not.
+Style/FrozenStringLiteralComment:
+  Enabled: false
+
+# Prefer the latest Hash syntax
+Style/HashSyntax:
+  Exclude:
+  # But Rakefiles generally have some definition like
+  #   :default => :test
+  # that looks nicer with the old rocket syntax.
+  - 'Rakefile'
+
+# We want to be able to decide when to use one-line if/unless modifiers.
+Style/IfUnlessModifier:
+  Enabled: false
+
+# [codesmell]
+# It's not always that bad.
+Style/IfInsideElse:
+  Enabled: false
+
+# module_function doesn't respect the visibility of the methods,
+# and doesn't work well when the module contain both public/private methods.
+Style/ModuleFunction:
+  Enabled: false
+
+Style/MultilineBlockChain:
+  Exclude:
+  # RSpec uses multi-line blocks for certain features
+  - 'spec/**/*_spec.rb'
+
+# unless is not always cool.
+Style/NegatedIf:
+  Enabled: false
+
+# Magic numbers are not welcomed
+Style/NumericLiterals:
+  Exclude:
+  # however tests can use numeric literals for method calls,
+  # without the need to define a variable just for that.
+  - 'spec/**/*_spec.rb'
+  - 'test/**/*_test.rb'
+
+# For years, %w() has been the de-facto standard. A lot of libraries are using ().
+# Switching to [] would be a nightmare.
+Style/PercentLiteralDelimiters:
+  Enabled: false
+
+# Enable but only for multiple returns value.
+#
+#   return foo, bar
+#
+# reads much better than
+#
+#   [foo, bar]
+#
+Style/RedundantReturn:
+  AllowMultipleReturnValues: true
+
+# Do we care?
+Style/RegexpLiteral:
+  Enabled: false
+
+# There are cases were the inline rescue is ok. We can either downgrade the severity,
+# or rely on the developer judgement on a case-by-case basis.
+Style/RescueModifier:
+  Enabled: false
+
+# This is quite annoying, especially in cases where we don't control it (e.g. schema.rb).
+Style/SymbolArray:
+  Enabled: false
+
+# We don't have a preference.
+Style/SpecialGlobalVars:
+  Enabled: false
+  EnforcedStyle: use_perl_names
+
+# We generally use double quotes, sometimes single quotes.
+# Should we enforce it at code level?
+Style/StringLiterals:
+  Enabled: false
+  EnforcedStyle: double_quotes
+
+# As before.
+Style/StringLiteralsInInterpolation:
+  Enabled: false
+  EnforcedStyle: double_quotes
+
+# It's nice to be consistent. The trailing comma also allows easy reordering,
+# and doesn't cause a diff in Git when you add a line to the bottom.
+Style/TrailingCommaInArrayLiteral:
+  EnforcedStyleForMultiline: consistent_comma
+
+# It's nice to be consistent. The trailing comma also allows easy reordering,
+# and doesn't cause a diff in Git when you add a line to the bottom.
+Style/TrailingCommaInHashLiteral:
+  EnforcedStyleForMultiline: consistent_comma
+
+Style/TrivialAccessors:
+  # IgnoreClassMethods because I want to be able to define class-level accessors
+  # that sets an instance variable on the metaclass, such as:
+  #
+  #    def self.default=(value)
+  #      @default = value
+  #    end
+  #
+  IgnoreClassMethods: true
+
+Style/WordArray:
+  EnforcedStyle: percent
+  MinSize: 3
+
+# Forces the order of comparison arguments.
+#
+# According to this cop, the following statement is bad:
+#
+#   "https" == uri.scheme
+#
+# Whereas the following is considered good:
+#
+#   uri.scheme == "https"
+Style/YodaCondition:
+  Enabled: false
+
+# For the same reason of EndAlignment, aligning with the case may have a bad impact
+# on a case after a very long variable.
+#
+#   invoice_error_message = case error
+#                           when 1 == 1
+#                             do_something
+#                           else
+#                             do_else
+#                           end
+#
+Layout/CaseIndentation:
+  EnforcedStyle: end
+
+# I was a big fan of leading, but trailing seems to be more commonly adopted.
+# At least at the time being.
+Layout/DotPosition:
+  EnforcedStyle: leading
+
+# Double empty lines are useful to separate conceptually different methods
+# in the same class or module.
+Layout/EmptyLines:
+  Enabled: false
+
+# This is buggy. It detects as a style violation a few `class` and `module` definitions
+Layout/EmptyLinesAroundArguments:
+  Enabled: false
+
+Layout/EmptyLinesAroundBlockBody:
+  Exclude:
+  # RSpec is all made of blocks. Disable this config in RSpec
+  # to be consistent with EmptyLinesAroundClassBody and EmptyLinesAroundModuleBody
+  - 'spec/**/*_spec.rb'
+  - 'test/**/*_test.rb'
+
+# In most cases, a space is nice. Sometimes, it's not.
+# Just be consistent with the rest of the surrounding code.
+Layout/EmptyLinesAroundClassBody:
+  Enabled: false
+
+# We're ok with it. We use it quite often for method-level rescue statements.
+Layout/EmptyLinesAroundExceptionHandlingKeywords:
+  Enabled: false
+
+# In most cases, a space is nice. Sometimes, it's not.
+# Just be consistent with the rest of the surrounding code.
+Layout/EmptyLinesAroundModuleBody:
+  Enabled: false
+
+# This is quite buggy, as it doesn't recognize double lines.
+Layout/EmptyLineBetweenDefs:
+  Enabled: false
+
+# Multi-line differs from standard indentation, they are indented twice.
+Layout/FirstParameterIndentation:
+  IndentationWidth: 4
+
+# Array indentation should be consistent with method/variable definition.
+Layout/IndentArray:
+  EnforcedStyle: consistent
+
+# Hash indentation should be consistent with method/variable definition.
+Layout/IndentHash:
+  EnforcedStyle: consistent
+
+# Multi-line differs from standard indentation, they are indented twice.
+Layout/MultilineMethodCallIndentation:
+  EnforcedStyle: indented
+  IndentationWidth: 4
+
+# Multi-line differs from standard indentation, they are indented twice.
+Layout/MultilineOperationIndentation:
+  EnforcedStyle: indented
+  IndentationWidth: 4
+
+# Sorry, but using trailing spaces helps readability.
+#
+#   %w( foo bar )
+#
+# looks better than:
+#
+#   %w(foo bar)
+#
+Layout/SpaceInsidePercentLiteralDelimiters:
+  Enabled: false

data/.rubocop_todo.yml

@@ -0,0 +1,207 @@
+# This configuration was generated by
+# `rubocop --auto-gen-config`
+# on 2018-10-29 22:14:14 +0100 using RuboCop version 0.60.0.
+# The point is for the user to remove these configuration records
+# one by one as the offenses are removed from the code base.
+# Note that changes in the inspected code, or installation of new
+# versions of RuboCop, may require this file to be generated again.
+
+# Offense count: 1
+# Configuration parameters: Include.
+# Include: **/*.gemspec
+Gemspec/RequiredRubyVersion:
+  Exclude:
+    - 'net-dns.gemspec'
+
+
+# Offense count: 2
+Lint/AmbiguousRegexpLiteral:
+  Exclude:
+    - 'test/unit/rr/mr_test.rb'
+    - 'test/unit/rr/types_test.rb'
+
+# Offense count: 1
+Lint/DuplicateMethods:
+  Exclude:
+    - 'lib/net/dns/resolver.rb'
+
+# Offense count: 1
+Lint/EmptyWhen:
+  Exclude:
+    - 'lib/net/dns/rr/types.rb'
+
+# Offense count: 1
+Lint/IneffectiveAccessModifier:
+  Exclude:
+    - 'lib/net/dns/rr.rb'
+
+# Offense count: 1
+Lint/LiteralAsCondition:
+  Exclude:
+    - 'lib/net/dns/header.rb'
+
+# Offense count: 1
+Lint/NonLocalExitFromIterator:
+  Exclude:
+    - 'lib/net/dns/resolver.rb'
+
+# Offense count: 5
+# Cop supports --auto-correct.
+# Configuration parameters: IgnoreEmptyBlocks, AllowUnusedKeywordArguments.
+Lint/UnusedBlockArgument:
+  Exclude:
+    - 'lib/net/dns/core_ext.rb'
+    - 'lib/net/dns/header.rb'
+    - 'lib/net/dns/resolver.rb'
+    - 'test/unit/rr/types_test.rb'
+
+# Offense count: 9
+# Cop supports --auto-correct.
+# Configuration parameters: AllowUnusedKeywordArguments, IgnoreEmptyMethods.
+Lint/UnusedMethodArgument:
+  Exclude:
+    - 'lib/net/dns/packet.rb'
+    - 'lib/net/dns/resolver.rb'
+    - 'test/unit/resolver_test.rb'
+
+# Offense count: 5
+# Configuration parameters: ContextCreatingMethods, MethodCreatingMethods.
+Lint/UselessAccessModifier:
+  Exclude:
+    - 'lib/net/dns/rr/null.rb'
+    - 'lib/net/dns/rr/ptr.rb'
+    - 'lib/net/dns/rr/soa.rb'
+    - 'lib/net/dns/rr/srv.rb'
+    - 'lib/net/dns/rr/txt.rb'
+
+# Offense count: 13
+Lint/UselessAssignment:
+  Exclude:
+    - 'lib/net/dns/packet.rb'
+    - 'lib/net/dns/question.rb'
+    - 'lib/net/dns/resolver.rb'
+    - 'lib/net/dns/rr.rb'
+    - 'lib/net/dns/rr/hinfo.rb'
+    - 'lib/net/dns/rr/srv.rb'
+    - 'test/unit/resolver_test.rb'
+
+# Offense count: 3
+# Configuration parameters: CheckForMethodsWithNoSideEffects.
+Lint/Void:
+  Exclude:
+    - 'lib/net/dns/rr.rb'
+    - 'lib/net/dns/rr/a.rb'
+    - 'lib/net/dns/rr/aaaa.rb'
+
+# Offense count: 23
+Naming/AccessorMethodName:
+  Exclude:
+    - 'lib/net/dns/rr.rb'
+    - 'lib/net/dns/rr/a.rb'
+    - 'lib/net/dns/rr/aaaa.rb'
+    - 'lib/net/dns/rr/cname.rb'
+    - 'lib/net/dns/rr/hinfo.rb'
+    - 'lib/net/dns/rr/mr.rb'
+    - 'lib/net/dns/rr/mx.rb'
+    - 'lib/net/dns/rr/ns.rb'
+    - 'lib/net/dns/rr/null.rb'
+    - 'lib/net/dns/rr/ptr.rb'
+    - 'lib/net/dns/rr/soa.rb'
+    - 'lib/net/dns/rr/txt.rb'
+
+# Offense count: 12
+Naming/ConstantName:
+  Exclude:
+    - 'lib/net/dns/header.rb'
+    - 'lib/net/dns/resolver.rb'
+    - 'test/unit/resolver_test.rb'
+    - 'test/unit/rr/a_test.rb'
+    - 'test/unit/rr/aaaa_test.rb'
+    - 'test/unit/rr/classes_test.rb'
+    - 'test/unit/rr/cname_test.rb'
+    - 'test/unit/rr/hinfo_test.rb'
+    - 'test/unit/rr/mr_test.rb'
+    - 'test/unit/rr/mx_test.rb'
+    - 'test/unit/rr/ns_test.rb'
+
+# Offense count: 12
+# Configuration parameters: EnforcedStyle.
+# SupportedStyles: snake_case, camelCase
+Naming/MethodName:
+  Exclude:
+    - 'lib/net/dns/header.rb'
+    - 'lib/net/dns/question.rb'
+    - 'lib/net/dns/resolver.rb'
+    - 'lib/net/dns/resolver/socks.rb'
+
+# Offense count: 24
+# Configuration parameters: EnforcedStyle.
+# SupportedStyles: snake_case, camelCase
+Naming/VariableName:
+  Exclude:
+    - 'lib/net/dns/header.rb'
+    - 'lib/net/dns/question.rb'
+
+# Offense count: 5
+Security/Eval:
+  Exclude:
+    - 'lib/net/dns/header.rb'
+    - 'lib/net/dns/resolver.rb'
+    - 'lib/net/dns/rr.rb'
+
+# Offense count: 2
+# Cop supports --auto-correct.
+# Configuration parameters: AutoCorrect, EnforcedStyle.
+# SupportedStyles: nested, compact
+Style/ClassAndModuleChildren:
+  Exclude:
+    - 'test/test_helper.rb'
+    - 'test/unit/resolver_test.rb'
+
+# Offense count: 5
+Style/ClassVars:
+  Exclude:
+    - 'lib/net/dns/resolver/socks.rb'
+    - 'lib/net/dns/rr/classes.rb'
+    - 'lib/net/dns/rr/types.rb'
+
+# Offense count: 6
+Style/Documentation:
+  Exclude:
+    - 'spec/**/*'
+    - 'test/**/*'
+    - 'lib/net/dns.rb'
+    - 'lib/net/dns/names.rb'
+    - 'lib/net/dns/resolver.rb'
+    - 'lib/net/dns/resolver/timeouts.rb'
+
+# Offense count: 2
+Style/DoubleNegation:
+  Exclude:
+    - 'Rakefile'
+    - 'lib/net/dns/resolver.rb'
+
+# Offense count: 4
+Style/EvalWithLocation:
+  Exclude:
+    - 'lib/net/dns/header.rb'
+    - 'lib/net/dns/resolver.rb'
+    - 'lib/net/dns/rr.rb'
+
+# Offense count: 41
+# Configuration parameters: MinBodyLength.
+Style/GuardClause:
+  Enabled: false
+
+# Offense count: 7
+# Cop supports --auto-correct.
+# Configuration parameters: AutoCorrect, EnforcedStyle, IgnoredMethods.
+# SupportedStyles: predicate, comparison
+Style/NumericPredicate:
+  Exclude:
+    - 'spec/**/*'
+    - 'lib/net/dns/header.rb'
+    - 'lib/net/dns/names.rb'
+    - 'lib/net/dns/question.rb'
+    - 'lib/net/dns/resolver.rb'
+    - 'lib/net/dns/resolver/timeouts.rb'