nested_form_fields 0.7.2 → 0.7.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 780896d01d77d65dabbf6e49138d75873f36ce38
-  data.tar.gz: 9f788fb496249e0478d40a7740fabc23f30aafed
+  metadata.gz: ab74838842c0f157a5efc9ae46b5b99e60ed0c4d
+  data.tar.gz: b5b7663f9f374ad79f6fa41d6ca2106f3767d1e9
 SHA512:
-  metadata.gz: 21559a77beb15101d5ffcabb94b70699d761efdd0ded937c9a2bd5b28a7fe5bcd1388fd209a98f521c37416c633532aa1b2a3d78c8a2724cdfc8a8b32b2f0704
-  data.tar.gz: cede63960729dd02ed7498ac2177919c3af187ed19fdb26c8b44d7b91cdb0a14242ec701a4f24b2fb322c3597d122bc084f7d8ea71e0de80676a8b5133376cfe
+  metadata.gz: 3fb53546a7acbbee53a0a5bbeba881558a46b5443b7db06e8e5bb9e8f70427ed1857674b3d1c3ffb4bbc95d3e0f2e3c21dd5a385d301db29989330150a779ad6
+  data.tar.gz: 65a2643fbcb49811b895ef960a4a9fba0612136ee51cf73c9800cc7adc84384a392109d47db6318afe589b4a9afbc63e0e61c9e3194f0dc12aa9ce70a45847c6

data/.travis.yml

@@ -1,5 +1,8 @@
 rvm:
-  - 2.1.3
+  - 1.9.3
+  - 2.0.0
+  - 2.1.7
+  - 2.2.3
 before_script:
   - "export DISPLAY=:99.0"
   - "sh -e /etc/init.d/xvfb start"

data/Gemfile

@@ -1,6 +1,4 @@
 source 'https://rubygems.org'
 
-ruby '2.1.3'
-
 # Specify your gem's dependencies in nested_form_fields.gemspec
 gemspec

data/README.md

@@ -5,8 +5,8 @@ This Rails gem helps creating forms for models with nested has_many associations
 It uses jQuery to dynamically add and remove nested associations.
 
 - Works for arbitrarily deeply nested associations (tested up to 4 levels).
-- Works with form builders like simple_form.
-- Requires Ruby 1.9 and the Rails asset pipeline
+- Works with form builders like [simple_form](https://github.com/plataformatec/simple_form).
+- Requires Ruby 1.9+ and the Rails asset pipeline.
 
 
 
@@ -28,45 +28,55 @@ In your application.js file add:
 
 Assume you have a user model with nested videos:
 
-    class User < ActiveRecord::Base
-      has_many :videos
-      accepts_nested_attributes_for :videos, allow_destroy: true
-    end
+```ruby
+class User < ActiveRecord::Base
+  has_many :videos
+  accepts_nested_attributes_for :videos, allow_destroy: true
+end
+```
 
-Use the *nested_fields_for* helper inside your user form to add the video fields:
+Use the `nested_fields_for` helper inside your user form to add the video fields:
 
-    = form_for @user do |f|
-      = f.nested_fields_for :videos do |ff|
-        = ff.text_field :video_title
-        ..
+```haml
+= form_for @user do |f|
+  = f.nested_fields_for :videos do |ff|
+    = ff.text_field :video_title
+    ..
+```
 
-Links to add and remove fields can be added using the *add_nested_fields_link* and *remove_nested_fields_link* helpers:
+Links to add and remove fields can be added using the `add_nested_fields_link` and `remove_nested_fields_link` helpers:
 
-    = form_for @user do |f|
-      = f.nested_fields_for :videos do |ff|
-        = ff.remove_nested_fields_link
-        = ff.text_field :video_title
-        ..
-      = f.add_nested_fields_link :videos
+```haml
+= form_for @user do |f|
+  = f.nested_fields_for :videos do |ff|
+    = ff.remove_nested_fields_link
+    = ff.text_field :video_title
+    ..
+  = f.add_nested_fields_link :videos
+```
 
-Note that *remove_nested_fields_link* needs to be called within the *nested_fields_for* call and *add_nested_fields_link* outside of it via the parent builder.
+Note that `remove_nested_fields_link` needs to be called within the `nested_fields_for` call and `add_nested_fields_link` outside of it via the parent builder.
 
 ## Link Customization
 
-You can change the link text of *remove_nested_fields_link* and *add_nested_fields_link* like this:
+You can change the link text of `remove_nested_fields_link` and `add_nested_fields_link` like this:
 
-    ...
-      ff.remove_nested_fields_link 'Remove me'
-      ...
-    f.add_nested_fields_link :videos, 'Add another funtastic video'
+```haml
+...
+  ff.remove_nested_fields_link 'Remove me'
+  ...
+f.add_nested_fields_link :videos, 'Add another funtastic video'
+```
+
+You can add classes/attributes to the  `remove_nested_fields_link` and `add_nested_fields_link` like this:
 
-You can add classes/attributes to the  *remove_nested_fields_link* and *add_nested_fields_link* like this:
+```haml
+...
+  ff.remove_nested_fields_link 'Remove me', class: 'btn btn-danger', role: 'button'
+  ...
+f.add_nested_fields_link :videos, 'Add another funtastic video', class: 'btn btn-primary', role: 'button'
+```
 
-    ...
-      ff.remove_nested_fields_link 'Remove me', class: 'btn btn-danger', role: 'button'
-      ...
-    f.add_nested_fields_link :videos, 'Add another funtastic video', class: 'btn btn-primary', role: 'button'
-    
 You can supply a block to the `remove_nested_fields_link` and the `add_nested_fields_link` helpers, as you can with `link_to`:
 
 ```haml
@@ -74,7 +84,7 @@ You can supply a block to the `remove_nested_fields_link` and the `add_nested_fi
   Remove me %span.icon-trash
 ```
 
-You can add a `data-confirm` attribute to the `remove_nested_fields_link` if you want the user to confirm whenever they remove a nested field: 
+You can add a `data-confirm` attribute to the `remove_nested_fields_link` if you want the user to confirm whenever they remove a nested field:
 
 ```haml
 = ff.remove_nested_fields_link 'Remove me', data: { confirm: 'Are you sure?' }
@@ -84,71 +94,99 @@ You can add a `data-confirm` attribute to the `remove_nested_fields_link` if you
 
 You can specify a custom container to add nested forms into, by supplying an id via the `data-insert-into` attribute of the `add_nested_fields_link`:
 
-    f.add_nested_fields_link :videos, 'Add another funtastic video', data: { insert_into: '<container_id>' }
+```haml
+f.add_nested_fields_link :videos, 'Add another funtastic video', data: { insert_into: '<container_id>' }
+```
 
 ## Custom Fields Wrapper
 
-You can change the type of the element wrapping the nested fields using the *wrapper_tag* option:
+You can change the type of the element wrapping the nested fields using the `wrapper_tag` option:
 
-    = f.nested_fields_for :videos, wrapper_tag: :div do |ff|
+```haml
+= f.nested_fields_for :videos, wrapper_tag: :div do |ff|
+```
 
 The default wrapper element is a fieldset. To add legend element to the fieldset use:
 
-    = f.nested_fields_for :videos, legend: "Video" do |ff|
+```haml
+= f.nested_fields_for :videos, legend: "Video" do |ff|
+```
 
 You can pass options like you would to the `content_tag` method by nesting them in a `:wrapper_options` hash:
 
-    = f.nested_fields_for :videos, wrapper_options: { class: 'row' } do |ff|
+```haml
+= f.nested_fields_for :videos, wrapper_options: { class: 'row' } do |ff|
+```
 
 ## Rails 4 Parameter Whitelisting
 
-If you are using Rails 4 remember to add << NESTED_MODEL >>_attributes and the attributes to the permitted params. 
-Also, if you want to destroy the nested model you should add :_destroy and :id.
+If you are using Rails 4 remember to add {{ NESTED_MODEL }}_attributes and the attributes to the permitted params.
+If you want to destroy the nested model you should add `:_destroy` and `:id`.
 For example:
 
-    # app/views/users/_form.haml.erb
-    = form_for @user do |f|
-      = f.nested_fields_for :videos do |ff|
-        = ff.remove_nested_fields_link
-        = ff.text_field :video_title
-        ..
-      = f.add_nested_fields_link :videos
-      
-    # app/controllers/users_controller
+```haml
+# app/views/users/_form.haml.erb
+= form_for @user do |f|
+  = f.nested_fields_for :videos do |ff|
+    = ff.remove_nested_fields_link
+    = ff.text_field :video_title
     ..
-    def user_params
-        params.require(:user)
-            .permit(:name,:email,videos_attributes:[:video_title,:_destroy,:id])
-    #                            ^^^                 ^^^           ^^^
-    #                            nested model attrs  
-    #                                                             they will let you delete the nested model                    
-    end
+  = f.add_nested_fields_link :videos
+```
+
+```ruby
+# app/controllers/users_controller
+..
+def user_params
+    params.require(:user)
+        .permit(:name,:email,videos_attributes:[:video_title,:_destroy,:id])
+#                            ^^^                 ^^^           ^^^
+#                            nested model attrs  
+#                                                             they will let you delete the nested model                    
+end
+```
 
 ## Events
 
-There are 4 javascipt events firing before and after addition/removal of the fields in the *nested_form_fields* namespace. Namely:
-    fields_adding, fields_added, fields_removing, fields_removed.
+There are four JavaScript events firing before and after addition/removal of the fields in the `nested_form_fields` namespace:
+
+- `fields_adding`
+- `fields_added`
+- `fields_removing`
+- `fields_removed`
 
 The events `fields_added` and `fields_removed` are triggered on the element being added or removed. The events bubble up so you can listen for them on any parent element.
-This makes it easy to add listeners when you have multiple nested_form_fields on the same page.
+This makes it easy to add listeners when you have multiple `nested_form_fields` on the same page.
 
 CoffeeScript samples:
 
-    # Listen on an element
-    initializeSortable -> ($el)
-      $el.sortable(...)
-      $el.on 'fields_added.nested_form_fields', (event, param) -> 
-        console.log event.target # The added field
-        console.log $(this)      # $el
-
-    # Listen on document
-    $(document).on "fields_added.nested_form_fields", (event, param) ->
-      switch param.object_class
-        when "video"
-          console.log "Video object added"
-        else
-          console.log "INFO: Fields were successfully added, callback not handled."
+```coffeescript
+# Listen on an element
+initializeSortable -> ($el)
+  $el.sortable(...)
+  $el.on 'fields_added.nested_form_fields', (event, param) ->
+    console.log event.target # The added field
+    console.log $(this)      # $el
+
+# Listen on document
+$(document).on "fields_added.nested_form_fields", (event, param) ->
+  switch param.object_class
+    when "video"
+      console.log "Video object added"
+    else
+      console.log "INFO: Fields were successfully added, callback not handled."
+```
+
+## Namespaced Associations
 
+In case your has_many association is namespaced, you need to add the `class_name` parameter to `nested_fields_for`.
+Example:
+
+```haml
+= form_for @user do |f|
+  = f.nested_fields_for :videos, class_name: "Medium::Video" do |ff|
+  ...
+```
 
 ## Contributing
 

data/lib/assets/javascripts/nested_form_fields.js.coffee

@@ -43,7 +43,11 @@ nested_form_fields.bind_nested_forms_links = () ->
     removed_index = parseInt(delete_association_field_name.match('(\\d+\\]\\[_destroy])')[0].match('\\d+')[0])
     $.event.trigger("fields_removing.nested_form_fields",{object_class: object_class, delete_association_field_name: delete_association_field_name, removed_index: removed_index });
     $nested_fields_container = $link.parents(".nested_fields").first()
-    $nested_fields_container.before "<input type='hidden' name='#{delete_association_field_name}' value='1' />"
+    delete_field = $nested_fields_container.find("input[type='hidden'][name='#{delete_association_field_name}']")
+    if delete_field.length > 0
+      delete_field.val('1')
+    else
+      $nested_fields_container.before "<input type='hidden' name='#{delete_association_field_name}' value='1' />"
     $nested_fields_container.hide()
     $nested_fields_container.find('input[required]:hidden').removeAttr('required')
     $nested_fields_container.trigger("fields_removed.nested_form_fields",{object_class: object_class, delete_association_field_name: delete_association_field_name, removed_index: removed_index});

data/lib/nested_form_fields/version.rb

@@ -1,3 +1,3 @@
 module NestedFormFields
-  VERSION = "0.7.2"
+  VERSION = "0.7.3"
 end

data/lib/nested_form_fields.rb

@@ -68,7 +68,13 @@ module ActionView::Helpers
 
       output = ActiveSupport::SafeBuffer.new
       association.each do |child|
-        output << nested_fields_wrapper(association_name, options[:wrapper_tag], options[:legend], options[:wrapper_options]) do
+        wrapper_options = options[:wrapper_options].clone || {}
+        if child._destroy == true
+          wrapper_options[:style] = wrapper_options[:style] ?
+                                      wrapper_options[:style] + ';' + 'display:none' :
+                                      'display:none'
+        end
+        output << nested_fields_wrapper(association_name, options[:wrapper_tag], options[:legend], wrapper_options) do
           fields_for_nested_model("#{name}[#{options[:child_index] || nested_child_index(name)}]", child, options, block)
         end
       end

data/nested_form_fields.gemspec

@@ -5,7 +5,7 @@ Gem::Specification.new do |gem|
   gem.authors       = ["Nico Ritsche"]
   gem.email         = ["ncrdevmail@gmail.com"]
   gem.description   = %q{Rails gem for dynamically adding and removing nested has_many association fields in a form.
-                         Uses jQuery and supports multiple nesting levels. Requires Ruby 1.9 and the asset pipeline.}
+                         Uses jQuery and supports multiple nesting levels. Requires Ruby 1.9+ and the asset pipeline.}
   gem.summary       = %q{Rails gem for dynamically adding and removing nested has_many association fields in a form.}
   gem.homepage      = ""
 
@@ -29,4 +29,5 @@ Gem::Specification.new do |gem|
   gem.add_development_dependency 'haml', '>= 3.1.5'
   gem.add_development_dependency 'haml-rails'
   gem.add_development_dependency 'sass-rails', '~> 3.2.3'
+  gem.add_development_dependency 'test-unit', '1.2.3'
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: nested_form_fields
 version: !ruby/object:Gem::Version
-  version: 0.7.2
+  version: 0.7.3
 platform: ruby
 authors:
 - Nico Ritsche
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-10-06 00:00:00.000000000 Z
+date: 2015-11-22 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails
@@ -164,9 +164,23 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: 3.2.3
+- !ruby/object:Gem::Dependency
+  name: test-unit
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - '='
+      - !ruby/object:Gem::Version
+        version: 1.2.3
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - '='
+      - !ruby/object:Gem::Version
+        version: 1.2.3
 description: |-
   Rails gem for dynamically adding and removing nested has_many association fields in a form.
-                           Uses jQuery and supports multiple nesting levels. Requires Ruby 1.9 and the asset pipeline.
+                           Uses jQuery and supports multiple nesting levels. Requires Ruby 1.9+ and the asset pipeline.
 email:
 - ncrdevmail@gmail.com
 executables: []