nepali_number 0.1.0 → 0.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 29cc199bf66bc17cf33aae0ff233060083e61ed53ea2a667d7568193bd0f2c8d
-  data.tar.gz: 6f711a7ba972a0630be4e984892366343c5e6c2baec04e7327030450607b5bab
+  metadata.gz: a820051dbeea8f45d3a9f5b8e23b170f3d2339827cbbf94a9a81c0074cb7bf95
+  data.tar.gz: 69652253a7c525b58b6f41d67f7663e0193adf1083ecf36fcdb4b51ce9584a19
 SHA512:
-  metadata.gz: 723097d571768a73e7c4c25b2a973b825da7f82cef4a8caabb7c88e6d83b222d183ac654fb17baabcdaec9aa893688955ef86626d55cb77ed0661e13a7d9c152
-  data.tar.gz: 5ea57a0185510aa74423cf9648262abf949cd57f5c314055abf4089ce93a190f49c61dfc04230c3c9078be26076536fe88bd6696869cec82534fdd1da3acb8d1
+  metadata.gz: 4c6b68ff373bfef520a3bbe2d9f6a88ddad7b910d203a775dac8d39d5b245e3c6d67636a28d4b9eb1494f8d0ec9d4ee3c57614fff70ed2434de74fdf80c4b357
+  data.tar.gz: 86c53d7f1287b9b6ae95c21ce6a1e262f3e6b45dfbb344c2e60a46375fdcfb73fbb1f21acc6e60bc98370bd1e5110a7d51984926cff2252d47f5ed597282ff8f

data/CHANGELOG.md

@@ -1,3 +1,12 @@
+## [0.2.0] - 2026-10-05
+
+- Fix whole `BigDecimal` values rendering with a phantom decimal place. `BigDecimal#to_s("F")` always emits at least one digit after the point, so `NepaliNumber.format(BigDecimal("10"))` returned `"10.0"` and `BigDecimal("100.00")` returned `"100.0"`. Whole values now render as whole numbers: `"10"`, `"1,00,000"`. This also reaches `NepaliNumber.currency`, where whole money previously gained a `.0`.
+- A value that genuinely carries a fraction is unchanged (`BigDecimal("10.5")` still formats as `"10.5"`). Truncating or rounding a fraction stays the caller's decision; the formatter no longer invents one.
+
+## [0.1.1] - 2026-09-06
+
+- Change default currency symbol from `रु.` to `रु` and remove the default space, so `NepaliNumber.currency(100)` now returns `रु100` (matching `रु1.45` style per Wikipedia/NPR convention).
+
 ## [0.1.0] - 2026-05-27
 
 - Merge the richer Devanagari/Nepali-number implementation into `nepali_number`.

data/README.md

@@ -22,14 +22,26 @@ NepaliNumber.format("123456.78")
 # => "1,23,456.78"
 ```
 
+A `BigDecimal` with no fractional part formats as a whole number, whatever scale
+its literal carried. One that genuinely has a fraction keeps it, so rounding or
+truncating stays the caller's decision rather than the formatter's.
+
+```ruby
+NepaliNumber.format(BigDecimal("100.0000"))
+# => "100"
+
+NepaliNumber.format(BigDecimal("10.5"))
+# => "10.5"
+```
+
 ### Currency
 
 ```ruby
 NepaliNumber.currency(100)
-# => "रु. 100"
+# => "रु100"
 
 NepaliNumber.currency(1234567.89, nepali: true)
-# => "रु. १२,३४,५६७.८९"
+# => "रु१२,३४,५६७.८९"
 ```
 
 ### Digit conversion
@@ -63,9 +75,49 @@ When Rails is loaded, NepaliNumber adds explicit helpers:
 
 ## Development
 
-After checking out the repo, run `bin/setup` to install dependencies. Then, run `rake test` to run the tests. You can also run `bin/console` for an interactive prompt that will allow you to experiment.
+After checking out the repo, run `bin/setup` (or `bundle install`) to install dependencies. You can also run `bin/console` for an interactive prompt.
+
+### Running tests
+
+```sh
+bundle install
+bundle exec rake test      # Minitest (test/test_nepali_number.rb)
+bundle exec rake standard  # lint (Standard Ruby)
+bundle exec rake           # runs test + standard
+```
+
+### Publishing to RubyGems
+
+This repo uses custom release tasks (`Rakefile:19`) — `bundler/gem_tasks` release is not used.
+
+```sh
+# 0. Ensure a clean working tree
+git status --porcelain  # must be empty
+
+# 1. Bump version in lib/nepali_number/version.rb:4
+bundle exec rake release:bump[patch]  # or [minor], [major], or [0.2.0]
+# 2. Update CHANGELOG.md and commit
+git add lib/nepali_number/version.rb CHANGELOG.md
+git commit -m "Bump version to X.Y.Z"
+
+# 3. Verify, build, and print publish commands
+bundle exec rake release:prepare  # runs release:check_clean, test, standard, build
+# -> builds pkg/nepali_number-X.Y.Z.gem (pkg/ is gitignored)
+
+# 4. Push to RubyGems (MFA OTP required)
+bundle exec gem push pkg/nepali_number-X.Y.Z.gem --otp <6-digit-code>
+# gem push uses credentials in ~/.local/share/gem/credentials (see `gem env`)
+
+# 5. Tag and push tag
+git tag vX.Y.Z
+git push origin vX.Y.Z
+```
+
+Tips:
 
-To install this gem onto your local machine, run `bundle exec rake install`. To release a new version, update the version number in `version.rb`, and then run `bundle exec rake release`, which will create a git tag for the version, push git commits and the created tag, and push the `.gem` file to [rubygems.org](https://rubygems.org).
+- `bundle exec rake release:build` — build only.
+- `bundle exec rake release:commands` — print artifact path and `gem push` / `git tag` commands without running checks.
+- To install locally without publishing: `bundle exec rake install`.
 
 ## Contributing
 

data/Rakefile

@@ -1,10 +1,91 @@
 # frozen_string_literal: true
 
 require "bundler/gem_tasks"
+require "fileutils"
 require "minitest/test_task"
+require_relative "lib/nepali_number/version"
 
 Minitest::TestTask.create
 
 require "standard/rake"
 
 task default: %i[test standard]
+
+release_gem_name = "nepali_number"
+release_gemspec = "#{release_gem_name}.gemspec"
+release_version = NepaliNumber::VERSION
+release_gem_file = "pkg/#{release_gem_name}-#{release_version}.gem"
+
+namespace :release do
+  desc "Bump version. Usage: rake release:bump[patch|minor|major|0.2.0]"
+  task :bump, [:level_or_version] do |_, args|
+    current_version = Gem::Version.new(NepaliNumber::VERSION)
+    next_version = next_release_version(current_version, args[:level_or_version])
+    version_file = "lib/nepali_number/version.rb"
+    contents = File.read(version_file)
+    updated = contents.sub(/VERSION = "[^"]+"/, %(VERSION = "#{next_version}"))
+
+    abort "Could not find VERSION assignment in #{version_file}" if contents == updated
+
+    File.write(version_file, updated)
+    puts "Bumped #{release_gem_name} from #{current_version} to #{next_version}"
+  end
+
+  desc "Verify the working tree has no uncommitted changes"
+  task :check_clean do
+    status = `git status --porcelain`.strip
+    abort "Working tree is not clean:\n#{status}" unless status.empty?
+  end
+
+  desc "Build #{release_gem_name} #{release_version} into pkg/"
+  task :build do
+    FileUtils.mkdir_p("pkg")
+    FileUtils.rm_f(release_gem_file)
+    sh "gem build #{release_gemspec} --output #{release_gem_file}"
+  end
+
+  desc "Print the manual commands for publishing #{release_gem_name} #{release_version}"
+  task :commands do
+    puts
+    puts "Release artifact: #{release_gem_file}"
+    puts
+    puts "Publish:"
+    puts "  gem push #{release_gem_file}"
+    puts
+    puts "Tag:"
+    puts "  git tag v#{release_version}"
+    puts "  git push origin v#{release_version}"
+    puts
+  end
+
+  desc "Run checks, build the gem, and print publish commands"
+  task prepare: [:check_clean, :test, :standard, :build, :commands]
+end
+
+def next_release_version(current_version, level_or_version)
+  level_or_version ||= "patch"
+
+  case level_or_version
+  when "patch", "minor", "major"
+    bump_version(current_version, level_or_version)
+  when /\A\d+\.\d+\.\d+(?:\.[A-Za-z0-9.-]+)?\z/
+    Gem::Version.new(level_or_version)
+  else
+    abort "Unknown version bump '#{level_or_version}'. Use patch, minor, major, or an explicit version like 0.2.0."
+  end
+end
+
+def bump_version(version, level)
+  segments = version.segments.first(3)
+  segments << 0 while segments.length < 3
+  major, minor, patch = segments
+
+  case level
+  when "major"
+    Gem::Version.new("#{major + 1}.0.0")
+  when "minor"
+    Gem::Version.new("#{major}.#{minor + 1}.0")
+  when "patch"
+    Gem::Version.new("#{major}.#{minor}.#{patch + 1}")
+  end
+end

data/lib/nepali_number/currency.rb

@@ -3,7 +3,7 @@
 module NepaliNumber
   class Currency
     class << self
-      def format(amount, symbol: "रु.", nepali: false, devanagari: nil, delimiter: ",", separator: ".", space: true)
+      def format(amount, symbol: "रु", nepali: false, devanagari: nil, delimiter: ",", separator: ".", space: false)
         formatted = Formatter.format(amount, delimiter: delimiter, separator: separator)
         return nil if formatted.nil?
 

data/lib/nepali_number/formatter.rb

@@ -23,12 +23,28 @@ module NepaliNumber
 
       private
 
+      # BigDecimal#to_s("F") always emits at least one decimal place, so a value
+      # carrying no fraction at all -- BigDecimal("10") -- came out as "10.0". That
+      # is an artifact of the rendering, not the number: it made whole share
+      # quantities read as fractional, and it did the same to whole money.
+      #
+      # A value that does carry a fraction keeps it. Callers that need a fraction
+      # rounded or dropped decide that themselves; the formatter's job is to not
+      # invent one.
       def normalize(number)
-        return number.to_s("F") if number.is_a?(BigDecimal)
+        return normalize_bigdecimal(number) if number.is_a?(BigDecimal)
 
         number.to_s.delete(",")
       end
 
+      def normalize_bigdecimal(number)
+        return number.to_i.to_s if number.frac.zero?
+
+        # to_s("F") keeps the full precision here, which is the point -- only the
+        # trailing ".0" of a whole value was ever wrong.
+        number.to_s("F")
+      end
+
       def group_integer(integer, delimiter)
         return integer if integer.length <= 3
 

data/lib/nepali_number/money_integration.rb

@@ -31,7 +31,7 @@ module NepaliNumber
       Money::Currency.register(
         iso_code: "NPR",
         name: "Nepalese Rupee",
-        symbol: "रु.",
+        symbol: "रु",
         subunit: "Paisa",
         subunit_to_unit: 100
       )
@@ -49,7 +49,7 @@ module NepaliNumber
     end
 
     def default_symbol_for(currency)
-      return "रु." if currency.iso_code == "NPR"
+      return "रु" if currency.iso_code == "NPR"
 
       currency.symbol || currency.iso_code
     end

data/lib/nepali_number/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module NepaliNumber
-  VERSION = "0.1.0"
+  VERSION = "0.2.0"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: nepali_number
 version: !ruby/object:Gem::Version
-  version: 0.1.0
+  version: 0.2.0
 platform: ruby
 authors:
 - Saroj Maharjan (zoras)
@@ -69,7 +69,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 4.0.12
+rubygems_version: 4.0.22
 specification_version: 4
 summary: Nepali number formatting, humanization, digit conversion, and currency helpers.
 test_files: []