neovim 0.7.1 → 0.8.0

data/spec/acceptance/rubydo_spec.vim

@@ -42,6 +42,15 @@ function! s:suite.updates_all_lines() abort
   call s:expect(getline(1, 4)).to_equal(["ONE", "TWO", "THREE", "FOUR"])
 endfunction
 
+function! s:suite.ignores_line_deletion() abort
+  " Just ensure `Index out of bounds` exception isn't raised.
+  "
+  " Deleting or adding lines inside `:rubydo` is documented as not supported.
+  " Therefore this will remain inconsistent with Vim, which deletes all but
+  " the first line (?)
+  %rubydo Vim.command("%d")
+endfunction
+
 function! s:suite.handles_standard_error() abort
   try
     1rubydo raise "BOOM"

data/spec/acceptance/rubyfile/curbuf_ivar_get.rb

@@ -1 +1 @@
-Vim.command("let g:foo = #{$curbuf.instance_variable_get(:@foo)}")
+Vim.command("let s:var = #{$curbuf.instance_variable_get(:@var)}")

data/spec/acceptance/rubyfile/curbuf_ivar_set.rb

@@ -1 +1 @@
-$curbuf.instance_variable_set(:@foo, 123)
+$curbuf.instance_variable_set(:@var, 123)

data/spec/acceptance/rubyfile/define_foo.rb

@@ -1,3 +1,3 @@
 def foo
-  Vim.command("let g:called = 1")
+  Vim.command("let s:var = 1")
 end

data/spec/acceptance/rubyfile/nested_inner.rb

@@ -1 +1 @@
-Vim.command("let g:ruby_nested = 123")
+Vim.command("let s:var = 123")

data/spec/acceptance/rubyfile/set_pwd_after.rb

@@ -1 +1 @@
-Vim.command("let g:pwd_after = '#{Dir.pwd}'")
+Vim.command("call add(s:var, '#{Dir.pwd}')")

data/spec/acceptance/rubyfile/set_pwd_before.rb

@@ -1 +1 @@
-Vim.command("let g:pwd_before = '#{Dir.pwd.sub(/^C:/, '')}'")
+Vim.command("let s:var = ['#{Dir.pwd.sub(/^C:/, '')}']")

data/spec/acceptance/rubyfile_spec.vim

@@ -2,12 +2,13 @@ let s:suite = themis#suite(":rubyfile")
 let s:expect = themis#helper("expect")
 
 function! s:suite.before() abort
-  let g:return_pwd = getcwd()
+  let s:pwd = getcwd()
   cd spec/acceptance/rubyfile
+  unlet! s:var
 endfunction
 
 function! s:suite.after() abort
-  execute("cd " . g:return_pwd)
+  execute("cd " . s:pwd)
 endfunction
 
 function! s:suite.before_each() abort
@@ -23,42 +24,43 @@ function! s:suite.defines_a_ruby_method() abort
   rubyfile ./define_foo.rb
   rubyfile ./call_foo.rb
 
-  call s:expect(g:called).to_equal(1)
+  call s:expect(s:var).to_equal(1)
 endfunction
 
 function! s:suite.persists_curbuf_state() abort
   rubyfile ./curbuf_ivar_set.rb
   rubyfile ./curbuf_ivar_get.rb
 
-  call s:expect(g:foo).to_equal(123)
+  call s:expect(s:var).to_equal(123)
 endfunction
 
 function! s:suite.updates_working_directory() abort
-  let g:rubyfile = getcwd() . "/set_pwd_before.rb"
+  let s:rubyfile = getcwd() . "/set_pwd_before.rb"
   cd /
-  exec "rubyfile " . g:rubyfile
+  exec "rubyfile " . s:rubyfile
   cd -
 
-  call s:expect(g:pwd_before).to_equal("/")
+  call s:expect(s:var).to_equal(["/"])
 endfunction
 
 function! s:suite.updates_working_directory_implicitly() abort
-  let g:before_file = getcwd() . "/set_pwd_before.rb"
-  let g:after_file = getcwd() . "/set_pwd_after.rb"
+  let s:before_file = getcwd() . "/set_pwd_before.rb"
+  let s:after_file = getcwd() . "/set_pwd_after.rb"
 
   split | lcd /
-  exec "rubyfile " . g:before_file
+  exec "rubyfile " . s:before_file
   wincmd p
-  exec "rubyfile " . g:after_file
+  exec "rubyfile " . s:after_file
   wincmd p | lcd -
 
-  call s:expect(g:pwd_before).not.to_equal(g:pwd_after)
+  call s:expect(len(s:var)).to_equal(2)
+  call s:expect(s:var[0]).not.to_equal(s:var[1])
 endfunction
 
 function! s:suite.supports_nesting() abort
   rubyfile ./nested.rb
 
-  call s:expect(g:ruby_nested).to_equal(123)
+  call s:expect(s:var).to_equal(123)
 endfunction
 
 function! s:suite.handles_standard_error() abort

data/spec/acceptance/runtime/init.vim

@@ -1,7 +1,7 @@
 let s:lib_path = getcwd() . "/lib"
-let s:bin_path = getcwd() . "/bin/neovim-ruby-host"
+let s:exe_path = getcwd() . "/exe/neovim-ruby-host"
 let g:acceptance_rtp = getcwd() . "/spec/acceptance/runtime"
-let g:ruby_host_prog = printf("ruby -I %s %s", s:lib_path, s:bin_path)
+let g:ruby_host_prog = printf("ruby -I %s %s", s:lib_path, s:exe_path)
 
 ruby require "rspec/expectations"
 ruby include ::RSpec::Matchers.dup

data/spec/helper.rb

@@ -1,10 +1,5 @@
 require "bundler/setup"
 
-if ENV["REPORT_COVERAGE"]
-  require "coveralls"
-  Coveralls.wear!
-end
-
 require "fileutils"
 require "msgpack"
 require "neovim"
@@ -14,7 +9,7 @@ require "securerandom"
 require "stringio"
 require "timeout"
 
-require File.expand_path("../support.rb", __FILE__)
+require File.expand_path("support.rb", __dir__)
 
 RSpec.configure do |config|
   config.expect_with :rspec do |exp|

data/spec/neovim/buffer_spec.rb

@@ -124,6 +124,12 @@ module Neovim
         end.to change { buffer.lines.to_a }.to(["first", "one", "two"])
       end
 
+      it "allows newlines" do
+        expect do
+          buffer.append(0, "first\nsecond")
+        end.to change { buffer.lines.to_a }.to(["first", "second", "one", "two"])
+      end
+
       it "doesn't move the cursor" do
         expect do
           buffer.append(0, "first")

data/spec/neovim/client_spec.rb

@@ -25,6 +25,13 @@ module Neovim
       end
     end
 
+    describe "#shutdown" do
+      it "causes nvim to exit" do
+        client.shutdown
+        expect { client.strwidth("hi") }.to raise_error(Neovim::Session::Exited)
+      end
+    end
+
     describe "#respond_to?" do
       it "returns true for vim functions" do
         expect(client).to respond_to(:strwidth)

data/spec/neovim/connection_spec.rb

@@ -7,11 +7,29 @@ module Neovim
     describe "#write" do
       it "writes msgpack to the underlying file descriptor" do
         rd, wr = IO.pipe
-        connection = Connection.new(nil_io, wr)
-        connection.write("some data")
+        Connection.new(nil_io, wr).write("some data").flush
+        data = rd.readpartial(1024)
+
+        expect(MessagePack.unpack(data)).to eq("some data")
+      end
+    end
+
+    describe "#flush" do
+      it "flushes writes to the underlying file descriptor" do
+        rd, wr = IO.pipe
+        connection = Connection.new(nil_io, wr).write("some data")
+
+        expect { connection.flush }
+          .to change { IO.select([rd], nil, nil, 0.01) }
+          .from(nil).to([[rd], [], []])
+      end
+
+      it "throws an exception when the file is closed" do
+        _, wr = IO.pipe
+        connection = Connection.new(nil_io, wr).write("some data")
         wr.close
 
-        expect(MessagePack.unpack(rd.read)).to eq("some data")
+        expect { connection.flush }.to raise_error(IOError)
       end
     end
 
@@ -19,11 +37,19 @@ module Neovim
       it "reads msgpack from the underlying file descriptor" do
         rd, wr = IO.pipe
         wr.write(MessagePack.pack("some data"))
-        wr.close
+        wr.flush
 
         connection = Connection.new(rd, nil_io)
         expect(connection.read).to eq("some data")
       end
+
+      it "throws an exception when the file is closed" do
+        rd, wr = IO.pipe
+        wr.close
+
+        connection = Connection.new(rd, nil_io)
+        expect { connection.read }.to raise_error(EOFError)
+      end
     end
 
     describe "#register_type" do

data/spec/neovim/event_loop_spec.rb

@@ -16,7 +16,9 @@ module Neovim
     describe "#request" do
       it "writes a msgpack request" do
         event_loop.request(1, :method, 1, 2)
+        connection.flush
         message = server_rd.readpartial(1024)
+
         expect(message).to eq(MessagePack.pack([0, 1, "method", [1, 2]]))
       end
     end
@@ -24,7 +26,9 @@ module Neovim
     describe "#respond" do
       it "writes a msgpack response" do
         event_loop.respond(2, "value", "error")
+        connection.flush
         message = server_rd.readpartial(1024)
+
         expect(message).to eq(MessagePack.pack([1, 2, "error", "value"]))
       end
     end
@@ -32,7 +36,9 @@ module Neovim
     describe "#notify" do
       it "writes a msgpack notification" do
         event_loop.notify(:method, 1, 2)
+        connection.flush
         message = server_rd.readpartial(1024)
+
         expect(message).to eq(MessagePack.pack([2, "method", [1, 2]]))
       end
     end

data/spec/neovim/session_spec.rb

@@ -24,6 +24,12 @@ module Neovim
         expect(session.request(:nvim_get_current_line)).to eq(large_str)
       end
 
+      it "raises an exception when a command causes nvim to exit" do
+        expect do
+          session.request(:nvim_command, "qa!")
+        end.to raise_error(Neovim::Session::Exited, /exited/)
+      end
+
       it "fails outside of the main thread", :silence_thread_exceptions do
         expect do
           Thread.new { session.request(:nvim_strwidth, "foo") }.join

data/spec/support.rb

@@ -4,7 +4,7 @@ module Support
   end
 
   def self.workspace
-    File.expand_path("../workspace", __FILE__)
+    File.expand_path("workspace", __dir__)
   end
 
   def self.socket_path

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: neovim
 version: !ruby/object:Gem::Version
-  version: 0.7.1
+  version: 0.8.0
 platform: ruby
 authors:
 - Alex Genco
 autorequire: 
-bindir: bin
+bindir: exe
 cert_chain: []
-date: 2018-03-04 00:00:00.000000000 Z
+date: 2018-12-27 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: msgpack
@@ -52,20 +52,6 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
-- !ruby/object:Gem::Dependency
-  name: coveralls
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
 - !ruby/object:Gem::Dependency
   name: pry
   requirement: !ruby/object:Gem::Requirement
@@ -128,14 +114,14 @@ dependencies:
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 0.52.1
+        version: 0.56.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - '='
       - !ruby/object:Gem::Version
-        version: 0.52.1
+        version: 0.56.0
 - !ruby/object:Gem::Dependency
   name: vim-flavor
   requirement: !ruby/object:Gem::Requirement
@@ -158,7 +144,6 @@ executables:
 extensions: []
 extra_rdoc_files: []
 files:
-- ".coveralls.yml"
 - ".gitignore"
 - ".rubocop.yml"
 - ".travis.yml"
@@ -170,7 +155,7 @@ files:
 - Rakefile
 - VimFlavor
 - appveyor.yml
-- bin/neovim-ruby-host
+- exe/neovim-ruby-host
 - lib/neovim.rb
 - lib/neovim/api.rb
 - lib/neovim/buffer.rb
@@ -246,7 +231,7 @@ files:
 - spec/neovim/window_spec.rb
 - spec/neovim_spec.rb
 - spec/support.rb
-homepage: https://github.com/alexgenco/neovim-ruby
+homepage: https://github.com/neovim/neovim-ruby
 licenses:
 - MIT
 metadata: {}
@@ -266,7 +251,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.6.13
+rubygems_version: 2.7.8
 signing_key: 
 specification_version: 4
 summary: A Ruby client for Neovim

data/.coveralls.yml

@@ -1 +0,0 @@
-service_name: travis-ci