neovim 0.7.0 → 0.7.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA256:
-  metadata.gz: 3699ba73810bb643b4a8412a6469d6c0ec95fb138248e4f9a391b7637681cb06
-  data.tar.gz: 9d4e6c4513864df909a791eb23420918fe0426aeeb8d2f2929e6d52cb2b2f48e
+SHA1:
+  metadata.gz: 97582ab6b5d7a61143cc0d0e3e1a5ffec8b6c292
+  data.tar.gz: 1b6c5905f2c870f4fd77490a144a32337f0eef11
 SHA512:
-  metadata.gz: bf087be0814ddb1a5d765e84e462991bccef0ba8135691da379a22393d3743dcbef9cd65307f54cdbb16a8a87e5ccca72c7dbc845714b3035818f2f2108f121c
-  data.tar.gz: e5b78dde7090c6ade20a1869ffacee5f3e1cefdd764be149a6db81fe2f3564c26f570f99b9f048ed3eb1fe9b8f5119febfa11fc01d42bad93a21f9a52caffda0
+  metadata.gz: 01f995a41e2ece2e05228762b8e0d9ca36428bbf6bf896eb388e19b34869ede4d972395d5300381e4f4706e0426bafc6f82f0abd053aab4fa157b232db190f15
+  data.tar.gz: e55008b53e7d042c631032455be96e81715256b1c2763c98f23a7891b44b89e88c1e4a449232bba9716a280844766c03666e346bc2943e6b025b9fc12a6234e8

data/.gitignore

@@ -5,6 +5,7 @@
 .config
 .yardoc
 Gemfile.lock
+VimFlavor.lock
 InstalledFiles
 _yardoc
 coverage
@@ -17,5 +18,6 @@ test/tmp
 test/version_tmp
 tmp
 spec/workspace
-spec/acceptance/runtime/rplugin.vim
+spec/acceptance/runtime/flavors
+spec/acceptance/runtime/rplugin_manifest.vim
 vendor/bundle

data/.rubocop.yml

@@ -0,0 +1,118 @@
+AllCops:
+  Exclude:
+    - _neovim/**/*
+    - spec/acceptance/**/*
+    - vendor/**/*
+    - script/**/*
+
+Layout/EndOfLine:
+  EnforcedStyle: lf
+
+Layout/SpaceAroundEqualsInParameterDefault:
+  EnforcedStyle: no_space
+
+Layout/SpaceInsideHashLiteralBraces:
+  EnforcedStyle: no_space
+
+Lint/AmbiguousBlockAssociation:
+  Exclude:
+    - spec/**/*
+
+Lint/HandleExceptions:
+  Exclude:
+    - lib/neovim/ruby_provider.rb
+    - lib/neovim/logging.rb
+    - lib/neovim/connection.rb
+    - lib/neovim/line_range.rb
+
+Lint/RescueException:
+  Exclude:
+    - lib/neovim/host.rb
+
+Lint/UnderscorePrefixedVariableName:
+  Exclude:
+    - lib/neovim/ruby_provider.rb
+
+Lint/UselessAccessModifier:
+  Exclude:
+    - lib/neovim/buffer.rb
+    - lib/neovim/client.rb
+
+Lint/Void:
+  Exclude:
+    - lib/neovim/window.rb
+
+Metrics/AbcSize:
+  Max: 20
+
+Metrics/BlockLength:
+  Exclude:
+    - spec/**/*
+
+Metrics/ClassLength:
+  Max: 500
+
+Metrics/LineLength:
+  Max: 125
+
+Metrics/MethodLength:
+  Max: 50
+
+Metrics/ModuleLength:
+  Exclude:
+    - spec/**/*
+
+Metrics/ParameterLists:
+  Max: 6
+
+Naming/AccessorMethodName:
+  Exclude:
+    - lib/neovim/client.rb
+
+Security/Eval:
+  Exclude:
+    - lib/neovim/ruby_provider.rb
+
+Style/BlockComments:
+  Exclude:
+    - lib/neovim/buffer.rb
+    - lib/neovim/client.rb
+    - lib/neovim/tabpage.rb
+    - lib/neovim/window.rb
+
+Style/ConditionalAssignment:
+  EnforcedStyle: assign_inside_condition
+  IncludeTernaryExpressions: false
+
+Style/DoubleNegation:
+  Enabled: false
+
+Style/FormatStringToken:
+  EnforcedStyle: unannotated
+
+Style/GlobalVars:
+  Exclude:
+    - lib/neovim/ruby_provider/vim.rb
+    - spec/neovim/ruby_provider/vim_spec.rb
+
+Style/ParallelAssignment:
+  Enabled: false
+
+Style/RescueStandardError:
+  EnforcedStyle: implicit
+
+Style/SpecialGlobalVars:
+  EnforcedStyle: use_perl_names
+
+Style/StringLiterals:
+  EnforcedStyle: double_quotes
+
+Style/SymbolArray:
+  EnforcedStyle: brackets
+
+Style/WordArray:
+  EnforcedStyle: brackets
+
+Style/ZeroLengthPredicate:
+  Exclude:
+    - lib/neovim/ruby_provider.rb

data/.travis.yml

@@ -13,7 +13,7 @@ rvm:
   - ruby-head
 
 before_install:
-  - eval "$(curl -Ss https://raw.githubusercontent.com/neovim/bot-ci/master/scripts/travis-setup.sh) nightly-x64"
+  - eval "$(curl --connect-timeout 30 --retry 3 -Ss https://raw.githubusercontent.com/neovim/bot-ci/master/scripts/travis-setup.sh) nightly-x64"
   - gem update --system
   - gem update bundler
   - bundle --version

data/CHANGELOG.md

@@ -1,3 +1,8 @@
+# 0.7.1
+
+- Fix `uninitialized constant Neovim::RubyProvider::StringIO`
+- Various backwards-compatible style changes to satisfy Rubocop rules
+
 # 0.7.0
 
 - Drop support for Ruby < 2.2.0, update syntax accordingly

data/Rakefile

@@ -1,27 +1,40 @@
 require "bundler/gem_tasks"
 require "rspec/core/rake_task"
+require "rubocop/rake_task"
 
-desc "Generate Neovim remote API docs"
-task :docs do
-  sh File.expand_path("../script/generate_docs", __FILE__)
-end
-
-desc "Dump nvim remote API"
-task :api do
-  sh File.expand_path("../script/dump_api", __FILE__)
-end
+RuboCop::RakeTask.new(:style)
 
 namespace :spec do
   desc "Run functional specs"
-  RSpec::Core::RakeTask.new(:functional) do |t|
-    t.exclude_pattern = "spec/acceptance_spec.rb,spec/acceptance/**/*"
-  end
+  RSpec::Core::RakeTask.new(:functional)
 
   desc "Run acceptance specs"
-  RSpec::Core::RakeTask.new(:acceptance) do |t|
-    t.pattern = "spec/acceptance_spec.rb"
-    t.rspec_opts = "--format documentation"
+  task acceptance: "acceptance:deps" do
+    run_script(:run_acceptance, "--reporter", "dot", "spec/acceptance")
+  end
+
+  namespace :acceptance do
+    desc "Install acceptance spec dependencies"
+    task :deps do
+      sh "bundle exec vim-flavor update --vimfiles-path=spec/acceptance/runtime"
+    end
   end
 end
 
-task default: ["spec:functional", "spec:acceptance"]
+namespace :docs do
+  desc "Generate Neovim remote API docs"
+  task :generate do
+    run_script(:generate_docs)
+  end
+
+  desc "Validate generated documentation is up-to-date"
+  task :validate do
+    run_script(:validate_docs)
+  end
+end
+
+task default: [:style, "spec:functional", "spec:acceptance", "docs:validate"]
+
+def run_script(script_name, *args)
+  ruby File.expand_path("../script/#{script_name}.rb", __FILE__), *args
+end

data/VimFlavor

@@ -0,0 +1 @@
+flavor "thinca/vim-themis", branch: "master"

data/appveyor.yml

@@ -2,11 +2,13 @@ version: '{build}'
 
 environment:
   matrix:
+    - RUBY_VERSION: 25
     - RUBY_VERSION: 24
     - RUBY_VERSION: 23
     - RUBY_VERSION: 22
 
 install:
+  - set SSL_CERT_FILE=C:/ruby24-x64/ssl/cert.pem
   - set PATH=C:\Ruby%RUBY_VERSION%\bin;C:\tools\neovim\Neovim\bin;%PATH%
   - set NVIM_RUBY_LOG_LEVEL=DEBUG
   - set NVIM_RUBY_LOG_FILE=%cd%\ci.log

data/lib/neovim/api.rb

@@ -32,7 +32,7 @@ module Neovim
 
     # Truncate the output of inspect so console sessions are more pleasant.
     def inspect
-      "#<#{self.class}:0x%x @channel_id=#{@channel_id.inspect} @types={...} @functions={...}>" % (object_id << 1)
+      format("#<#{self.class}:0x%x @channel_id=#{@channel_id.inspect}>", object_id << 1)
     end
 
     private
@@ -67,6 +67,7 @@ module Neovim
       end
     end
 
+    # @api private
     class Function
       attr_reader :name
 

data/lib/neovim/buffer.rb

@@ -55,7 +55,7 @@ module Neovim
     # @return [String]
     def [](index)
       check_index(index)
-      @lines[index-1]
+      @lines[index - 1]
     end
 
     # Set the given line (1-indexed).
@@ -65,7 +65,7 @@ module Neovim
     # @return [String]
     def []=(index, str)
       check_index(index)
-      @lines[index-1] = str
+      @lines[index - 1] = str
     end
 
     # Delete the given line (1-indexed).
@@ -74,7 +74,7 @@ module Neovim
     # @return [void]
     def delete(index)
       check_index(index)
-      @lines.delete(index-1)
+      @lines.delete(index - 1)
       nil
     end
 
@@ -100,9 +100,7 @@ module Neovim
     #
     # @return [String, nil]
     def line
-      if active?
-        @session.request(:nvim_get_current_line)
-      end
+      @session.request(:nvim_get_current_line) if active?
     end
 
     # Set the current line of an active buffer.
@@ -110,18 +108,14 @@ module Neovim
     # @param str [String]
     # @return [String, nil]
     def line=(str)
-      if active?
-        @session.request(:nvim_set_current_line, str)
-      end
+      @session.request(:nvim_set_current_line, str) if active?
     end
 
     # Get the current line number of an active buffer.
     #
     # @return [Integer, nil]
     def line_number
-      if active?
-        @session.request(:nvim_get_current_win).get_cursor[0]
-      end
+      @session.request(:nvim_get_current_win).get_cursor[0] if active?
     end
 
     # Determine if the buffer is active.
@@ -134,9 +128,7 @@ module Neovim
     private
 
     def check_index(index)
-      if index < 0
-        raise ArgumentError, "Index out of bounds"
-      end
+      raise ArgumentError, "Index out of bounds" if index < 0
     end
 
     public

data/lib/neovim/client.rb

@@ -30,15 +30,15 @@ module Neovim
 
     # Intercept method calls and delegate to appropriate RPC methods.
     def method_missing(method_name, *args)
-      if func = @api.function_for_object_method(self, method_name)
+      if (func = @api.function_for_object_method(self, method_name))
         func.call(@session, *args)
       else
         super
       end
     end
 
-    # Extend +respond_to?+ to support RPC methods.
-    def respond_to?(method_name, *)
+    # Extend +respond_to_missing?+ to support RPC methods.
+    def respond_to_missing?(method_name, *)
       super || rpc_methods.include?(method_name.to_sym)
     end
 

data/lib/neovim/connection.rb

@@ -17,12 +17,11 @@ module Neovim
       new(socket, socket)
     end
 
-    def self.child(_argv)
-      argv = _argv.include?("--embed") ? _argv : _argv + ["--embed"]
+    def self.child(argv)
+      argv = argv.include?("--embed") ? argv : argv + ["--embed"]
 
-      io = ::IO.popen(argv, "rb+").tap do |_io|
-        Process.detach(_io.pid)
-      end
+      io = ::IO.popen(argv, "rb+")
+      Process.detach(io.pid)
 
       new(io, io)
     end
@@ -50,10 +49,10 @@ module Neovim
       end
     end
 
-    def register_type(id, &block)
+    def register_type(id)
       @unpacker.register_type(id) do |data|
         index = MessagePack.unpack(data)
-        block.call(index)
+        yield index
       end
     end
 

data/lib/neovim/event_loop.rb

@@ -67,15 +67,15 @@ module Neovim
       write(:notification, method, args)
     end
 
-    def run(&callback)
+    def run
       @running = true
 
       loop do
-        break if !@running
+        break unless @running
         break if @shutdown
 
         begin
-          callback.call(read)
+          yield read
         rescue EOFError => e
           log_exception(:debug, e, __method__)
           shutdown

data/lib/neovim/executable.rb

@@ -1,4 +1,5 @@
 module Neovim
+  # Object representing the `nvim` executable.
   class Executable
     VERSION_PATTERN = /\ANVIM v?(.+)$/
 

data/lib/neovim/host.rb

@@ -31,9 +31,9 @@ module Neovim
     def handle(message)
       log(:debug) { message.to_h }
 
-      @handlers.
-        fetch(message.method_name, default_handler).
-        call(@client, message)
+      @handlers
+        .fetch(message.method_name, default_handler)
+        .call(@client, message)
     rescue Exception => e
       log_exception(:error, e, __method__)
 
@@ -43,22 +43,22 @@ module Neovim
         @client.err_writeln("Exception handling #{message.method_name}: (#{e.class}) #{e.message}")
       end
 
-      raise unless StandardError === e
+      raise unless e.is_a?(StandardError)
     end
 
     private
 
     def poll_handler
-      @poll_handler ||= -> (_, req) {
+      @poll_handler ||= lambda do |_, req|
         initialize_client(req.id)
         initialize_plugins
 
         @session.respond(req.id, "ok")
-      }
+      end
     end
 
     def specs_handler
-      @specs_handler ||= -> (_, req) {
+      @specs_handler ||= lambda do |_, req|
         source = req.arguments.fetch(0)
 
         if @specs.key?(source)
@@ -66,14 +66,14 @@ module Neovim
         else
           @session.respond(req.id, nil, "Unknown plugin #{source}")
         end
-      }
+      end
     end
 
     def default_handler
-      @default_handler ||= -> (_, message) {
+      @default_handler ||= lambda do |_, message|
         next unless message.sync?
         @session.respond(message.id, nil, "Unknown request #{message.method_name}")
-      }
+      end
     end
 
     def initialize_client(request_id)
@@ -93,12 +93,12 @@ module Neovim
     end
 
     def wrap_plugin_handler(handler)
-      -> (client, message) {
+      lambda do |client, message|
         args = message.arguments.flatten(1)
         result = handler.call(client, *args)
 
         @session.respond(message.id, result) if message.sync?
-      }
+      end
     end
   end
 end