neography 0.0.31 → 1.0.0

data/spec/integration/rest_node_spec.rb

@@ -1,4 +1,4 @@
-require File.join(File.dirname(__FILE__), '..', 'spec_helper')
+require 'spec_helper'
 
 describe Neography::Rest do
   before(:each) do
@@ -64,11 +64,12 @@ describe Neography::Rest do
       existing_node["self"].split('/').last.should == new_node[:id]
     end
 
-    it "returns nil if it tries to get a node that does not exist" do
+    it "raises an error if it tries to get a node that does not exist" do
       new_node = @neo.create_node
       fake_node = new_node["self"].split('/').last.to_i + 1000
-      existing_node = @neo.get_node(fake_node)
-      existing_node.should be_nil
+      expect {
+        @neo.get_node(fake_node)
+      }.to raise_error Neography::NodeNotFoundException
     end
   end
 
@@ -84,9 +85,9 @@ describe Neography::Rest do
     it "it fails to set properties on a node that does not exist" do
       new_node = @neo.create_node
       fake_node = new_node["self"].split('/').last.to_i + 1000
-      @neo.set_node_properties(fake_node, {"weight" => 150, "hair" => "blonde"})
-      node_properties = @neo.get_node_properties(fake_node)
-      node_properties.should be_nil
+      expect {
+        @neo.set_node_properties(fake_node, {"weight" => 150, "hair" => "blonde"})
+      }.to raise_error Neography::NodeNotFoundException
     end
   end
 
@@ -104,9 +105,9 @@ describe Neography::Rest do
     it "it fails to reset properties on a node that does not exist" do
       new_node = @neo.create_node
       fake_node = new_node["self"].split('/').last.to_i + 1000
-      @neo.reset_node_properties(fake_node, {"weight" => 170, "eyes" => "green"})
-      node_properties = @neo.get_node_properties(fake_node)
-      node_properties.should be_nil
+      expect {
+        @neo.reset_node_properties(fake_node, {"weight" => 170, "eyes" => "green"})
+      }.to raise_error Neography::NodeNotFoundException
     end
   end
 
@@ -131,15 +132,19 @@ describe Neography::Rest do
       @neo.get_node_properties(new_node).should be_nil
     end
 
-    it "returns nil if it tries to get some of the properties on a node that does not have any" do
+    it "raises error if it tries to get some of the properties on a node that does not have any" do
       new_node = @neo.create_node
-      @neo.get_node_properties(new_node, ["weight", "height"]).should be_nil
+      expect {
+        @neo.get_node_properties(new_node, ["weight", "height"]).should be_nil
+      }.to raise_error Neography::NoSuchPropertyException
     end
 
-    it "returns nil if it fails to get properties on a node that does not exist" do
+    it "raises error if it fails to get properties on a node that does not exist" do
       new_node = @neo.create_node
       fake_node = new_node["self"].split('/').last.to_i + 1000
-      @neo.get_node_properties(fake_node).should be_nil
+      expect {
+        @neo.get_node_properties(fake_node).should be_nil
+      }.to raise_error Neography::NodeNotFoundException
     end
   end
 
@@ -150,10 +155,12 @@ describe Neography::Rest do
       @neo.get_node_properties(new_node).should be_nil
     end
 
-    it "returns nil if it fails to remove the properties of a node that does not exist" do
+    it "raises error if it fails to remove the properties of a node that does not exist" do
       new_node = @neo.create_node
       fake_node = new_node["self"].split('/').last.to_i + 1000
-      @neo.remove_node_properties(fake_node).should be_nil
+      expect {
+        @neo.remove_node_properties(fake_node).should be_nil
+      }.to raise_error Neography::NodeNotFoundException
     end
 
     it "can remove a specific node property" do
@@ -177,35 +184,39 @@ describe Neography::Rest do
     it "can delete an unrelated node" do
       new_node = @neo.create_node
       @neo.delete_node(new_node).should be_nil
-      existing_node = @neo.get_node(new_node)
-      existing_node.should be_nil
+      expect {
+        @neo.get_node(new_node)
+      }.to raise_error Neography::NodeNotFoundException
     end
 
     it "cannot delete a node that has relationships" do
       new_node1 = @neo.create_node
       new_node2 = @neo.create_node
       @neo.create_relationship("friends", new_node1, new_node2)
-      @neo.delete_node(new_node1).should be_nil
+      expect {
+        @neo.delete_node(new_node1).should be_nil
+      }.to raise_error Neography::OperationFailureException
       existing_node = @neo.get_node(new_node1)
       existing_node.should_not be_nil
     end
 
-    it "returns nil if it tries to delete a node that does not exist" do
+    it "raises error if it tries to delete a node that does not exist" do
       new_node = @neo.create_node
       fake_node = new_node["self"].split('/').last.to_i + 1000
-      @neo.delete_node(fake_node).should be_nil
-      existing_node = @neo.get_node(fake_node)
-      existing_node.should be_nil
+      expect {
+        @neo.delete_node(fake_node).should be_nil
+      }.to raise_error Neography::NodeNotFoundException
     end
 
-    it "returns nil if it tries to delete a node that has already been deleted" do
+    it "raises error if it tries to delete a node that has already been deleted" do
       new_node = @neo.create_node
       @neo.delete_node(new_node).should be_nil
-      existing_node = @neo.get_node(new_node)
-      existing_node.should be_nil
-      @neo.delete_node(new_node).should be_nil
-      existing_node = @neo.get_node(new_node)
-      existing_node.should be_nil
+      expect {
+        existing_node = @neo.get_node(new_node)
+      }.to raise_error Neography::NodeNotFoundException
+      expect {
+        @neo.delete_node(new_node).should be_nil
+      }.to raise_error Neography::NodeNotFoundException
     end
   end
 
@@ -213,8 +224,9 @@ describe Neography::Rest do
     it "can delete an unrelated node" do
       new_node = @neo.create_node
       @neo.delete_node!(new_node).should be_nil
-      existing_node = @neo.get_node(new_node)
-      existing_node.should be_nil
+      expect {
+        existing_node = @neo.get_node(new_node)
+      }.to raise_error Neography::NodeNotFoundException
     end
 
     it "can delete a node that has relationships" do
@@ -222,27 +234,29 @@ describe Neography::Rest do
       new_node2 = @neo.create_node
       @neo.create_relationship("friends", new_node1, new_node2)
       @neo.delete_node!(new_node1).should be_nil
-      existing_node = @neo.get_node(new_node1)
-      existing_node.should be_nil
+      expect {
+        existing_node = @neo.get_node(new_node1)
+      }.to raise_error Neography::NodeNotFoundException
     end
 
-    it "returns nil if it tries to delete a node that does not exist" do
+    it "raises error if it tries to delete a node that does not exist" do
       new_node = @neo.create_node
       fake_node = new_node["self"].split('/').last.to_i + 1000
-      @neo.delete_node!(fake_node).should be_nil
-      existing_node = @neo.get_node(fake_node)
-      existing_node.should be_nil
+      expect {
+        @neo.delete_node!(fake_node).should be_nil
+      }.to raise_error Neography::NodeNotFoundException
     end
 
-    it "returns nil if it tries to delete a node that has already been deleted" do
+    it "raises error if it tries to delete a node that has already been deleted" do
       new_node = @neo.create_node
       @neo.delete_node!(new_node).should be_nil
-      existing_node = @neo.get_node(new_node)
-      existing_node.should be_nil
-      @neo.delete_node!(new_node).should be_nil
-      existing_node = @neo.get_node(new_node)
-      existing_node.should be_nil
+      expect {
+        existing_node = @neo.get_node(new_node)
+      }.to raise_error Neography::NodeNotFoundException
+      expect {
+        @neo.delete_node!(new_node).should be_nil
+      }.to raise_error Neography::NodeNotFoundException
     end
   end
 
-end
+end

data/spec/integration/rest_path_spec.rb

@@ -1,4 +1,4 @@
-require File.join(File.dirname(__FILE__), '..', 'spec_helper')
+require 'spec_helper'
 
 describe Neography::Rest do
   before(:each) do
@@ -83,9 +83,9 @@ describe Neography::Rest do
       @neo.create_relationship("friends", new_node3, new_node4)
       @neo.create_relationship("friends", new_node4, new_node5)
       @neo.create_relationship("friends", new_node3, new_node5)
-      path = @neo.get_path(new_node1, new_node5, {"type"=> "friends", "direction" => "out"}, depth=2, algorithm="shortestPath")
-      path["start"].should be_nil
-      path["end"].should be_nil
+      expect {
+        @neo.get_path(new_node1, new_node5, {"type"=> "friends", "direction" => "out"}, depth=2, algorithm="shortestPath")
+      }.to raise_error Neography::NotFoundException
     end
 
     it "can get a path between two nodes of a specific relationship" do
@@ -228,4 +228,4 @@ describe Neography::Rest do
   end
 
 
-end
+end

data/spec/integration/rest_plugin_spec.rb

@@ -1,4 +1,4 @@
-require File.join(File.dirname(__FILE__), '..', 'spec_helper')
+require 'spec_helper'
 
 describe Neography::Rest do
   before(:each) do
@@ -62,6 +62,12 @@ describe Neography::Rest do
       existing_node["data"][0][0]["self"].split('/').last.should == id
     end
 
+    it "throws an error for an invalid query" do
+      expect {
+        @neo.execute_query("this is not a query")
+      }.to raise_error(Neography::SyntaxException)
+    end
+
   end
 
-end
+end

data/spec/integration/rest_relationship_spec.rb

@@ -1,4 +1,4 @@
-require File.join(File.dirname(__FILE__), '..', 'spec_helper')
+require 'spec_helper'
 
 describe Neography::Rest do
   before(:each) do
@@ -30,7 +30,7 @@ describe Neography::Rest do
       new_relationship["data"]["since"].should == '10-1-2010'
       new_relationship["data"]["met"].should == "college"
     end
-    
+
     it "can create a unique node with more than one property" do
       index_name = generate_text(6)
       key = generate_text(6)
@@ -40,7 +40,7 @@ describe Neography::Rest do
       new_node["data"]["name"].should == "Max"
       new_node["data"]["age"].should == 31
     end
-    
+
     it "can create a unique relationship" do
       index_name = generate_text(6)
       key = generate_text(6)
@@ -51,7 +51,6 @@ describe Neography::Rest do
       new_relationship["data"][key].should == value
     end
 
-    
   end
 
   describe "get_relationship" do
@@ -65,13 +64,14 @@ describe Neography::Rest do
       existing_relationship["self"].should == new_relationship["self"]
     end
 
-    it "returns nil if it tries to get a relationship that does not exist" do
+    it "raises error if it tries to get a relationship that does not exist" do
       new_node1 = @neo.create_node
       new_node2 = @neo.create_node
       new_relationship = @neo.create_relationship("friends", new_node1, new_node2)
       fake_relationship = new_relationship["self"].split('/').last.to_i + 1000
-      existing_relationship = @neo.get_relationship(fake_relationship)
-      existing_relationship.should be_nil
+      expect {
+        existing_relationship = @neo.get_relationship(fake_relationship)
+      }.to raise_error Neography::RelationshipNotFoundException
     end
   end
 
@@ -93,9 +93,9 @@ describe Neography::Rest do
       new_node2 = @neo.create_node
       new_relationship = @neo.create_relationship("friends", new_node1, new_node2)
       fake_relationship = new_relationship["self"].split('/').last.to_i + 1000
-      @neo.set_relationship_properties(fake_relationship, {"since" => '10-1-2010', "met" => "college"})
-      relationship_properties = @neo.get_relationship_properties(fake_relationship)
-      relationship_properties.should be_nil
+      expect {
+        @neo.set_relationship_properties(fake_relationship, {"since" => '10-1-2010', "met" => "college"})
+      }.to raise_error Neography::RelationshipNotFoundException
     end
   end
 
@@ -117,9 +117,9 @@ describe Neography::Rest do
       new_node2 = @neo.create_node
       new_relationship = @neo.create_relationship("friends", new_node1, new_node2)
       fake_relationship = new_relationship["self"].split('/').last.to_i + 1000
-      @neo.reset_relationship_properties(fake_relationship, {"since" => '10-1-2010', "met" => "college"})
-      relationship_properties = @neo.get_relationship_properties(fake_relationship)
-      relationship_properties.should be_nil
+      expect {
+        @neo.reset_relationship_properties(fake_relationship, {"since" => '10-1-2010', "met" => "college"})
+      }.to raise_error Neography::RelationshipNotFoundException
     end
   end
 
@@ -151,21 +151,23 @@ describe Neography::Rest do
       relationship_properties.should be_nil
     end
 
-    it "returns nil if it tries to get some of the properties on a relationship that does not have any" do
+    it "raises error if it tries to get some of the properties on a relationship that does not have any" do
       new_node1 = @neo.create_node
       new_node2 = @neo.create_node
       new_relationship = @neo.create_relationship("friends", new_node1, new_node2)
-      relationship_properties = @neo.get_relationship_properties(new_relationship, ["since", "roommates"])
-      relationship_properties.should be_nil
+      expect {
+        @neo.get_relationship_properties(new_relationship, ["since", "roommates"])
+      }.to raise_error Neography::NoSuchPropertyException
     end
 
-    it "returns nil if it fails to get properties on a relationship that does not exist" do
+    it "raises error if it fails to get properties on a relationship that does not exist" do
       new_node1 = @neo.create_node
       new_node2 = @neo.create_node
       new_relationship = @neo.create_relationship("friends", new_node1, new_node2)
       fake_relationship = new_relationship["self"].split('/').last.to_i + 1000
-      relationship_properties = @neo.get_relationship_properties(fake_relationship)
-      relationship_properties.should be_nil
+      expect {
+        @neo.get_relationship_properties(fake_relationship)
+      }.to raise_error Neography::RelationshipNotFoundException
     end
   end
 
@@ -178,13 +180,14 @@ describe Neography::Rest do
       @neo.get_relationship_properties(new_relationship).should be_nil
     end
 
-    it "returns nil if it fails to remove the properties of a relationship that does not exist" do
+    it "raises error if it fails to remove the properties of a relationship that does not exist" do
       new_node1 = @neo.create_node
       new_node2 = @neo.create_node
       new_relationship = @neo.create_relationship("friends", new_node1, new_node2, {"since" => '10-1-2010', "met" => "college"})
       fake_relationship = new_relationship["self"].split('/').last.to_i + 1000
-      @neo.remove_relationship_properties(fake_relationship).should be_nil
-      @neo.get_relationship_properties(fake_relationship).should be_nil
+      expect {
+        @neo.remove_relationship_properties(fake_relationship)
+      }.to raise_error Neography::RelationshipNotFoundException
     end
 
     it "can remove a specific relationship property" do
@@ -192,7 +195,7 @@ describe Neography::Rest do
       new_node2 = @neo.create_node
       new_relationship = @neo.create_relationship("friends", new_node1, new_node2, {"since" => '10-1-2010', "met" => "college"})
       @neo.remove_relationship_properties(new_relationship, "met")
-      relationship_properties = @neo.get_relationship_properties(new_relationship, ["met", "since"])
+      relationship_properties = @neo.get_relationship_properties(new_relationship)
       relationship_properties["met"].should be_nil
       relationship_properties["since"].should == '10-1-2010'
     end
@@ -202,7 +205,7 @@ describe Neography::Rest do
       new_node2 = @neo.create_node
       new_relationship = @neo.create_relationship("friends", new_node1, new_node2, {"since" => '10-1-2010', "met" => "college", "roommates" => "no"})
       @neo.remove_relationship_properties(new_relationship, ["met", "since"])
-      relationship_properties = @neo.get_relationship_properties(new_relationship, ["since", "met", "roommates"])
+      relationship_properties = @neo.get_relationship_properties(new_relationship)
       relationship_properties["met"].should be_nil
       relationship_properties["since"].should be_nil
       relationship_properties["roommates"].should == "no"
@@ -219,13 +222,14 @@ describe Neography::Rest do
       relationships.should be_nil
     end
 
-    it "returns nil if it tries to delete a relationship that does not exist" do
+    it "raises error if it tries to delete a relationship that does not exist" do
       new_node1 = @neo.create_node
       new_node2 = @neo.create_node
       new_relationship = @neo.create_relationship("friends", new_node1, new_node2, {"since" => '10-1-2010', "met" => "college"})
       fake_relationship = new_relationship["self"].split('/').last.to_i + 1000
-      existing_relationship = @neo.delete_relationship(fake_relationship)
-      existing_relationship.should be_nil
+      expect {
+        existing_relationship = @neo.delete_relationship(fake_relationship)
+      }.to raise_error Neography::RelationshipNotFoundException
     end
 
     it "returns nil if it tries to delete a relationship that has already been deleted" do
@@ -234,8 +238,9 @@ describe Neography::Rest do
       new_relationship = @neo.create_relationship("friends", new_node1, new_node2, {"since" => '10-1-2010', "met" => "college"})
       existing_relationship = @neo.delete_relationship(new_relationship)
       existing_relationship.should be_nil
-      existing_relationship = @neo.delete_relationship(new_relationship)
-      existing_relationship.should be_nil
+      expect {
+        existing_relationship = @neo.delete_relationship(new_relationship)
+      }.to raise_error Neography::RelationshipNotFoundException
     end
   end
 
@@ -346,4 +351,4 @@ describe Neography::Rest do
     end
   end
 
-end
+end

data/spec/integration/rest_traverse_spec.rb

@@ -1,4 +1,4 @@
-require File.join(File.dirname(__FILE__), '..', 'spec_helper')
+require 'spec_helper'
 
 describe Neography::Rest do
   before(:each) do
@@ -146,4 +146,4 @@ describe Neography::Rest do
 
   end
 
-end
+end

data/spec/matchers.rb

@@ -0,0 +1,33 @@
+# Convenience matcher for matching JSON fields with a hash
+RSpec::Matchers.define :json_match do |field, expected|
+
+  match do |actual|
+    expected == JSON.parse(actual[field])
+  end
+
+  failure_message_for_should do
+    "expected JSON in field '#{field}' to match '#{expected}'"
+  end
+
+  description do
+    "JSON in field '#{field}' should match '#{expected.inspect}'"
+  end
+
+end
+
+# Convenience matcher for matching fields in a hash
+RSpec::Matchers.define :hash_match do |field, expected|
+
+  match do |actual|
+    expected == actual[field]
+  end
+
+  failure_message_for_should do
+    "expected field '#{field}' to match '#{expected}'"
+  end
+
+  description do
+    "field '#{field}' should match '#{expected.inspect}'"
+  end
+
+end

data/spec/neography_spec.rb

@@ -0,0 +1,23 @@
+require 'spec_helper'
+
+describe Neography do
+
+  describe "::configure" do
+
+    it "returns the same configuration" do
+      Neography.configuration.should == Neography.configuration
+    end
+
+    it "returns the Config" do
+      Neography.configuration.should be_a Neography::Config
+    end
+
+    it "yields the configuration" do
+      Neography.configure do |config|
+        config.should == Neography.configuration
+      end
+    end
+
+  end
+
+end

data/spec/spec_helper.rb

@@ -1,5 +1,6 @@
 require 'neography'
 require 'benchmark'
+require 'matchers'
 
 # If you want to see more, uncomment the next few lines
 # require 'net-http-spy'
@@ -15,4 +16,21 @@ end
 
 RSpec.configure do |c|
   c.filter_run_excluding :slow => true, :break_gremlin => true
-end
+end
+
+
+def json_content_type
+  {"Content-Type"=>"application/json"}
+end
+
+def error_response(attributes)
+  stub(
+    code: attributes[:code],
+    body: {
+    message:   attributes[:message],
+    exception: attributes[:exception],
+    stacktrace: attributes[:stacktrace]
+  }.reject { |k,v| v.nil? }.to_json
+  )
+end
+

data/spec/unit/config_spec.rb

@@ -0,0 +1,46 @@
+require 'spec_helper'
+
+module Neography
+  describe Config do
+
+    subject(:config)
+
+    context "defaults" do
+
+      its(:protocol)       { should == 'http://' }
+      its(:server)         { should == 'localhost' }
+      its(:port)           { should == 7474 }
+      its(:directory)      { should == '' }
+      its(:cypher_path)    { should == '/cypher' }
+      its(:gremlin_path)   { should == '/ext/GremlinPlugin/graphdb/execute_script' }
+      its(:log_file)       { should == 'neography.log' }
+      its(:log_enabled)    { should == false }
+      its(:max_threads)    { should == 20 }
+      its(:authentication) { should == nil }
+      its(:username)       { should == nil }
+      its(:password)       { should == nil }
+      its(:parser)         { should == { :parser => MultiJsonParser } }
+
+      it "has a hash representation" do
+        expected_hash = {
+          :protocol       => 'http://',
+          :server         => 'localhost',
+          :port           => 7474,
+          :directory      => '',
+          :cypher_path    => '/cypher',
+          :gremlin_path   => '/ext/GremlinPlugin/graphdb/execute_script',
+          :log_file       => 'neography.log',
+          :log_enabled    => false,
+          :max_threads    => 20,
+          :authentication => nil,
+          :username       => nil,
+          :password       => nil,
+          :parser         => { :parser => MultiJsonParser }
+        }
+        config.to_hash.should == expected_hash
+      end
+
+    end
+
+  end
+end