neo4j 9.1.7 → 9.1.8

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 629a77a4c318a7b47878d92f72053bc34714092b
-  data.tar.gz: 61dccf00f3e329d4ce1e4a9a7cd9074508068b97
+  metadata.gz: 842191c44b13a4617ba19ce62e6b5d3179678c1e
+  data.tar.gz: 43f5f578a72409ee07c739331212c72b0a4996be
 SHA512:
-  metadata.gz: 4153c3488109fc16d8001e5f53d416baf0646e5790f16deb51f6e2eacf535ef52914b2c71929d39a2d7ce61847c3fce148ad04d3437e786f80836db314bcbeae
-  data.tar.gz: 351b07006b2055702e5272c9bb9baaf88d99add95533f012afa6422a9114e64b6904e6b5d188026896a777a64c346b980cf7cecd449719af4aa0431394d78e9f
+  metadata.gz: c0f44c117c92a7ab2851d58ac0a515a3f72e63826fae0939088681832cce66022da8f3b6ea93319d413d3f80015e0ae2224435ab7f817ee1265e2ecf7557f586
+  data.tar.gz: 75ce59a03daf27109d80013780109b05c8573552631cc7ae26cb9f748e3ffe0d8ba1c2ae1d3d67d0450e04b216d0f04d78c4508a3439c53c4575af9467240e98

data/CHANGELOG.md

@@ -3,6 +3,12 @@ All notable changes to this project will be documented in this file.
 This file should follow the standards specified on [http://keepachangelog.com/]
 This project adheres to [Semantic Versioning](http://semver.org/).
 
+## [9.1.8] 2018-03-27
+
+## Fixed
+
+- Micro-optimizations which help when dealing with a lot of data (thanks @jgaskins / see #1490)
+
 ## [9.1.7] 2018-03-27
 
 ## Fixed

data/lib/neo4j/shared/declared_property.rb

@@ -7,13 +7,17 @@ module Neo4j::Shared
     include Neo4j::Shared::DeclaredProperty::Index
 
     ILLEGAL_PROPS = %w(from_node to_node start_node end_node)
-    attr_reader :name, :name_string, :name_sym, :options, :magic_typecaster
+    attr_reader :name, :name_string, :name_sym, :options, :magic_typecaster, :type, :typecaster, :default_value
+    alias default default_value
 
     def initialize(name, options = {})
       fail IllegalPropertyError, "#{name} is an illegal property" if ILLEGAL_PROPS.include?(name.to_s)
       fail TypeError, "can't convert #{name.class} into Symbol" unless name.respond_to?(:to_sym)
       @name = @name_sym = name.to_sym
       @name_string = name.to_s
+      @type = options[:type]
+      @typecaster = options[:typecaster]
+      @default_value = options[:default]
       @options = options
       fail_invalid_options!
     end
@@ -55,19 +59,6 @@ module Neo4j::Shared
       register_magic_properties
     end
 
-    def type
-      options[:type]
-    end
-
-    def typecaster
-      options[:typecaster]
-    end
-
-    def default_value
-      options[:default]
-    end
-    alias default default_value
-
     def fail_invalid_options!
       case
       when index?(:exact) && constraint?(:unique)
@@ -89,7 +80,7 @@ module Neo4j::Shared
 
     # Tweaks properties
     def register_magic_properties
-      options[:type] ||= Neo4j::Config.timestamp_type if timestamp_prop?
+      @type ||= Neo4j::Config.timestamp_type if timestamp_prop?
 
       register_magic_typecaster
       register_type_converter
@@ -100,18 +91,18 @@ module Neo4j::Shared
     end
 
     def register_magic_typecaster
-      found_typecaster = Neo4j::Shared::TypeConverters.typecaster_for(options[:type])
+      found_typecaster = Neo4j::Shared::TypeConverters.typecaster_for(type)
       return unless found_typecaster && found_typecaster.respond_to?(:primitive_type)
-      options[:typecaster] = found_typecaster
-      @magic_typecaster = options[:type]
-      options[:type] = found_typecaster.primitive_type
+      @typecaster = found_typecaster
+      @magic_typecaster = type
+      @type = found_typecaster.primitive_type
     end
 
     def register_type_converter
       converter = options[:serializer]
       return unless converter
-      options[:type]        = converter.convert_type
-      options[:typecaster]  = Neo4j::Shared::TypeConverters::ObjectConverter
+      @type        = converter.convert_type
+      @typecaster  = Neo4j::Shared::TypeConverters::ObjectConverter
       Neo4j::Shared::TypeConverters.register_converter(converter)
     end
   end

data/lib/neo4j/shared/type_converters.rb

@@ -101,7 +101,7 @@ module Neo4j::Shared
     end
 
     class BooleanConverter < BaseConverter
-      FALSE_VALUES = %w(n N no No NO false False FALSE off Off OFF f F)
+      FALSE_VALUES = %w(n N no No NO false False FALSE off Off OFF f F).to_set
 
       class << self
         def converted?(value)
@@ -362,24 +362,24 @@ module Neo4j::Shared
 
     def converted_property(type, value, direction)
       return nil if value.nil?
-      type.respond_to?(:db_type) || TypeConverters::CONVERTERS[type] ? TypeConverters.to_other(direction, value, type) : value
+      CONVERTERS[type] || type.respond_to?(:db_type) ? TypeConverters.to_other(direction, value, type) : value
     end
 
     # If the attribute is to be typecast using a custom converter, which converter should it use? If no, returns the type to find a native serializer.
     def primitive_type(attr)
       case
-      when self.serialized_properties_keys.include?(attr)
+      when serialized_properties.include?(attr)
         serialized_properties[attr]
-      when self.magic_typecast_properties_keys.include?(attr)
-        self.magic_typecast_properties[attr]
+      when magic_typecast_properties.include?(attr)
+        magic_typecast_properties[attr]
       else
-        self.fetch_upstream_primitive(attr)
+        fetch_upstream_primitive(attr)
       end
     end
 
     # Returns true if the property isn't defined in the model or if it is nil
     def skip_conversion?(obj, attr, value)
-      !obj.class.attributes[attr] || value.nil?
+      value.nil? || !obj.class.attributes.key?(attr)
     end
 
     class << self

data/lib/neo4j/version.rb

@@ -1,3 +1,3 @@
 module Neo4j
-  VERSION = '9.1.7'
+  VERSION = '9.1.8'
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: neo4j
 version: !ruby/object:Gem::Version
-  version: 9.1.7
+  version: 9.1.8
 platform: ruby
 authors:
 - Andreas Ronge, Brian Underwood, Chris Grigg