neetodeploy-autoscale 2.1.3 → 2.1.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 942309370bfcc61c764b61b1c782b34ec5f43cc12e25247b7ce07be3ceca791e
-  data.tar.gz: f7edeff323e0e257df4939e70b428ccaa05fcbbacc459b20aaf586b7019ee0be
+  metadata.gz: cdd8f665987aa730bfca4343fea2b9ae6f93bc5a4d6dcbc4152a7fb879165703
+  data.tar.gz: e0390da1428e2fa58547fc8045b7c769c824c502e37db945732833f2d3beb2b8
 SHA512:
-  metadata.gz: a1ae22516f4c9fd27e4056efaaf26fdd93bb8541acbcf3cd7ee68b2c8669ce7c58d7ba29ed4318e753ae919eaef7325313d476c255fe43d06b38fcf5d4479baf
-  data.tar.gz: 52e27b2013db7f75b33afcc43ca702c39ec993d5a151d9bc741f2fca367bbb1e7d202235fe91cc4f8e91e256f5ef73b2e82fb0859b828b9c5924449eae62fb38
+  metadata.gz: a7e6a766486c6785ff2f53d7f0759bfaa1738b416c0f679df970ad2bcee1de9a1b1e97f0fedc61a6f94625ef30d14f7fdf5081eae0cb37bf1005a85b057bb34e
+  data.tar.gz: 2d843f184f0f3ba6acf8f0823e04860ded3c9e76fe6a1d512592e154507890c66021283a2087775387cdb153511412f3382fa0d0f83a47e124307616f1a898bf

data/lib/neetodeploy/autoscale/rails/metrics_store.rb

@@ -1,29 +1,69 @@
 # frozen_string_literal: true
 
 require "singleton"
+require "neetodeploy/autoscale/logger"
 
 module Neetodeploy
   module Rails
     class MetricsStore
       include Singleton
 
+      # Use sliding window: keep last 2 minutes of data (120 seconds)
+      # At 2s reporting interval, this gives us ~60 samples per window
+      # This ensures percentiles work correctly even with low traffic
+      WINDOW_SIZE_SECONDS = 120
+      MAX_SAMPLES = 1000  # Safety limit to prevent memory bloat
+
       attr_reader :metrics
 
       def initialize
-        @metrics = []
+        @metrics = []  # Array of {time: timestamp, value: queue_time}
         @mutex = Mutex.new
       end
 
       def push(queue_time)
         @mutex.synchronize do
-          @metrics << queue_time
+          now = Time.now.to_f
+          @metrics << { time: now, value: queue_time }
+          
+          # Remove old data outside window
+          cutoff = now - WINDOW_SIZE_SECONDS
+          @metrics.reject! { |m| m[:time] < cutoff }
+          
+          # Safety limit: keep only most recent samples
+          if @metrics.size > MAX_SAMPLES
+            @metrics = @metrics.last(MAX_SAMPLES)
+          end
+          
+          # Log high queue times to help debug
+          if queue_time > 500
+            NeetoDeploy::Logger.logger.debug("MetricsStore: Pushed high queue_time=#{queue_time}ms (total in window: #{@metrics.size})")
+          end
+        end
+      end
+
+      # Get recent samples from the sliding window (last N seconds)
+      def get_recent(seconds = WINDOW_SIZE_SECONDS)
+        @mutex.synchronize do
+          cutoff = Time.now.to_f - seconds
+          @metrics.select { |m| m[:time] >= cutoff }.map { |m| m[:value] }
         end
       end
 
+      # Flush: return all values in window, but DON'T clear (sliding window)
+      # This allows high values to persist across multiple reporting cycles
       def flush
         @mutex.synchronize do
-          result = @metrics
-          @metrics = []
+          # Clean up old data first
+          cutoff = Time.now.to_f - WINDOW_SIZE_SECONDS
+          @metrics.reject! { |m| m[:time] < cutoff }
+          
+          result = @metrics.map { |m| m[:value] }
+          size = result.size
+          max_val = result.max if result.any?
+          NeetoDeploy::Logger.logger.debug("MetricsStore: Reporting from sliding window: #{size} values, max=#{max_val}ms") if result.any?
+          
+          # Return values but keep them in the window for next cycle
           result
         end
       end

data/lib/neetodeploy/autoscale/version.rb

@@ -2,6 +2,6 @@
 
 module Neetodeploy
   module Autoscale
-    VERSION = "2.1.3"
+    VERSION = "2.1.4"
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: neetodeploy-autoscale
 version: !ruby/object:Gem::Version
-  version: 2.1.3
+  version: 2.1.4
 platform: ruby
 authors:
 - Sreeram Venkitesh