neetob 0.5.68 → 0.5.69

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 7e552e130888b6f3315ca5eca7e6a17e9dc3e03d5c3330d21f98e5c45bc87416
-  data.tar.gz: af535649338ce0ad4139b204027b08ffad842d261a29b0135e74e49202fe0545
+  metadata.gz: 1fe5407c19ee902b9471fcd4c0774823a93e43a84dbd6ca26d017a4f0fe300dc
+  data.tar.gz: 2c0f79f96f0bfe02b6c4bc4c2c755381556aef67f046282850f8854f5d0e1cc3
 SHA512:
-  metadata.gz: 45dabca79cf9eb38ca6bae03b0ac9a56a42bab6d820c1b0f6045d7e53c35f967bf2a1b539780bd5f72df3db5fc924d2f24b1323a91412bd123df14cd2eafef5e
-  data.tar.gz: e854b32638603388a3673622ee0dc248ce4fbc5a4179a05c4fb1237535124318a5c8ac872cce8ab84523a31831ac09b334c265336dda91389d4ba9bd84dfb889
+  metadata.gz: b9e1fe5ca8b58144913a7635fc3376b6197f0851659b002cc5403b7c3dbb4d2ee3ee40e624193c81081f43138f23370c174a23dc00c32abef17a783f622283cb
+  data.tar.gz: 4c98377780c60fa3873155d025353bdddbb96a50329c78c797047c1f97f452ad33368bc52a292284efbb23926855a54dd8a6899ad53569451f3ce8e44bbc0e90

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    neetob (0.5.68)
+    neetob (0.5.69)
       actionview
       activesupport
       brakeman (~> 5.0)

data/lib/neetob/cli/base.rb

@@ -19,6 +19,38 @@ module Neetob
 
     private
 
+      def strip_ansi_codes(str)
+        str.gsub(/\e\[[\d;]*m/, "")
+      end
+
+      def domain_to_repo(domain)
+        domain = domain.gsub(".com", "")
+
+        if domain == "neeto"
+          return "neeto-website"
+        end
+
+        if domain == "bigbinary"
+          return "bigbinary-website"
+        end
+
+        if domain.start_with?("neeto")
+          app = domain.sub("neeto", "neeto-")
+        else
+          app = domain
+        end
+        "#{app}-web"
+      end
+
+      def app_to_repo(app_name)
+        app_name = app_name.downcase
+
+        if app_name.start_with?("neeto")
+          app = app_name.sub("neeto", "neeto-")
+        end
+        "#{app}-web"
+      end
+
       def find_all_matching_apps_or_repos(apps, platform_name, sandbox_mode, quiet = false)
         all_neeto_repos = apps == ["all"]
         inform_about_current_working_mode(sandbox_mode, quiet)

data/lib/neetob/cli/github/issues/helpers.rb

@@ -0,0 +1,27 @@
+# frozen_string_literal: true
+
+require_relative "../base"
+
+module Neetob
+  class CLI
+    module Github
+      module Issues
+        class Helpers < Base
+          def initialize
+            super()
+          end
+
+          def get_issue_with_title(repo, title)
+            begin
+              issues = client.issues(repo, state: "open")
+              issue = issues.find { |issue| issue.title == title }
+              issue
+            rescue StandardError => e
+              ExceptionHandler.new(e).process
+            end
+          end
+        end
+      end
+    end
+  end
+end

data/lib/neetob/cli/monthly_audit/commands.rb

@@ -9,9 +9,10 @@ module Neetob
       class Commands < Thor
         desc "perform", "Perform the audit"
         option :month, type: :string, aliases: "-m", required: true, desc: "Month. Example: June-2024"
+        option :skip_issue, type: :boolean, default: false, desc: "Skip creating GitHub issues"
 
         def perform
-          Perform.new(options[:month], options[:sandbox]).run
+          Perform.new(options[:month], options[:sandbox], options[:skip_issue]).run
         end
       end
     end

data/lib/neetob/cli/monthly_audit/databases/users_unique_email_index.rb

@@ -1,5 +1,6 @@
 # frozen_string_literal: true
 
+require_relative "../github_issue_creation"
 module Neetob
   class CLI
     module MonthlyAudit
@@ -28,7 +29,11 @@ module Neetob
               if unique_email_index_result
                 repo_data << [repo, "Yes", nil, "Yes"]
               else
-                repo_data << [repo, "No", "Unique email index is not present for the users table", "No"]
+                issue_url = GithubIssueCreation.new.create_issue(
+                  repo:, title: "Add unique index on users email",
+                  description: "Unique email index is not present for the users table")
+                audit_passed = "No" + " #{issue_url}"
+                repo_data << [repo, "No", "Unique email index is not present for the users table", audit_passed]
               end
             end
             ui.print_table(repo_data)

data/lib/neetob/cli/monthly_audit/databases/uuid_primary_key.rb

@@ -1,5 +1,7 @@
 # frozen_string_literal: true
 
+require_relative "../github_issue_creation"
+
 module Neetob
   class CLI
     module MonthlyAudit
@@ -40,6 +42,12 @@ module Neetob
               all_tables_have_uuid_primary_keys = tables_without_uuid.empty? ? "Yes" : "No"
               audit_passed = all_tables_have_uuid_primary_keys == "Yes" ? "Yes" : "No"
               comments = tables_without_uuid.empty? ? nil : "Tables without UUID primary keys: #{tables_without_uuid.join(', ')}"
+              if audit_passed == "No"
+                issue_url = GithubIssueCreation.new.create_issue(
+                  repo:, title: "Use UUID primary keys for all tables",
+                  description: comments)
+                audit_passed += " #{issue_url}"
+              end
               same_as_last_comment = audit_passed == "No" && comments == last_comment
               last_comment = comments
               if same_as_last_comment

data/lib/neetob/cli/monthly_audit/github_issue_creation.rb

@@ -0,0 +1,35 @@
+# frozen_string_literal: true
+
+require_relative "../github/base"
+require_relative "../github/issues/helpers"
+class GithubIssueCreation < Neetob::CLI::Github::Base
+  def initialize
+    super()
+    @helpers = Neetob::CLI::Github::Issues::Helpers.new
+  end
+
+  def create_issue(repo:, title:, description:, labels: "")
+    return if Thread.current[:skip_issue]
+
+    month = Thread.current[:month].capitalize.gsub("-", " ")
+    title = "#{month} Audit - #{title}"
+
+    # Checking if the issue already exists
+    issue = @helpers.get_issue_with_title("bigbinary/#{repo}", title)
+    if issue
+      return issue.html_url
+    end
+
+    begin
+      issue = client.create_issue(
+        "bigbinary/#{repo}",
+        title,
+        "## #{title} \n #{description}",
+        { labels: }
+      )
+      issue.html_url
+    rescue StandardError => e
+      ExceptionHandler.new(e).process
+    end
+  end
+end

data/lib/neetob/cli/monthly_audit/instances_and_addons/cloudflare/always_use_https_is_enabled.rb

@@ -1,5 +1,7 @@
 # frozen_string_literal: true
 
+require_relative "../../github_issue_creation"
+
 module Neetob
   class CLI
     module MonthlyAudit
@@ -20,6 +22,15 @@ module Neetob
                 ui.info("Checking Always use HTTPS value for #{domain}", print_to_audit_log: false)
                 always_use_https_value = Neetob::CLI::Cloudflare::AlwaysUseHttps.new(domain).run
                 audit_passed = always_use_https_value.to_s == "on" ? "Yes" : "No"
+
+                if audit_passed == "No"
+                  repo = domain_to_repo(domain.to_s)
+                  issue_url = GithubIssueCreation.new.create_issue(
+                    repo:, title: "Enable HTTPS for domain",
+                    description: "HTTPs is not enabled for #{domain}.")
+                  audit_passed += " #{issue_url}"
+                end
+
                 domains_data << [domain, always_use_https_value, audit_passed]
               end
               ui.print_table(domains_data)

data/lib/neetob/cli/monthly_audit/instances_and_addons/cloudflare/bot_protection_enabled.rb

@@ -1,5 +1,6 @@
 # frozen_string_literal: true
 
+require_relative "../../github_issue_creation"
 module Neetob
   class CLI
     module MonthlyAudit
@@ -20,6 +21,14 @@ module Neetob
                 bot_fight_mode = Neetob::CLI::Cloudflare::BotFightMode.new(domain).run
                 ui.info("Checking Bot fight mode for #{domain}", print_to_audit_log: false)
                 audit_passed = bot_fight_mode == "on" ? "Yes" : "No"
+
+                if audit_passed == "No"
+                  repo = domain_to_repo(domain.to_s)
+                  issue_url = GithubIssueCreation.new.create_issue(
+                    repo:, title: "Enable bot protection for #{domain}",
+                    description: "Bot Protection is not enabled for #{domain}.")
+                  audit_passed += " #{issue_url}"
+                end
                 domains_data << [domain, bot_fight_mode, audit_passed]
               end
               ui.print_table(domains_data)

data/lib/neetob/cli/monthly_audit/instances_and_addons/cloudflare/dns_entry_has_proxy_status.rb

@@ -1,5 +1,7 @@
 # frozen_string_literal: true
 
+require_relative "../../github_issue_creation"
+
 module Neetob
   class CLI
     module MonthlyAudit
@@ -39,6 +41,13 @@ module Neetob
                   dns_proxy_status = "* record has proxying turned #{proxy_status}"
                   same_as_last_dns_proxy_status = dns_proxy_status == last_dns_proxy_status
                   last_dns_proxy_status = dns_proxy_status
+                  if audit_passed == "No"
+                    repo = domain_to_repo(domain.to_s)
+                    issue_url = GithubIssueCreation.new.create_issue(
+                      repo:, title: "Enable proxying for wildcard DNS on #{domain}",
+                      description: dns_proxy_status)
+                    audit_passed += " #{issue_url}"
+                  end
                   if same_as_last_dns_proxy_status
                     dns_proxy_status = "''"
                   end

data/lib/neetob/cli/monthly_audit/instances_and_addons/cloudflare/minimum_tls_version_is_one_point_two.rb

@@ -1,6 +1,7 @@
 # frozen_string_literal: true
 
 require_relative "../../../cloudflare/min_tls_version"
+require_relative "../../github_issue_creation"
 
 module Neetob
   class CLI
@@ -22,6 +23,16 @@ module Neetob
                 ui.info("Checking Minimum TLS version for #{domain}", print_to_audit_log: false)
                 min_tls_version = Neetob::CLI::Cloudflare::MinTlsVersion.new(domain).run
                 audit_passed = min_tls_version.to_s == "1.2" ? "Yes" : "No"
+
+                if audit_passed == "No"
+                  repo = domain_to_repo(domain.to_s)
+                  issue_url = GithubIssueCreation.new.create_issue(
+                    repo:, title: "Set minimum TLS version to 1.2 for #{domain}",
+                    description: "Minimum TLS version for #{domain} is set to #{min_tls_version}. It should be set to '1.2'."
+                    )
+                  audit_passed += " #{issue_url}"
+                end
+
                 domains_data << [domain, min_tls_version, audit_passed]
               end
               ui.print_table(domains_data)

data/lib/neetob/cli/monthly_audit/instances_and_addons/cloudflare/spf_records_are_valid.rb

@@ -1,5 +1,6 @@
 # frozen_string_literal: true
 
+require_relative "../../github_issue_creation"
 module Neetob
   class CLI
     module MonthlyAudit
@@ -29,6 +30,14 @@ module Neetob
                 data = spf_records_verification_data[:spf_txt_records].map { |record|
                   "#{record[:name]} => #{record[:content]}"
                 }.join(", ")
+
+                if audit_passed == "No"
+                  repo = domain_to_repo(domain.to_s)
+                  issue_url = GithubIssueCreation.new.create_issue(
+                    repo:, title: "Fix invalid SPF records for #{domain}",
+                    description: "#{comments} \n\n SPF records data: #{data}")
+                  audit_passed += " #{issue_url}"
+                end
                 domains_data << [domain, data, comments, audit_passed]
               end
               ui.print_table(domains_data)

data/lib/neetob/cli/monthly_audit/instances_and_addons/cloudflare/ssl_tls_encryption_mode_set_to_full.rb

@@ -1,6 +1,7 @@
 # frozen_string_literal: true
 
 require_relative "../../../cloudflare/ssl_mode"
+require_relative "../../github_issue_creation"
 
 module Neetob
   class CLI
@@ -22,6 +23,14 @@ module Neetob
                 ui.info("Checking SSL/TLS encryption mode for #{domain}", print_to_audit_log: false)
                 ssl_mode = Neetob::CLI::Cloudflare::SSLMode.new(domain).run
                 audit_passed = ssl_mode.to_s == "full" ? "Yes" : "No"
+                repo = domain_to_repo(domain.to_s)
+                if audit_passed == "No"
+                  comments = "SSL/TLS encryption mode is set to #{ssl_mode}. It should be set to 'Full'."
+                  issue_url = GithubIssueCreation.new.create_issue(
+                    repo:, title: "Set SSL TLS mode to Full for #{domain}",
+                    description: comments)
+                  audit_passed += " #{issue_url}"
+                end
                 domains_data << [domain, ssl_mode, audit_passed]
               end
               ui.print_table(domains_data)

data/lib/neetob/cli/monthly_audit/instances_and_addons/cronitor/setup_correctly_for_apps.rb

@@ -1,6 +1,7 @@
 # frozen_string_literal: true
 
 require_relative "../../../cronitor/get_all_monitors"
+require_relative "../../github_issue_creation"
 
 module Neetob
   class CLI
@@ -42,6 +43,15 @@ module Neetob
                   end
                 end
 
+                if audit_passed == "No"
+                  repo = app_to_repo(app.to_s)
+                  issue_url = GithubIssueCreation.new.create_issue(
+                    repo:, title: "Fix missing or paused Cronitor monitor for #{app}",
+                    description: " Monitor for Application present:#{monitor_for_app_present}
+                    \n Monitor for Application enabled:#{monitor_for_app_enabled} \n  #{comments}")
+                  audit_passed += " #{issue_url}"
+                end
+
                 apps_data << [app, monitor_for_app_present, monitor_for_app_enabled, comments, audit_passed]
               end
 

data/lib/neetob/cli/monthly_audit/instances_and_addons/cronitor/setup_correctly_for_help_center.rb

@@ -1,5 +1,7 @@
 # frozen_string_literal: true
 
+require_relative "../../github_issue_creation"
+
 module Neetob
   class CLI
     module MonthlyAudit
@@ -47,6 +49,16 @@ module Neetob
                   audit_passed = "Ignored"
                 end
 
+                if audit_passed == "No"
+                  repo = app_to_repo(app.to_s)
+                  issue_url = GithubIssueCreation.new.create_issue(
+                    repo:, title: "Fix missing or paused Cronitor monitor for #{app} help center",
+                    description: " Monitor for Application help center present:#{monitor_for_app_help_center_present}
+                    \n Monitor for Application help center enabled:#{monitor_for_app_help_center_enabled} \n  #{comments}"
+                    )
+                  audit_passed += " #{issue_url}"
+                end
+
                 apps_data << [app, monitor_for_app_help_center_present, monitor_for_app_help_center_enabled, comments,
 audit_passed]
               end

data/lib/neetob/cli/monthly_audit/instances_and_addons/cronitor/setup_correctly_for_landing_pages.rb

@@ -1,5 +1,7 @@
 # frozen_string_literal: true
 
+require_relative "../../github_issue_creation"
+
 module Neetob
   class CLI
     module MonthlyAudit
@@ -49,6 +51,16 @@ module Neetob
                   audit_passed = "Ignored"
                 end
 
+                if audit_passed == "No"
+                  repo = app_to_repo(app.to_s)
+                  issue_url = GithubIssueCreation.new.create_issue(
+                    repo:, title: "Fix missing or paused Cronitor monitor for #{app} landing page",
+                    description: " Monitor for Application landing page present:#{monitor_for_app_landing_page_present}
+                    \n Monitor for Application landing page enabled:#{monitor_for_app_landing_page_enabled} \n  #{comments}"
+                    )
+                  audit_passed += " #{issue_url}"
+                end
+
                 apps_data << [app, monitor_for_app_landing_page_present, monitor_for_app_landing_page_enabled,
 comments, audit_passed]
               end

data/lib/neetob/cli/monthly_audit/instances_and_addons/neeto_deploy_or_heroku/auto_scaling_enabled.rb

@@ -1,5 +1,7 @@
 # frozen_string_literal: true
 
+require_relative "../../github_issue_creation"
+
 module Neetob
   class CLI
     module MonthlyAudit
@@ -22,6 +24,7 @@ module Neetob
                 audit_passed = nil
                 comments = nil
                 autoscaling_config = nil
+                repo = app.gsub("-production", "")
                 if autoscaling_config_result.is_a?(Hash) && autoscaling_config_result["error"] == "Forbidden"
                   audit_passed = "No"
                   comments = "You do not have permission to access the config for this app."
@@ -32,6 +35,10 @@ module Neetob
                   audit_passed = autoscaling_turned_on_for_web ? "Yes" : "No"
                   if audit_passed == "No"
                     comments = "Auto-scaling is not enabled for web dynos."
+                    issue_url = GithubIssueCreation.new.create_issue(
+                      repo:, title: "Enable auto scaling for web dynos",
+                      description: comments)
+                    audit_passed += " #{issue_url}"
                     same_as_last_comment = comments == last_comment
                     last_comment = comments
                     comments = "''" if same_as_last_comment

data/lib/neetob/cli/monthly_audit/instances_and_addons/neeto_deploy_or_heroku/cloudfront_cdn_enabled.rb

@@ -1,5 +1,6 @@
 # frozen_string_literal: true
 
+require_relative "../../github_issue_creation"
 module Neetob
   class CLI
     module MonthlyAudit
@@ -26,6 +27,7 @@ module Neetob
                 audit_passed = nil
                 comments = nil
                 asset_host_value = nil
+                repo = app.gsub("-production", "")
                 if config_vars.is_a?(Hash) && config_vars["error"] == "Forbidden"
                   audit_passed = "No"
                   comments = "You do not have permission to access the config vars for this app."
@@ -34,6 +36,10 @@ module Neetob
                   if asset_host_line.nil?
                     audit_passed = "No"
                     comments = "ASSET_HOST value not found."
+                    issue_url = GithubIssueCreation.new.create_issue(
+                      repo:, title: "Cloudfront CDN audit failed",
+                      description: comments)
+                    audit_passed += " #{issue_url}"
                   else
                     asset_host_value = asset_host_line.split("|")[2].strip
                     is_direct_cloudfront_asset_host = asset_host_value.include?("cloudfront.net")
@@ -41,9 +47,14 @@ module Neetob
                     audit_passed = is_direct_cloudfront_asset_host || is_cdn_subdomain_asset_host ? "Yes" : "No"
                     if audit_passed == "No"
                       comments = "ASSET_HOST value is not a Cloudfront CDN URL or a CDN subdomain URL."
+                      issue_url = GithubIssueCreation.new.create_issue(
+                        repo:, title: "Set ASSET_HOST to a valid Cloudfront CDN URL",
+                        description: comments)
+                      audit_passed += " #{issue_url}"
                     end
                   end
                 end
+
                 apps_data << [app, asset_host_value, comments, audit_passed]
               end
               Neetob::CLI::Sre::Base::APPS_LIST[:heroku].select { |app| app.include?("production") }.each do |app|

data/lib/neetob/cli/monthly_audit/instances_and_addons/neeto_deploy_or_heroku/essential_environment_variables_set.rb

@@ -1,5 +1,6 @@
 # frozen_string_literal: true
 
+require_relative "../../github_issue_creation"
 module Neetob
   class CLI
     module MonthlyAudit
@@ -15,12 +16,14 @@ module Neetob
 
               apps_data = [["App", "All essential env variables set", "Comments", "Audit Passed"]]
               ui.info("\n", print_to_audit_log: false)
+
               Neetob::CLI::Sre::Base::APPS_LIST[:neetodeploy].select { |app| app.include?("production") }.each do |app|
                 ui.info("Checking essential env variables for #{app}", print_to_audit_log: false)
                 essential_env_variables_result = Neetob::CLI::Sre::CheckEssentialEnv.new(app).run
                 audit_passed = nil
                 comments = nil
                 all_essential_env_variables_set = nil
+                repo = app.gsub("-production", "")
                 if essential_env_variables_result["error"] == "Forbidden"
                   audit_passed = "No"
                   comments = "You do not have permission to access the config vars for this app."
@@ -29,6 +32,10 @@ module Neetob
                   audit_passed = all_essential_env_variables_set ? "Yes" : "No"
                   if audit_passed == "No"
                     comments = "Missing keys: #{essential_env_variables_result[:missing_keys].join(", ")}"
+                    issue_url = GithubIssueCreation.new.create_issue(
+                      repo:, title: "Missing essential environment variables",
+                      description: comments)
+                    audit_passed += " #{issue_url}"
                   end
                 end
                 apps_data << [app, all_essential_env_variables_set, comments, audit_passed]
@@ -38,8 +45,13 @@ module Neetob
                 essential_env_variables_result = Neetob::CLI::Sre::CheckEssentialEnv.new(app).run
                 all_essential_env_variables_set = essential_env_variables_result[:all_keys_present]
                 audit_passed = all_essential_env_variables_set ? "Yes" : "No"
+                repo = app.gsub("-production", "")
                 if audit_passed == "No"
                   comments = "Missing keys: #{essential_env_variables_result[:missing_keys].join(", ")}"
+                  issue_url = GithubIssueCreation.new.create_issue(
+                    repo:, title: "Add missing essential environment variables",
+                    description: comments)
+                  audit_passed += " #{issue_url}"
                 end
                 apps_data << [app, all_essential_env_variables_set, comments, audit_passed]
               end

data/lib/neetob/cli/monthly_audit/instances_and_addons/neeto_deploy_or_heroku/scheduled_exports_enabled.rb

@@ -1,5 +1,6 @@
 # frozen_string_literal: true
 
+require_relative "../../github_issue_creation"
 module Neetob
   class CLI
     module MonthlyAudit
@@ -22,6 +23,7 @@ module Neetob
                 audit_passed = nil
                 comments = nil
                 scheduled_exports_config = nil
+                repo = app.gsub("-production", "")
                 if scheduled_exports_result.include? "Forbidden"
                   audit_passed = "No"
                   comments = "You do not have permission to access the config for this app."
@@ -34,6 +36,10 @@ module Neetob
                   audit_passed = scheduled_exports_config.include?("turned on") ? "Yes" : "No"
                   if audit_passed == "No"
                     comments = scheduled_exports_config
+                    issue_url = GithubIssueCreation.new.create_issue(
+                      repo:, title: "Enable scheduled exports",
+                      description: strip_ansi_codes(comments))
+                    audit_passed += " #{issue_url}"
                   end
                   same_as_last_scheduled_export_config = scheduled_exports_config == last_scheduled_exports_config
                   last_scheduled_exports_config = scheduled_exports_config

data/lib/neetob/cli/monthly_audit/instances_and_addons/neeto_deploy_or_heroku/ssl_certificates_over_thirty_days_from_expiry.rb

@@ -1,5 +1,7 @@
 # frozen_string_literal: true
 
+require_relative "../../github_issue_creation"
+
 module Neetob
   class CLI
     module MonthlyAudit
@@ -53,6 +55,11 @@ module Neetob
                       "#{certificate["name"]}(#{certificate["domains"].map { |domain| domain["hostname"] }.join(", ")})"
                     }
                     comments = "Certificates #{certificates_failing_audit.join(", ")} are expiring in less than 30 days."
+                    repo = app.gsub("-production", "")
+                    issue_url = GithubIssueCreation.new.create_issue(
+                      repo:, title: "SSL certificates over 30 days from expiry",
+                      description: comments)
+                    audit_passed += " #{issue_url}"
                   end
                 end
                 apps_data << [app, certificates_expiring_in_less_than_30_days, comments, audit_passed]
@@ -68,6 +75,11 @@ module Neetob
                   audit_passed = "Yes"
                 else
                   comments = "Certificates #{certificates_expiring_in_less_than_30_days.map { |certificate| certificate[:name] }.join(", ")} are expiring in less than 30 days."
+                  repo = app.gsub("-production", "")
+                  issue_url = GithubIssueCreation.new.create_issue(
+                    repo:, title: "Renew SSL certificates expiring in less than 30 days",
+                    description: comments)
+                  audit_passed += " #{issue_url}"
                   certificates_expiring_in_less_than_30_days_present = "Yes"
                 end
                 apps_data << [app, certificates_expiring_in_less_than_30_days_present, comments, audit_passed]

data/lib/neetob/cli/monthly_audit/misc/redirections_working_correctly.rb

@@ -1,12 +1,17 @@
 # frozen_string_literal: true
 
+require_relative "../github_issue_creation"
+
 module Neetob
   class CLI
     module MonthlyAudit
       module Misc
         class RedirectionsWorkingCorrectly < CLI::Base
           REDIRECTIONS_LIST = [
-            { source: "https://academy.bigbinary.com", destination: "https://bigbinaryacademy.com" }
+            {
+              source: "https://academy.bigbinary.com", destination: "https://bigbinaryacademy.com",
+              repo: "bigbinary-website"
+            },
           ]
           def initialize
             super()
@@ -19,6 +24,14 @@ module Neetob
               status = check.run ? "Working" : "Not working"
               audit_passed = status == "Working" ? "Yes" : "No"
 
+              if audit_passed == "No"
+                issue_url = GithubIssueCreation.new.create_issue(
+                  repo: redirection[:repo], title: "Fix broken redirection",
+                  description: "Redirection from #{redirection[:source]} to #{redirection[:destination]} is not working."
+                  )
+                audit_passed += " #{issue_url}"
+              end
+
               table_data << [redirection[:source], redirection[:destination], status, audit_passed]
             end
             ui.print_table(table_data)

data/lib/neetob/cli/monthly_audit/perform.rb

@@ -9,20 +9,25 @@ module Neetob
   class CLI
     module MonthlyAudit
       class Perform < CLI::Base
-        attr_accessor :sandbox, :month
+        attr_accessor :sandbox, :month, :skip_issue
 
-        def initialize(month, sandbox = false)
+        def initialize(month, sandbox = false, skip_issue = false)
           super()
           @month = month
           @sandbox = sandbox
+          @skip_issue = skip_issue
         end
 
         def run
+          Thread.current[:month] = month
+          Thread.current[:skip_issue] = skip_issue
           Thread.current[:audit_mode] = true
           markdown_file_name = "audit-report-#{DateTime.now.to_i}.md"
           Thread.current[:markdown_file_name] = markdown_file_name
           ui.success("## Starting the audit for #{month}")
           ui.info "\n"
+          ui.say("## Issue creation is #{skip_issue ? 'disabled' : 'enabled'}")
+          ui.info "\n"
           Security::Main.new.run
           ui.info "\n"
           Databases::Main.new.run

data/lib/neetob/cli/monthly_audit/security/code/active_record_doctor.rb

@@ -16,18 +16,23 @@ module Neetob
               ui.success("### 1.1.4. Checking whether running `rake active_record_doctor` throws any vulnerabilities")
               repo_data = [["Repository", "Issues Found", "Comments", "Audit Passed"]]
               ui.info "\n"
-              NeetoCompliance::NeetoRepos.products.keys.take(5).each do |repo|
+              NeetoCompliance::NeetoRepos.products.keys.each do |repo|
                 ui.info("Checking ActiveRecordDoctor run results for #{repo}", print_to_audit_log: false)
                 active_record_doctor_run_result = Neetob::CLI::Github::ActiveRecordDoctor.new([repo]).run
-
+                audit_passed = "No"
                 if active_record_doctor_run_result.blank?
-                  issues_found = "No"
+                  audit_passed = "Yes"
                   comments = nil
                 else
                   issues_found = "Yes"
                   comments = "#{active_record_doctor_run_result.lines.first.strip} ..."
+
+                  issue_url = GithubIssueCreation.new.create_issue(
+                    repo:, title: "Fix issues reported by active_record_doctor",
+                    description: comments)
+                  audit_passed += " #{issue_url}"
                 end
-                audit_passed = issues_found == "No" ? "Yes" : "No"
+
                 repo_data << [repo, issues_found, comments, audit_passed]
               end
               ui.print_table(repo_data)

data/lib/neetob/cli/monthly_audit/security/code/brakeman.rb

@@ -25,6 +25,11 @@ module Neetob
                 else
                   vulnerabilities_found = "Yes"
                   comments = brakeman_run_result.gsub("\n", "<br>")
+
+                  issue_url = GithubIssueCreation.new.create_issue(
+                    repo:, title: "Fix vulnerabilities reported by Brakeman",
+                    description: comments)
+                  audit_passed += " #{issue_url}"
                 end
                 repo_data << [repo, vulnerabilities_found, comments, audit_passed]
               end

data/lib/neetob/cli/monthly_audit/security/code/bundle_audit.rb

@@ -1,7 +1,7 @@
 # frozen_string_literal: true
 
 require_relative "../../../github/bundle_audit"
-
+require_relative "../../github_issue_creation"
 module Neetob
   class CLI
     module MonthlyAudit
@@ -26,9 +26,13 @@ module Neetob
                 if bundle_audit_result && bundle_audit_result.include?("No vulnerabilities found")
                   audit_passed = "Yes"
                 else
+
                   vulnerabilities_found = "Yes"
                   comments = bundle_audit_result.gsub("\n", "<br>").gsub("~", "\\~")
-
+                  issue_url = GithubIssueCreation.new.create_issue(
+                    repo:, title: "Fix vulnerabilities reported by bundle-audit",
+                    description: comments)
+                  audit_passed += " #{issue_url}"
                   same_as_last_vulnerabilities = comments == last_comment
                   last_comment = comments
                   if same_as_last_vulnerabilities

data/lib/neetob/cli/monthly_audit/security/code/checks_for_unused_assets.rb

@@ -1,6 +1,7 @@
 # frozen_string_literal: true
 
 require_relative "../../../github/unused_assets_audit"
+require_relative "../../github_issue_creation"
 
 module Neetob
   class CLI
@@ -24,6 +25,10 @@ module Neetob
                   unused_assets_found = "Yes"
                   audit_passed = "No"
                   comments = unused_files.join("<br>")
+                  issue_url = GithubIssueCreation.new.create_issue(
+                    repo:, title: "Remove unused assets",
+                    description: comments)
+                  audit_passed += " #{issue_url}"
                 else
                   unused_assets_found = "No"
                   audit_passed = "Yes"

data/lib/neetob/cli/monthly_audit/security/code/fasterer.rb

@@ -1,6 +1,7 @@
 # frozen_string_literal: true
 
 require_relative "../../../github/fasterer_audit"
+require_relative "../../github_issue_creation"
 
 module Neetob
   class CLI
@@ -27,6 +28,13 @@ module Neetob
                   comments = "Vulnerabilities not detected"
                 else
                   optimizations_needed = "Yes"
+                  comments = strip_ansi_codes(fasterer_exec_result).gsub("\n", "<br>")
+
+                  issue_url = GithubIssueCreation.new.create_issue(
+                    repo:, title: "Fasterer suggestions to improve performance",
+                    description: comments)
+                  audit_passed += " #{issue_url}"
+
                   comments = "Vulnerabilities detected"
                 end
                 repo_data << [repo, optimizations_needed, comments, audit_passed]

data/lib/neetob/cli/monthly_audit/security/code/yarn_audit.rb

@@ -31,6 +31,11 @@ line.include?("Severity:") }.first&.strip&.gsub("|", ",")
                   vulnerabilities = yarn_audit_result.split("\n").select { |line|
  line.include?("vulnerabilities found") }.first&.strip
                   comments = "#{vulnerabilities}<br>#{severity}"
+
+                  issue_url = GithubIssueCreation.new.create_issue(
+                    repo:, title: "Yarn audit: High/Critical vulnerabilities found",
+                    description: comments)
+                  audit_passed += " #{issue_url}"
                 end
                 repo_data << [repo, vulnerabilities_found, comments, audit_passed]
               end

data/lib/neetob/cli/monthly_audit/security/github/dependabot_prs_merged.rb

@@ -1,6 +1,7 @@
 # frozen_string_literal: true
 
 require_relative "../../../github/repositories/pull_requests"
+require_relative "../../github_issue_creation"
 
 module Neetob
   class CLI
@@ -35,6 +36,10 @@ module Neetob
                   audit_passed = dependabot_prs_older_than_2_days_merged = "Yes"
                 else
                   comments = "PRs older than 2 days: #{dependabot_prs_older_than_2_days.map { |pr| pr[:number] }.join(', ')}"
+                  issue_url = GithubIssueCreation.new.create_issue(
+                    repo:, title: "Merge Dependabot PRs older than 2 days",
+                    description: comments)
+                  audit_passed += " #{issue_url}"
                 end
                 repo_data << [repo, dependabot_prs_older_than_2_days_merged, comments, audit_passed]
               end

data/lib/neetob/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Neetob
-  VERSION = "0.5.68"
+  VERSION = "0.5.69"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: neetob
 version: !ruby/object:Gem::Version
-  version: 0.5.68
+  version: 0.5.69
 platform: ruby
 authors:
 - Udai Gupta
@@ -245,6 +245,7 @@ files:
 - lib/neetob/cli/github/issues/commands.rb
 - lib/neetob/cli/github/issues/create.rb
 - lib/neetob/cli/github/issues/create_product_sub_issues.rb
+- lib/neetob/cli/github/issues/helpers.rb
 - lib/neetob/cli/github/issues/list.rb
 - lib/neetob/cli/github/labels/commands.rb
 - lib/neetob/cli/github/labels/delete.rb
@@ -287,6 +288,7 @@ files:
 - lib/neetob/cli/monthly_audit/databases/main.rb
 - lib/neetob/cli/monthly_audit/databases/users_unique_email_index.rb
 - lib/neetob/cli/monthly_audit/databases/uuid_primary_key.rb
+- lib/neetob/cli/monthly_audit/github_issue_creation.rb
 - lib/neetob/cli/monthly_audit/instances_and_addons/cloudflare/always_use_https_is_enabled.rb
 - lib/neetob/cli/monthly_audit/instances_and_addons/cloudflare/bot_protection_enabled.rb
 - lib/neetob/cli/monthly_audit/instances_and_addons/cloudflare/dns_entry_has_proxy_status.rb