neetob 0.5.32 → 0.5.34

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: bdc4b3fcccf8922a0af4103b623e59450fe925a70895acb4775e2529d43c62a5
-  data.tar.gz: d6174c39ae93a4d3b02269c33783b066084b8fd313e9990aeb49cdbe0e6f7070
+  metadata.gz: 7d1e81ad19b7fc0000a78ee52943577368c4eb26ee7fa8765cefdd7c48184be0
+  data.tar.gz: 64bdf65d26eeefa1c8f7282ad6f5b33be88df114cc4b24e2ac661a3fb7975a9e
 SHA512:
-  metadata.gz: 36c2cecc7209321eeea50e5f1567483156717719e2230aa12fc49cfd7b67e44801766c061b6c7a7473c300d59d14d234f975ad64778af30d31b2787a31911b1c
-  data.tar.gz: b03fcafed7e88cc22f0608e10c3a9259fee735f3801394ece26deee34cf402722cb3731f1060a3c4daf44f5fec6049d9d39f668c761ae949a3484535bd4aff48
+  metadata.gz: ba217948009c17afa6ed22ff558d7edf585b2a9f8beb5bb8786c967cc52ff9f8f11ccd9d26467c0b7cd8350afc102341e4a2513fdd29e25c752edb2a78b3dc1e
+  data.tar.gz: 5cb907b16d2508c4fbac786eeb9567fe54f35e1a750c8366d1f3590bbb9d1705c997c6a992775761bc152b5282634faf479c533a6f306ab3c6abc34400f22c64

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    neetob (0.5.32)
+    neetob (0.5.34)
       brakeman (~> 5.0)
       chronic
       dotenv (~> 2.8.1)

data/lib/neetob/cli/cronitor/base.rb

@@ -32,16 +32,32 @@ module Neetob
           end
 
           def get(username:, password:, headers: { "Accept" => "application/json" })
-            uri = URI(MONITORS_URL)
-            request = Net::HTTP::Get.new(uri)
-            headers.each { |key, value| request[key] = value }
-            request.basic_auth(username, password)
+            monitors = []
+            move_to_next_page = true
+            page = 1
+            while move_to_next_page
+              url_to_fetch_from = MONITORS_URL
+              url_to_fetch_from += "?page=#{page}" if page > 1
+              uri = URI(url_to_fetch_from)
+              request = Net::HTTP::Get.new(uri)
+              headers.each { |key, value| request[key] = value }
+              request.basic_auth(username, password)
 
-            response = Net::HTTP.start(uri.hostname, uri.port, use_ssl: uri.scheme == "https") do |http|
-              http.request(request)
-            end
+              response = Net::HTTP.start(uri.hostname, uri.port, use_ssl: uri.scheme == "https") do |http|
+                http.request(request)
+              end
 
-            parse_response(response)
+              parsed_response = parse_response(response)
+              total_monitor_count = parsed_response[:total_monitor_count]
+              page_size = parsed_response[:page_size]
+              if total_monitor_count > (page * page_size)
+                page += 1
+              else
+                move_to_next_page = false
+              end
+              monitors += parsed_response[:monitors]
+            end
+            monitors
           end
       end
     end

data/lib/neetob/cli/cronitor/get_all_monitors.rb

@@ -11,8 +11,8 @@ module Neetob
         end
 
         def run
-          cronitor_one_monitors = get(username: ENV["CRONITOR_ONE_API_KEY"], password: "")[:monitors]
-          cronitor_three_monitors = get(username: ENV["CRONITOR_THREE_API_KEY"], password: "")[:monitors]
+          cronitor_one_monitors = get(username: ENV["CRONITOR_ONE_API_KEY"], password: "")
+          cronitor_three_monitors = get(username: ENV["CRONITOR_THREE_API_KEY"], password: "")
           cronitor_one_monitors + cronitor_three_monitors
         end
       end

data/lib/neetob/cli/github/active_record_doctor.rb

@@ -0,0 +1,59 @@
+# frozen_string_literal: true
+
+require_relative "./make_pr/base"
+
+module Neetob
+  class CLI
+    module Github
+      class ActiveRecordDoctor < MakePr::Base
+        DESCRIPTION = "Fix vulnerabilities reported by active_record_doctor"
+        attr_accessor :repos, :sandbox
+
+        def initialize(repos, sandbox = false)
+          super()
+          @repos = repos
+          @sandbox = sandbox
+        end
+
+        def run
+          matching_repos = find_all_matching_apps_or_repos(repos, :github, sandbox)
+          report = nil
+          matching_repos.each do |repo|
+            begin
+              ui.info("\nWorking on repo #{repo}", print_to_audit_log: false)
+              clone_repo_in_tmp_dir(repo)
+              bundle_install!(repo)
+              setup_db!(repo)
+              report = run_active_record_doctor(repo)
+              ui.success("Successfully executed active_record_doctor for #{repo}", print_to_audit_log: false)
+
+              report = report.lines.reject { |line| line.start_with?("**") }.join("\n")
+              if !report.blank? && !Thread.current[:audit_mode]
+                issue = client.create_issue(repo, DESCRIPTION, parse_description(warnings))
+                ui.success("Issue created at #{issue.html_url}")
+              end
+            rescue StandardError => e
+              ExceptionHandler.new(e).process
+            end
+          end
+          `rm -rf /tmp/neetob` unless Thread.current[:audit_mode]
+          if Thread.current[:audit_mode]
+            report
+          end
+        end
+
+        private
+
+          def run_active_record_doctor(repo)
+            `#{cd_to_repo(repo)} && bundle exec rake active_record_doctor`
+          end
+
+          def setup_db!(repo)
+            `#{cd_to_repo(repo)} && cp config/database.yml.postgresql config/database.yml`
+            `#{cd_to_repo(repo)} && sed -i '' 's/_development/_development_audit/g' config/database.yml`
+            `#{cd_to_repo(repo)} && bundle exec rake setup`
+          end
+      end
+    end
+  end
+end

data/lib/neetob/cli/monthly_audit/instances_and_addons/cronitor/main.rb

@@ -10,16 +10,19 @@ module Neetob
       module InstancesAndAddons
         module Cronitor
           class Main < CLI::Base
+            attr_accessor :cumulative_monitors_data
+
             def initialize
               super()
+              @cumulative_monitors_data = Neetob::CLI::Cronitor::GetAllMonitors.new.run
             end
 
             def run
-              SetupCorrectlyForApps.new.run
+              SetupCorrectlyForApps.new(cumulative_monitors_data).run
               ui.info "\n"
-              SetupCorrectlyForHelpCenter.new.run
+              SetupCorrectlyForHelpCenter.new(cumulative_monitors_data).run
               ui.info "\n"
-              SetupCorrectlyForLandingPages.new.run
+              SetupCorrectlyForLandingPages.new(cumulative_monitors_data).run
             end
           end
         end

data/lib/neetob/cli/monthly_audit/instances_and_addons/cronitor/setup_correctly_for_apps.rb

@@ -8,15 +8,16 @@ module Neetob
       module InstancesAndAddons
         module Cronitor
           class SetupCorrectlyForApps < CLI::Base
-            def initialize
+            attr_reader :all_monitors
+
+            def initialize(cumulative_monitors_data)
               super()
+              @all_monitors = cumulative_monitors_data
             end
 
             def run
               ui.success "### 3.3.1. Checking whether Cronitor monitors are set up correctly for apps"
 
-              all_monitors = Neetob::CLI::Cronitor::GetAllMonitors.new.run
-
               apps_data = [["App", "Monitor for Application present", "Monitor for Application enabled", "Comments",
 "Audit Passed"]]
               ui.info("\n", print_to_audit_log: false)

data/lib/neetob/cli/monthly_audit/instances_and_addons/cronitor/setup_correctly_for_help_center.rb

@@ -10,15 +10,16 @@ module Neetob
               "NeetoTower"
             ]
 
-            def initialize
+            attr_reader :all_monitors
+
+            def initialize(cumulative_monitors_data)
               super()
+              @all_monitors = cumulative_monitors_data
             end
 
             def run
               ui.success "### 3.3.2. Checking whether Cronitor monitors are set up correctly for Help Centers"
 
-              all_monitors = Neetob::CLI::Cronitor::GetAllMonitors.new.run
-
               apps_data = [["App", "Monitor for Application help center present",
 "Monitor for Application help center enabled", "Comments", "Audit Passed"]]
               ui.info("\n", print_to_audit_log: false)

data/lib/neetob/cli/monthly_audit/instances_and_addons/cronitor/setup_correctly_for_landing_pages.rb

@@ -11,15 +11,16 @@ module Neetob
               "NeetoTower"
             ]
 
-            def initialize
+            attr_reader :all_monitors
+
+            def initialize(cumulative_monitors_data)
               super()
+              @all_monitors = cumulative_monitors_data
             end
 
             def run
               ui.success "### 3.3.3. Checking whether Cronitor monitors are set up correctly for landing pages"
 
-              all_monitors = Neetob::CLI::Cronitor::GetAllMonitors.new.run
-
               apps_data = [["App", "Monitor for Application landing page present",
 "Monitor for Application landing page enabled", "Comments", "Audit Passed"]]
               ui.info("\n", print_to_audit_log: false)

data/lib/neetob/cli/monthly_audit/security/code/active_record_doctor.rb

@@ -0,0 +1,40 @@
+# frozen_string_literal: true
+
+require_relative "../../../github/active_record_doctor"
+
+module Neetob
+  class CLI
+    module MonthlyAudit
+      module Security
+        module Code
+          class ActiveRecordDoctor < CLI::Base
+            def initialize
+              super()
+            end
+
+            def run
+              ui.success("### 1.1.4. Checking whether running `rake active_record_doctor` throws any vulnerabilities")
+              repo_data = [["Repository", "Issues Found", "Comments", "Audit Passed"]]
+              ui.info "\n"
+              NeetoCompliance::NeetoRepos.products.keys.take(5).each do |repo|
+                ui.info("Checking ActiveRecordDoctor run results for #{repo}", print_to_audit_log: false)
+                active_record_doctor_run_result = Neetob::CLI::Github::ActiveRecordDoctor.new([repo]).run
+
+                if active_record_doctor_run_result.blank?
+                  issues_found = "No"
+                  comments = nil
+                else
+                  issues_found = "Yes"
+                  comments = "#{active_record_doctor_run_result.lines.first.strip} ..."
+                end
+                audit_passed = issues_found == "No" ? "Yes" : "No"
+                repo_data << [repo, issues_found, comments, audit_passed]
+              end
+              ui.print_table(repo_data)
+            end
+          end
+        end
+      end
+    end
+  end
+end

data/lib/neetob/cli/monthly_audit/security/code/main.rb

@@ -3,6 +3,7 @@
 require_relative "bundle_audit"
 require_relative "yarn_audit"
 require_relative "brakeman"
+require_relative "active_record_doctor"
 
 module Neetob
   class CLI
@@ -20,6 +21,8 @@ module Neetob
               YarnAudit.new.run
               ui.info "\n"
               Brakeman.new.run
+              ui.info "\n"
+              ActiveRecordDoctor.new.run
             end
           end
         end

data/lib/neetob/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Neetob
-  VERSION = "0.5.32"
+  VERSION = "0.5.34"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: neetob
 version: !ruby/object:Gem::Version
-  version: 0.5.32
+  version: 0.5.34
 platform: ruby
 authors:
 - Udai Gupta
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2025-01-28 00:00:00.000000000 Z
+date: 2025-01-29 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: thor
@@ -185,6 +185,7 @@ files:
 - lib/neetob/cli/cronitor/base.rb
 - lib/neetob/cli/cronitor/get_all_monitors.rb
 - lib/neetob/cli/fetchorupdate_repos/execute.rb
+- lib/neetob/cli/github/active_record_doctor.rb
 - lib/neetob/cli/github/auth.rb
 - lib/neetob/cli/github/base.rb
 - lib/neetob/cli/github/brakeman.rb
@@ -260,6 +261,7 @@ files:
 - lib/neetob/cli/monthly_audit/misc/sparkpost_sub_account_used_for_all_apps.rb
 - lib/neetob/cli/monthly_audit/misc/ssl_certs_setup_for_auto_renewal.rb
 - lib/neetob/cli/monthly_audit/perform.rb
+- lib/neetob/cli/monthly_audit/security/code/active_record_doctor.rb
 - lib/neetob/cli/monthly_audit/security/code/brakeman.rb
 - lib/neetob/cli/monthly_audit/security/code/bundle_audit.rb
 - lib/neetob/cli/monthly_audit/security/code/main.rb