neetob 0.5.29 → 0.5.31

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 60a560c06d296ab7f0c5654305fe6925319b7165cf0748645537c7f548676ec9
-  data.tar.gz: 4934ce04f1a4dcd547e5b4887095d549fd798c5c4447b0106760938f5d4bf413
+  metadata.gz: f8882c4e2293a3dc0c4eb58244d1ec1ad3361e402e892c2b171b0f351fa7e6bf
+  data.tar.gz: 60214f801b4a0c0d5b1f44b87a2b9fa6de2dbe0ba395539494d2b75611332a0d
 SHA512:
-  metadata.gz: f5ef8c07638328dc5115efac10a03d09fb331e9137566eca0b553975c4d82835fffa6874f6d46cac9db67334e8a741187d7f099898adbb98f7e4121f0cffc97c
-  data.tar.gz: 35f7b37bd40f1064f874ab1afa3977449fc3ecd7a79ddda9a7b7250573249c57dc492e907ab908a6e7fe85ec4ef96bf36542c8b7c80e791c42feda4e0523623b
+  metadata.gz: e6230b2c8aac65c478dfa6795c06fd85ddc7f18d4b4f3134b8fe1f2f43bce5f5e3aa8fc4bc9beb4c5ea169fbcb8553f2f4aa809c2081eafbcae7e42df963269d
+  data.tar.gz: 890f6afa8d41ceb454cf3e947a6e794df153f29eda9abbbfb206fd11d002ca332e1f07156812872564f0d8d1d355ecadbadbe7b2f7c44d7e032fef42c297cc92

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    neetob (0.5.29)
+    neetob (0.5.31)
       brakeman (~> 5.0)
       chronic
       dotenv (~> 2.8.1)

data/lib/neetob/cli/code/audit.rb

@@ -51,7 +51,9 @@ module Neetob
           def find_tables_without_uuid_as_primary_key(db_schema)
             create_table_regex = /create_table.*?,\s*force:\s*:cascade\s*do\s*\|t\|/
             db_schema.scan(create_table_regex).map do |create_table_line|
-              !create_table_line.include?("id: :uuid") ? create_table_line.scan(/"([^"]+)"/).flatten.first : nil
+              !(create_table_line.include?("id: :uuid") || create_table_line.include?("id: false")) ?
+              create_table_line.scan(/"([^"]+)"/).flatten.first :
+              nil
             end
           end
 

data/lib/neetob/cli/heroku/autoscaling_config.rb

@@ -17,47 +17,22 @@ module Neetob
         end
 
         def run
-          raise(StandardError, "HEROKU_API_KEY is not given") if ENV["HEROKU_API_KEY"].nil?
+          addons_list_heroku_output = `heroku addons -a #{app}`
 
-          url = create_url(app)
-          response = get(url)
-          if response.any? { |addon| addon[:addon_service][:name] == "judoscale" }
-            ui.success("Judoscale addon is #{print_success('enabled')} for #{app}")
-          else
-            ui.error("Judoscale #{print_failure('not present')} for #{app}")
-          end
-        end
+          judoscale_addon = addons_list_heroku_output.lines.select { |line| line.include?("judoscale") }.first
 
-        private
-
-          def create_url(app)
-            "https://api.heroku.com/apps/#{app}/addons"
-          end
+          judoscale_addon_enabled = judoscale_addon && judoscale_addon.include?("created")
 
-          def parse_response(http_result)
-            case http_result
-            when Net::HTTPSuccess
-              compressed_string = StringIO.new(http_result.body)
-              response = Zlib::GzipReader.new(compressed_string).read
-              JSON.parse(response, symbolize_names: true)
-            else
-              error_message = JSON.parse(http_result.body)["message"]
-              raise(StandardError, "Request failed with status code #{http_result.code}: #{error_message}")
-            end
+          if judoscale_addon_enabled
+            ui.success("Judoscale addon is enabled for #{app}.", print_to_audit_log: false)
+          else
+            ui.error("Judoscale addon is not enabled for #{app}.", print_to_audit_log: false)
           end
 
-          def get(url,
-headers: { "Accept" => "application/vnd.heroku+json; version=3", "Authorization" => "Bearer #{ENV["HEROKU_API_KEY"]}" })
-            uri = URI(url)
-            request = Net::HTTP::Get.new(uri)
-            headers.each { |key, value| request[key] = value }
-
-            response = Net::HTTP.start(uri.hostname, uri.port, use_ssl: uri.scheme == "https") do |http|
-              http.request(request)
-            end
-
-            parse_response(response)
+          if Thread.current[:audit_mode]
+            { judoscale_addon_enabled: }
           end
+        end
       end
     end
   end

data/lib/neetob/cli/heroku/certs.rb

@@ -0,0 +1,39 @@
+# frozen_string_literal: true
+
+require_relative "../base"
+
+module Neetob
+  class CLI
+    module Heroku
+      class Certs < Base
+        attr_accessor :app
+
+        def initialize(app)
+          super()
+          @app = app
+        end
+
+        def run
+          certificates_list_heroku_output = `heroku certs -a #{app}`
+          ui.success("Certificates of #{app}", print_to_audit_log: false)
+          ui.info(certificates_list_heroku_output, print_to_audit_log: false)
+
+          if Thread.current[:audit_mode]
+            certificates_list_heroku_output.lines[2..].map do |line|
+              match = line.match(
+                /^\s*(\S+)\s+([^\d]+?)(?=\s+(\d{4}-\d{2}-\d{2} \d{2}:\d{2} UTC))/
+              )
+              next unless match
+
+              {
+                name: match[1],
+                common_names: match[2],
+                expires: match[3]
+              }
+            end
+          end
+        end
+      end
+    end
+  end
+end

data/lib/neetob/cli/heroku/commands.rb

@@ -7,6 +7,7 @@ require_relative "execute"
 require_relative "stack"
 require_relative "autoscaling_config"
 require_relative "maintenance_window"
+require_relative "certs"
 
 module Neetob
   class CLI
@@ -43,6 +44,12 @@ module Neetob
         def maintenance_window
           MaintenanceWindow.new(options[:app]).process
         end
+
+        desc "certs", "Check the certificates of the app on Heroku"
+        option :app, type: :string, aliases: "-a", required: "true", desc: "Name of your app in Heroku"
+        def certs
+          Certs.new(options[:app]).process
+        end
       end
     end
   end

data/lib/neetob/cli/heroku/config_vars/list.rb

@@ -19,16 +19,25 @@ module Neetob
 
           def run
             matching_apps = find_all_matching_apps_or_repos(apps, :heroku, sandbox)
+            final_data = []
             matching_apps.each do |app|
-              ui.info("\n  Config of #{app}\n")
+              ui.info("\n  Config of #{app}\n", print_to_audit_log: false)
               config = `heroku config -a #{app} --json`
               unless $?.success?
-                ui.error("There is a problem in accessing the app with name \"#{app}\" in your account.")
-                ui.error("Please check the specified app name and ensure you're authorized to view that app.")
+                ui.error(
+                  "There is a problem in accessing the app with name \"#{app}\" in your account.",
+                  print_to_audit_log: false)
+                ui.error(
+                  "Please check the specified app name and ensure you're authorized to view that app.",
+                  print_to_audit_log: false)
                 next
               end
               table = Terminal::Table.new headings: table_columns, rows: filter_config(config)
-              ui.success(table)
+              ui.success(table, print_to_audit_log: false)
+              final_data << JSON.parse(config)
+            end
+            if Thread.current[:audit_mode]
+              final_data
             end
           end
 

data/lib/neetob/cli/monthly_audit/instances_and_addons/main.rb

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-require_relative "neeto_deploy/main"
+require_relative "neeto_deploy_or_heroku/main"
 require_relative "cloudflare/main"
 require_relative "cronitor/main"
 require_relative "honeybadger/main"
@@ -17,9 +17,9 @@ module Neetob
           def run
             ui.success("# 3. Running audit for application instances and add-ons")
             ui.info "\n"
-            ui.success("## 3.1. Checking NeetoDeploy related configurations")
+            ui.success("## 3.1. Checking NeetoDeploy/Heroku related configurations")
             ui.info "\n"
-            NeetoDeploy::Main.new.run
+            NeetoDeployOrHeroku::Main.new.run
             ui.info "\n"
             ui.success("## 3.2. Checking Cloudflare related configurations")
             ui.info "\n"

data/lib/neetob/cli/monthly_audit/instances_and_addons/{neeto_deploy → neeto_deploy_or_heroku}/auto_scaling_enabled.rb

@@ -4,7 +4,7 @@ module Neetob
   class CLI
     module MonthlyAudit
       module InstancesAndAddons
-        module NeetoDeploy
+        module NeetoDeployOrHeroku
           class AutoScalingEnabled < CLI::Base
             def initialize
               super()
@@ -40,6 +40,17 @@ module Neetob
                 end
                 apps_data << [app, autoscaling_config, comments, audit_passed]
               end
+              Neetob::CLI::Sre::Base::APPS_LIST[:heroku].select { |app| app.include?("production") }.each do |app|
+                ui.info("Checking auto_scaling config for #{app}", print_to_audit_log: false)
+                autoscaling_config_result = Neetob::CLI::Heroku::AutoscalingConfig.new(app).run
+                comments = nil
+
+                audit_passed = autoscaling_config_result[:judoscale_addon_enabled] ? "Yes" : "No"
+                if audit_passed == "No"
+                  comments = "Judoscale addon is not enabled"
+                end
+                apps_data << [app, autoscaling_config_result, comments, audit_passed]
+              end
               ui.print_table(apps_data)
             end
           end

data/lib/neetob/cli/monthly_audit/instances_and_addons/{neeto_deploy → neeto_deploy_or_heroku}/cloudfront_cdn_enabled.rb

@@ -4,7 +4,7 @@ module Neetob
   class CLI
     module MonthlyAudit
       module InstancesAndAddons
-        module NeetoDeploy
+        module NeetoDeployOrHeroku
           class CloudfrontCdnEnabled < CLI::Base
             def initialize
               super()
@@ -46,6 +46,23 @@ module Neetob
                 end
                 apps_data << [app, asset_host_value, comments, audit_passed]
               end
+              Neetob::CLI::Sre::Base::APPS_LIST[:heroku].select { |app| app.include?("production") }.each do |app|
+                ui.info("Checking ASSET_HOST value for #{app}", print_to_audit_log: false)
+                config_vars_result = Neetob::CLI::Heroku::ConfigVars::List.new([app]).run[0]
+                asset_host_value = config_vars_result["ASSET_HOST"]
+                if asset_host_value.nil?
+                  audit_passed = "No"
+                  comments = "ASSET_HOST value not found."
+                else
+                  is_direct_cloudfront_asset_host = asset_host_value.include?("cloudfront.net")
+                  is_cdn_subdomain_asset_host = asset_host_value == "cdn.#{app.gsub("-web-production", "").gsub("-", "")}.com"
+                  audit_passed = is_direct_cloudfront_asset_host || is_cdn_subdomain_asset_host ? "Yes" : "No"
+                  if audit_passed == "No"
+                    comments = "ASSET_HOST value is not a Cloudfront CDN URL or a CDN subdomain URL."
+                  end
+                end
+                apps_data << [app, asset_host_value, comments, audit_passed]
+              end
               ui.print_table(apps_data)
             end
           end

data/lib/neetob/cli/monthly_audit/instances_and_addons/{neeto_deploy → neeto_deploy_or_heroku}/essential_environment_variables_set.rb

@@ -4,7 +4,7 @@ module Neetob
   class CLI
     module MonthlyAudit
       module InstancesAndAddons
-        module NeetoDeploy
+        module NeetoDeployOrHeroku
           class EssentialEnvironmentVariablesSet < CLI::Base
             def initialize
               super()
@@ -33,6 +33,16 @@ module Neetob
                 end
                 apps_data << [app, all_essential_env_variables_set, comments, audit_passed]
               end
+              Neetob::CLI::Sre::Base::APPS_LIST[:heroku].select { |app| app.include?("production") }.each do |app|
+                ui.info("Checking essential env variables for #{app}", print_to_audit_log: false)
+                essential_env_variables_result = Neetob::CLI::Sre::CheckEssentialEnv.new(app).run
+                all_essential_env_variables_set = essential_env_variables_result[:all_keys_present]
+                audit_passed = all_essential_env_variables_set ? "Yes" : "No"
+                if audit_passed == "No"
+                  comments = "Missing keys: #{essential_env_variables_result[:missing_keys].join(", ")}"
+                end
+                apps_data << [app, all_essential_env_variables_set, comments, audit_passed]
+              end
               ui.print_table(apps_data)
             end
           end

data/lib/neetob/cli/monthly_audit/instances_and_addons/{neeto_deploy → neeto_deploy_or_heroku}/main.rb

@@ -10,7 +10,7 @@ module Neetob
   class CLI
     module MonthlyAudit
       module InstancesAndAddons
-        module NeetoDeploy
+        module NeetoDeployOrHeroku
           class Main < CLI::Base
             def initialize
               super()

data/lib/neetob/cli/monthly_audit/instances_and_addons/{neeto_deploy → neeto_deploy_or_heroku}/scheduled_exports_enabled.rb

@@ -4,7 +4,7 @@ module Neetob
   class CLI
     module MonthlyAudit
       module InstancesAndAddons
-        module NeetoDeploy
+        module NeetoDeployOrHeroku
           class ScheduledExportsEnabled < CLI::Base
             def initialize
               super()

data/lib/neetob/cli/monthly_audit/instances_and_addons/{neeto_deploy → neeto_deploy_or_heroku}/ssl_certificates_over_thirty_days_from_expiry.rb

@@ -4,7 +4,7 @@ module Neetob
   class CLI
     module MonthlyAudit
       module InstancesAndAddons
-        module NeetoDeploy
+        module NeetoDeployOrHeroku
           class SslCertificatesOverThirtyDaysFromExpiry < CLI::Base
             def initialize
               super()
@@ -33,6 +33,21 @@ module Neetob
                 end
                 apps_data << [app, certificates_expiring_in_less_than_30_days, comments, audit_passed]
               end
+              Neetob::CLI::Sre::Base::APPS_LIST[:heroku].select { |app| app.include?("production") }.each do |app|
+                ui.info("Checking Certificates status for #{app}", print_to_audit_log: false)
+                certificates_status = Neetob::CLI::Heroku::Certs.new(app).run
+                certificates_expiring_in_less_than_30_days = certificates_status.select { |certificate| DateTime.parse(certificate[:expires]) <= 32.days.from_now }
+                comments = nil
+                audit_passed = "No"
+                certificates_expiring_in_less_than_30_days_present = "No"
+                if certificates_expiring_in_less_than_30_days.empty?
+                  audit_passed = "Yes"
+                else
+                  comments = "Certificates #{certificates_expiring_in_less_than_30_days.map { |certificate| certificate[:name] }.join(", ")} are expiring in less than 30 days."
+                  certificates_expiring_in_less_than_30_days_present = "Yes"
+                end
+                apps_data << [app, certificates_expiring_in_less_than_30_days_present, comments, audit_passed]
+              end
               ui.print_table(apps_data)
             end
           end

data/lib/neetob/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Neetob
-  VERSION = "0.5.29"
+  VERSION = "0.5.31"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: neetob
 version: !ruby/object:Gem::Version
-  version: 0.5.29
+  version: 0.5.31
 platform: ruby
 authors:
 - Udai Gupta
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2025-01-22 00:00:00.000000000 Z
+date: 2025-01-28 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: thor
@@ -218,6 +218,7 @@ files:
 - lib/neetob/cli/heroku/access/remove.rb
 - lib/neetob/cli/heroku/autoscaling_config.rb
 - lib/neetob/cli/heroku/base.rb
+- lib/neetob/cli/heroku/certs.rb
 - lib/neetob/cli/heroku/commands.rb
 - lib/neetob/cli/heroku/config_vars/audit.rb
 - lib/neetob/cli/heroku/config_vars/base.rb
@@ -248,12 +249,12 @@ files:
 - lib/neetob/cli/monthly_audit/instances_and_addons/honeybadger/main.rb
 - lib/neetob/cli/monthly_audit/instances_and_addons/honeybadger/setup_correctly_for_apps.rb
 - lib/neetob/cli/monthly_audit/instances_and_addons/main.rb
-- lib/neetob/cli/monthly_audit/instances_and_addons/neeto_deploy/auto_scaling_enabled.rb
-- lib/neetob/cli/monthly_audit/instances_and_addons/neeto_deploy/cloudfront_cdn_enabled.rb
-- lib/neetob/cli/monthly_audit/instances_and_addons/neeto_deploy/essential_environment_variables_set.rb
-- lib/neetob/cli/monthly_audit/instances_and_addons/neeto_deploy/main.rb
-- lib/neetob/cli/monthly_audit/instances_and_addons/neeto_deploy/scheduled_exports_enabled.rb
-- lib/neetob/cli/monthly_audit/instances_and_addons/neeto_deploy/ssl_certificates_over_thirty_days_from_expiry.rb
+- lib/neetob/cli/monthly_audit/instances_and_addons/neeto_deploy_or_heroku/auto_scaling_enabled.rb
+- lib/neetob/cli/monthly_audit/instances_and_addons/neeto_deploy_or_heroku/cloudfront_cdn_enabled.rb
+- lib/neetob/cli/monthly_audit/instances_and_addons/neeto_deploy_or_heroku/essential_environment_variables_set.rb
+- lib/neetob/cli/monthly_audit/instances_and_addons/neeto_deploy_or_heroku/main.rb
+- lib/neetob/cli/monthly_audit/instances_and_addons/neeto_deploy_or_heroku/scheduled_exports_enabled.rb
+- lib/neetob/cli/monthly_audit/instances_and_addons/neeto_deploy_or_heroku/ssl_certificates_over_thirty_days_from_expiry.rb
 - lib/neetob/cli/monthly_audit/misc/main.rb
 - lib/neetob/cli/monthly_audit/misc/redirections_working_correctly.rb
 - lib/neetob/cli/monthly_audit/misc/sparkpost_sub_account_used_for_all_apps.rb