neetob 0.5.27 → 0.5.29

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 43bee5927b6fc71846d91dde3422ae976aafe5f25a9d00324b74fdf1e9582c2f
-  data.tar.gz: c8335267601b2bbcb5a2055d09c774aa76d1c1868fc0b2e3d9437bfe6c2cd3cd
+  metadata.gz: 60a560c06d296ab7f0c5654305fe6925319b7165cf0748645537c7f548676ec9
+  data.tar.gz: 4934ce04f1a4dcd547e5b4887095d549fd798c5c4447b0106760938f5d4bf413
 SHA512:
-  metadata.gz: 3f51dcfcae88fc1bcb8993c7f69473cc7cea25e434f551f5fa2a737c16b3a580bad6c85077e0160b76021fe0c86750e2d5a78b291b5d845fbff32bcd833fd8c3
-  data.tar.gz: 4be54dcb091c319bead3605732579fe1e8079903014d9802cfd512397b5191fd6314b23b746916b91e2adf74a908b2da31b1cfc8400d88e931a060da95a4eddf
+  metadata.gz: f5ef8c07638328dc5115efac10a03d09fb331e9137566eca0b553975c4d82835fffa6874f6d46cac9db67334e8a741187d7f099898adbb98f7e4121f0cffc97c
+  data.tar.gz: 35f7b37bd40f1064f874ab1afa3977449fc3ecd7a79ddda9a7b7250573249c57dc492e907ab908a6e7fe85ec4ef96bf36542c8b7c80e791c42feda4e0523623b

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    neetob (0.5.27)
+    neetob (0.5.29)
       brakeman (~> 5.0)
       chronic
       dotenv (~> 2.8.1)

data/lib/neetob/cli/monthly_audit/databases/uuid_primary_key.rb

@@ -17,6 +17,7 @@ module Neetob
               "Audit Passed"
               ]
             ]
+            last_comment = nil
             NeetoCompliance::NeetoRepos.products.keys.each do |repo|
               ui.info "Checking #{repo}...", print_to_audit_log: false
               code_audit_result = Neetob::CLI::Code::Audit.new([repo]).run[0]
@@ -34,6 +35,11 @@ module Neetob
               all_tables_have_uuid_primary_keys = tables_without_uuid.empty? ? "Yes" : "No"
               audit_passed = all_tables_have_uuid_primary_keys == "Yes" ? "Yes" : "No"
               comments = tables_without_uuid.empty? ? nil : "Tables without UUID primary keys: #{tables_without_uuid.join(', ')}"
+              same_as_last_comment = audit_passed == "No" && comments == last_comment
+              last_comment = comments
+              if same_as_last_comment
+                comments = "''"
+              end
               repo_data << [repo, all_tables_have_uuid_primary_keys, comments, audit_passed]
             end
             ui.print_table(repo_data)

data/lib/neetob/cli/monthly_audit/instances_and_addons/cloudflare/dns_entry_has_proxy_status.rb

@@ -20,6 +20,7 @@ module Neetob
 
               domains_data = [["Domain", "DNS proxy status", "Audit Passed"]]
               ui.info("\n", print_to_audit_log: false)
+              last_dns_proxy_status = nil
               Neetob::CLI::Cloudflare::Base::ZONE_IDS.keys.select { |domain|
  domain.to_s.include?(".com") }.map do |domain|
                 ui.info("Checking proxy status for DNS entries for #{domain}", print_to_audit_log: false)
@@ -35,8 +36,13 @@ module Neetob
                                   "Ignored" :
                                   (is_wildcard_subdomain_proxied ? "Yes" : "No")
                   proxy_status = is_wildcard_subdomain_proxied ? "on" : "off"
-                  domains_data << [domain, "#{record_to_check[:name]} has proxying turned #{proxy_status}",
-audit_passed]
+                  dns_proxy_status = "* record has proxying turned #{proxy_status}"
+                  same_as_last_dns_proxy_status = dns_proxy_status == last_dns_proxy_status
+                  last_dns_proxy_status = dns_proxy_status
+                  if same_as_last_dns_proxy_status
+                    dns_proxy_status = "''"
+                  end
+                  domains_data << [domain, dns_proxy_status, audit_passed]
                 end
               end
               ui.print_table(domains_data)

data/lib/neetob/cli/monthly_audit/instances_and_addons/cronitor/setup_correctly_for_help_center.rb

@@ -6,6 +6,10 @@ module Neetob
       module InstancesAndAddons
         module Cronitor
           class SetupCorrectlyForHelpCenter < CLI::Base
+            APPS_TO_IGNORE = [
+              "NeetoTower"
+            ]
+
             def initialize
               super()
             end
@@ -38,6 +42,9 @@ module Neetob
                     audit_passed = "Yes"
                   end
                 end
+                if (audit_passed == "No") && APPS_TO_IGNORE.map(&:downcase).include?(app.downcase.to_s)
+                  audit_passed = "Ignored"
+                end
 
                 apps_data << [app, monitor_for_app_help_center_present, monitor_for_app_help_center_enabled, comments,
 audit_passed]

data/lib/neetob/cli/monthly_audit/instances_and_addons/cronitor/setup_correctly_for_landing_pages.rb

@@ -6,6 +6,11 @@ module Neetob
       module InstancesAndAddons
         module Cronitor
           class SetupCorrectlyForLandingPages < CLI::Base
+            APPS_TO_IGNORE = [
+              "NeetoAuth",
+              "NeetoTower"
+            ]
+
             def initialize
               super()
             end
@@ -39,6 +44,10 @@ module Neetob
                   end
                 end
 
+                if (audit_passed == "No") && APPS_TO_IGNORE.map(&:downcase).include?(app.downcase.to_s)
+                  audit_passed = "Ignored"
+                end
+
                 apps_data << [app, monitor_for_app_landing_page_present, monitor_for_app_landing_page_enabled,
 comments, audit_passed]
               end

data/lib/neetob/cli/monthly_audit/instances_and_addons/neeto_deploy/auto_scaling_enabled.rb

@@ -15,6 +15,7 @@ module Neetob
 
               apps_data = [["App", "Autoscaling config", "Comments", "Audit Passed"]]
               ui.info("\n", print_to_audit_log: false)
+              last_comment = nil
               Neetob::CLI::Sre::Base::APPS_LIST[:neetodeploy].select { |app| app.include?("production") }.each do |app|
                 ui.info("Checking auto_scaling config for #{app}", print_to_audit_log: false)
                 autoscaling_config_result = Neetob::CLI::NeetoDeploy::AutoscalingConfig.new(app).run
@@ -32,6 +33,9 @@ module Neetob
                   audit_passed = autoscaling_turned_on_for_web && autoscaling_turned_on_for_worker ? "Yes" : "No"
                   if audit_passed == "No"
                     comments = "Auto-scaling is not enabled for web and/or worker dynos."
+                    same_as_last_comment = comments == last_comment
+                    last_comment = comments
+                    comments = "''" if same_as_last_comment
                   end
                 end
                 apps_data << [app, autoscaling_config, comments, audit_passed]

data/lib/neetob/cli/monthly_audit/instances_and_addons/neeto_deploy/scheduled_exports_enabled.rb

@@ -15,6 +15,7 @@ module Neetob
 
               apps_data = [["App", "Scheduled exports config", "Comments", "Audit Passed"]]
               ui.info("\n", print_to_audit_log: false)
+              last_scheduled_exports_config = nil
               Neetob::CLI::Sre::Base::APPS_LIST[:neetodeploy].select { |app| app.include?("production") }.each do |app|
                 ui.info("Checking Scheduled exports config for #{app}", print_to_audit_log: false)
                 scheduled_exports_result = Neetob::CLI::NeetoDeploy::ScheduledExports.new(app).run
@@ -25,11 +26,20 @@ module Neetob
                   audit_passed = "No"
                   comments = "You do not have permission to access the config for this app."
                 else
-                  scheduled_exports_config = scheduled_exports_result.gsub("\e[32m", "").gsub("\e[0m", "").strip
+                  scheduled_exports_config = scheduled_exports_result
+                    .gsub("\e[32m", "")
+                    .gsub("\e[0m", "")
+                    .gsub("#{app}'s", "")
+                    .strip
                   audit_passed = scheduled_exports_config.include?("turned on") ? "Yes" : "No"
                   if audit_passed == "No"
                     comments = scheduled_exports_config
                   end
+                  same_as_last_scheduled_export_config = scheduled_exports_config == last_scheduled_exports_config
+                  last_scheduled_exports_config = scheduled_exports_config
+                  if same_as_last_scheduled_export_config
+                    scheduled_exports_config = "''"
+                  end
                 end
                 apps_data << [app, scheduled_exports_config, comments, audit_passed]
               end

data/lib/neetob/cli/monthly_audit/instances_and_addons/neeto_deploy/ssl_certificates_over_thirty_days_from_expiry.rb

@@ -12,24 +12,26 @@ module Neetob
 
             def run
               ui.success "### 3.1.1. Checking whether SSL certificates are over 30 days from expiry"
-              apps_data = [["App", "Certificates status", "Comments", "Audit Passed"]]
+              apps_data = [["App", "Certificates expiring before 30 days present?", "Comments", "Audit Passed"]]
               ui.info("\n", print_to_audit_log: false)
               Neetob::CLI::Sre::Base::APPS_LIST[:neetodeploy].select { |app| app.include?("production") }.each do |app|
                 ui.info("Checking Certificates status for #{app}", print_to_audit_log: false)
                 certificates_status = Neetob::CLI::NeetoDeploy::Certificates.new(app).run
                 audit_passed = nil
                 comments = nil
+                certificates_expiring_in_less_than_30_days = "No"
                 if certificates_status.is_a?(Hash) && certificates_status["error"] == "Forbidden"
                   audit_passed = "No"
                   comments = "You do not have permission to access the certificates for this app."
                 else
                   audit_passed = certificates_status.any? { |certificate| certificate["expires_before_30_days"] } ? "No" : "Yes"
+                  certificates_expiring_in_less_than_30_days = "Yes" if audit_passed == "No"
                   if audit_passed == "No"
                     certificates_failing_audit = certificates_status.select { |certificate| certificate["expires_before_30_days"] }.map { |certificate| certificate["name"] }
                     comments = "Certificates #{certificates_failing_audit.join(", ")} are expiring in less than 30 days."
                   end
                 end
-                apps_data << [app, certificates_status, comments, audit_passed]
+                apps_data << [app, certificates_expiring_in_less_than_30_days, comments, audit_passed]
               end
               ui.print_table(apps_data)
             end

data/lib/neetob/cli/monthly_audit/security/code/bundle_audit.rb

@@ -16,6 +16,7 @@ module Neetob
               ui.success("### 1.1.1. Checking whether running `bundle-audit check` throws any vulnerabilities")
               repo_data = [["Repository", "Vulnerabilities Found", "Comments", "Audit Passed"]]
               ui.info "\n"
+              last_comment = nil
               NeetoCompliance::NeetoRepos.products.keys.each do |repo|
                 ui.info("Checking bundle audit run results for #{repo}", print_to_audit_log: false)
                 bundle_audit_result = Neetob::CLI::Github::BundleAudit.new([repo]).run
@@ -27,6 +28,11 @@ module Neetob
                 else
                   vulnerabilities_found = "Yes"
                   comments = bundle_audit_result.gsub("\n", "<br>")
+                  same_as_last_vulnerabilities = comments == last_comment
+                  last_comment = comments
+                  if same_as_last_vulnerabilities
+                    comments = "''"
+                  end
                 end
                 repo_data << [repo, vulnerabilities_found, comments, audit_passed]
               end

data/lib/neetob/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Neetob
-  VERSION = "0.5.27"
+  VERSION = "0.5.29"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: neetob
 version: !ruby/object:Gem::Version
-  version: 0.5.27
+  version: 0.5.29
 platform: ruby
 authors:
 - Udai Gupta
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2025-01-21 00:00:00.000000000 Z
+date: 2025-01-22 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: thor