neeto-translate-cli 0.2.22 → 0.3.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 9a2411721a8b69022a3d121cb36bedcd42dd671697a8589201035f2eb13c143a
-  data.tar.gz: d24db647b3d37a49af437dfc5f6d7c4c005ede89074ce57fef019747147adaf4
+  metadata.gz: 2843b446edd2c585c87d15b48cc8b950e80dab86bac2d6eaf928478ceb4fd8ba
+  data.tar.gz: 0dd014fabdbb035100109d4abf5a6d9f27412def945e5f40780839bb43672581
 SHA512:
-  metadata.gz: 2263880a2466eee917a72eb40598ba77b7100b8bc3d37cb97e1f4b3f028a63a5bf8feb39609935531bd0679f61f8ad1502bdfba0407d6d2d4d6f0cfa75cd0420
-  data.tar.gz: 647aba2e1fb8e4ca1402c7c7c66bd868ae738a6d9595b01085826cc4d99fef6959261b7370742d476cc2dd28e2795490fdc001a765c869d08e53a43a28a5cfdf
+  metadata.gz: 6b6f0aa12230ed0e04f997051c5275a866745f0407c4dd940fbc76919a2fe36401bfae67d65fbaffebd6ccfd9368fbb9b9ed10985ea871873e57de2f2552b347
+  data.tar.gz: eda8a84c5c70b9d5d690f1aedf53e939bbdc51bb81530c2f389b7bfa04354a64359a02916cb727de98e0a298beadf58fa5f6ac051f6d16eacde553e40131480e

data/README.md

@@ -87,11 +87,12 @@ The following environment variables can be configured:
 ### How It Works
 
 1. **Extraction**: The tool reads your English translation files (`en.json` for frontend, `en.yml` for backend)
-2. **Analysis**: It compares with other language files to identify missing translations
+2. **Analysis**: It compares with other language files to identify missing translations, and keys that are no longer in the English files (plural forms other languages need, like `_few` or `.many`, are kept)
 3. **Change Detection**: It detects keys that have been updated since the last automated translation run
 4. **API Request**: Sends a payload to the neeto-translate API with:
    - Current English translations
    - Missing translation keys for each language
+   - Keys removed from the English files, for each language
    - Updated keys that need re-translation
    - Repository metadata
 

data/lib/neeto_translate_cli/payload_builder.rb

@@ -4,6 +4,12 @@ require_relative "git_helper"
 
 module NeetoTranslateCli
   class PayloadBuilder
+    TYPES = %i[frontend backend].freeze
+    KEY_KINDS = %i[missing_keys removed_keys].freeze
+    # Same plural rule as Github::CreatePullRequestService on the server.
+    PLURAL_FORM_REGEX = /\A(?<base>.+)(?<separator>[._])(?:zero|one|two|few|many|other)\z/
+    PLURAL_BASE_FORMS = %w[one other].freeze
+
     attr_reader :options, :updated_keys
 
     def initialize(options)
@@ -14,8 +20,8 @@ module NeetoTranslateCli
 
     def process!
       {
-        frontend: { en: en_json_flattened, missing_keys: find_missing_keys_for(:frontend) },
-        backend: { en: en_yml_flattened, missing_keys: find_missing_keys_for(:backend) },
+        frontend: payload_for(:frontend),
+        backend: payload_for(:backend),
         metadata: {
           repo: options[:repo],
           frontend: options[:frontend],
@@ -26,11 +32,21 @@ module NeetoTranslateCli
     end
 
     def no_new_changes?(payload)
-      payload[:frontend][:missing_keys].values.all?(&:empty?) && payload[:backend][:missing_keys].values.all?(&:empty?)
+      TYPES.all? do |type|
+        KEY_KINDS.all? { |kind| payload[type][kind].to_h.values.all?(&:empty?) }
+      end
     end
 
     private
 
+    def payload_for(type)
+      {
+        en: type == :frontend ? en_json_flattened : en_yml_flattened,
+        missing_keys: find_missing_keys_for(type),
+        removed_keys: find_removed_keys_for(type)
+      }
+    end
+
     def git_commit_id
       GitHelper.find_neeto_translate_commit
     end
@@ -94,6 +110,36 @@ module NeetoTranslateCli
       end
     end
 
+    def find_removed_keys_for(type)
+      base_keys = type == :frontend ? en_json_flattened.keys : en_yml_flattened.keys
+
+      languages.each_with_object({}) do |lang, removed|
+        translations = load_translations(type, lang)
+        next unless translations
+
+        removed[lang] = (flatten_hash(translations).keys - base_keys).reject { |key| plural_form_of?(key, base_keys) }
+      end
+    end
+
+    def load_translations(type, lang)
+      if type == :frontend
+        file_path = File.expand_path("#{lang}.json", options[:frontend])
+        load_json(file_path) if File.file?(file_path)
+      else
+        file_path = File.expand_path("#{lang}.yml", options[:backend])
+        load_yml(file_path)[lang].to_h if File.file?(file_path)
+      end
+    end
+
+    # Languages like ar and ru need plural forms that en doesn't have (e.g. `item_few`, `items.many`),
+    # so a plural form of an en key is not treated as removed.
+    def plural_form_of?(key, base_keys)
+      match = key.match(PLURAL_FORM_REGEX)
+      return false unless match
+
+      PLURAL_BASE_FORMS.any? { |form| base_keys.include?("#{match[:base]}#{match[:separator]}#{form}") }
+    end
+
     def load_json(file_path)
       return {} unless File.file?(file_path)
 

data/lib/neeto_translate_cli/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module NeetoTranslateCli
-  VERSION = "0.2.22"
+  VERSION = "0.3.0"
 end

data/test/neeto_translate_cli/payload_builder_test.rb

@@ -1,4 +1,6 @@
 require "test_helper"
+require "fileutils"
+require "tmpdir"
 
 class NeetoTranslateCli::PayloadBuilderTest < Minitest::Test
   def setup
@@ -170,8 +172,71 @@ class NeetoTranslateCli::PayloadBuilderTest < Minitest::Test
     end
   end
 
+  def test_removed_keys_are_the_keys_missing_from_en
+    with_locale_files do |payload_builder|
+      payload = payload_builder.process!
+
+      assert_equal %w[common.deleted dashboard.stats.removed], payload.dig(:frontend, :removed_keys, "es").sort
+      assert_equal %w[common.deleted], payload.dig(:backend, :removed_keys, "es")
+      assert_empty payload.dig(:frontend, :removed_keys, "de")
+    end
+  end
+
+  def test_removed_keys_keep_plural_forms_of_en_keys
+    with_locale_files do |payload_builder|
+      payload = payload_builder.process!
+
+      refute_includes payload.dig(:frontend, :removed_keys, "es"), "common.item_many"
+      refute_includes payload.dig(:backend, :removed_keys, "es"), "common.items.few"
+    end
+  end
+
+  def test_no_new_changes_is_false_when_keys_were_only_removed
+    with_locale_files do |payload_builder|
+      payload = payload_builder.process!
+
+      assert payload[:frontend][:missing_keys].values.all?(&:empty?)
+      assert payload[:backend][:missing_keys].values.all?(&:empty?)
+      refute payload_builder.no_new_changes?(payload)
+    end
+  end
+
   private
 
+    def with_locale_files
+      Dir.mktmpdir do |dir|
+        frontend = File.join(dir, "frontend")
+        backend = File.join(dir, "backend")
+        FileUtils.mkdir_p([frontend, backend])
+
+        en_json = { "common" => { "ok" => "OK", "item_one" => "Item", "item_other" => "Items" } }
+        es_json = {
+          "common" => { "ok" => "Aceptar", "item_one" => "Elemento", "item_other" => "Elementos",
+                        "item_many" => "Elementos", "deleted" => "Borrado" },
+          "dashboard" => { "stats" => { "removed" => "Eliminado" } }
+        }
+        File.write(File.join(frontend, "en.json"), JSON.generate(en_json))
+        File.write(File.join(frontend, "es.json"), JSON.generate(es_json))
+        File.write(File.join(frontend, "de.json"), JSON.generate(en_json))
+
+        en_yml = { "en" => { "common" => { "ok" => "OK", "items" => { "one" => "Item", "other" => "Items" } } } }
+        es_yml = {
+          "es" => {
+            "common" => { "ok" => "Aceptar", "deleted" => "Borrado",
+                          "items" => { "one" => "Elemento", "few" => "Elementos", "other" => "Elementos" } }
+          }
+        }
+        File.write(File.join(backend, "en.yml"), en_yml.to_yaml)
+        File.write(File.join(backend, "es.yml"), es_yml.to_yaml)
+        File.write(File.join(backend, "de.yml"), { "de" => en_yml["en"] }.to_yaml)
+
+        options = @options.merge(frontend:, backend:)
+        NeetoTranslateCli::GitHelper.stub :find_neeto_translate_commit, "" do
+          yield NeetoTranslateCli::PayloadBuilder.new(options)
+        end
+      end
+    end
+
     def flatten_hash(hash, prefix = nil)
       hash.each_with_object({}) do |(key, value), result|
         current_key = prefix ? "#{prefix}.#{key}" : key.to_s

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: neeto-translate-cli
 version: !ruby/object:Gem::Version
-  version: 0.2.22
+  version: 0.3.0
 platform: ruby
 authors:
 - Neeraj Singh
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2026-09-12 00:00:00.000000000 Z
+date: 2026-11-15 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: faraday