ndr_support 5.5.0 → 5.7.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 6e21f71716e6733363c47fb4fb1f457ec616a913902729cb40fa8a227a77d530
-  data.tar.gz: 9b251bf890fb3d835c256fe81d136d51327e749970c21bad0a77529e12655384
+  metadata.gz: 8e95a05bf2c1dd28e2bfe10716b35e761c5db50ac58947f168585692b588c499
+  data.tar.gz: 49ed22feef4c4a22ea2094883263eaf81d24a497cff6d0977fa23c6889518e77
 SHA512:
-  metadata.gz: f603f2982d2615bfc0a4b1963f324ee633a1e9fa8248c575ae52a74403b3dc514a1cbec13b2f162f351e297d6d3df50e9cd8ace0692571f3f8202603fd969598
-  data.tar.gz: 9c3248c3286b5eba6ebf757a8e1f43958c585718f768de8798be3d482a5cfda28e36dfba1286782d9701d587aa3bc7465828f5c576e17bf0ccce377ce974743f
+  metadata.gz: aaa5b6b7e04962f01738e60815f338c3c54ca38c5862ab5b5a373a9f9628712670d75db1f7bae9e2e2830e6cf511a36b9bc0ec304822352e0e64b94caa375160
+  data.tar.gz: e204589b6cd0951139bea6d2d96d23d4ec0bfe7d0c2be501bdd0ed1668802d4dbb3a7866e73242d004bce25cfc9d8407b934051a3c5afe29b101fe813cee49d5

data/CHANGELOG.md

@@ -1,6 +1,32 @@
 ## [Unreleased]
 *no unreleased changes*
 
+## 5.7.1 / 2021-01-03
+## Fixed
+* Postcodeize old Newport postcodes
+* Bump rake version
+* Support 2022 public holidays
+
+## 5.7.0 / 2020-06-30
+## Added
+* Handle three char months in Daterange
+
+## 5.6.1 / 2020-01-02
+## Fixed
+* Fix issue with 2020 public holiday
+* Support 2021 public holidays
+* Ensure dateranges up to 2030 are supported
+
+## 5.6.0 / 2019-08-29
+### Added
+* Add `Integer#working_days_since`. (#11)
+
+## 5.5.1 / 2019-05-15
+### Fixed
+* Support Ruby 2.6, Rails 6.0. Minimum Ruby/Rails versions are now 2.5/5.2
+* Warn when WorkingDays lookup is getting stale
+* Improved date parsing in `String#to_date`
+
 ## 5.5.0 / 2018-11-16
 ### Added
 * Add `ThreatScanner` to wrap ClamAV for virus detection (#10)

data/code_safety.yml

@@ -12,12 +12,12 @@ file safety:
     comments: 'diff failed; reviewed whole file. Revision c88f5ac8c12fd657bb142144e0d3afaa7f9bc361:
       Slack notification secret is public/private key encrypted, so not a disclosure
       risk. As a secondary protection, it''s excluded from the .gem file by ndr_support.gemspec'
-    reviewed_by: brian.shand
-    safe_revision: c88f5ac8c12fd657bb142144e0d3afaa7f9bc361
+    reviewed_by: josh.pencheon
+    safe_revision: 0cfcfac5ddcd721a67dcd23f04cbf6bc2278b922
   CHANGELOG.md:
     comments: 
-    reviewed_by: josh.pencheon
-    safe_revision: ea1f7dc9a164981570ee2ad7c38197fdb17a6880
+    reviewed_by: brian.shand
+    safe_revision: f7cfb534917c991a6e1811f1eb4cff2083c141d2
   CODE_OF_CONDUCT.md:
     comments: 
     reviewed_by: timgentry
@@ -42,42 +42,34 @@ file safety:
     comments: 
     reviewed_by: timgentry
     safe_revision: e33e9dae7f38bc449ce9276515a539836dbbbd53
-  gemfiles/Gemfile.rails42:
-    comments: 
-    reviewed_by: pauleves
-    safe_revision: f76ad0fe72d42b1ff37553c8194935a8b93a6848
-  gemfiles/Gemfile.rails50:
-    comments: 
-    reviewed_by: josh.pencheon
-    safe_revision: 55ed1c2a18b9cc4d1d996ee69419f5ee38f87746
-  gemfiles/Gemfile.rails51:
-    comments: 
-    reviewed_by: brian.shand
-    safe_revision: 4e87fd9d64fc0f15b359ba60fc48cda54453c647
   gemfiles/Gemfile.rails52:
     comments: 
     reviewed_by: josh.pencheon
     safe_revision: 8a6bedae77d33d0db1b67eaed7972870b6afc993
-  lib/ndr_support.rb:
+  gemfiles/Gemfile.rails60:
     comments: 
     reviewed_by: josh.pencheon
-    safe_revision: ed8ff421cc9353456af13a37049a07ce2545aac1
+    safe_revision: 0cfcfac5ddcd721a67dcd23f04cbf6bc2278b922
+  lib/ndr_support.rb:
+    comments: 
+    reviewed_by: brian.shand
+    safe_revision: 44fbdf72f47f4022c7dc9148150ebc18589dac8f
   lib/ndr_support/array.rb:
     comments: 
     reviewed_by: pauleves
     safe_revision: 4a4ed24d2cfe7e1736baadf4cf6e0fece6823be1
   lib/ndr_support/concerns/working_days.rb:
     comments: 
-    reviewed_by: josh.pencheon
-    safe_revision: e5671bd9435490d521028d02bc91ccb47c74c580
+    reviewed_by: brianshand
+    safe_revision: b72baa322dc58820ccd615a178371c2e5dab113c
   lib/ndr_support/date_and_time_extensions.rb:
     comments: 
     reviewed_by: josh.pencheon
-    safe_revision: 3553509e52b3697d361cfa4c6f8a67754ed942d3
+    safe_revision: c1158eccb843b637b4dd82815dc7c081f12b93e4
   lib/ndr_support/daterange.rb:
     comments: 
-    reviewed_by: brian.shand
-    safe_revision: c7ed8bc16be8ec803dfaeb3473fbc538b54587ec
+    reviewed_by: ollietulloch
+    safe_revision: 9a4b8e53f477725c2c2be5000b3c9e66f07d7389
   lib/ndr_support/hash.rb:
     comments: 
     reviewed_by: pauleves
@@ -94,6 +86,10 @@ file safety:
     comments: 
     reviewed_by: josh.pencheon
     safe_revision: 2685f35c907af6968a69eabb5ab9424b490d0f40
+  lib/ndr_support/integer/working_days.rb:
+    comments: 
+    reviewed_by: josh.pencheon
+    safe_revision: c1158eccb843b637b4dd82815dc7c081f12b93e4
   lib/ndr_support/nil.rb:
     comments: 
     reviewed_by: pauleves
@@ -132,20 +128,20 @@ file safety:
     safe_revision: 4492da77f6a8b678c40dd571fdd46fd936052cca
   lib/ndr_support/string/cleaning.rb:
     comments: 
-    reviewed_by: brian.shand
-    safe_revision: 60cc69774d5aff92252558feae9604544def7583
+    reviewed_by: brianshand
+    safe_revision: b7b033ad9773cc9037c408a7763b113d31cbf191
   lib/ndr_support/string/conversions.rb:
     comments: 
-    reviewed_by: brian.shand
-    safe_revision: 0a06fed3e7530185497f786decdb77a62d35e101
+    reviewed_by: ollietulloch
+    safe_revision: 9a4b8e53f477725c2c2be5000b3c9e66f07d7389
   lib/ndr_support/tasks.rb:
     comments: 
     reviewed_by: timgentry
     safe_revision: 62337584a32e5c30c2e9af7cd998a9df684885cc
   lib/ndr_support/threat_scanner.rb:
     comments: 
-    reviewed_by: josh.pencheon
-    safe_revision: ed8ff421cc9353456af13a37049a07ce2545aac1
+    reviewed_by: brianshand
+    safe_revision: befa1d4f27448d5be4e133f442c2b5fbac7d8f25
   lib/ndr_support/utf8_encoding.rb:
     comments: 
     reviewed_by: josh.pencheon
@@ -163,29 +159,33 @@ file safety:
     reviewed_by: timgentry
     safe_revision: f7adf44fc2772e1926df37abfd9041d41c303328
   lib/ndr_support/version.rb:
+    comments: 
+    reviewed_by: brian.shand
+    safe_revision: f7cfb534917c991a6e1811f1eb4cff2083c141d2
+  lib/ndr_support/working_days.rb:
     comments: 
     reviewed_by: josh.pencheon
-    safe_revision: ea1f7dc9a164981570ee2ad7c38197fdb17a6880
+    safe_revision: c1158eccb843b637b4dd82815dc7c081f12b93e4
   lib/ndr_support/yaml/serialization_migration.rb:
     comments: 
     reviewed_by: timgentry
     safe_revision: 29595e6431587ff9b7db6e3ad3abbb3577bff99c
   ndr_support.gemspec:
     comments: 
-    reviewed_by: josh.pencheon
-    safe_revision: c197b91c07807345f2caf07ec4c14d8b9cbb4e53
+    reviewed_by: brianshand
+    safe_revision: befa1d4f27448d5be4e133f442c2b5fbac7d8f25
   test/array_test.rb:
     comments: 
     reviewed_by: timgentry
     safe_revision: 2a5d30674dc9dde336e1dbbbf3c8a98905647432
   test/concerns/working_days_test.rb:
     comments: 
-    reviewed_by: timgentry
-    safe_revision: 506a317e59d0ccb5b32d813b74d822f35a55cea9
+    reviewed_by: josh.pencheon
+    safe_revision: fe6c3beff445e3c84ed0c89f08e1ab10bfb00587
   test/daterange_test.rb:
     comments: 
-    reviewed_by: brian.shand
-    safe_revision: c7ed8bc16be8ec803dfaeb3473fbc538b54587ec
+    reviewed_by: ollietulloch
+    safe_revision: 9a4b8e53f477725c2c2be5000b3c9e66f07d7389
   test/hash_test.rb:
     comments: 
     reviewed_by: timgentry
@@ -198,6 +198,10 @@ file safety:
     comments: 
     reviewed_by: josh.pencheon
     safe_revision: 2685f35c907af6968a69eabb5ab9424b490d0f40
+  test/integer/working_days_test.rb:
+    comments: 
+    reviewed_by: josh.pencheon
+    safe_revision: c1158eccb843b637b4dd82815dc7c081f12b93e4
   test/nil_test.rb:
     comments: 
     reviewed_by: timgentry
@@ -236,12 +240,12 @@ file safety:
     safe_revision: b562d0c15ff1b1d565522a47e6bae47ea09706f0
   test/string/cleaning_test.rb:
     comments: 
-    reviewed_by: brian.shand
-    safe_revision: 60cc69774d5aff92252558feae9604544def7583
+    reviewed_by: brianshand
+    safe_revision: b7b033ad9773cc9037c408a7763b113d31cbf191
   test/string/conversions_test.rb:
     comments: 
-    reviewed_by: brian.shand
-    safe_revision: 1955bf30ffe581610981f0148569e252cba02926
+    reviewed_by: ollietulloch
+    safe_revision: 9a4b8e53f477725c2c2be5000b3c9e66f07d7389
   test/test_helper.rb:
     comments: 
     reviewed_by: josh.pencheon

data/gemfiles/Gemfile.rails60

@@ -0,0 +1,6 @@
+source 'https://rubygems.org'
+
+gemspec path: '..'
+
+gem 'activerecord',  '~> 6.0.0rc1'
+gem 'activesupport', '~> 6.0.0rc1'

data/lib/ndr_support.rb

@@ -21,3 +21,5 @@ require 'ndr_support/yaml/serialization_migration'
 module NdrSupport
   # Your code goes here...
 end
+
+WorkingDays.check_lookup

data/lib/ndr_support/concerns/working_days.rb

@@ -3,6 +3,8 @@ require 'active_support/time'
 # This module contains logic for #working_days_until, #weekday?, and #public_holiday?.
 module WorkingDays
   WEEK_DAYS = 1..5
+  
+  # TODO: could we use https://github.com/alphagov/gds-api-adapters ?
   HOLIDAYS  = [ # Sourced from https://www.gov.uk/bank-holidays
     # 2012
     '2012-01-02', # Monday    - New Year's Day (substitute day)
@@ -77,14 +79,49 @@ module WorkingDays
     '2019-08-26', # Monday    - Summer bank holiday
     '2019-12-25', # Wednesday - Christmas Day
     '2019-12-26', # Thursday  - Boxing Day
+    # 2020
+    '2020-01-01', # Wednesday - New Year's Day
+    '2020-04-10', # Friday    - Good Friday
+    '2020-04-13', # Monday    - Easter Monday
+    '2020-05-08', # Friday    - Early May bank holiday (moved from Monday)
+    '2020-05-25', # Monday    - Spring bank holiday
+    '2020-08-31', # Monday    - Summer bank holiday
+    '2020-12-25', # Friday    - Christmas Day
+    '2020-12-28', # Monday    - Boxing Day (substitute day)
+    # 2021
+    '2021-01-01', # Friday - New Year’s Day
+    '2021-04-02', # Friday - Good Friday
+    '2021-04-05', # Monday - Easter Monday
+    '2021-05-03', # Monday - Early May bank holiday
+    '2021-05-31', # Monday - Spring bank holiday
+    '2021-08-30', # Monday - Summer bank holiday
+    '2021-12-27', # Monday - Christmas Day
+    '2021-12-28', # Tuesday - Boxing Day
+    # 2022
+    '2022-01-03', # Monday   - New Year’s Day (substitute day)
+    '2022-04-15', # Friday   - Good Friday
+    '2022-04-18', # Monday   - Easter Monday
+    '2022-05-02', # Monday   - Early May bank holiday
+    '2022-06-02', # Thursday - Spring bank holiday
+    '2022-06-03', # Friday   - Platinum Jubilee bank holiday
+    '2022-08-29', # Monday   - Summer bank holiday
+    '2022-12-26', # Monday   - Boxing Day
+    '2022-12-27', # Tuesday  - Christmas Day (substitute day)
   ].map { |str| Date.parse(str) }
 
+  def self.check_lookup
+    return true if HOLIDAYS.max >= 1.year.from_now
+
+    warn "NdrSupport's WorkingDays extension has under a year of future data. Check for updates?"
+    false
+  end
+
   # How many complete working days there are until the given
   # `other`. Returns negative number if `other` is earlier.
   def working_days_until(other)
     return -other.working_days_until(self) if other < self
 
-    whole_days_to(other).count do |day|
+    count_whole_days_to(other) do |day|
       day.weekday? && !day.public_holiday?
     end
   end
@@ -93,7 +130,7 @@ module WorkingDays
   # `other`. Returns negative number if `other` is earlier.
   def weekdays_until(other)
     return -other.weekdays_until(self) if other < self
-    whole_days_to(other).count(&:weekday?)
+    count_whole_days_to(other, &:weekday?)
   end
 
   # Is this a weekday?
@@ -108,14 +145,15 @@ module WorkingDays
 
   private
 
-  def whole_days_to(other)
-    [self].tap do |days|
-      loop do
-        next_day  = days.last + 1.day
-        next_day <= other ? days.push(next_day) : break
-      end
+  def count_whole_days_to(other, &block)
+    day = self + 1.day
+    count = 0
 
-      days.shift # Drop `self` off the front
+    while day <= other
+      count += 1 if block.call(day)
+      day += 1.day
     end
+
+    count
   end
 end

data/lib/ndr_support/date_and_time_extensions.rb

@@ -1,8 +1,6 @@
 require 'yaml'
 require 'date'
-
-require 'ndr_support/concerns/working_days'
-[Time, Date, DateTime].each { |klass| klass.send(:include, WorkingDays) }
+require 'ndr_support/working_days'
 
 class Date
   # to_iso output must be SQL safe for security reasons

data/lib/ndr_support/daterange.rb

@@ -6,7 +6,7 @@ require 'ndr_support/integer/julian_date_conversions'
 class Daterange
   attr_reader :date1, :date2, :source
 
-  OKYEARS = 1880..2020
+  OKYEARS = 1880..2030
 
   def self.extract(dates_string)
     dates_string.to_s.split(',').map { |str| new(str) }
@@ -135,12 +135,12 @@ class Daterange
 
   # Update our attribute values using a string representation of the date(s).
   # +s+ consists of one or more dates separated with spaces.
-  # Each date can be in various formats, e.g. d/m/yyyy, ddmmyyyy, yyyy-mm-dd.
-  # Each date can omit days or months, e.g. yyyy, dd/yyyy, yyyy-mm
+  # Each date can be in various formats, e.g. d/m/yyyy, ddmmyyyy, yyyy-mm-dd, dd-mon-yyyy
+  # Each date can omit days or months, e.g. yyyy, dd/yyyy, yyyy-mm, mon-yyyy
   def source=(s)
     @source = s
     ss = s.upcase.sub(/TO/, ' ') # accept default _to_s format
-    if ss =~ /[^0-9\-\/\. ]/ # only allow digits, hyphen, slash, dot, space
+    if ss =~ /[^\w0-9\-\/\. ]/i # only allow letters, digits, hyphen, slash, dot, space
       @date1 = @date2 = nil
     else
       da = [] # temporary array of arrays of dates
@@ -184,7 +184,9 @@ class Daterange
   # e.g year only or year/month only) and return an array of 1..3 integers
   # representing the year, month and day
   def date_string_parts(ds)
-    if ds =~ /([\/\.\-])/ # find a slash or dot or hyphen
+    if ds =~ /\A(\d{1,2}[\/\.\-])?\w{3}[\/\.\-]\d{4}\z/i # dd[-/.]mon[-/.]yyyy or mon[-/.]yyyy
+      result = handle_three_char_months(ds)
+    elsif ds =~ /([\/\.\-])/ # find a slash or dot or hyphen
       delimiter = $1
       result = ds.split(delimiter)
     elsif ds.length == 8 # ddmmyyyy
@@ -200,4 +202,21 @@ class Daterange
     result.reverse! unless delimiter == '-' # change to YMD if not ISO format
     result.collect(&:to_i)
   end
+
+  def handle_three_char_months(datestring)
+    delimiter  = datestring.match(%r{[\/\.\-]})[0]
+    components = datestring.split(delimiter)
+
+    if datestring =~ /\A\d{1,2}#{delimiter}\w{3}#{delimiter}\d{4}\z/i
+      month = abbreviated_month_index_for(components[1])
+      month.nil? ? [] : [components.first, month, components.last]
+    elsif datestring =~ /\A\w{3}#{delimiter}\d{4}\z/i
+      month = abbreviated_month_index_for(components.first)
+      month.nil? ? [] : [month, components.last]
+    end
+  end
+
+  def abbreviated_month_index_for(string)
+    Date::ABBR_MONTHNAMES.index(string.capitalize)
+  end
 end

data/lib/ndr_support/integer/working_days.rb

@@ -0,0 +1,11 @@
+# Mixin for working_days
+class Integer
+  # Returns a date of the number of working days since a given date
+  def working_days_since(date)
+    times do
+      date = date.next
+      date = date.next while date.public_holiday? || !date.weekday?
+    end
+    date
+  end
+end

data/lib/ndr_support/string/cleaning.rb

@@ -10,6 +10,7 @@ class String
       [A-Z][0-9][0-9]      |
       [A-Z][0-9][A-Z]      |
       [A-Z][A-Z][0-9]      |
+      NPT                  |
       [A-Z][A-Z][0-9][0-9] |
       [A-Z][A-Z][0-9][A-Z]
     )

data/lib/ndr_support/string/conversions.rb

@@ -85,7 +85,6 @@ class String
   # Try to convert the string value into a date.
   # If given a pattern, use it to parse date, otherwise use default setting to parse it
   def to_date(pattern = nil)
-    return ''  if empty? # TODO: check if this is used... :/
     return nil if blank?
 
     pattern = '%d%m%Y' if 'ddmmyyyy' == pattern
@@ -112,13 +111,13 @@ class String
 
       if ['yyyy/dd/mm', 'mm/dd/yyyy'].include?(pattern)
         month, day = day, month
-      elsif 8 == length && self !~ /\d{8}/
+      elsif 8 == length && self =~ /\A\d{2}[^A-Z0-9]\d{2}[^A-Z0-9]\d{2}\z/i
         # dd/mm/yy, rather than yyyymmdd
         year, day = day, year
         year += 100 if year <= Ourdate.today.year % 100
         year += 1900
-      elsif 9 == length
-        # dd/mmm/yy, rare case.
+      elsif 9 == length && self =~ /\A\d{2}[^A-Z0-9][A-Z]{3}[^A-Z0-9]\d{2}\z/i
+        # dd/mon/yy, rare case.
         year += 100 if year <= Ourdate.today.year % 100
         year += 1900
       end

data/lib/ndr_support/threat_scanner.rb

@@ -1,4 +1,5 @@
 require 'English'
+require 'shellwords'
 
 # Runs a virus/malware check against the given path, using ClamAV.
 #

data/lib/ndr_support/version.rb

@@ -3,5 +3,5 @@
 # This defines the NdrSupport version. If you change it, rebuild and commit the gem.
 # Use "rake build" to build the gem, see rake -T for all bundler rake tasks.
 module NdrSupport
-  VERSION = '5.5.0'
+  VERSION = '5.7.1'
 end

data/lib/ndr_support/working_days.rb

@@ -0,0 +1,5 @@
+require 'date'
+require 'ndr_support/concerns/working_days'
+require 'ndr_support/integer/working_days'
+
+[Time, Date, DateTime].each { |klass| klass.send(:include, WorkingDays) }

data/ndr_support.gemspec

@@ -20,19 +20,19 @@ Gem::Specification.new do |spec|
   spec.test_files    = spec.files.grep(%r{^(test|spec|features)/})
   spec.require_paths = ['lib']
 
-  spec.add_dependency 'activerecord',  '>= 4.0.13', '< 5.3'
-  spec.add_dependency 'activesupport', '>= 4.0.13', '< 5.3'
+  spec.add_dependency 'activerecord',  '>= 5.2.0', '< 7'
+  spec.add_dependency 'activesupport', '>= 5.2.0', '< 7'
 
-  spec.add_development_dependency 'bundler', '~> 1.7'
-  spec.add_development_dependency 'rake', '~> 10.0'
+  spec.add_development_dependency 'bundler'
+  spec.add_development_dependency 'rake', '>= 12.3.3'
 
-  spec.required_ruby_version = '>= 2.1.0'
+  spec.required_ruby_version = '>= 2.5.0'
 
   # Avoid std-lib minitest (which has different namespace)
   spec.add_development_dependency 'minitest', '>= 5.0.0'
   spec.add_development_dependency 'mocha', '~> 1.1'
 
-  spec.add_development_dependency 'ndr_dev_support', '~> 3.1', '>= 3.1.3'
+  spec.add_development_dependency 'ndr_dev_support', '~> 5.4', '>= 5.4.5'
   spec.add_development_dependency 'guard'
   spec.add_development_dependency 'listen', '< 3.1' # Bundle 1.12 should be (but isn't) resolving Ruby 2.1 issue
   spec.add_development_dependency 'guard-rubocop'

data/test/concerns/working_days_test.rb

@@ -119,4 +119,22 @@ class WorkingDaysTest < Minitest::Test
     assert_equal 253, @normal_time.working_days_until(@normal_time + 1.year)
     assert_equal 253, @normal_date_time.working_days_until(@normal_date_time + 1.year)
   end
+
+  test 'against GOV.UK holidays' do
+    require 'net/http'
+    require 'json'
+
+    url = 'https://www.gov.uk/bank-holidays/england-and-wales.json'
+    response = Net::HTTP.get(URI(url))
+
+    events = JSON.parse(response)['events']
+    events.each do |event|
+      event_date = event['date']
+      parsed_date = Date.parse(event_date)
+
+      assert parsed_date.public_holiday?, "#{event_date} should be a public holiday"
+      # next if parsed_date.public_holiday?
+      # puts "'#{event_date}', # #{parsed_date.strftime('%A')} - #{event['title']}"
+    end
+  end
 end

data/test/daterange_test.rb

@@ -63,6 +63,12 @@ class DaterangeTest < Minitest::Test
     assert_equal '1880 2020', dr.source
   end
 
+  def test_year_range_future
+    s = 2.years.from_now.strftime('%Y')
+    dr = Daterange.new(s)
+    assert_equal s, dr.to_s, "Daterange should support future years up to #{s}"
+  end
+
   def test_hyphen_month_input_style
     dr = Daterange.new('2000-05')
     assert_equal '05.2000', dr.to_s
@@ -220,4 +226,42 @@ class DaterangeTest < Minitest::Test
     refute_equal dr1, nil
     refute_equal dr1, 0
   end
+
+  def test_three_char_months
+    dr1 = Daterange.new('01-APR-2020')
+    assert_equal '01.04.2020', dr1.date1.to_s
+    assert_equal '01.04.2020', dr1.date2.to_s
+
+    dr2 = Daterange.new('APR-2020')
+    assert_equal '01.04.2020', dr2.date1.to_s
+    assert_equal '30.04.2020', dr2.date2.to_s
+
+    dr3 = Daterange.new('JAN-2020 TO apr-2020')
+    assert_equal '01.01.2020', dr3.date1.to_s
+    assert_equal '30.04.2020', dr3.date2.to_s
+
+    dr4 = Daterange.new('20-JAN-2020 TO 12-Apr-2020')
+    assert_equal '20.01.2020', dr4.date1.to_s
+    assert_equal '12.04.2020', dr4.date2.to_s
+
+    dr5 = Daterange.new('01-BOB-2020')
+    assert_nil dr5.date1
+    assert_nil dr5.date2
+
+    dr6 = Daterange.new('01/APR/2020')
+    assert_equal '01.04.2020', dr6.date1.to_s
+    assert_equal '01.04.2020', dr6.date2.to_s
+
+    dr7 = Daterange.new('APR/2020')
+    assert_equal '01.04.2020', dr7.date1.to_s
+    assert_equal '30.04.2020', dr7.date2.to_s
+
+    dr8 = Daterange.new('JAN/2020 TO apr.2020')
+    assert_equal '01.01.2020', dr8.date1.to_s
+    assert_equal '30.04.2020', dr8.date2.to_s
+
+    dr9 = Daterange.new('20.JAN.2020 TO 12/Apr/2020')
+    assert_equal '20.01.2020', dr9.date1.to_s
+    assert_equal '12.04.2020', dr9.date2.to_s
+  end
 end

data/test/integer/working_days_test.rb

@@ -0,0 +1,14 @@
+require 'test_helper'
+
+# This tests our Integer working days extension
+class Integer::WorkingDaysTest < Minitest::Test
+  test 'Integer should be extended with #working_days_since' do
+    assert 1.respond_to?(:working_days_since)
+  end
+
+  test 'Integer#working_days_since should behave correctly' do
+    assert_equal Date.new(2019, 12, 23), 1.working_days_since(Date.new(2019, 12, 20))
+    assert_equal Date.new(2019, 12, 27), 3.working_days_since(Date.new(2019, 12, 20))
+    assert_equal Date.new(2019, 12, 30), 4.working_days_since(Date.new(2019, 12, 20))
+  end
+end

data/test/string/cleaning_test.rb

@@ -23,6 +23,9 @@ class String
       assert_equal 'AA9 9AA', 'AA9 9AA'.postcodeize(:db)
       assert_equal 'AA999AA', 'AA99 9AA'.postcodeize(:db)
       assert_equal 'AA9A9AA', 'AA9A 9AA'.postcodeize(:db)
+      # Old Newport postcodes until end 1984
+      assert_equal 'NPT 1AA' , 'NPT  1AA'.postcodeize(:db)
+      assert_equal 'NPT 1AA' , 'NPT 1AA'.postcodeize(:db)
       # Examples of legacy postcodes, that should be unchanged
       assert_equal 'IP222', 'IP222'.postcodeize(:db)
       assert_equal 'IP222E', 'IP222E'.postcodeize(:db)

data/test/string/conversions_test.rb

@@ -58,6 +58,10 @@ class String::ConversionsTest < Minitest::Test
     assert_ymd [2001, 3, 2],  '02/03/2001'.to_date
     assert_ymd [2010, 7, 11], '2010-07-11'.to_date
 
+    assert_ymd [2001, 3, 2],  '2.3.2001'.to_date
+    assert_ymd [2001, 3, 2],  '2/3/2001'.to_date
+    assert_ymd [2010, 7, 11], '2010-7-11'.to_date
+
     assert_ymd [2001, 2, 3], '2001/02/03'.to_date('yyyy/mm/dd')
     assert_ymd [2001, 2, 3], '2001/03/02'.to_date('yyyy/dd/mm')
     assert_ymd [2001, 2, 3], '2001-02-03'.to_date('yyyy-mm-dd')
@@ -240,8 +244,8 @@ class String::ConversionsTest < Minitest::Test
     assert_equal Ourdate.build_datetime(1998, 02, 13), '1998-02-13'.to_date('%Y-%m-%d')
     assert_equal Ourdate.build_datetime(1998, 05, 03), '1998-05-03'.to_date('%Y-%m-%d')
 
-    assert ''.to_date('%Y-%m-%d').blank?
-    assert '  '.to_date('%Y-%m-%d').blank?
+    assert_nil ''.to_date('%Y-%m-%d') # Should behave like Rails-defined to_date
+    assert_nil '  '.to_date('%Y-%m-%d')
   end
 
   test '%d-%m-%Y string to_date' do
@@ -307,7 +311,7 @@ class String::ConversionsTest < Minitest::Test
     assert_equal Ourdate.build_datetime(2008, 05, 03), '03/05/08'.to_date
   end
 
-  test 'inferred dd/mmm/yy string to_date' do
+  test 'inferred dd/mon/yy string to_date' do
     # pre_epoch
     assert_equal Ourdate.build_datetime(1945, 02, 13), '13/FEB/45'.to_date
     assert_equal Ourdate.build_datetime(1945, 06, 03), '03/JUN/45'.to_date
@@ -334,6 +338,12 @@ class String::ConversionsTest < Minitest::Test
     assert_equal Ourdate.build_datetime(2008, 05, 03), '03/05/2008 13:38'.to_date
   end
 
+  test 'incorrectly formatted string to_date' do
+    assert_nil '10-1975'.to_date
+    assert_nil '10.1975A'.to_date
+    assert_nil '10.1975AA'.to_date
+  end
+
   test 'to_boolean' do
     assert_equal true, 'true'.to_boolean
     assert_equal true, 'yes'.to_boolean

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: ndr_support
 version: !ruby/object:Gem::Version
-  version: 5.5.0
+  version: 5.7.1
 platform: ruby
 authors:
 - NCRS Development Team
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-11-16 00:00:00.000000000 Z
+date: 2021-01-03 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord
@@ -16,68 +16,68 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 4.0.13
+        version: 5.2.0
     - - "<"
       - !ruby/object:Gem::Version
-        version: '5.3'
+        version: '7'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 4.0.13
+        version: 5.2.0
     - - "<"
       - !ruby/object:Gem::Version
-        version: '5.3'
+        version: '7'
 - !ruby/object:Gem::Dependency
   name: activesupport
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 4.0.13
+        version: 5.2.0
     - - "<"
       - !ruby/object:Gem::Version
-        version: '5.3'
+        version: '7'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 4.0.13
+        version: 5.2.0
     - - "<"
       - !ruby/object:Gem::Version
-        version: '5.3'
+        version: '7'
 - !ruby/object:Gem::Dependency
   name: bundler
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '1.7'
+        version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '1.7'
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '10.0'
+        version: 12.3.3
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '10.0'
+        version: 12.3.3
 - !ruby/object:Gem::Dependency
   name: minitest
   requirement: !ruby/object:Gem::Requirement
@@ -112,20 +112,20 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '3.1'
+        version: '5.4'
     - - ">="
       - !ruby/object:Gem::Version
-        version: 3.1.3
+        version: 5.4.5
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '3.1'
+        version: '5.4'
     - - ">="
       - !ruby/object:Gem::Version
-        version: 3.1.3
+        version: 5.4.5
 - !ruby/object:Gem::Dependency
   name: guard
   requirement: !ruby/object:Gem::Requirement
@@ -240,10 +240,8 @@ files:
 - README.md
 - Rakefile
 - code_safety.yml
-- gemfiles/Gemfile.rails42
-- gemfiles/Gemfile.rails50
-- gemfiles/Gemfile.rails51
 - gemfiles/Gemfile.rails52
+- gemfiles/Gemfile.rails60
 - lib/ndr_support.rb
 - lib/ndr_support/array.rb
 - lib/ndr_support/concerns/working_days.rb
@@ -253,6 +251,7 @@ files:
 - lib/ndr_support/integer/calculations.rb
 - lib/ndr_support/integer/julian_date_conversions.rb
 - lib/ndr_support/integer/rounding.rb
+- lib/ndr_support/integer/working_days.rb
 - lib/ndr_support/nil.rb
 - lib/ndr_support/obfuscator.rb
 - lib/ndr_support/ourdate.rb
@@ -271,6 +270,7 @@ files:
 - lib/ndr_support/utf8_encoding/force_binary.rb
 - lib/ndr_support/utf8_encoding/object_support.rb
 - lib/ndr_support/version.rb
+- lib/ndr_support/working_days.rb
 - lib/ndr_support/yaml/serialization_migration.rb
 - ndr_support.gemspec
 - test/array_test.rb
@@ -279,6 +279,7 @@ files:
 - test/hash_test.rb
 - test/integer/calculations_test.rb
 - test/integer/rounding_test.rb
+- test/integer/working_days_test.rb
 - test/nil_test.rb
 - test/obfuscator_test.rb
 - test/ourdate_test.rb
@@ -308,15 +309,14 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: 2.1.0
+      version: 2.5.0
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubyforge_project: 
-rubygems_version: 2.7.6
+rubygems_version: 3.0.3
 signing_key: 
 specification_version: 4
 summary: NDR Support library
@@ -327,6 +327,7 @@ test_files:
 - test/hash_test.rb
 - test/integer/calculations_test.rb
 - test/integer/rounding_test.rb
+- test/integer/working_days_test.rb
 - test/nil_test.rb
 - test/obfuscator_test.rb
 - test/ourdate_test.rb

data/gemfiles/Gemfile.rails42

@@ -1,6 +0,0 @@
-source 'https://rubygems.org'
-
-gemspec path: '..'
-
-gem 'activerecord',  '~> 4.2.0'
-gem 'activesupport', '~> 4.2.0'

data/gemfiles/Gemfile.rails50

@@ -1,6 +0,0 @@
-source 'https://rubygems.org'
-
-gemspec path: '..'
-
-gem 'activerecord',  '~> 5.0.0'
-gem 'activesupport', '~> 5.0.0'

data/gemfiles/Gemfile.rails51

@@ -1,9 +0,0 @@
-source 'https://rubygems.org'
-
-gemspec path: '..'
-
-# Minitest 5.10.2 doesn't work with Rails version
-gem 'minitest',      '< 5.10.2'
-
-gem 'activerecord',  '~> 5.1.0'
-gem 'activesupport', '~> 5.1.0'