ndr_support 5.4.1 → 5.4.2

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
checksums.yaml CHANGED
@@ -1,7 +1,7 @@
1
1
  ---
2
2
  SHA1:
3
- metadata.gz: 77ad0f720a4aab0df38d540c85a3049c5713c61f
4
- data.tar.gz: 61501939a91bc87d0f8d8620bd29d35f8cf7f51a
3
+ metadata.gz: 07ba3c21f982adf4857b352bf87e1046dd393090
4
+ data.tar.gz: 5dd49f19587d0071d82565e1912a775ec065d986
5
5
  SHA512:
6
- metadata.gz: 2169e7247a0d6ae3c2489571dc092bad511740ddf38c8f79b948bb5d946945ced8da3dba2e212ebeece92f67a78fefb884b47af71e68bef7bfe37a39f51999b2
7
- data.tar.gz: 2b2e58b3fd266661f94539f9dcf5a715237438f4f1f3dcdd7e999c8f551b8bc67553f0986ddd3c9f17a43ad943245f2e5a7095b09c2ce6b24501b4b900bd5897
6
+ metadata.gz: 58504a8eabba9ab32fb4ab2a0e6f935101614f92c7bcd7eb6db606d3404394290cd8f6f8d7921d7606ca42c1924e1183a7301882558a912c15c39c5644484088
7
+ data.tar.gz: cdcbd43264a63a9427bfdca4c5e0f57e51a8d29fb3273e247d7c06004dba86d98b788effc60823b33e8ba1950ef60ab78217cb4cdba6b67ff2b6d5174c99ce67
@@ -9,8 +9,10 @@ file safety:
9
9
  reviewed_by: josh.pencheon
10
10
  safe_revision: a02f14cbf1fc36fbaf820365fdedfdc9af326db1
11
11
  ".travis.yml":
12
- comments: diff failed; reviewed whole file
13
- reviewed_by: josh.pencheon
12
+ comments: 'diff failed; reviewed whole file. Revision c88f5ac8c12fd657bb142144e0d3afaa7f9bc361:
13
+ Slack notification secret is public/private key encrypted, so not a disclosure
14
+ risk. As a secondary protection, it''s excluded from the .gem file by ndr_support.gemspec'
15
+ reviewed_by: brian.shand
14
16
  safe_revision: c88f5ac8c12fd657bb142144e0d3afaa7f9bc361
15
17
  CODE_OF_CONDUCT.md:
16
18
  comments:
@@ -70,8 +72,8 @@ file safety:
70
72
  safe_revision: 3553509e52b3697d361cfa4c6f8a67754ed942d3
71
73
  lib/ndr_support/daterange.rb:
72
74
  comments:
73
- reviewed_by: josh.pencheon
74
- safe_revision: e43b6e6fa52c267abf51a9f119b24ca7645d4077
75
+ reviewed_by: brian.shand
76
+ safe_revision: c7ed8bc16be8ec803dfaeb3473fbc538b54587ec
75
77
  lib/ndr_support/hash.rb:
76
78
  comments:
77
79
  reviewed_by: pauleves
@@ -154,16 +156,16 @@ file safety:
154
156
  safe_revision: f7adf44fc2772e1926df37abfd9041d41c303328
155
157
  lib/ndr_support/version.rb:
156
158
  comments:
157
- reviewed_by: josh.pencheon
158
- safe_revision: f7e1eb75323e5675b532cdef04516cc877d15e9f
159
+ reviewed_by: brian.shand
160
+ safe_revision: a4ba32dcdab4a08db5851767282008ca3e7d8672
159
161
  lib/ndr_support/yaml/serialization_migration.rb:
160
162
  comments:
161
163
  reviewed_by: timgentry
162
164
  safe_revision: 29595e6431587ff9b7db6e3ad3abbb3577bff99c
163
165
  ndr_support.gemspec:
164
166
  comments:
165
- reviewed_by: josh.pencheon
166
- safe_revision: 4cad594a94f334c7928457eb21a53096cdb63d0d
167
+ reviewed_by: brian.shand
168
+ safe_revision: e8d08f6466acbdd4cbd6cbf90f1cfa45ffd656ec
167
169
  test/array_test.rb:
168
170
  comments:
169
171
  reviewed_by: timgentry
@@ -175,7 +177,7 @@ file safety:
175
177
  test/daterange_test.rb:
176
178
  comments:
177
179
  reviewed_by: brian.shand
178
- safe_revision: 9a61389244a4e8e271515ab792aa5a9f8674eb1f
180
+ safe_revision: c7ed8bc16be8ec803dfaeb3473fbc538b54587ec
179
181
  test/hash_test.rb:
180
182
  comments:
181
183
  reviewed_by: timgentry
@@ -100,7 +100,9 @@ class Daterange
100
100
  end
101
101
 
102
102
  def ==(other)
103
- self.date1 == other.date1 && self.date2 == other.date2
103
+ date1 == other.date1 && date2 == other.date2
104
+ rescue NoMethodError # Comparing to things that don't work like Dateranges, e.g. nil, integer
105
+ false
104
106
  end
105
107
 
106
108
  def intersects?(other)
@@ -3,5 +3,5 @@
3
3
  # This defines the NdrSupport version. If you change it, rebuild and commit the gem.
4
4
  # Use "rake build" to build the gem, see rake -T for all bundler rake tasks.
5
5
  module NdrSupport
6
- VERSION = '5.4.1'
6
+ VERSION = '5.4.2'
7
7
  end
@@ -1,4 +1,3 @@
1
- # coding: utf-8
2
1
  lib = File.expand_path('../lib', __FILE__)
3
2
  $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
4
3
  require 'ndr_support/version'
@@ -15,6 +14,8 @@ Gem::Specification.new do |spec|
15
14
 
16
15
  # Exclude older versions of this gem from the package.
17
16
  spec.files = `git ls-files -z`.split("\x0").reject { |s| s =~ /^pkg\// }
17
+ # SECURE BNS 2018-08-06: Minimise sharing of (public-key encrypted) slack secrets in .travis.yml
18
+ spec.files -= %w[.travis.yml] # Not needed in the gem
18
19
  spec.executables = spec.files.grep(%r{^bin/}) { |f| File.basename(f) }
19
20
  spec.test_files = spec.files.grep(%r{^(test|spec|features)/})
20
21
  spec.require_paths = ['lib']
@@ -209,4 +209,15 @@ class DaterangeTest < Minitest::Test
209
209
  dr = Daterange.merge('2001, 30.04.2005, 2003,,')
210
210
  assert_equal '01.01.2001 to 30.04.2005', dr.to_s
211
211
  end
212
+
213
+ def test_comparison
214
+ dr1 = Daterange.new('01.04.2000')
215
+ dr2 = Daterange.new('01.04.2000 to 01.04.2000')
216
+ assert_equal dr1, dr2
217
+ assert_equal dr1, dr1.to_s
218
+ refute_equal nil, dr1
219
+ refute_equal 0, dr1
220
+ refute_equal dr1, nil
221
+ refute_equal dr1, 0
222
+ end
212
223
  end
metadata CHANGED
@@ -1,14 +1,14 @@
1
1
  --- !ruby/object:Gem::Specification
2
2
  name: ndr_support
3
3
  version: !ruby/object:Gem::Version
4
- version: 5.4.1
4
+ version: 5.4.2
5
5
  platform: ruby
6
6
  authors:
7
7
  - NCRS Development Team
8
8
  autorequire:
9
9
  bindir: bin
10
10
  cert_chain: []
11
- date: 2018-07-09 00:00:00.000000000 Z
11
+ date: 2018-08-07 00:00:00.000000000 Z
12
12
  dependencies:
13
13
  - !ruby/object:Gem::Dependency
14
14
  name: activerecord
@@ -226,7 +226,6 @@ extra_rdoc_files: []
226
226
  files:
227
227
  - ".gitignore"
228
228
  - ".rubocop.yml"
229
- - ".travis.yml"
230
229
  - CODE_OF_CONDUCT.md
231
230
  - Gemfile
232
231
  - Guardfile
@@ -1,19 +0,0 @@
1
- language: ruby
2
- rvm:
3
- - 2.3
4
- - 2.4
5
- - 2.5
6
- gemfile:
7
- - gemfiles/Gemfile.rails42
8
- - gemfiles/Gemfile.rails50
9
- - gemfiles/Gemfile.rails51
10
- - gemfiles/Gemfile.rails52
11
- sudo: false
12
- cache: bundler
13
- before_install: rm -f ${BUNDLE_GEMFILE}.lock
14
- before_script: bundle update
15
- script: bundle exec rake test
16
- notifications:
17
- slack:
18
- rooms:
19
- secure: q8ctt0jGlGS70M0VpxfnYO/sHLIzSr0IgBNh0sv5EjR9ZQhyY6LLd+QVoBV9CV4p1V213c+SfKEtA32VLVCW4jq3pznDrDxJgCknAoooyQlRR2a/rrCV2ihGJWc1WAE5CWqxnT4Xd3lGnw/Y0dHkt9tAZIozgJM/5g0FXgNklsJSpmFntjl0Z4353K4F+FhqZPqjiLzyKAgtn0gQxM86ywaQahNyWTqSLm8F4+9DToqp31VN0IIlUWkiVWgBml3VV15JvunkRrBWio8AqPbuMKixJXQN5tLjX3/j3ETRLouvOvzMJ0P/HcQ7VH/wDyO/HqLyaToUBST/RnlAKMa/WSNiLkfJ0YUTZXl5DDcyzMh7lkskTar9yFNHeo4vxqcE2ZoNOMMLItT4AYtuKzkbGaJyxqEJHlRqUL0CAjLf6wrAobKdeVwQxEZRRVXHcIvoZu7ahtMuwZNJsqNFxUAGySk1rKeBC4eVvPur16f6+4+dz4NKwCIQ/vU/Ge8a2vQD0AnMIhH+SGQ2nGGtNDD2Svb2TKYQumUwD8ekb6J+J361BkWnMw9LfPGki5C1dG5EChDB26PWQjtU/A99HVqt8xJiai60dvhVqfV6vJ30uKZq1bPyCfRk5SMdUBexO3SXgSoFbEv1HnPmBCfbLnzXADZfH0Mqr4mXTQExmqT871k=