ndr_support 5.2.0 → 5.3.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 609a55a5903e1a1920b0870cb6338be2d3ce9d47
-  data.tar.gz: 15adfab49032115e4693bcbaace8b8d46837911b
+  metadata.gz: 58ff59277d90358201c0b8b48028d8bb58667370
+  data.tar.gz: 591185e41c91b8793b5c732f035eeee70372a014
 SHA512:
-  metadata.gz: f2270a5b0d7a368945b7276e92a0297a0ea6dacad884a85eefee2e565bac5079fdd92d85ab68e625bb5debb6626c242c050a27613e85dd46f3770f954b95b196
-  data.tar.gz: ac102ce2887029107c2d5adad88fbdb04df9ecc7eeb6698fc206a6abe982f807edc7715e9bab620bf955d90be439d76f8b8669ebf9eab0d74db0e75f12702c34
+  metadata.gz: 654f474643d49fa3e5a09ea2aadc1b84ddd5599aa2f8f36b12df907ec678cb457382674f7578dd0d0281491297e668eadb5783e81746164b5ec45db7eefd02f9
+  data.tar.gz: aa687792d931205f369b6ab655f46ef4c24cae1f1c51c6d84d499007cbbcbd10e351788063be65836c7cc153f7e24a4ab4a5a81e761bf06e10814baa6826ee33

data/code_safety.yml

@@ -122,8 +122,8 @@ file safety:
     safe_revision: 4492da77f6a8b678c40dd571fdd46fd936052cca
   lib/ndr_support/string/cleaning.rb:
     comments: 
-    reviewed_by: josh.pencheon
-    safe_revision: d30717902e767bd63a35c0482b9a3ee52b0cdc73
+    reviewed_by: brian.shand
+    safe_revision: 947308c8e3dd8fbb53d38db27f24fff09e7ab295
   lib/ndr_support/string/conversions.rb:
     comments: 
     reviewed_by: timgentry
@@ -150,8 +150,8 @@ file safety:
     safe_revision: f7adf44fc2772e1926df37abfd9041d41c303328
   lib/ndr_support/version.rb:
     comments: 
-    reviewed_by: josh.pencheon
-    safe_revision: 802eaa1206e0f179d403aa46c7826b1d4ab7b369
+    reviewed_by: brian.shand
+    safe_revision: 2550a205795bd7931fb4f5f11cded52399c84f08
   lib/ndr_support/yaml/serialization_migration.rb:
     comments: 
     reviewed_by: timgentry
@@ -218,8 +218,8 @@ file safety:
     safe_revision: b562d0c15ff1b1d565522a47e6bae47ea09706f0
   test/string/cleaning_test.rb:
     comments: 
-    reviewed_by: josh.pencheon
-    safe_revision: d30717902e767bd63a35c0482b9a3ee52b0cdc73
+    reviewed_by: brian.shand
+    safe_revision: 947308c8e3dd8fbb53d38db27f24fff09e7ab295
   test/string/conversions_test.rb:
     comments: 
     reviewed_by: josh.pencheon

data/lib/ndr_support/string/cleaning.rb

@@ -134,8 +134,9 @@ class String
       else
         downcase
       end
-    when :upcase
-      upcase
+    when :strip, :upcase
+      # SECURE: 14-06-2017 TPG Fixed list of executable methods (whats)
+      send(what)
     else
       gsub(' ?', ' ')
     end

data/lib/ndr_support/version.rb

@@ -3,5 +3,5 @@
 # This defines the NdrSupport version. If you change it, rebuild and commit the gem.
 # Use "rake build" to build the gem, see rake -T for all bundler rake tasks.
 module NdrSupport
-  VERSION = '5.2.0'
+  VERSION = '5.3.0'
 end

data/test/string/cleaning_test.rb

@@ -200,6 +200,14 @@ class String
       assert_equal 'UPCASE', 'UPCASE'.clean(:upcase)
     end
 
+    test 'clean strip' do
+      assert_equal '', ''.clean(:strip)
+      assert_equal 'no leading or trailing spaces', 'no leading or trailing spaces'.clean(:strip)
+      assert_equal 'leading and trailing spaces', '  leading and trailing spaces  '.clean(:strip)
+      assert_equal 'leading spaces', '    leading spaces'.clean(:strip)
+      assert_equal 'trailing spaces', 'trailing spaces  '.clean(:strip)
+    end
+
     test 'clean fallback' do
       assert_equal 'UN KNOWN', 'UN ?KNOWN'.clean(:somethingorother)
       assert_equal 'UNKNOWN', 'UNKNOWN'.clean(:somethingorother)

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: ndr_support
 version: !ruby/object:Gem::Version
-  version: 5.2.0
+  version: 5.3.0
 platform: ruby
 authors:
 - NCRS Development Team
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-02-23 00:00:00.000000000 Z
+date: 2017-06-14 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activerecord