ndr_lookup 0.2.0 → 0.3.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: ef8ffa13786096c8d95f8d8454d8b1e60611d71c9d54a72f57d6d64a8c13eeda
-  data.tar.gz: 87ded454a35954c619f0b785af5a1eaf6b95070d7a628f60d56dd662f3de628f
+  metadata.gz: 4b166463e25022038550ad9bae665670beb892bb3db7571c09433697c50fcb80
+  data.tar.gz: 3aca4b0a8550ea824a8d01dd0f84c9e0abc17be5fedb19d3f85d2af925ee2c94
 SHA512:
-  metadata.gz: d70a25899667f9006538f119a430fff5984a62aa3e97390d0e0fa99b60da33f4084ae6c2f49527d36f84b49d848568738a206d176b46bed33b1baf83aa96a4e1
-  data.tar.gz: 68efe8f25d0763497b39d1e1e847b523a75e5c63123c4fcf4b618a14bad0d70a834d5c1e2155d14972e4be6ce6b79fff351f81ad3a0aaba966155855c881156d
+  metadata.gz: 4d04c47f6edff7ccb720b62bc27d6e5183658e15995e363ce47a036ec4cc175b2e0c808aca0f5546a40fadbc208e8f480e9a62fea0eeff45e29234cb9d17eb5c
+  data.tar.gz: 8b13686621258be52f9c62e6ec06f7dea39a0eea6a95932d374de1a8e81a0b99982b4b3f65d3d22f0f2873e0af225356643c3d77d909b30d15270ebd71c5ea73

data/CHANGELOG.md

@@ -1,5 +1,12 @@
 ## [Unreleased]
-* no unreleased changes
+
+## 0.3.0 / 2026-02-26
+### Added
+* Added specific error classes (InvalidURIError, UnauthorizedError) for granular error handling
+* Extracted common error handling into `with_error_handling` method
+
+### Fixed
+* Support Ruby 3.4. Drop support for Rails 7.0, Ruby 3.1
 
 ## 0.1.4 / 2025-09-19
 ### Added

data/lib/ndr_lookup/fhir/base.rb

@@ -6,9 +6,12 @@ module NdrLookup
   module Fhir
     # Client for interacting with the NHS Digital FHIR API
     class Base < ActiveResource::Base
+      # Specific error classes for different API failure modes
       class ApiError < StandardError; end
       class ResourceNotFound < ApiError; end
       class InvalidResponse < ApiError; end
+      class InvalidURIError < ApiError; end
+      class UnauthorizedError < ApiError; end
 
       class << self
         attr_writer :additional_headers
@@ -24,17 +27,10 @@ module NdrLookup
         # Finds a specific FHIR resource by type and ID
         # @return [Hash] Parsed FHIR resource
         def find(resource_type, id)
-          response = connection.get(
-            "#{endpoint}/#{resource_type}/#{id}",
-            headers
-          )
-          JSON.parse(response.body)
-        rescue ActiveResource::ResourceNotFound
-          raise ResourceNotFound, "#{resource_type} with ID '#{id}' not found"
-        rescue JSON::ParserError
-          raise InvalidResponse, 'Invalid JSON response from server'
-        rescue StandardError => e
-          raise ApiError, "Unexpected error: #{e.message}"
+          with_error_handling("#{resource_type} with ID '#{id}' not found") do
+            response = connection.get("#{endpoint}/#{resource_type}/#{id}", headers)
+            JSON.parse(response.body)
+          end
         end
 
         def endpoint
@@ -51,24 +47,33 @@ module NdrLookup
         # @example Search for relationships
         #   Client.search('OrganizationAffiliation', organization: 'RHAGX')
         def search(resource_type, params = {})
-          url = construct_url(endpoint, resource_type, params)
-
-          # Make the request
-          response = connection.get(url, headers)
+          with_error_handling do
+            url = construct_url(endpoint, resource_type, params)
+            response = connection.get(url, headers)
+            payload = JSON.parse(response.body)
+            raise_unless_response_success(response, payload)
+            payload
+          end
+        end
 
-          # Process response
-          payload = JSON.parse(response.body)
-          raise_unless_response_success(response, payload)
+        private
 
-          payload
+        # Wraps API calls with consistent error handling, converting external exceptions
+        # (ActiveResource, JSON, URI) into our own error classes.
+        def with_error_handling(not_found_message = nil)
+          yield
+        rescue ActiveResource::ResourceNotFound
+          raise ResourceNotFound, not_found_message || 'Resource not found'
+        rescue ActiveResource::UnauthorizedAccess
+          raise UnauthorizedError, 'Authentication failed'
         rescue JSON::ParserError
           raise InvalidResponse, 'Invalid JSON response from server'
+        rescue URI::InvalidURIError => e
+          raise InvalidURIError, "Invalid ID format: #{e.message}"
         rescue StandardError => e
-          raise ApiError, "Search failed: #{e.message}"
+          raise ApiError, "Unexpected error: #{e.message}"
         end
 
-        private
-
         def construct_url(endpoint, resource_type, params = {})
           url = "#{endpoint}/#{resource_type}"
 

data/lib/ndr_lookup/version.rb

@@ -1,3 +1,3 @@
 module NdrLookup
-  VERSION = '0.2.0'.freeze
+  VERSION = '0.3.0'.freeze
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: ndr_lookup
 version: !ruby/object:Gem::Version
-  version: 0.2.0
+  version: 0.3.0
 platform: ruby
 authors:
 - NCRS Development Team
 autorequire:
 bindir: exe
 cert_chain: []
-date: 2025-09-25 00:00:00.000000000 Z
+date: 2026-02-26 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activeresource
@@ -36,7 +36,7 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '7.0'
+        version: '7.1'
     - - "<"
       - !ruby/object:Gem::Version
         version: '8.1'
@@ -46,7 +46,7 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '7.0'
+        version: '7.1'
     - - "<"
       - !ruby/object:Gem::Version
         version: '8.1'
@@ -190,7 +190,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: '3.0'
+      version: '3.2'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="