ndr_error 2.0.0 → 2.0.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
-SHA1:
-  metadata.gz: ca01898083de92ab17019a9f2f312f4536bcf144
-  data.tar.gz: 8593a587b1fd43619dfebe0002205c78ea1018cf
+SHA256:
+  metadata.gz: 36773a1b7fa7f3920aa3cf37d44048d1e0c5318aaac34149bd2a7d5bf746dc2f
+  data.tar.gz: 8baf632d5a3bd99e49b67d16f4e5d777d0ea75b721e506324b5de26b782f301c
 SHA512:
-  metadata.gz: b4b6b12acc1e1472a63d0c14df1254a6789a83acf9894ea60a319d71a1a19b6c9926de3ac7db4b3cd875ac51a450729e968b11e1dedaedf689703c39b2d34400
-  data.tar.gz: 1151c024cde520d1d6ada13e679e7f12bacfebe292db259a7c4f31a45b489c4829933c922d22cefbcbc413aa8979ef16d228d0ab51aa80c6235003f36bda5704
+  metadata.gz: 67307d58e06a199e3272602e42d44367abed2743e083427c9758be47641505c07ccf70f8934aa4a41a7ac373b0c07f8c24e9797aa6c732663e79b2914849200d
+  data.tar.gz: edcaf1d99c8024e2d6556020ee5032d5309f90474da6de1bf42ba2a27f2c8664ecc2d22f86f4c0f7b145039bd095837bdeab10933da5d76d2a5decba1f91c6e2

data/app/controllers/ndr_error/application_controller.rb

@@ -1,3 +1,5 @@
+require 'ndr_ui'
+
 module NdrError
   # Global controller logic
   class ApplicationController < ActionController::Base

data/app/controllers/ndr_error/errors_controller.rb

@@ -1,8 +1,8 @@
 module NdrError
   # Controller for viewing and managing errors
   class ErrorsController < ApplicationController
-    before_action :find_fingerprint,  only: [:show, :edit, :update, :destroy]
-    before_action :check_permissions, only: [:edit, :update, :destroy]
+    before_action :find_fingerprint,  only: %i[show edit update destroy]
+    before_action :check_permissions, only: %i[edit update destroy]
 
     def index
       if NdrError::Log.perform_cleanup!
@@ -25,8 +25,7 @@ module NdrError
       end
     end
 
-    def edit
-    end
+    def edit; end
 
     def update
       @fingerprint.ticket_url = params[:error_fingerprint][:ticket_url]

data/app/models/ndr_error/log.rb

@@ -9,9 +9,7 @@ module NdrError
     include NdrError::UuidBuilder
 
     # Migrate away from host-specific column name:
-    unless :user_id == NdrError.user_column
-      alias_attribute :user_id, NdrError.user_column
-    end
+    alias_attribute :user_id, NdrError.user_column unless NdrError.user_column == :user_id
 
     self.primary_key = 'error_logid'
 
@@ -32,15 +30,15 @@ module NdrError
     before_create :set_uuid_primary_key
 
     def self.text_columns
-      user_column = NdrError.user_column.to_s
-      %w(error_class description).tap do |text_columns|
-        # Allow searching of `user_column` if it is textual:
-        if :string == columns_hash[user_column].try(:type)
-          text_columns << user_column
-        else
-          fail SecurityError, "Column '#{user_column}' not found!"
-        end
-      end
+      whitelist   = %w[error_class description]
+      column_name = NdrError.user_column.to_s
+      user_column = columns_hash[column_name]
+
+      raise SecurityError, 'User column missing!' unless user_column
+
+      # allow the user column to be searched if it is textual:
+      whitelist << column_name if user_column.type == :string
+      whitelist
     end
 
     def self.filter_by_keywords(keywords)
@@ -173,7 +171,7 @@ module NdrError
       filter = ActionDispatch::Http::ParameterFilter.new(NdrError.filtered_parameters)
 
       if request
-        sources = [:parameters, :request_parameters, :query_parameters]
+        sources = %i[parameters request_parameters query_parameters]
         sources.inject(params) { |a, e| a.merge! request.send(e) }
       end
 

data/config/routes.rb

@@ -1,6 +1,6 @@
 NdrError::Engine.routes.draw do
   resources :errors,
-            only: [:index, :show, :edit, :update, :destroy],
+            only: %i[index show edit update destroy],
             controller: 'errors',
             as: 'error_fingerprints'
 end

data/lib/ndr_error.rb

@@ -41,7 +41,7 @@ module NdrError
   # NdrError::Middleware::PublicExceptions middleware is used, it is called
   # with the Rack request object.
   mattr_accessor :log_parameters
-  self.log_parameters = ->(_request) { Hash.new }
+  self.log_parameters = ->(_request) { {} }
 
   # Request parameters that we should not be capturing as part of the error context.
   mattr_accessor :filtered_parameters

data/lib/ndr_error/backtrace_compression.rb

@@ -48,7 +48,7 @@ module NdrError
         data = Base64.decode64(string)
         begin
           string = Zlib::Inflate.inflate(data)
-        rescue
+        rescue StandardError
           Rails.logger.warn('NdrError: failed to inflate backtrace!')
         end
       end

data/lib/ndr_error/engine.rb

@@ -12,11 +12,11 @@ module NdrError
 
     # Hook into host app's asset pipeline
     initializer 'ndr_error.assets.precompile' do |app|
-      app.config.assets.precompile += %w(
+      app.config.assets.precompile += %w[
         ndr_error/ndr_error.css
         ndr_error/ndr_error.js
         ndr_error/bootstrap/glyphicons-halflings-regular*
-      )
+      ]
     end
 
     # Extract context filtering from the host application

data/lib/ndr_error/logging.rb

@@ -2,7 +2,7 @@ module NdrError
   # Module to contain helpers for logging
   module Logging
     # Which attributes can be populated when manually logging an exception:
-    ANCILLARY_ATTRS_WHITELIST = [:user_id, :user_roles, :svn_revision].freeze
+    ANCILLARY_ATTRS_WHITELIST = %i[user_id user_roles svn_revision].freeze
 
     # Log the given `exception`.
     def log(exception, ancillary_data, request_object)
@@ -34,7 +34,7 @@ module NdrError
     def initialize_log(ancillary_data)
       Log.new.tap do |log|
         ancillary_data.symbolize_keys.each do |key, value|
-          fail "Mass-assigning #{key} is forbidden!" unless ANCILLARY_ATTRS_WHITELIST.include?(key)
+          raise "Mass-assigning #{key} is forbidden!" unless ANCILLARY_ATTRS_WHITELIST.include?(key)
 
           if ActiveRecord::Base.respond_to?(:protected_attributes)
             log.assign_attributes({ key => value }, without_protection: true)

data/lib/ndr_error/version.rb

@@ -1,5 +1,6 @@
 # frozen_string_literal: true
+
 # Contains the version of NdrError. Sourced by the gemspec.
 module NdrError
-  VERSION = '2.0.0'.freeze
+  VERSION = '2.0.1'.freeze
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: ndr_error
 version: !ruby/object:Gem::Version
-  version: 2.0.0
+  version: 2.0.1
 platform: ruby
 authors:
 - NCRS Development Team
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-06-05 00:00:00.000000000 Z
+date: 2018-10-11 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails
@@ -59,7 +59,7 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: sqlite3
+  name: pry
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -73,7 +73,7 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: pry
+  name: sqlite3
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -87,35 +87,35 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: test-unit
+  name: mocha
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '3.0'
+        version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '3.0'
+        version: '0'
 - !ruby/object:Gem::Dependency
-  name: mocha
+  name: test-unit
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '3.0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '3.0'
 - !ruby/object:Gem::Dependency
-  name: simplecov
+  name: database_cleaner
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -134,16 +134,22 @@ dependencies:
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '3.0'
+        version: '3.1'
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 3.1.3
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - "~>"
       - !ruby/object:Gem::Version
-        version: '3.0'
+        version: '3.1'
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: 3.1.3
 - !ruby/object:Gem::Dependency
-  name: database_cleaner
+  name: simplecov
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -211,7 +217,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.5.2.3
+rubygems_version: 2.7.6
 signing_key: 
 specification_version: 4
 summary: Rails exception logging