ndr_dev_support 5.7.0 → 5.9.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 597318cf10af72895cde73338ece46a13d00893ec14c240ee24b4063c68bfef9
-  data.tar.gz: af273055a5d011e8897bcdbd164cd9d31b99175ad48c862de84ed4765cff6644
+  metadata.gz: 4deca61439d2e531328591d3191d66a2a8645970173d00820a9daf4233f519c2
+  data.tar.gz: c65e29722b6bfc8f75b005df61c700d3d15aea1bf689513af214120f8ce73b55
 SHA512:
-  metadata.gz: 2368ad56bd91b4f48815998b8e4ccf5ed0fde7d62c337e99222ccc77c16619eaf696d5b30fe78be9048b256787da199d9b23142c2577e8ec2fd2a05021af1a8f
-  data.tar.gz: 8ef7192f3b4f8404982bdab883e2cde34c79bbaae9f58a22ef78a409a0eda1a6b492af343e72db7fe8b8096b042fba35c6d483faf5df171f064059c3af4f06b2
+  metadata.gz: bbc48e4af8beee14e7d543d1a6c30cca2af8716c25a62a7279fac879fed2f752cc3f6c20bb122c9a4186e9c65ad08baf3ed47f4eedd48d1500f81c415613c774
+  data.tar.gz: 6e9e4923d97560c6eab4f5437df85005342f2c25ca2fc79071ce18372f975a019244badf5e64bce3edf4643d7de386cba66174d120fa3049209dd7818e3cb404

data/CHANGELOG.md

@@ -1,6 +1,32 @@
 ## [Unreleased]
 *no unreleased changes*
 
+## 5.9.0 / 2021-01-12
+### Added
+* Move to keep up with Rubocop releases
+* Add `rubocop-rake`, for additional rake-specific Rubocop checks
+* Disable browser animations in the test environment by default
+
+### Fixed
+* Fix unnecessary 'parser/current' warnings when not using rubocop
+* Test against Ruby 3.0
+
+## 5.8.2 / 2020-07-22
+### Fixed
+* Tweak integration testing driver config, for capybara 3.33.0 deprecations
+
+## 5.8.1 / 2020-07-10
+### Fixed
+* Fix issue running `brakeman:fingerprint_details` task
+
+## 5.8.0 / 2020-04-07
+### Added
+* Ability to select git CI branch by exporting `RAKE_CI_BRANCH_NAME`
+
+## 5.7.1 / 2020-04-07
+### Fixed
+* Address issue updating redmine using commit message tags
+
 ## 5.7.0 / 2020-03-26
 ### Added
 * Add `ci:brakeman:strict` alternative CI task. (#77)

data/README.md

@@ -28,7 +28,7 @@ Or install it yourself as:
 To add development support tasks (see below) to your project, add this line to your application's `Rakefile`:
 
 ```ruby
-require 'ndr_dev_support/tasks'
+require 'ndr_dev_support/tasks' if Rails.env.development? || Rails.env.test?
 ```
 
 ## Usage

data/code_safety.yml

@@ -15,11 +15,11 @@ file safety:
   ".travis.yml":
     comments: 
     reviewed_by: josh.pencheon
-    safe_revision: 1f2197bd4ea2f4330dae266eec6983e86482b613
+    safe_revision: e5ac2d160975264f40bac7e871b61aa6b54f7af2
   CHANGELOG.md:
     comments: 
     reviewed_by: josh.pencheon
-    safe_revision: 1f4383e983313441ba3b118891dfb1c3ff962368
+    safe_revision: 0fa311a1f72ceb8c8d5c5a66fd0ac22eb0317781
   CODE_OF_CONDUCT.md:
     comments: 
     reviewed_by: timgentry
@@ -35,7 +35,7 @@ file safety:
   README.md:
     comments: 
     reviewed_by: josh.pencheon
-    safe_revision: b405f60e921805378ba1f3beaeb10cf1a8503182
+    safe_revision: e389930b98976f20e3fc94c771e5c456b729f8cb
   Rakefile:
     comments: 
     reviewed_by: josh.pencheon
@@ -51,7 +51,7 @@ file safety:
   config/rubocop/ndr.yml:
     comments: 
     reviewed_by: josh.pencheon
-    safe_revision: 6211cff0ce44645ed3752723b5b0ee65f24c66aa
+    safe_revision: 05476acacadfa0ad7404f3c37cf3c17c4e0ba11b
   gemfiles/Gemfile.rails52:
     comments: 
     reviewed_by: josh.pencheon
@@ -107,7 +107,7 @@ file safety:
   lib/ndr_dev_support/daemon/ci_server.rb:
     comments: 
     reviewed_by: josh.pencheon
-    safe_revision: 5075331fb3f33cd214c2ca76b199f27ddd743170
+    safe_revision: 3fdf010a91bd9927ef34e3df66b8a4bbbd20315a
   lib/ndr_dev_support/daemon/stoppable.rb:
     comments: 
     reviewed_by: josh.pencheon
@@ -115,7 +115,7 @@ file safety:
   lib/ndr_dev_support/integration_testing.rb:
     comments: 
     reviewed_by: josh.pencheon
-    safe_revision: a2f178853da640112cf3063ca1d640157c9edb9f
+    safe_revision: 5b427cb12907bc87e5e0cb754dcaa524fdbfb1b9
   lib/ndr_dev_support/integration_testing/drivers/chrome.rb:
     comments: 
     reviewed_by: josh.pencheon
@@ -135,7 +135,7 @@ file safety:
   lib/ndr_dev_support/integration_testing/drivers/switchable.rb:
     comments: 
     reviewed_by: josh.pencheon
-    safe_revision: f1a32b1f2d1851b87a883dbf8620aa0e921e436c
+    safe_revision: e9b74559d28e7520c0376d1bec4a2566aae14b05
   lib/ndr_dev_support/integration_testing/dsl.rb:
     comments: 
     reviewed_by: josh.pencheon
@@ -179,7 +179,7 @@ file safety:
   lib/ndr_dev_support/rake_ci/redmine/ticket_resolver.rb:
     comments: 
     reviewed_by: josh.pencheon
-    safe_revision: 12aad1254186ee9ce0fde263bf8dccf46cdfebe2
+    safe_revision: 788b8fc31952a6fb640101df96a370b21d269249
   lib/ndr_dev_support/rake_ci/simple_cov_helper.rb:
     comments: 
     reviewed_by: timgentry
@@ -194,8 +194,8 @@ file safety:
     safe_revision: 6211cff0ce44645ed3752723b5b0ee65f24c66aa
   lib/ndr_dev_support/rubocop/range_augmenter.rb:
     comments: 
-    reviewed_by: joshpencheon
-    safe_revision: fe5f0a693b77eeecaa39ff6fcf87ad59c4fb46e1
+    reviewed_by: josh.pencheon
+    safe_revision: 136936265a5b79f0eca1bc7e58c607a2492e57a5
   lib/ndr_dev_support/rubocop/range_finder.rb:
     comments: 
     reviewed_by: josh.pencheon
@@ -215,7 +215,7 @@ file safety:
   lib/ndr_dev_support/version.rb:
     comments: 
     reviewed_by: josh.pencheon
-    safe_revision: 1f4383e983313441ba3b118891dfb1c3ff962368
+    safe_revision: 0fa311a1f72ceb8c8d5c5a66fd0ac22eb0317781
   lib/tasks/audit_code.rake:
     comments: Identical to the version reviewed by josh.pencheon when contained within
       ndr_support
@@ -224,7 +224,7 @@ file safety:
   lib/tasks/ci/brakeman.rake:
     comments: 
     reviewed_by: josh.pencheon
-    safe_revision: 053c9834ca5d402a1f8dc8d09257dc7075a5ec06
+    safe_revision: fe7dfc7f1775e8b85ae6968e8f475b9e930addf7
   lib/tasks/ci/bundle_audit.rake:
     comments: 
     reviewed_by: josh.pencheon
@@ -288,7 +288,7 @@ file safety:
   ndr_dev_support.gemspec:
     comments: 
     reviewed_by: josh.pencheon
-    safe_revision: f4c1ea57d3eb817783fdc47a16169d215f9788a6
+    safe_revision: 5b427cb12907bc87e5e0cb754dcaa524fdbfb1b9
   test/daemon/ci_server_test.rb:
     comments: 
     reviewed_by: josh.pencheon

data/config/rubocop/ndr.yml

@@ -6,8 +6,13 @@
 
 require:
   - rubocop-rails
+  - rubocop-rake
 
 AllCops:
+  # Given we take a "follow the herd" approach, with this file
+  # containing just deviations, enable new cops by default.
+  NewCops: enable
+
   # All cops should ignore files in the following locations:
   Exclude:
   - 'bin/*'
@@ -127,6 +132,11 @@ Rails/DynamicFindBy:
   Exclude:
   - 'test/integration/**/*.rb'
 
+Rails/RakeEnvironment:
+  # Particularly without spring, this can make things that should be quick
+  # slower than desirable.
+  Enabled: false
+
 Rails/RefuteMethods:
   Enabled: false
 

data/lib/ndr_dev_support/daemon/ci_server.rb

@@ -48,7 +48,7 @@ module NdrDevSupport
 
         git_fetch
         git_discard_changes
-        git_checkout(MASTER_BRANCH_NAME)
+        git_checkout(git_branch_name)
 
         objectids_between_master_and_remote.each do |oid|
           log("testing #{oid}...")
@@ -72,6 +72,10 @@ module NdrDevSupport
         raise exception
       end
 
+      def git_branch_name
+        ENV.fetch('RAKE_CI_BRANCH_NAME', MASTER_BRANCH_NAME)
+      end
+
       def git_fetch
         system(svn_remote? ? 'git svn fetch' : 'git fetch')
       end
@@ -117,7 +121,7 @@ module NdrDevSupport
       def objectids_between_master_and_remote
         walker = Rugged::Walker.new(@repo)
         walker.push(repo.branches[remote_branch].target_id)
-        current_target_id = repo.branches[MASTER_BRANCH_NAME].target_id
+        current_target_id = repo.branches[git_branch_name].target_id
 
         revisions = []
         # walk backwards from the most recent commit, breaking at the current one

data/lib/ndr_dev_support/integration_testing.rb

@@ -35,5 +35,8 @@ require 'ndr_dev_support/integration_testing/drivers/switchable'
 Capybara.default_driver    = :switchable
 Capybara.javascript_driver = :switchable
 
+# Inject middleware to disable jQuery fx, CSS transitions/animations
+Capybara.disable_animation = true
+
 Capybara.save_path = Rails.root.join('tmp', 'screenshots')
 Capybara::Screenshot.prune_strategy = { keep: 20 }

data/lib/ndr_dev_support/integration_testing/drivers/switchable.rb

@@ -18,14 +18,23 @@ module NdrDevSupport
         CONFIGURED = ENV.fetch('INTEGRATION_DRIVER', DEFAULT).to_sym
 
         Capybara.register_driver(:switchable) do |app|
-          Capybara.drivers.fetch(CONFIGURED).call(app)
+          configured_driver = Capybara.drivers[CONFIGURED]
+          raise "Driver #{CONFIGURED} not found!" unless configured_driver
+
+          configured_driver.call(app)
         end
 
         Capybara::Screenshot.register_driver(:switchable) do |driver, path|
-          Capybara::Screenshot.registered_drivers.fetch(CONFIGURED).call(driver, path)
+          configured_screenshot_driver = Capybara::Screenshot.registered_drivers[CONFIGURED]
+          raise "Screenshot driver #{CONFIGURED} not found!" unless configured_screenshot_driver
+
+          configured_screenshot_driver.call(driver, path)
         end
 
-        ShowMeTheCookies.register_adapter(:switchable, ShowMeTheCookies.adapters.fetch(CONFIGURED))
+        cookie_driver = ShowMeTheCookies.adapters[CONFIGURED]
+        raise "Cookie driver #{CONFIGURED} not found!" unless cookie_driver
+
+        ShowMeTheCookies.register_adapter(:switchable, cookie_driver)
       end
     end
   end

data/lib/ndr_dev_support/rake_ci/redmine/ticket_resolver.rb

@@ -86,7 +86,7 @@ module NdrDevSupport
           @http
         end
 
-        def update_ticket(message, user, revision, ticket, resolved)
+        def update_ticket(message, user, revision, ticket, resolved, tests_passed)
           payload = update_payload(message, user, revision, ticket_closed?(ticket), resolved, tests_passed)
 
           http.send_request('PUT',

data/lib/ndr_dev_support/rubocop/range_augmenter.rb

@@ -4,8 +4,6 @@ module NdrDevSupport
     # all lines covered, expanding the ranges to include full method
     # defintions, and class/module headers.
     class RangeAugmenter
-      require 'parser/current'
-
       MODULE_TYPES = [:module, :class].freeze
       METHOD_TYPES = [:def, :defs].freeze
 
@@ -27,6 +25,7 @@ module NdrDevSupport
       end
 
       def augmented_lines
+        require 'parser/current'
         root  = Parser::CurrentRuby.parse IO.read(filename)
         nodes = extract_augmenting_nodes(root)
 

data/lib/ndr_dev_support/version.rb

@@ -2,5 +2,5 @@
 # This defines the NdrDevSupport version. If you change it, rebuild and commit the gem.
 # Use "rake build" to build the gem, see rake -T for all bundler rake tasks (and our own).
 module NdrDevSupport
-  VERSION = '5.7.0'.freeze
+  VERSION = '5.9.0'.freeze
 end

data/lib/tasks/ci/brakeman.rake

@@ -57,7 +57,7 @@ namespace :ci do
 
       brakeman = NdrDevSupport::RakeCI::BrakemanHelper.new
       brakeman.commit = @commit
-      brakeman.run
+      brakeman.run(strict: false)
 
       text_reporter = Brakeman::Report::Text.new(brakeman.tracker)
 

data/ndr_dev_support.gemspec

@@ -1,4 +1,4 @@
-lib = File.expand_path('../lib', __FILE__)
+lib = File.expand_path('lib', __dir__)
 $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
 require 'ndr_dev_support/version'
 
@@ -19,7 +19,7 @@ Gem::Specification.new do |spec|
   spec.executables   = spec.files.grep(%r{^exe/}) { |f| File.basename(f) }
   spec.require_paths = ['lib']
 
-  spec.required_ruby_version = '>= 2.5'
+  spec.required_ruby_version = '>= 2.6'
 
   spec.add_dependency 'pry'
 
@@ -29,12 +29,13 @@ Gem::Specification.new do |spec|
   # Rubocop dependencies:
   spec.add_dependency 'parser'
   spec.add_dependency 'rainbow'
-  spec.add_dependency 'rubocop', '0.79.0'
-  spec.add_dependency 'rubocop-rails', '2.4.1'
+  spec.add_dependency 'rubocop', '~> 1.7'
+  spec.add_dependency 'rubocop-rake', '~> 0.5'
+  spec.add_dependency 'rubocop-rails', '~> 2.9'
   spec.add_dependency 'unicode-display_width', '>= 1.3.3'
 
   # Integration test dependencies:
-  spec.add_dependency 'capybara', '>= 3.20'
+  spec.add_dependency 'capybara', '>= 3.34'
   spec.add_dependency 'capybara-screenshot'
   spec.add_dependency 'minitest', '~> 5.0'
   spec.add_dependency 'poltergeist', '>= 1.8.0'

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: ndr_dev_support
 version: !ruby/object:Gem::Version
-  version: 5.7.0
+  version: 5.9.0
 platform: ruby
 authors:
 - NCRS Development Team
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2020-03-26 00:00:00.000000000 Z
+date: 2021-01-12 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: pry
@@ -70,30 +70,44 @@ dependencies:
   name: rubocop
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '='
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.79.0
+        version: '1.7'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '='
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: 0.79.0
+        version: '1.7'
+- !ruby/object:Gem::Dependency
+  name: rubocop-rake
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '0.5'
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '0.5'
 - !ruby/object:Gem::Dependency
   name: rubocop-rails
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '='
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: 2.4.1
+        version: '2.9'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '='
+    - - "~>"
       - !ruby/object:Gem::Version
-        version: 2.4.1
+        version: '2.9'
 - !ruby/object:Gem::Dependency
   name: unicode-display_width
   requirement: !ruby/object:Gem::Requirement
@@ -114,14 +128,14 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '3.20'
+        version: '3.34'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '3.20'
+        version: '3.34'
 - !ruby/object:Gem::Dependency
   name: capybara-screenshot
   requirement: !ruby/object:Gem::Requirement
@@ -470,7 +484,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: '2.5'
+      version: '2.6'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="