ndr_dev_support 5.4.5 → 5.4.6

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 6b86e00e753960cae74adb3f670ae116cba2048b9c7cfc6eee3d5877590e65de
-  data.tar.gz: 3c285d165ecf4adb2bafd137dc665c1402ac9e14585dc351010cbeff3b2b4e6d
+  metadata.gz: d80fe79747bbea476a6fa3aeaf05091efe636aa09b2f95150d73cd45ca520927
+  data.tar.gz: 3536a4f79cadcc3f5ef4c6474c21c35c7cb5cb47070c89321b7d5472df39befe
 SHA512:
-  metadata.gz: 2db926f3fdae507fdb205e2e6eb244f71d838725470b49d33a8ac35e076c1e822da5a3b19d4f3c0ca0c580911916ddc931b0f7529cc7e8d061793928ab4ea13c
-  data.tar.gz: 1b3c7133acf9f168c4bc0b932771393d7026658f5e25e99d2f2e57d552f46069bfd856309c250999fb38aef84494d0bb2db2806aa22cad38c9c5cf59de26648d
+  metadata.gz: a45533691e54a36098b08e1a910734f3a216305df7dd3a4006a4487b2b0495239f3fd42d4561703db40287aa1d88ec8170f55161ee44c73ffc372c8b22e95af1
+  data.tar.gz: f37d83b0e37fab6a911a7c6b5698fbc32059676e2ae96e53fcb6f28026fe07d3e8eb05ddba41f20f90bffb404b23ae29414e02760e43eaa79b93c2f4c330f0d1

data/CHANGELOG.md

@@ -1,6 +1,12 @@
 ## [Unreleased]
 *no unreleased changes*
 
+## 5.4.6 / 2019-12-12
+### Fixed
+* Fix issue with CI invoked through rake binstub for projects using Spring (#69)
+* Fix issue with shared paths in the `private/` directory
+* Fix CI brakeman task with recent brakeman version
+
 ## 5.4.5 / 2019-07-24
 ### Fixed
 * Fix issue where other minitest plugins sporadically fail to load

data/code_safety.yml

@@ -15,11 +15,11 @@ file safety:
   ".travis.yml":
     comments: 
     reviewed_by: josh.pencheon
-    safe_revision: 38266fd047417ecb4d5e6de71746f40495fc9de9
+    safe_revision: 1f2197bd4ea2f4330dae266eec6983e86482b613
   CHANGELOG.md:
     comments: 
     reviewed_by: josh.pencheon
-    safe_revision: e40336350473cb2fc9e0b277233610033d9bbf5a
+    safe_revision: 9d79c8a00cb8db92a7ed021b8f6805358f5d6913
   CODE_OF_CONDUCT.md:
     comments: 
     reviewed_by: timgentry
@@ -75,7 +75,7 @@ file safety:
   lib/ndr_dev_support/capistrano/ndr_model.rb:
     comments: 
     reviewed_by: josh.pencheon
-    safe_revision: fa4042dc341b14eb7feafcc78baf052dbb100eb3
+    safe_revision: 57271c07e44808d8809e1fa11227a8c2e91a14bf
   lib/ndr_dev_support/capistrano/restart.rb:
     comments: 
     reviewed_by: josh.pencheon
@@ -203,7 +203,7 @@ file safety:
   lib/ndr_dev_support/version.rb:
     comments: 
     reviewed_by: josh.pencheon
-    safe_revision: e40336350473cb2fc9e0b277233610033d9bbf5a
+    safe_revision: 9d79c8a00cb8db92a7ed021b8f6805358f5d6913
   lib/tasks/audit_code.rake:
     comments: Identical to the version reviewed by josh.pencheon when contained within
       ndr_support
@@ -212,7 +212,7 @@ file safety:
   lib/tasks/ci/brakeman.rake:
     comments: 
     reviewed_by: josh.pencheon
-    safe_revision: d3d238a863c0b016d2d782b1696964fa3f40738b
+    safe_revision: 908c04663ca6949259f41fe38ee705f03774cbdf
   lib/tasks/ci/bundle_audit.rake:
     comments: 
     reviewed_by: josh.pencheon
@@ -236,7 +236,7 @@ file safety:
   lib/tasks/ci/minitest.rake:
     comments: 
     reviewed_by: josh.pencheon
-    safe_revision: 26efe45f35f211e7cb7a04967c51c0b6d116321e
+    safe_revision: 29b7dc86673f4f876667db95e79a57b20766077e
   lib/tasks/ci/notes.rake:
     comments: 
     reviewed_by: timgentry
@@ -276,7 +276,7 @@ file safety:
   ndr_dev_support.gemspec:
     comments: 
     reviewed_by: josh.pencheon
-    safe_revision: 4c73385591e807216d3bcd50b5f23b757c69f23b
+    safe_revision: 1f2197bd4ea2f4330dae266eec6983e86482b613
   test/daemon/ci_server_test.rb:
     comments: 
     reviewed_by: josh.pencheon

data/lib/ndr_dev_support/capistrano/ndr_model.rb

@@ -128,15 +128,15 @@ Capistrano::Configuration.instance(:must_exist).load do
       # This task binds after a standard capistrano step, so we need to be careful:
       next unless ndr_model_deployment
 
+      # Make the private/ directory in the release writeable to the application user:
+      private_directory = File.join(release_path, 'private')
+      run "mkdir -p #{private_directory} && chgrp #{fetch(:application_group)} #{private_directory} && chmod g+s #{private_directory}"
+
       fetch(:shared_paths, []).each do |path|
         # Symlink `path` from the shared space to the release being prepared, replacing anything
         # already there:
         run "rm -rf #{File.join(release_path, path)} && ln -s #{File.join(shared_path, path)} #{File.join(release_path, path)}"
       end
-
-      # Make the private/ directory in the release writeable to the application user:
-      private_directory = File.join(release_path, 'private')
-      run "mkdir -p #{private_directory} && chgrp #{fetch(:application_group)} #{private_directory} && chmod g+s #{private_directory}"
     end
 
     after 'deploy:finalize_update', 'ndr_dev_support:filesystem_tweaks'

data/lib/ndr_dev_support/version.rb

@@ -2,5 +2,5 @@
 # This defines the NdrDevSupport version. If you change it, rebuild and commit the gem.
 # Use "rake build" to build the gem, see rake -T for all bundler rake tasks (and our own).
 module NdrDevSupport
-  VERSION = '5.4.5'.freeze
+  VERSION = '5.4.6'.freeze
 end

data/lib/tasks/ci/brakeman.rake

@@ -31,7 +31,7 @@ namespace :ci do
         title: "#{brakeman.new_fingerprints.size} new Brakeman warning(s) :rotating_light:",
         text: '_Brakeman_ warning fingerprint(s):' \
               "```#{brakeman.new_fingerprints.to_a.join("\n")}```",
-        footer: 'bundle exec rake ci:brakeman',
+        footer: 'bundle exec rake ci:brakeman:fingerprint_details FINGERPRINTS=...',
         mrkdwn_in: ['text']
       }
       @attachments << attachment
@@ -72,7 +72,7 @@ namespace :ci do
       brakeman.commit = @commit
       brakeman.run
 
-      text_reporter = Brakeman::Report::Text.new(nil, brakeman.tracker)
+      text_reporter = Brakeman::Report::Text.new(brakeman.tracker)
 
       brakeman.warnings.each do |warning|
         next unless fingerprints.include?(warning.fingerprint)

data/lib/tasks/ci/minitest.rake

@@ -5,7 +5,7 @@ namespace :ci do
 
     # Run the tests
     test_cmd = 'bundle exec rake ci:minitest:setup ci:simplecov:setup default'
-    system test_cmd
+    system({ 'RAILS_ENV' => nil }, test_cmd)
 
     Rake::Task['ci:minitest:process'].invoke
 

data/ndr_dev_support.gemspec

@@ -19,7 +19,7 @@ Gem::Specification.new do |spec|
   spec.executables   = spec.files.grep(%r{^exe/}) { |f| File.basename(f) }
   spec.require_paths = ['lib']
 
-  spec.required_ruby_version = '>= 2.4'
+  spec.required_ruby_version = '>= 2.5'
 
   spec.add_dependency 'pry'
 
@@ -42,7 +42,7 @@ Gem::Specification.new do |spec|
 
   # CI server dependencies:
   spec.add_dependency 'activesupport', '< 6.1'
-  spec.add_dependency 'brakeman', '>= 4.2.0'
+  spec.add_dependency 'brakeman', '>= 4.7.1'
   spec.add_dependency 'bundler-audit'
   spec.add_dependency 'github-linguist'
   spec.add_dependency 'prometheus-client', '>= 0.9.0'

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: ndr_dev_support
 version: !ruby/object:Gem::Version
-  version: 5.4.5
+  version: 5.4.6
 platform: ruby
 authors:
 - NCRS Development Team
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2019-07-24 00:00:00.000000000 Z
+date: 2019-12-12 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: pry
@@ -198,14 +198,14 @@ dependencies:
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 4.2.0
+        version: 4.7.1
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: 4.2.0
+        version: 4.7.1
 - !ruby/object:Gem::Dependency
   name: bundler-audit
   requirement: !ruby/object:Gem::Requirement
@@ -447,7 +447,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="
     - !ruby/object:Gem::Version
-      version: '2.4'
+      version: '2.5'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
   - - ">="