ndr_dev_support 5.1.0 → 5.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: b33b208c31e16b68d55cbbc40f482d5e1d6146ef2190999b9481670706851535
-  data.tar.gz: 3cdc280a9023b1e326680f86e753d67e1124ce185046cc9fefb590b0cd5a9a34
+  metadata.gz: 3b2e7533f6beb88747b0f1f90d6f0145971967afe89a3abc40f2d758e05731ca
+  data.tar.gz: 12a546e8f88d752ec2148a84c8976ba732c3eae138262bd9318645aa019892b7
 SHA512:
-  metadata.gz: f453af8d2db1f63f3cf9fe95141ba4943b80394a4769f76f194864168d1d20c7499d22f8ee5a5e74ada6cd2261bb95f1cde31b9e99dd1c47046d29fd48b6a06f
-  data.tar.gz: 2470eac3017806dd8ad4707044ffb67e133df973414d729a374525ca3b6e36226ced375335ac4f1c0e1ccf0d74a247f692130c7c532607b526ad31884bf9f46a
+  metadata.gz: 5952f961e82afc9e82bfeeef9d93e2a006f2eac01e2ea5a0e99dbfb521c6214b4c352eaedacd42ed11e6333b45c4e8530e1db9eea1e6bb0fd3a0e83f2f1b843b
+  data.tar.gz: 694ac0dc87603055ec136502b07b02f80a77dbee444ae96a9be6473c35b3bbbdc55913f0195669a6215658b08c549b9a19eeae7fb65518f9cb43804b4bb0d3c0

data/CHANGELOG.md

@@ -1,6 +1,13 @@
 ## [Unreleased]
 *no unreleased changes*
 
+## 5.2.0 / 2019-03-21
+### Added
+* Added rake task to filter brakeman output to specific fingerprints. (#51)
+
+### Fixed
+* CI: Remove duplicated revision information from commit message
+
 ## 5.1.0 / 2019-01-31
 ### Added
 * CI: send a slack message whenever tests pass

data/code_safety.yml

@@ -19,7 +19,7 @@ file safety:
   CHANGELOG.md:
     comments: 
     reviewed_by: josh.pencheon
-    safe_revision: 21bcc26b9d466ccd9283dcb170fbee9138b7bfee
+    safe_revision: e3afc74e63943e91305df371dfe8ad0e30f8341b
   CODE_OF_CONDUCT.md:
     comments: 
     reviewed_by: timgentry
@@ -131,7 +131,7 @@ file safety:
   lib/ndr_dev_support/rake_ci/brakeman_helper.rb:
     comments: 
     reviewed_by: josh.pencheon
-    safe_revision: 49caa4ef8ad9926843354d36f4610d40603ec632
+    safe_revision: d3d238a863c0b016d2d782b1696964fa3f40738b
   lib/ndr_dev_support/rake_ci/commit_cop.rb:
     comments: 
     reviewed_by: josh.pencheon
@@ -195,7 +195,7 @@ file safety:
   lib/ndr_dev_support/version.rb:
     comments: 
     reviewed_by: josh.pencheon
-    safe_revision: 21bcc26b9d466ccd9283dcb170fbee9138b7bfee
+    safe_revision: e3afc74e63943e91305df371dfe8ad0e30f8341b
   lib/tasks/audit_code.rake:
     comments: Identical to the version reviewed by josh.pencheon when contained within
       ndr_support
@@ -204,7 +204,7 @@ file safety:
   lib/tasks/ci/brakeman.rake:
     comments: 
     reviewed_by: josh.pencheon
-    safe_revision: 49caa4ef8ad9926843354d36f4610d40603ec632
+    safe_revision: d3d238a863c0b016d2d782b1696964fa3f40738b
   lib/tasks/ci/bundle_audit.rake:
     comments: 
     reviewed_by: josh.pencheon
@@ -243,8 +243,8 @@ file safety:
     safe_revision: 2d1b9d19acafebe6ca5f995bf15243abe2847eec
   lib/tasks/ci/rugged.rake:
     comments: 
-    reviewed_by: timgentry
-    safe_revision: 7ab7061b257f916eb43bc8d184aa425f1f08b739
+    reviewed_by: josh.pencheon
+    safe_revision: 15543b915771dfe2ed81b8b326bdd3ab2cb5b562
   lib/tasks/ci/server.rake:
     comments: 
     reviewed_by: josh.pencheon
@@ -268,7 +268,7 @@ file safety:
   ndr_dev_support.gemspec:
     comments: 
     reviewed_by: josh.pencheon
-    safe_revision: 1cce5269b61341c5ec06e91b819df84ac6140165
+    safe_revision: 62d99a8df1244b46709b109a86e3edca17325def
   test/daemon/ci_server_test.rb:
     comments: 
     reviewed_by: josh.pencheon

data/lib/ndr_dev_support/rake_ci/brakeman_helper.rb

@@ -8,7 +8,7 @@ module NdrDevSupport
 
       include CommitMetadataPersistable
 
-      attr_reader :new_fingerprints, :old_fingerprints
+      attr_reader :new_fingerprints, :old_fingerprints, :tracker
 
       def run
         @tracker = ::Brakeman.run(app_path: '.')

data/lib/ndr_dev_support/version.rb

@@ -2,5 +2,5 @@
 # This defines the NdrDevSupport version. If you change it, rebuild and commit the gem.
 # Use "rake build" to build the gem, see rake -T for all bundler rake tasks (and our own).
 module NdrDevSupport
-  VERSION = '5.1.0'.freeze
+  VERSION = '5.2.0'.freeze
 end

data/lib/tasks/ci/brakeman.rake

@@ -51,4 +51,37 @@ namespace :ci do
 
     brakeman.save_current_fingerprints
   end
+
+  namespace :brakeman do
+    desc 'Brakeman fingerprint details'
+    task fingerprint_details: 'ci:rugged:setup' do
+      # Usage: bundle exec rake ci:brakeman:fingerprint_details FINGERPRINTS=fp1,fp2,...
+      next unless defined?(Rails)
+
+      require 'ndr_dev_support/rake_ci/brakeman_helper'
+      require 'brakeman/scanner'
+      require 'brakeman/report/report_text'
+
+      fingerprints = ENV['FINGERPRINTS'].split(/,/)
+
+      puts 'Scanning for fingerprints...'
+      puts fingerprints
+      puts
+
+      brakeman = NdrDevSupport::RakeCI::BrakemanHelper.new
+      brakeman.commit = @commit
+      brakeman.run
+
+      text_reporter = Brakeman::Report::Text.new(nil, brakeman.tracker)
+
+      brakeman.warnings.each do |warning|
+        next unless fingerprints.include?(warning.fingerprint)
+
+        puts
+        puts text_reporter.label('Fingerprint', warning.fingerprint.to_s)
+        puts text_reporter.output_warning(warning)
+      end
+      puts
+    end
+  end
 end

data/lib/tasks/ci/rugged.rake

@@ -24,9 +24,11 @@ namespace :ci do
         }
       end
 
+      text = @commit.message.lines.grep_v(/\Agit-svn-id: /).join.strip
+
       attachment = {
-        fallback: @commit.message,
-        text: @commit.message,
+        fallback: text,
+        text: text,
         fields: fields,
         ts: @commit.author[:time].to_i
       }

data/ndr_dev_support.gemspec

@@ -52,7 +52,7 @@ Gem::Specification.new do |spec|
   # Deployment dependencies:
   spec.add_dependency 'capistrano', '~> 2.15'
 
-  spec.add_development_dependency 'bundler', '~> 1.7'
+  spec.add_development_dependency 'bundler'
   spec.add_development_dependency 'minitest', '~> 5.0'
   spec.add_development_dependency 'mocha'
   spec.add_development_dependency 'rake', '~> 10.0'

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: ndr_dev_support
 version: !ruby/object:Gem::Version
-  version: 5.1.0
+  version: 5.2.0
 platform: ruby
 authors:
 - NCRS Development Team
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2019-01-31 00:00:00.000000000 Z
+date: 2019-03-21 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: pry
@@ -294,16 +294,16 @@ dependencies:
   name: bundler
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '1.7'
+        version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
+    - - ">="
       - !ruby/object:Gem::Version
-        version: '1.7'
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: minitest
   requirement: !ruby/object:Gem::Requirement