ncua 0.7.2 → 0.8.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 16c9dd591d860da6e7e8fa6a86e3342e9f2065a9
-  data.tar.gz: c3c4d2003adbbc3e86c919f69606893d392fd6b0
+  metadata.gz: 7239d68f260fe6848f3bb85f19e6f51815531635
+  data.tar.gz: b690ef06d9dd96db0af6e6e1e47fd1035f0b506f
 SHA512:
-  metadata.gz: de9c5bef9c1b65db09bb1cc1ab2d81dea57ee01bea17b4f0365b5eef2420d52d5f7d5ed6d62981cd4dad82f24dcfc040ade9c39ee99b2d26151c486cfca514d7
-  data.tar.gz: cc61bb395bad5ae58149fd9caa71fee4b9ebf721ccd5931eaafb9a921ff8ed9d58992eadd96ad1e82c1752479c09e829c0b711762e5576b3323cf5e48904be73
+  metadata.gz: df38dffc69a867b8240e751452cfcbe75d55ca20dae4f5fb809dda1c28cc06d15eefe6f26bedd54d871f06ddf3dce6d33439cafd925669cb2bf7e7aa1fdfac9e
+  data.tar.gz: b721282110eb5cd8a98a292c0900d850af75da2ad2a7b4f76445edc8bee671b9e67ff4bd60e42e934843bafe90cd1c91369baa596e71180bee9bc9d71e710989

data/README.md

@@ -108,6 +108,10 @@ Right now, an `NCUA::CreditUnion::Details` object has the following getters:
 
 You can also scrape this directly from the NCUA module by calling `NCUA.find_credit_union(charter_number)`
 
+If you pass `nil` into this method, it will raise an `ArgumentError`. The NCUA will actually return a 200 without a charter number, but the data on the page is blank.
+
+If for some reason the NCUA returns a 500 error when directly scraping for credit union details, the gem will raise `NCUA::CreditUnion::ServerError`. This can happen if your charter number is invalid.
+
 ## Contributing
 
 Bug reports and pull requests are welcome on GitHub at https://github.com/ContinuityControl/ncua.

data/lib/ncua.rb

@@ -6,6 +6,7 @@ require 'ncua/credit_union/record'
 require 'ncua/credit_union/office'
 require 'ncua/credit_union/details'
 require 'ncua/credit_union/scraper'
+require 'ncua/credit_union/details_client'
 
 module NCUA
   def self.find_office_by_address(address, opts={radius: 100})

data/lib/ncua/credit_union/details_client.rb

@@ -0,0 +1,36 @@
+module NCUA
+  module CreditUnion
+    class ServerError < ::StandardError; end
+    class DetailsClient
+      include HTTParty
+
+      base_uri 'http://mapping.ncua.gov'
+      def get_details(charter_number)
+        if charter_number.nil?
+          raise ArgumentError, "charter number cannot be nil"
+        end
+
+        response = execute_query(charter_number)
+
+        case response.code
+        when 200...300
+          response
+        when 500...600
+          raise ServerError
+        end
+      end
+
+      private
+
+      def endpoint
+        '/SingleResult.aspx'
+      end
+
+      def execute_query(charter_number)
+        self.class.get(endpoint, query: {
+          "ID" => charter_number
+        })
+      end
+    end
+  end
+end

data/lib/ncua/credit_union/scraper.rb

@@ -2,9 +2,6 @@ module NCUA
   module CreditUnion
     class Scraper
       #This bit is as brittle as glass, as coupled as conjoined twins, and as stinky as bad cheese
-      include HTTParty
-
-      base_uri 'http://mapping.ncua.gov'
       def initialize(charter_number)
         @charter_number = charter_number
       end
@@ -36,13 +33,7 @@ module NCUA
       end
 
       def request
-        self.class.get(endpoint, query: {
-          "ID" => @charter_number
-        })
-      end
-
-      def endpoint
-        '/SingleResult.aspx'
+        @request ||= DetailsClient.new.get_details(@charter_number)
       end
     end
   end

data/lib/ncua/version.rb

@@ -1,3 +1,3 @@
 module NCUA
-  VERSION = "0.7.2"
+  VERSION = "0.8.0"
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: ncua
 version: !ruby/object:Gem::Version
-  version: 0.7.2
+  version: 0.8.0
 platform: ruby
 authors:
 - Tom Reznick
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2015-09-13 00:00:00.000000000 Z
+date: 2015-10-19 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: httparty
@@ -105,6 +105,7 @@ files:
 - lib/ncua.rb
 - lib/ncua/client.rb
 - lib/ncua/credit_union/details.rb
+- lib/ncua/credit_union/details_client.rb
 - lib/ncua/credit_union/office.rb
 - lib/ncua/credit_union/record.rb
 - lib/ncua/credit_union/scraper.rb