ncs_mdes_warehouse 0.15.0.pre2 → 0.15.0.pre3

data/lib/ncs_navigator/warehouse/transform_load.rb

@@ -33,25 +33,12 @@ module NcsNavigator::Warehouse
 
           build_status_for(transformer, position).tap do |status|
             begin
-              TransformStatus.transaction do
-                if repo.adapter.to_s =~ /Postgres/
-                  repo.adapter.execute("SET LOCAL synchronous_commit TO OFF")
-                end
-                begin
-                  transformer.transform(status)
-                rescue => e
-                  shell.say_line("\nTransform failed. (See log for more detail.)")
-                  msg = "Transform failed. #{e.class}: #{e}\n#{stringify_trace(e.backtrace)}"
-                  log.error(msg)
-                  status.add_error(msg)
-                end
-              end
-            rescue DataObjects::IntegrityError => e
-              shell.say_line(
-                "\nTransform failed with data integrity error. (See log for more detail.)")
-              log.error(
-                "Transform failed with data integrity error: #{e}.\n#{stringify_trace(e.backtrace)}")
-              status.add_error("Transform failed with data integrity error: #{e}.")
+              transformer.transform(status)
+            rescue => e
+              shell.say_line("\nTransform failed. (See log for more detail.)")
+              msg = "Transform failed. #{e.class}: #{e}\n#{stringify_trace(e.backtrace)}"
+              log.error(msg)
+              status.add_error(msg)
             end
             status.end_time = Time.now
             unless status.save

data/lib/ncs_navigator/warehouse/transformers/enum_transformer.rb

@@ -143,7 +143,7 @@ module NcsNavigator::Warehouse::Transformers
             record
             foreign_key_index.record(record)
           else
-            msg = "Could not save record #{record.inspect}.\n\t Errors: #{record.errors.inspect}"
+            msg = "Could not save record #{record_ident record}."
             log.error msg
             status.unsuccessful_record(record, msg)
           end

data/lib/ncs_navigator/warehouse/version.rb

@@ -1,5 +1,5 @@
 module NcsNavigator
   module Warehouse
-    VERSION = '0.15.0.pre2'
+    VERSION = '0.15.0.pre3'
   end
 end

data/spec/ncs_navigator/warehouse/transform_load_spec.rb

@@ -140,34 +140,6 @@ module NcsNavigator::Warehouse
         end
       end
 
-      describe 'with an integrity error on transaction commit' do
-        let(:runs) { [] }
-
-        before do
-          config.add_transformer(BlockTransformer.new { |s| runs << 'A' })
-          config.add_transformer(BlockTransformer.new { |s| runs << 'B' })
-          config.add_transformer(BlockTransformer.new { |s| runs << 'C3' })
-
-          TransformStatus.should_receive(:transaction).ordered.and_yield
-          TransformStatus.should_receive(:transaction).ordered.
-            and_raise(DataObjects::IntegrityError.new('Foo'))
-          TransformStatus.should_receive(:transaction).ordered.and_yield
-
-          loader.run
-        end
-
-        it 'records a TransformError' do
-          TransformStatus.all[1].transform_errors.first.message.
-            should =~ /^Transform failed with data integrity error: Foo/
-        end
-
-        it 'still runs all the transformers' do
-          # this is not A B C3 due to a limitation in rspec-mocks --
-          # you apparently can't .and_yield.and_raise and have both apply.
-          runs.should == %w(A C3)
-        end
-      end
-
       describe 'with post-ETL hooks' do
         let(:hook_a) { RecordingHook.new }
         let(:hook_success) { RecordingHook.new(:succeeded) }

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: ncs_mdes_warehouse
 version: !ruby/object:Gem::Version
-  version: 0.15.0.pre2
+  version: 0.15.0.pre3
   prerelease: 7
 platform: ruby
 authors:
@@ -3670,7 +3670,7 @@ required_ruby_version: !ruby/object:Gem::Requirement
       version: '0'
       segments:
       - 0
-      hash: 775523728278121596
+      hash: 1848761035843935953
 required_rubygems_version: !ruby/object:Gem::Requirement
   none: false
   requirements:
@@ -3679,7 +3679,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: 1.3.1
 requirements: []
 rubyforge_project: 
-rubygems_version: 1.8.24
+rubygems_version: 1.8.25
 signing_key: 
 specification_version: 3
 summary: Scripts and models for building and maintaining the MDES-based reporting