ncore 3.4.4 → 3.5.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 37764b440a06ae592f8c0b536e431a83ade55ebf27503e591325561876acd1de
-  data.tar.gz: dd35be93d3d788b55ac6404db24dadc805cee91a87b42485347dd2ea707dee3a
+  metadata.gz: 16e01242ae632039f017faa4e3c51e6c885b05bb86ba0c53db9e6cf21b5e011b
+  data.tar.gz: 849bce6e876e202690601839d0b0012a70347aeb25fe0fff0c56006f180e5a61
 SHA512:
-  metadata.gz: 2b4a3cec14d91cea9efb6fa947362b9098b212a46102977564060a53b666eff93bcaf1c298e959039597974a729355b92661c4dddd72d03d9353e2e0a249392f
-  data.tar.gz: d0255d70bba9e5735373b9af7f22f5348736273cd42aedf03d961ba4e33ff121bd6248efe9cc1df4c6630628154b73ed1315152a9d55c51d8ada6309e18b699a
+  metadata.gz: ced939921588d62b7141fb481b1aa8638be6e297f0d355137c4aa155c8efde8d41198e4d76acdb9c574cf9bdefe7026df384dc84a70002153b38ded55cf9e80e
+  data.tar.gz: 2497400057a0229616f5d9771f141be8966e65ab7d9ab767c3c54c3efaeb13f15017d46d7da6c1f73f23b22032c093d2a3f93246f968fece9ade3372dc981a66

data/CHANGELOG.md

@@ -1,3 +1,15 @@
+#### 3.5.1
+
+- Preserve 'metadata' and 'errors' keys as attributes when inside a standard
+  data payload
+
+#### 3.5.0
+
+- Allow ActiveModel 7.1
+- Update LogSubscriber for ActiveSupport 7.1
+- Associations: add arg :association_key to has_many, belongs_to
+- Associations: has_many now builds retrieve_{assoc}
+
 #### 3.4.4
 
 - Improve keepalive handling
@@ -96,6 +108,10 @@ Other changes
   - #i18n_scope, config via Api.i18n_scope=
   - #cache_key, #cache_version, #cache_key_with_version
 
+#### 2.3.3
+
+- Improve keepalive handling
+
 #### 2.3.2
 
 - Allow ActiveSupport 7.0

data/LICENSE

@@ -1,4 +1,4 @@
-Copyright (c) 2014-2022 Notioneer, Inc.
+Copyright (c) 2014-2023 Notioneer, Inc.
 
 MIT License
 

data/lib/ncore/associations.rb

@@ -1,109 +1,148 @@
 module NCore
   module Associations
 
-    def has_many(assoc, class_name: nil)
-      assoc = assoc.to_s
-      klass = class_name || "#{module_name}::#{assoc.camelize.singularize}"
-      key = "#{attrib_name}_id"
-      class_eval <<-M1, __FILE__, __LINE__+1
-        def #{assoc}(params={})
+    # assoc_name       - plural association name
+    # :association_key - key used by the association to reference the parent
+    #                    defaults to `attrib_name+'_id'`
+    # :class_name      - Module::Class of the child association, as a string
+    def has_many(assoc_name, association_key: nil, class_name: nil)
+      assoc_name = assoc_name.to_s
+      parent_key = association_key&.to_s || "#{attrib_name}_id"
+      klass      = class_name || "#{module_name}::#{assoc_name.camelize.singularize}"
+
+      # def items({})
+      class_eval <<-A1, __FILE__, __LINE__+1
+        def #{assoc_name}(params={})
           return [] unless id
           reload = params.delete :reload
           cacheable = params.except(:credentials, :request).empty?
           params = parse_request_params(params).reverse_merge credentials: api_creds
-          params[:#{key}] = id
+          params[:#{parent_key}] = id
           if cacheable
             # only cache unfiltered, default api call
-            @attribs[:#{assoc}] = (!reload && @attribs[:#{assoc}]) || #{klass}.all(params)
+            @attribs[:#{assoc_name}] = (!reload && @attribs[:#{assoc_name}]) || #{klass}.all(params)
           else
             #{klass}.all(params)
           end
         end
-      M1
-      class_eval <<-M2, __FILE__, __LINE__+1
-        def find_#{assoc.singularize}(aid, params={})
+      A1
+
+      # def find_item(id, {})
+      class_eval <<-F1, __FILE__, __LINE__+1
+        def find_#{assoc_name.singularize}(aid, params={})
           raise UnsavedObjectError unless id
           params = parse_request_params(params).reverse_merge credentials: api_creds
-          params[:#{key}] = id
+          params[:#{parent_key}] = id
           #{klass}.find(aid, params)
         end
-      M2
-      # will always return the object; check .errors? or .valid? to see how it went
-      class_eval <<-M3, __FILE__, __LINE__+1
-        def create_#{assoc.singularize}(params={})
+      F1
+
+      # def retrieve_item(id, {})
+      class_eval <<-F2, __FILE__, __LINE__+1
+        def retrieve_#{assoc_name.singularize}(aid, params={})
           raise UnsavedObjectError unless id
           params = parse_request_params(params).reverse_merge credentials: api_creds
-          params[:#{key}] = id
-          #{klass}.create(params)
+          params[:#{parent_key}] = id
+          #{klass}.retrieve(aid, params)
         end
-      M3
+      F2
+
+      # def create_item({})
       # will always return the object; check .errors? or .valid? to see how it went
-      class_eval <<-M4, __FILE__, __LINE__+1
-        def update_#{assoc.singularize}(aid, params={})
+      class_eval <<-C1, __FILE__, __LINE__+1
+        def create_#{assoc_name.singularize}(params={})
           raise UnsavedObjectError unless id
           params = parse_request_params(params).reverse_merge credentials: api_creds
-          params[:#{key}] = id
-          #{klass}.update(aid, params)
+          params[:#{parent_key}] = id
+          #{klass}.create(params)
         end
-      M4
-      class_eval <<-M5, __FILE__, __LINE__+1
-        def create_#{assoc.singularize}!(params={})
+      C1
+
+      # def create_item!({})
+      class_eval <<-C2, __FILE__, __LINE__+1
+        def create_#{assoc_name.singularize}!(params={})
           raise UnsavedObjectError unless id
           params = parse_request_params(params).reverse_merge credentials: api_creds
-          params[:#{key}] = id
+          params[:#{parent_key}] = id
           #{klass}.create!(params)
         end
-      M5
-      class_eval <<-M6, __FILE__, __LINE__+1
-        def update_#{assoc.singularize}!(aid, params={})
+      C2
+
+      # def update_item(id, {})
+      # will always return the object; check .errors? or .valid? to see how it went
+      class_eval <<-U1, __FILE__, __LINE__+1
+        def update_#{assoc_name.singularize}(aid, params={})
+          raise UnsavedObjectError unless id
+          params = parse_request_params(params).reverse_merge credentials: api_creds
+          params[:#{parent_key}] = id
+          #{klass}.update(aid, params)
+        end
+      U1
+
+      # def update_item!(id, {})
+      class_eval <<-U2, __FILE__, __LINE__+1
+        def update_#{assoc_name.singularize}!(aid, params={})
           raise UnsavedObjectError unless id
           params = parse_request_params(params).reverse_merge credentials: api_creds
-          params[:#{key}] = id
+          params[:#{parent_key}] = id
           #{klass}.update!(aid, params)
         end
-      M6
+      U2
+
+      # def delete_item(id, {})
       # will always return the object; check .errors? or .valid? to see how it went
-      class_eval <<-M7, __FILE__, __LINE__+1
-        def delete_#{assoc.singularize}(aid, params={})
+      class_eval <<-D1, __FILE__, __LINE__+1
+        def delete_#{assoc_name.singularize}(aid, params={})
           raise UnsavedObjectError unless id
           params = parse_request_params(params).reverse_merge credentials: api_creds
-          params[:#{key}] = id
+          params[:#{parent_key}] = id
           #{klass}.delete(aid, params)
         end
-      M7
-      class_eval <<-M8, __FILE__, __LINE__+1
-        def delete_#{assoc.singularize}!(aid, params={})
+      D1
+
+      # def delete_item!(id, {})
+      class_eval <<-D2, __FILE__, __LINE__+1
+        def delete_#{assoc_name.singularize}!(aid, params={})
           raise UnsavedObjectError unless id
           params = parse_request_params(params).reverse_merge credentials: api_creds
-          params[:#{key}] = id
+          params[:#{parent_key}] = id
           #{klass}.delete!(aid, params)
         end
-      M8
+      D2
     end
 
-    def belongs_to(assoc, class_name: nil)
-      assoc = assoc.to_s
-      klass = class_name || "#{module_name}::#{assoc.camelize}"
-      class_eval <<-M1, __FILE__, __LINE__+1
-        attr :#{assoc}_id
-        def #{assoc}(params={})
-          return nil unless #{assoc}_id
+    # assoc_name       - singular association name
+    # :association_key - key on this resource used to reference the parent association
+    #                    defaults to `assoc_name+'_id'`
+    # :class_name      - Module::Class of the parent association, as a string
+    def belongs_to(assoc_name, association_key: nil, class_name: nil)
+      assoc_name = assoc_name.to_s
+      parent_key = association_key&.to_s || "#{assoc_name}_id"
+      klass      = class_name || "#{module_name}::#{assoc_name.camelize}"
+
+      # attr :parent_id
+      # def parent({})
+      class_eval <<-P1, __FILE__, __LINE__+1
+        attr :#{parent_key}
+        def #{assoc_name}(params={})
+          return nil unless #{parent_key}
           params = parse_request_params(params).reverse_merge credentials: api_creds
           if params.except(:credentials, :request).empty?
             # only cache unfiltered, default api call
-            @attribs[:#{assoc}] ||= #{klass}.find(#{assoc}_id, params)
+            @attribs[:#{assoc_name}] ||= #{klass}.find(#{parent_key}, params)
           else
-            #{klass}.find(#{assoc}_id, params)
+            #{klass}.find(#{parent_key}, params)
           end
         end
-      M1
-      class_eval <<-M2, __FILE__, __LINE__+1
-        def #{assoc}_id=(v)
-          @attribs[:#{assoc}] = nil unless @attribs[:#{assoc}_id] == v
-          @attribs[:#{assoc}_id] = v
+      P1
+
+      class_eval <<-P2, __FILE__, __LINE__+1
+        def #{parent_key}=(v)
+          @attribs[:#{assoc_name}] = nil unless @attribs[:#{parent_key}] == v
+          @attribs[:#{parent_key}] = v
         end
-        private :#{assoc}_id=
-      M2
+        private :#{parent_key}=
+      P2
     end
 
   end

data/lib/ncore/attributes.rb

@@ -168,7 +168,9 @@ module NCore
       self.metadata = args[:metadata] || {}.with_indifferent_access
       self.errors = parse_errors(args[:errors])
       args[:data].each do |k,v|
-        if respond_to? "#{k}="
+        if k=='metadata' || k=='errors'
+          @attribs[k] = self.class.interpret_type(v, api_creds)
+        elsif respond_to?("#{k}=")
           send "#{k}=", self.class.interpret_type(v, api_creds)
         else
           @attribs[k] = self.class.interpret_type(v, api_creds)

data/lib/ncore/rails/log_subscriber.rb

@@ -37,11 +37,11 @@ module NCore
       msg = "%s %s" % [http_method, url]
       res = " -> %d (%.1f ms)" % [http_status, event.duration]
 
-      msg = color(msg, ActiveSupport::LogSubscriber::YELLOW, false)
+      msg = color(msg, :yellow)
       if (200..299).include? http_status
-        res = color(res, ActiveSupport::LogSubscriber::GREEN, true)
+        res = color(res, :green, bold: true)
       else
-        res = color(res, ActiveSupport::LogSubscriber::RED, true)
+        res = color(res, :red, bold: true)
       end
 
       if (200..299).include? http_status

data/lib/ncore/version.rb

@@ -1,3 +1,3 @@
 module NCore
-  VERSION = '3.4.4'
+  VERSION = '3.5.1'
 end

data/ncore.gemspec

@@ -18,7 +18,7 @@ Gem::Specification.new do |spec|
   spec.test_files    = spec.files.grep(%r{^(test|spec|features)/})
   spec.require_paths = ["lib"]
 
-  spec.add_dependency 'activemodel', '>= 5.2', '< 7.1'
+  spec.add_dependency 'activemodel', '>= 5.2', '< 7.2'
   spec.add_dependency 'excon', '~> 0.32'
 
   spec.add_development_dependency "bundler"

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: ncore
 version: !ruby/object:Gem::Version
-  version: 3.4.4
+  version: 3.5.1
 platform: ruby
 authors:
 - Notioneer Team
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2022-04-26 00:00:00.000000000 Z
+date: 2023-01-20 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activemodel
@@ -19,7 +19,7 @@ dependencies:
         version: '5.2'
     - - "<"
       - !ruby/object:Gem::Version
-        version: '7.1'
+        version: '7.2'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
@@ -29,7 +29,7 @@ dependencies:
         version: '5.2'
     - - "<"
       - !ruby/object:Gem::Version
-        version: '7.1'
+        version: '7.2'
 - !ruby/object:Gem::Dependency
   name: excon
   requirement: !ruby/object:Gem::Requirement
@@ -142,7 +142,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.2.32
+rubygems_version: 3.3.26
 signing_key:
 specification_version: 4
 summary: NCore - Gem for building REST API clients