ncore 3.14.0 → 3.15.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 82327b8c22a9db2b69dfca2505b658b9a01d5a880cd21a7db9d11c1031d001e7
-  data.tar.gz: abf4f4eef8f9e3bdebbce6e987507ca3adc31d4bb31ffae63d46b5466c417505
+  metadata.gz: 9ddf8c778ed7a75566b6c1665880413606d276e3c07269fe8f4e63ad9f98d0fc
+  data.tar.gz: 0a527000d932792291a0f0fce5ad834560ee7ee0637c4798354f0d63067a9784
 SHA512:
-  metadata.gz: de4443f42157acf82e2ea6ca3741ecb6c09ce61a6585cb36f4c84d7898346a9cbf4acdd35303923b8f69cc7cf110931d5e2cf4f26cb4f01f6fd0218ed76bc331
-  data.tar.gz: bbaa72e2993e5f56367f6aeff83825f7f7b0c852d8bac70fc275a4ed86dd02c52a07ea09395e28db44bdc82efee02185d66e56de879b203f1884f9934edcf9e9
+  metadata.gz: 998f66195437f3d3b05783d5cfe96569ba4dfe81d5128319c3352d942b54f273b64bbe32bde720e81e0a87ebb9c1f659a2ac8d9c196e16b27ec029c9216fe38c
+  data.tar.gz: 58667228dee3c13b4316839b156e01b619aa88f710ba6d5ff5c821bf4133964165d6fc14b709b03da4cc051fa01865f4e44f3caf7c529403b22aa43f3ae32b6c

data/.github/pull_request_template.md

@@ -0,0 +1,15 @@
+<!--
+Describe your PR. What's the purpose/use-case of this PR?
+What's been added, changed, and/or removed?
+-->
+
+## Contribution
+
+<!-- Check only what applies. The goal here is clarity, not checking all the boxes. -->
+
+- [ ] I tested my changes locally
+- [ ] Includes a breaking change (be sure to explain above)
+<!--
+Select one: -->
+- [ ] PR contents is 100% human written
+- [ ] PR includes LLM output  <!-- see README.md's Contributing section (near bottom) -->

data/.gitignore

@@ -4,7 +4,6 @@
 .config
 .ruby-*
 .yardoc
-Gemfile.lock
 InstalledFiles
 _yardoc
 coverage

data/CHANGELOG.md

@@ -1,3 +1,13 @@
+#### 3.15.1
+
+- Compatibility with json gem 3.0
+
+#### 3.15.0
+
+- Make JSON parsing and generation more consistent by using JSON::Coder
+- Remove MultiJson
+- Make attr_decimal use BigDecimal and attr_money use BigMoney
+
 #### 3.14.0
 
 - Resources: add #to_s

data/Gemfile

@@ -2,3 +2,5 @@ source 'https://rubygems.org'
 
 # Specify your gem's dependencies in ncore.gemspec
 gemspec
+
+gem 'minitest-reporters'

data/Gemfile.lock

@@ -0,0 +1,63 @@
+PATH
+  remote: .
+  specs:
+    ncore (3.15.1)
+      activemodel (>= 5.2, < 8.2)
+      excon (< 2)
+      json (>= 2.17)
+
+GEM
+  remote: https://rubygems.org/
+  specs:
+    activemodel (8.1.3.1)
+      activesupport (= 8.1.3.1)
+    activesupport (8.1.3.1)
+      base64
+      bigdecimal
+      concurrent-ruby (~> 1.0, >= 1.3.1)
+      connection_pool (>= 2.2.5)
+      drb
+      i18n (>= 1.6, < 2)
+      json
+      logger (>= 1.4.2)
+      minitest (>= 5.1)
+      securerandom (>= 0.3)
+      tzinfo (~> 2.0, >= 2.0.5)
+      uri (>= 0.13.1)
+    ansi (1.6.0)
+    base64 (0.3.0)
+    bigdecimal (4.1.2)
+    builder (3.3.0)
+    concurrent-ruby (1.3.8)
+    connection_pool (3.0.2)
+    drb (2.2.3)
+    excon (1.7.1)
+      logger
+    i18n (1.15.2)
+      concurrent-ruby (~> 1.0)
+    json (3.0.0)
+    logger (1.7.0)
+    minitest (6.0.6)
+      drb (~> 2.0)
+      prism (~> 1.5)
+    minitest-reporters (1.8.0)
+      ansi
+      builder
+      minitest (>= 5.0, < 7)
+      ruby-progressbar
+    prism (1.9.0)
+    ruby-progressbar (1.13.0)
+    securerandom (0.4.1)
+    tzinfo (2.0.6)
+      concurrent-ruby (~> 1.0)
+    uri (1.1.1)
+
+PLATFORMS
+  ruby
+
+DEPENDENCIES
+  minitest-reporters
+  ncore!
+
+BUNDLED WITH
+  4.0.16

data/{LICENSE → LICENSE.txt}

@@ -1,4 +1,4 @@
-Copyright 2014-2025 Notioneer, Inc.
+Copyright 2014-2026 Notioneer, Inc.
 
 MIT License
 

data/README.md

@@ -5,36 +5,35 @@ client by itself, but provides several useful building blocks to build one.
 
 It relies on `excon` for HTTP handling and `activemodel`.
 
-If present, uses `multi_json`. Otherwise, the stdlib 'json' is used.
-'multi_json' with an accelerated json gem is recommended.
-
-See `example/` for the beginning of an actual api client.
+See `example/` for the beginning of an actual api client. See [dnscaster-ruby](https://github.com/cosmicio/dnscaster-ruby) for a complete client.
 
 
 ## Installation
 
 Add this line to your application's Gemfile:
 
-    gem 'ncore'
+    gem 'ncore', '~> 3'
 
-And then execute:
+Or this to your gem's gemspec:
 
-    $ bundle
+    spec.add_dependency 'ncore', '~> 3'
 
-Or install it yourself as:
 
-    $ gem install ncore
+## Contributing
 
+Contributions are welcomed. If unsure about the scope or reach of a potential PR, feel free to open a discussion Issue first (not required though).
 
-## Contributing
+Please submit human-written contributions only. No contributions containing output generated by LLMs or other non-deterministic systems are allowed.
+
+* Code, tests, docs, PRs: must be 100% human written.
+* Issues, security reports: must originally be 100% human written. If not originally in English, an LLM may be used to translate to English provided that this translation is disclosed.
+
+We recognize that opinions about the use of LLMs and non-deterministic systems vary widely. Still, we respectfully ask that you honor this policy when interacting with this project.
 
-1. Fork it
-2. Create your feature branch (`git checkout -b my-new-feature`)
-3. Commit your changes (`git commit -am 'Add some feature'`)
-4. Push to the branch (`git push origin my-new-feature`)
-5. Create new Pull Request
+###### Q: May I use LLMs apart from contributions?
+All usage, training or otherwise, must respect copyrights. Beyond that, we've found that LLMs are prone to errors and misunderstandings--sometimes obvious, sometimes subtle. Please verify everything before trusting an LLM's output.
 
 
 ## License
 
-MIT
+[MIT](LICENSE.txt)

data/Rakefile

@@ -1 +1,5 @@
-require "bundler/gem_tasks"
+require 'bundler/gem_tasks'
+
+require 'minitest/test_task'
+Minitest::TestTask.create
+task default: :test

data/lib/ncore/attributes.rb

@@ -48,9 +48,29 @@ module NCore
       end
 
       # attr_decimal(:amount, ...)
-      #   adds: obj.amount  => BigMoney if String, else raw json type
+      #   adds: obj.amount  => BigDecimal if String, else raw json type
       #         obj.amount? => bool
       def attr_decimal(*attrs, predicate: true)
+        attrs.each do |attr|
+          check_existing_method(attr)
+          class_eval <<-AD, __FILE__, __LINE__+1
+            def #{attr}
+              case self[:#{attr}]
+              when String
+                BigDecimal(self[:#{attr}])
+              else
+                self[:#{attr}]
+              end
+            end
+          AD
+          attr_boolean :"#{attr}?" if predicate
+        end
+      end
+
+      # attr_money(:amount, ...)
+      #   adds: obj.amount  => BigMoney if String or BigDecimal, else raw json type
+      #         obj.amount? => bool
+      def attr_money(*attrs, predicate: true)
         attrs.each do |attr|
           check_existing_method(attr)
           class_eval <<-AD, __FILE__, __LINE__+1
@@ -58,6 +78,8 @@ module NCore
               case self[:#{attr}]
               when String
                 BigMoney.new(self[:#{attr}])
+              when BigDecimal
+                BigMoney.new(self[:#{attr}].to_s)
               else
                 self[:#{attr}]
               end

data/lib/ncore/client.rb

@@ -31,11 +31,7 @@ module NCore
           path += qs
           payload = nil
         else
-          if defined? MultiJson
-            payload = MultiJson.encode params.as_json
-          else
-            payload = params.to_json
-          end
+          payload = json_coder.generate params
         end
 
         rest_opts = {
@@ -252,22 +248,42 @@ module NCore
         response
       end
 
+
+      def json_opts
+        { allow_duplicate_key: false,
+          create_additions:    false,
+          decimal_class:       BigDecimal,
+          symbolize_names:     false,
+        }.tap{|opts|
+          opts.delete :create_additions if JSON::VERSION >= '3'
+        }
+      end
+
+      def json_coder
+        @json_coder ||= ::JSON::Coder.new(**json_opts) do |value, is_key|
+          case value
+          when BigDecimal
+            ::JSON::Fragment.new value.to_s
+          when DateTime, Time
+            value.iso8601(3)
+          else
+            if is_key
+              value.as_json.to_s
+            else
+              value.as_json
+            end
+          end
+        end
+      end
+
       def parse_response(response)
         if response.body.blank?
           json = {}
         else
-          if defined? MultiJson
-            begin
-              json = MultiJson.load(response.body, symbolize_keys: false) || {}
-            rescue MultiJson::ParseError
-              raise module_parent::Error, "Unable to parse API response; HTTP status: #{response.status}; body: #{response.body.inspect}"
-            end
-          else
-            begin
-              json = JSON.parse(response.body, symbolize_names: false) || {}
-            rescue JSON::ParserError
-              raise module_parent::Error, "Unable to parse API response; HTTP status: #{response.status}; body: #{response.body.inspect}"
-            end
+          begin
+            json = json_coder.parse response.body
+          rescue JSON::ParserError
+            raise module_parent::Error, "Unable to parse API response; HTTP status: #{response.status}; body: #{response.body.inspect}"
           end
         end
         json = json.with_indifferent_access
@@ -339,11 +355,7 @@ module NCore
       def debug_response(response)
         return unless logger.debug?
         headers = response.headers.transform_keys(&:downcase)
-        if defined? MultiJson
-          json = MultiJson.load(response.body||'', symbolize_keys: false) rescue response.body
-        else
-          json = JSON.parse(response.body||'', symbolize_names: false) rescue response.body
-        end
+        json = json_coder.parse(response.body) rescue response.body
         logger << <<~DBG
           RESPONSE:
             #{response.status} | #{headers['content-type']} | #{response.body.size} bytes

data/lib/ncore/version.rb

@@ -1,3 +1,3 @@
 module NCore
-  VERSION = '3.14.0'
+  VERSION = '3.15.1'
 end

data/ncore.gemspec

@@ -27,7 +27,5 @@ Gem::Specification.new do |spec|
 
   spec.add_dependency 'activemodel', '>= 5.2', '< 8.2'
   spec.add_dependency 'excon', '< 2'
-
-  spec.add_development_dependency "bundler"
-  spec.add_development_dependency "rake"
+  spec.add_dependency 'json', '>= 2.17'
 end

data/test/ncore_test.rb

@@ -0,0 +1,7 @@
+require "test_helper"
+
+class NCoreTest < ActiveSupport::TestCase
+  test "it has a version number" do
+    assert NCore::VERSION
+  end
+end

data/test/test_helper.rb

@@ -0,0 +1,4 @@
+require 'minitest/reporters'
+Minitest::Reporters.use! Minitest::Reporters::SpecReporter.new
+
+require 'ncore'

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: ncore
 version: !ruby/object:Gem::Version
-  version: 3.14.0
+  version: 3.15.1
 platform: ruby
 authors:
 - Notioneer Team
@@ -44,33 +44,19 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '2'
 - !ruby/object:Gem::Dependency
-  name: bundler
+  name: json
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '0'
-  type: :development
-  prerelease: false
-  version_requirements: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-- !ruby/object:Gem::Dependency
-  name: rake
-  requirement: !ruby/object:Gem::Requirement
-    requirements:
-    - - ">="
-      - !ruby/object:Gem::Version
-        version: '0'
-  type: :development
+        version: '2.17'
+  type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
       - !ruby/object:Gem::Version
-        version: '0'
+        version: '2.17'
 description: NCore - Ruby gem useful for building REST API clients
 email:
 - hello@notioneer.com
@@ -78,10 +64,12 @@ executables: []
 extensions: []
 extra_rdoc_files: []
 files:
+- ".github/pull_request_template.md"
 - ".gitignore"
 - CHANGELOG.md
 - Gemfile
-- LICENSE
+- Gemfile.lock
+- LICENSE.txt
 - README.md
 - Rakefile
 - example/lib/my_api.rb
@@ -123,6 +111,8 @@ files:
 - lib/ncore/version.rb
 - lib/ncore/wait.rb
 - ncore.gemspec
+- test/ncore_test.rb
+- test/test_helper.rb
 homepage: https://notioneer.com/
 licenses:
 - MIT
@@ -143,7 +133,9 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.6.9
+rubygems_version: 4.0.16
 specification_version: 4
 summary: NCore - Gem for building REST API clients
-test_files: []
+test_files:
+- test/ncore_test.rb
+- test/test_helper.rb