ncore 1.2.0 → 1.2.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: ef94f6b1037f27d30294786117a465ad2f884c18
-  data.tar.gz: 105361f8d4f0cc2639078bc48053d20ddaa6e9f1
+  metadata.gz: ec1bdffa679ca20445f4b48c4f7dd4cfcf6b2076
+  data.tar.gz: 7403cc773dc32014c0b9717fcb8d8fac6c433eb3
 SHA512:
-  metadata.gz: 14c748af57d663dcf4b7881e1ed6cda3df04105310a3858095e853bc7be8f5b1cd9016ec5c10f498b1de0736f3b501658947ed490f906c219461938378266d0a
-  data.tar.gz: 311dee415e76cbb165e19114502b47124b1c5c9d8cc819ca8998e9b8d59cafe8efd2c4cf3bf52a1e6336950f036e22d412907198f90580e736891d1a73d97ac2
+  metadata.gz: 4d98693b19a89b725457faf351417e64d150964a8dfddb17d49535479f7b4410836dd47f6c90da96d2ea18b8073ab172ff9d5e7a2c022f2283caa6c55eb36318
+  data.tar.gz: b187d445f6273acc6b777a0adad97dfaeb41541573c3566f3d7c4d78fcbfe3f3e519df4d90dc9a178676e3e13a33af05d43ef2947b7a75f1de46fdce84be5687

data/CHANGELOG.md

@@ -0,0 +1,15 @@
+#### 1.2.1
+
+- Connection errors should raise NCore::ConnectionError
+
+#### 1.2.0
+
+- Add delete association methods
+
+#### 1.1.0
+
+- Fix compatibility with ActiveModel 4.2
+
+#### 1.0.0
+
+- Initial release

data/lib/ncore/associations.rb

@@ -36,8 +36,6 @@ module NCore
           obj = find_#{assoc.singularize}(aid)
           obj.update(params)
           obj
-          # raise UnsavedObjectError unless id
-          # #{klass}.update(aid, {#{key}: id}.reverse_merge(params), api_creds)
         end
       M4
       class_eval <<-M5, __FILE__, __LINE__+1
@@ -58,8 +56,6 @@ module NCore
           obj = find_#{assoc.singularize}(aid)
           obj.delete(params)
           obj
-          # raise UnsavedObjectError unless id
-          # #{klass}.delete(aid, {#{key}: id}.reverse_merge(params), api_creds)
         end
       M7
       class_eval <<-M8, __FILE__, __LINE__+1
@@ -70,34 +66,6 @@ module NCore
       M8
     end
 
-    # def embeds_many(assoc)
-    #   assoc = assoc.to_s
-    #   class_eval <<-M1, __FILE__, __LINE__+1
-    #     def #{assoc}(params={})
-    #       @attribs[:#{assoc}] ||= []
-    #     end
-    #   M1
-    #   class_eval <<-M2, __FILE__, __LINE__+1
-    #     def find_#{assoc.singularize}(aid)
-    #       #{assoc}.detect{|o| o.id == aid} || raise(RecordNotFound)
-    #     end
-    #   M2
-    # 
-    #   # appease activerecord:
-    #   class_eval <<-M3, __FILE__, __LINE__+1
-    #     def #{assoc}_attributes=(v)
-    #       v = v.values if v.is_a?(Hash)
-    #       if v.is_a?(Array)
-    #         v.each{|o| o['object'] ||= '#{assoc.singularize}' if o.is_a?(Hash) }
-    #         @attribs[:#{assoc}] = self.class.interpret_type(v, api_creds)
-    #       else
-    #         @attribs[:#{assoc}] = v
-    #       end
-    #     end
-    #     alias :#{assoc}= :#{assoc}_attributes=
-    #   M3
-    # end
-
     def belongs_to(assoc, klass=nil)
       assoc = assoc.to_s
       klass ||= "#{module_name}::#{assoc.camelize}"
@@ -105,7 +73,6 @@ module NCore
         attr :#{assoc}_id
         def #{assoc}(params={})
           return nil unless #{assoc}_id
-#          @attribs[:#{assoc}] ||= #{klass}.find(#{assoc}_id, params, api_creds)
           if params.empty?
             # only cache unfiltered, default api call
             @attribs[:#{assoc}] ||= #{klass}.find(#{assoc}_id, {}, api_creds)

data/lib/ncore/client.rb

@@ -178,10 +178,13 @@ module NCore
         rescue Errno::ECONNREFUSED
           raise parent::ConnectionError, "Connection error for #{host_for_error rest_opts[:url]} : check network and DNS or visit #{status_page}."
         rescue Excon::Errors::SocketError => e
-          if e.message =~ /Unable to verify certificate/
+          case e.message
+          when /Unable to verify certificate/
             raise parent::ConnectionError, "Unable to verify certificate for #{host_for_error rest_opts[:url]} : verify URL or disable SSL certificate verification (insecure)."
-          elsif e.message =~ /Name or service not known/
+          when /Name or service not known/
             raise parent::ConnectionError, "DNS error for #{host_for_error rest_opts[:url]} : check network and DNS or visit #{status_page}."
+          when /Errno::ECONNREFUSED/
+            raise parent::ConnectionError, "Connection error for #{host_for_error rest_opts[:url]} : check network and DNS or visit #{status_page}."
           else
             raise e
           end
@@ -200,9 +203,7 @@ module NCore
           raise parent::AccessDenied, "Access denied; check your API credentials and permissions."
         when 404
           raise parent::RecordNotFound
-        # when 409
-        #   raise parent::Conflict
-        when 422, 409 # todo: is this really universally true (check both AR + PS)
+        when 422
           # pass through
         when 429
           raise parent::RateLimited

data/lib/ncore/configuration.rb

@@ -48,13 +48,8 @@ module NCore
 
         mattr_accessor :logger
         self.logger = Logger.new(STDOUT)
-        # self.logger.level = Logger::DEBUG
       end
 
-      # def credentials=(v)
-      #   super v.with_indifferent_access
-      # end
-
     end
 
   end

data/lib/ncore/version.rb

@@ -1,3 +1,3 @@
 module NCore
-  VERSION = '1.2.0'
+  VERSION = '1.2.1'
 end

data/ncore.gemspec

@@ -10,9 +10,7 @@ Gem::Specification.new do |spec|
   spec.email         = ["hello@notioneer.com"]
   spec.description   = %q{NCore - Ruby gem useful for building REST API clients}
   spec.summary       = %q{NCore - Gem for building REST API clients}
-  # spec.homepage      = "https://github.com/notioneer/ncore-ruby"
   spec.homepage      = 'http://notioneer.com/'
-  # spec.homepage      = 'https://authrocket.com/'
   spec.license       = "MIT"
 
   spec.files         = `git ls-files`.split($/)

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: ncore
 version: !ruby/object:Gem::Version
-  version: 1.2.0
+  version: 1.2.1
 platform: ruby
 authors:
 - thomas morgan
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-02-16 00:00:00.000000000 Z
+date: 2015-06-22 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport
@@ -94,6 +94,7 @@ extensions: []
 extra_rdoc_files: []
 files:
 - ".gitignore"
+- CHANGELOG.md
 - Gemfile
 - LICENSE
 - README.md